Re: Protected master needs to be turned off

2017-12-01 Thread Mu Li
That's how it works before, committers can stop a CI test if it's a simple fix, such as typo. But with apache's jenkins server, it's nontrivial to request the permission to stop/start a CI test. I had a thought about to let the CI be smart enough to only run the tests related to the code

Re: Protected master needs to be turned off

2017-12-01 Thread Marco de Abreu
We plan to add the possibility to trigger or stop a build by adding a comment in the pull request - this will be added after we switched to the new CI. Am 01.12.2017 7:25 nachm. schrieb "Mu Li" : > That's how it works before, committers can stop a CI test if it's a simple >

Re: Protected master needs to be turned off

2017-12-01 Thread Pedro Larroy
CI catches problems all the time. I don't think many of us can afford to build all the flavors and architectures in their laptops or workstations, so we have to rely on CI to catch all kinds of errors from compilation errors to bugs plus regressions, specially in a project which has so many build

[BUILD FAILED] Branch master build 703

2017-12-01 Thread Apache Jenkins Server
Build for MXNet branch master has broken. Please view the build at https://builds.apache.org/job/incubator-mxnet/job/master/703/

Re: Protected master needs to be turned off

2017-12-01 Thread Mu Li
Totally agree that CI is useful. Actually, I wrote the jenkinsfile and setup the jenkins server before moving to apache server. I just mention that we cannot rely on the CI test. It currently covers operator unittests and regression test on several cnns. But the code coverage isn't great. If a PR

Re: Protected master needs to be turned off

2017-12-01 Thread Tianqi Chen
I think we are still using CI to catch bugs. And we should take caution when merging something that CI did not catch up due to the response time. This do not contradict what comitter can do with their best judgement. For example, I would normally switch CI off and merge simple typo fixes. If the

Re: Perl module copyright/author notation

2017-12-01 Thread Hen
Thanks Sergey :) Cc'd to dev@ as an FYI. Hen On Thu, Nov 30, 2017 at 10:58 PM, Sergey Kolychev < sergeykolychev.git...@gmail.com> wrote: > Yes, sure please change it as needed. Thanks! > > On Thu, Nov 30, 2017 at 12:44 PM, Hen wrote: > >> Hi Sergey, >> >> In looking at the

MXNet External Sources (was Re: [VOTE] Apache MXNet (incubating) 1.0.0 release RC1)

2017-12-01 Thread John D. Ament
One question about the below. We've noted that much of the source code for MXNet is coming from the external DMLC repos. Are there plans to move those repos into the ASF? John On Fri, Dec 1, 2017 at 7:13 PM Hen wrote: > +1. > > Items I note should happen post release are: