Re: [VOTE] Release Apache MXNet (incubating) version 1.4.0.rc2

2019-02-01 Thread Marco de Abreu
Considering the release process has been started last year and the code tag has also been based on last year, I'd say that it is not really a big deal. -Marco Am Fr., 1. Feb. 2019, 09:33 hat Sheng Zha geschrieben: > I found an awesome checklist for incubator releases [1] so I'm using it >

Re: [VOTE] Release Apache MXNet (incubating) version 1.4.0.rc2

2019-02-01 Thread Sheng Zha
I found an awesome checklist for incubator releases [1] so I'm using it here: -[Y] Are release files in correct location? -[Y] Do release files have the word incubating in their name? -[Y] Are the digital signature and hashes correct? -[Y] Does DISCLAIMER file exist? -[Y] Do LICENSE and NOTICE

Re: [VOTE] Release Apache MXNet (incubating) version 1.4.0.rc2

2019-02-01 Thread Steffen Rochel
Hi Sheng - thanks for the feedback. TVM notice file is missing as the 1.4.x branch/v1.4.0 release is using TVM commit 0f053c8 from Oct 8, 2018, which didn't have the NOTICE file. IMHO, MXNet NOTICE file is consistent