Unfortunately, merging the following PR
Set correct update on kvstore flag in dist_device_sync mode (v1.3.x)
https://github.com/apache/incubator-mxnet/pull/13121
Broke `dist-kvstore tests CPU` test stage:
Due to various problems we had to postpone the tagging and vote for the
release till Monday, the 12th of November 2018.
Following change has been updated and waiting to be merged:
Disable flaky test test_operator.test_dropout (v1.3.x)
https://github.com/apache/incubator-mxnet/pull/13200
Indeed
In case the tests for MACOS will time out as well we can disable them and
keep at least the build stage as in:
Disable travis tests
https://github.com/apache/incubator-mxnet/pull/13137
Best
Anton
пт, 9 нояб. 2018 г. в 11:17, Anton Chernov :
>
> Hi Naveen,
>
> I believe that the timeout is not
Hi Naveen,
I believe that the timeout is not an issue for the branch. And I see great
benefit in having tests for MACOS on the release branch. The travis build
is not blocking anyway, so I don't see any risk in adding it.
* test_dropout
Currently, there is a problem with test_dropout that fails
Anton, I don't think we need to add the Mac OS tests for 1.3.1 branch since
travis CI is timing out and creates blockers, it also did not exist for
v1.3.0.
On Thu, Nov 8, 2018 at 10:04 AM Anton Chernov wrote:
> A PR to fix the tests:
>
> Remove test for non existing index copy operator
Thank you everyone for your support and suggestions. All proposed PR's have
been merged. We will tag the release candidate and start the vote on
Friday, the 9th of November 2018.
Unfortunately after the merges the tests started to fail:
A PR to fix the tests:
Remove test for non existing index copy operator (v1.3.x)
https://github.com/apache/incubator-mxnet/pull/13180
Best
Anton
чт, 8 нояб. 2018 г. в 10:05, Anton Chernov :
> An addition has been made to include MacOS tests for the v1.3.x branch:
>
> [MXNET-908] Enable
An addition has been made to include MacOS tests for the v1.3.x branch:
[MXNET-908] Enable minimal OSX Travis build (v1.3.x)
https://github.com/apache/incubator-mxnet/pull/13179
It includes following PR's for master:
[MXNET-908] Enable minimal OSX Travis build
Yes, you are right about the versions wording, thanks for clarification.
A performance improvement can be considered a bugfix as well. I see no big
risks in including PR's by Haibin and Lin into the patch release.
@Haibin, if you can reopen the PR's they should be good to go for the
relase,
; Anton
>> >>>>>>
>> >>>>>> вт, 6 нояб. 2018 г. в 16:06, Anton Chernov :
>> >>>>>>
>> >>>>>>> Hi Haibin,
>> >>>>>>>
>> >>>>>>> I have a few comments regarding the pro
gt;>>>>>> https://github.com/apache/incubator-mxnet/pull/13056
> >>>>>>>
> >>>>>>> There is no doubt that this change brings value, but I don't see
> >> it
> >>>> as a
> >>>>>>> critical bug f
;>>>>> sample_like operators
>>>>>>> https://github.com/apache/incubator-mxnet/pull/13034
>>>>>>>
>>>>>>> Even if it's related to performance, this is an addition of
>>>>> functionality
>>
> > > > >>
> > > > >>
> > > > >> вт, 6 нояб. 2018 г. в 15:55, Anton Chernov :
> > > > >>
> > > > >>> Hi Patric,
> > > > >>>
> > > > >>> This change was listed in t
t;> Best
> >>> Anton
> >>>
> >>> [1]
> >>>
> https://cwiki.apache.org/confluence/display/MXNET/Project+Proposals+for+next+MXNet+Release#PR_candidates
> >>>
> >>>
> >>> вт, 6 нояб. 2018 г. в 1:14, Zhao, Patric :
> &g
t; Thanks for looking into the MKL-DNN PR.
>>>>
>>>> As my understanding of cwiki (
>>>> https://cwiki.apache.org/confluence/display/MXNET/Project+Proposals+for+next+MXNet+Release
>>>> ),
>>>> these features will go into 1.4 rather than patc
-DNN PR.
>>>
>>> As my understanding of cwiki (
>>> https://cwiki.apache.org/confluence/display/MXNET/Project+Proposals+for+next+MXNet+Release
>>> ),
>>> these features will go into 1.4 rather than patch release of 1.3.1.
>>>
>>> Feel free
1.
>>
>> Feel free to correct me :)
>>
>> Thanks,
>>
>> --Patric
>>
>> > -Original Message-----
>> > From: Anton Chernov [mailto:mecher...@gmail.com]
>> > Sent: Tuesday, November 6, 2018 3:11 AM
>> > To: d...@mxnet.apache.o
on Chernov [mailto:mecher...@gmail.com]
> > Sent: Tuesday, November 6, 2018 3:11 AM
> > To: d...@mxnet.apache.org
> > Subject: Re: [Announce] Upcoming Apache MXNet (incubating) 1.3.1 patch
> > release
> >
> > It seems that there is a problem porting following changes t
> -Original Message-
> From: Anton Chernov [mailto:mecher...@gmail.com]
> Sent: Tuesday, November 6, 2018 3:11 AM
> To: d...@mxnet.apache.org
> Subject: Re: [Announce] Upcoming Apache MXNet (incubating) 1.3.1 patch
> release
>
> It seems that there is a problem p
Hi Anton,
Thanks for driving the patch release. Besides the MKL improvements, I
suggest we include two changes for *performance improvement* for NLP tasks
below:
CUDNN support for LSTM with projection & clipping:
- https://github.com/apache/incubator-mxnet/pull/13056
- It is used in state of the
It seems that there is a problem porting following changes to the v1.3.x
release branch:
Implement mkldnn convolution fusion and quantization
https://github.com/apache/incubator-mxnet/pull/12530
MKL-DNN Quantization Examples and README
https://github.com/apache/incubator-mxnet/pull/12808
The
As part of:
Implement mkldnn convolution fusion and quantization
https://github.com/apache/incubator-mxnet/pull/12530
I propose to add the examples and documentation PR as well:
MKL-DNN Quantization Examples and README
https://github.com/apache/incubator-mxnet/pull/12808
Best regards,
Anton
22 matches
Mail list logo
