[
https://issues.apache.org/jira/browse/MYFACES-4247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16545469#comment-16545469
]
ASF GitHub Bot commented on MYFACES-4247:
-
pnicolucci closed pull request #11: MYFACES-4247:
[
https://issues.apache.org/jira/browse/MYFACES-4247?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Paul Nicolucci resolved MYFACES-4247.
-
Resolution: Fixed
Fix Version/s: 2.3.2
2.2.13
> [perf] minor
[
https://issues.apache.org/jira/browse/MYFACES-4247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16545471#comment-16545471
]
ASF GitHub Bot commented on MYFACES-4247:
-
pnicolucci closed pull request #12: MYFACES-4247:
[
https://issues.apache.org/jira/browse/MYFACES-4247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16545470#comment-16545470
]
ASF GitHub Bot commented on MYFACES-4247:
-
pnicolucci edited a comment on issue #11:
pnicolucci closed pull request #12: MYFACES-4247: reduce number of char[]
objects and CommonPropertyUtils…
URL: https://github.com/apache/myfaces/pull/12
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of
pnicolucci closed pull request #11: MYFACES-4247: reduce number of char[]
objects and CommonPropertyUtils…
URL: https://github.com/apache/myfaces/pull/11
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of
pnicolucci edited a comment on issue #11: MYFACES-4247: reduce number of char[]
objects and CommonPropertyUtils…
URL: https://github.com/apache/myfaces/pull/11#issuecomment-405272258
I'll add a couple unit tests and ensure the behavior is the same before and
after the changes just to be
pnicolucci opened a new pull request #12: MYFACES-4247: reduce number of char[]
objects and CommonPropertyUtils…
URL: https://github.com/apache/myfaces/pull/12
… calls
This is an automated message from the Apache Git
[
https://issues.apache.org/jira/browse/MYFACES-4247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16545196#comment-16545196
]
ASF GitHub Bot commented on MYFACES-4247:
-
pnicolucci opened a new pull request #12:
[
https://issues.apache.org/jira/browse/MYFACES-4247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16545211#comment-16545211
]
ASF GitHub Bot commented on MYFACES-4247:
-
tandraschko commented on issue #11: MYFACES-4247:
[
https://issues.apache.org/jira/browse/MYFACES-4247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16545198#comment-16545198
]
ASF GitHub Bot commented on MYFACES-4247:
-
tandraschko commented on issue #11: MYFACES-4247:
tandraschko commented on issue #11: MYFACES-4247: reduce number of char[]
objects and CommonPropertyUtils…
URL: https://github.com/apache/myfaces/pull/11#issuecomment-405244998
+1 for the CommonProperties stuff
+0 for the changes in write
could you explain them before?
[
https://issues.apache.org/jira/browse/MYFACES-4247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16545203#comment-16545203
]
ASF GitHub Bot commented on MYFACES-4247:
-
pnicolucci commented on issue #11: MYFACES-4247:
pnicolucci commented on issue #11: MYFACES-4247: reduce number of char[]
objects and CommonPropertyUtils…
URL: https://github.com/apache/myfaces/pull/11#issuecomment-405247268
@tandraschko : String.toCharArray() is what is not called now
The string uses its internal char[] instead of a
tandraschko commented on issue #11: MYFACES-4247: reduce number of char[]
objects and CommonPropertyUtils…
URL: https://github.com/apache/myfaces/pull/11#issuecomment-405248399
if it works fine, i'm ok with it
it would be just better if we would have a unittest for it?
[
https://issues.apache.org/jira/browse/MYFACES-4248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16545212#comment-16545212
]
Thomas Andraschko commented on MYFACES-4248:
oh damn, good catch!
>
[
https://issues.apache.org/jira/browse/MYFACES-4248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16545226#comment-16545226
]
Thomas Andraschko commented on MYFACES-4248:
[~paul.nicolucci] I fixed it in trunk but
[
https://issues.apache.org/jira/browse/MYFACES-4247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16545275#comment-16545275
]
ASF GitHub Bot commented on MYFACES-4247:
-
pnicolucci commented on issue #11: MYFACES-4247:
pnicolucci commented on issue #11: MYFACES-4247: reduce number of char[]
objects and CommonPropertyUtils…
URL: https://github.com/apache/myfaces/pull/11#issuecomment-405272258
I'll add a couple unit tests and ensure the behavior is the same before an
after the changes just to be extra
[
https://issues.apache.org/jira/browse/MYFACES-4248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16545353#comment-16545353
]
Thomas Andraschko commented on MYFACES-4248:
+1, thanks :)
>
pnicolucci closed pull request #13: MYFACES-4248
URL: https://github.com/apache/myfaces/pull/13
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the
[
https://issues.apache.org/jira/browse/MYFACES-4248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16545357#comment-16545357
]
ASF GitHub Bot commented on MYFACES-4248:
-
pnicolucci closed pull request #13: MYFACES-4248
[
https://issues.apache.org/jira/browse/MYFACES-4248?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Paul Nicolucci resolved MYFACES-4248.
-
Resolution: Fixed
> OpenWebBeansELResolverComparator references outdated openwebbeans
pnicolucci opened a new pull request #13: MYFACES-4248
URL: https://github.com/apache/myfaces/pull/13
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL
[
https://issues.apache.org/jira/browse/MYFACES-4248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16545341#comment-16545341
]
ASF GitHub Bot commented on MYFACES-4248:
-
pnicolucci opened a new pull request #13:
[
https://issues.apache.org/jira/browse/MYFACES-4248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16545345#comment-16545345
]
Paul Nicolucci commented on MYFACES-4248:
-
[~tandraschko] I have a PR with your changes if it
26 matches
Mail list logo
