[GitHub] krichter722 opened a new pull request #1: added initial .travis.yml

2017-10-25 Thread GitBox
krichter722 opened a new pull request #1: added initial .travis.yml URL: https://github.com/apache/myfaces-tobago/pull/1 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] deki commented on issue #1: added initial .travis.yml

2017-10-26 Thread GitBox
deki commented on issue #1: added initial .travis.yml URL: https://github.com/apache/myfaces-tobago/pull/1#issuecomment-339617910 Thanks for the PR. Can you elaborate a bit more on your usecase? Currently we are using Jenkins builds...

[GitHub] pnicolucci closed pull request #5: MYFACES-4236: Add package-info.java to javax.faces.bean package

2018-06-07 Thread GitBox
pnicolucci closed pull request #5: MYFACES-4236: Add package-info.java to javax.faces.bean package URL: https://github.com/apache/myfaces/pull/5 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As

[GitHub] pnicolucci opened a new pull request #5: MYFACES-4236: Add package-info.java to javax.faces.bean package

2018-06-07 Thread GitBox
pnicolucci opened a new pull request #5: MYFACES-4236: Add package-info.java to javax.faces.bean package URL: https://github.com/apache/myfaces/pull/5 This is an automated message from the Apache Git Service. To respond to

[GitHub] pnicolucci opened a new pull request #6: MYFACES-4237: improve performance when checking for duplicate ids

2018-06-13 Thread GitBox
pnicolucci opened a new pull request #6: MYFACES-4237: improve performance when checking for duplicate ids URL: https://github.com/apache/myfaces/pull/6 This is an automated message from the Apache Git Service. To respond

[GitHub] pnicolucci closed pull request #7: MYFACES-4237: improve performance when checking for duplicate ids

2018-06-13 Thread GitBox
pnicolucci closed pull request #7: MYFACES-4237: improve performance when checking for duplicate ids URL: https://github.com/apache/myfaces/pull/7 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance:

[GitHub] pnicolucci opened a new pull request #7: MYFACES-4237: improve performance when checking for duplicate ids

2018-06-13 Thread GitBox
pnicolucci opened a new pull request #7: MYFACES-4237: improve performance when checking for duplicate ids URL: https://github.com/apache/myfaces/pull/7 This is an automated message from the Apache Git Service. To respond

[GitHub] henningn opened a new pull request #12: TOBAGO-1879 tc:date does not support Calendar and DateTime

2018-06-15 Thread GitBox
henningn opened a new pull request #12: TOBAGO-1879 tc:date does not support Calendar and DateTime URL: https://github.com/apache/myfaces-tobago/pull/12 * tc:convertDateTime implemented, Calendar and java8.time API supported * test added * Annotation 'ConverterTag' implemented

[GitHub] ebreijo closed pull request #1: MYFACES-4231 Update SearchExpressionContextFactory and FaceletCache s…

2018-05-29 Thread GitBox
ebreijo closed pull request #1: MYFACES-4231 Update SearchExpressionContextFactory and FaceletCache s… URL: https://github.com/apache/myfaces/pull/1 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance:

[GitHub] pnicolucci opened a new pull request #4: MYFACES-4235: Use cached BeanManager

2018-06-04 Thread GitBox
pnicolucci opened a new pull request #4: MYFACES-4235: Use cached BeanManager URL: https://github.com/apache/myfaces/pull/4 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] pnicolucci closed pull request #4: MYFACES-4235: Use cached BeanManager

2018-06-04 Thread GitBox
pnicolucci closed pull request #4: MYFACES-4235: Use cached BeanManager URL: https://github.com/apache/myfaces/pull/4 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull

[GitHub] deki closed pull request #3: MYFACES-4234 Use intern() on FACELET_CACHE_KEY value

2018-06-01 Thread GitBox
deki closed pull request #3: MYFACES-4234 Use intern() on FACELET_CACHE_KEY value URL: https://github.com/apache/myfaces/pull/3 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] ebreijo opened a new pull request #1: MYFACES-4231 Update SearchExpressionContextFactory and FaceletCache s…

2018-05-29 Thread GitBox
ebreijo opened a new pull request #1: MYFACES-4231 Update SearchExpressionContextFactory and FaceletCache s… URL: https://github.com/apache/myfaces/pull/1 …ignature methods in the JSF 2.3 API JIRA issue: https://issues.apache.org/jira/browse/MYFACES-4231

[GitHub] pnicolucci opened a new pull request #3: MYFACES-4234 Use intern() on FACELET_CACHE_KEY value

2018-06-01 Thread GitBox
pnicolucci opened a new pull request #3: MYFACES-4234 Use intern() on FACELET_CACHE_KEY value URL: https://github.com/apache/myfaces/pull/3 https://issues.apache.org/jira/browse/MYFACES-4234 This is an automated message from

[GitHub] ebreijo opened a new pull request #2: MYFACES-4232 Update UIWebsocket signature in the JSF 2.3 API

2018-05-30 Thread GitBox
ebreijo opened a new pull request #2: MYFACES-4232 Update UIWebsocket signature in the JSF 2.3 API URL: https://github.com/apache/myfaces/pull/2 https://issues.apache.org/jira/browse/MYFACES-4232 This is an automated message

[GitHub] ebreijo closed pull request #2: MYFACES-4232 Update UIWebsocket signature in the JSF 2.3 API

2018-05-31 Thread GitBox
ebreijo closed pull request #2: MYFACES-4232 Update UIWebsocket signature in the JSF 2.3 API URL: https://github.com/apache/myfaces/pull/2 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this

[GitHub] pnicolucci commented on issue #8: MYFACES-4239: Multiple performance improvements

2018-06-25 Thread GitBox
pnicolucci commented on issue #8: MYFACES-4239: Multiple performance improvements URL: https://github.com/apache/myfaces/pull/8#issuecomment-399940917 I'll work to remove the sb changes from this PR and will open a new issue / PR for the changes and get a discussion started on the mailing

[GitHub] tandraschko commented on issue #8: MYFACES-4239: Multiple performance improvements

2018-06-22 Thread GitBox
tandraschko commented on issue #8: MYFACES-4239: Multiple performance improvements URL: https://github.com/apache/myfaces/pull/8#issuecomment-399597447 I also thought a bit about it, i think it would be better if we discuss it first on the mailing list. And details about it would be

[GitHub] pnicolucci commented on issue #8: MYFACES-4239: Multiple performance improvements

2018-06-25 Thread GitBox
pnicolucci commented on issue #8: MYFACES-4239: Multiple performance improvements URL: https://github.com/apache/myfaces/pull/8#issuecomment-400047548 @tandraschko ok with the current changes in this PR? This is an

[GitHub] tandraschko commented on issue #8: MYFACES-4239: Multiple performance improvements

2018-06-25 Thread GitBox
tandraschko commented on issue #8: MYFACES-4239: Multiple performance improvements URL: https://github.com/apache/myfaces/pull/8#issuecomment-400075148 Yep! :) This is an automated message from the Apache Git Service. To

[GitHub] tandraschko commented on issue #8: MYFACES-4239: Multiple performance improvements

2018-06-22 Thread GitBox
tandraschko commented on issue #8: MYFACES-4239: Multiple performance improvements URL: https://github.com/apache/myfaces/pull/8#issuecomment-399456368 @pnicolucci i'm not sure about this changes out.write vs sb.append... Why do you switchted from out.write to a new StringBuilder?

[GitHub] tandraschko edited a comment on issue #8: MYFACES-4239: Multiple performance improvements

2018-06-22 Thread GitBox
tandraschko edited a comment on issue #8: MYFACES-4239: Multiple performance improvements URL: https://github.com/apache/myfaces/pull/8#issuecomment-399456368 @pnicolucci i'm not sure about this changes out.write vs sb.append... Why do you switchted from out.write to a new

[GitHub] pnicolucci commented on issue #8: MYFACES-4239: Multiple performance improvements

2018-06-22 Thread GitBox
pnicolucci commented on issue #8: MYFACES-4239: Multiple performance improvements URL: https://github.com/apache/myfaces/pull/8#issuecomment-399464056 @tandraschko , we've been running some performance tests and can see a .5 - 1% increase in our testing in performance with an application

[GitHub] tandraschko commented on issue #8: MYFACES-4239: Multiple performance improvements

2018-06-22 Thread GitBox
tandraschko commented on issue #8: MYFACES-4239: Multiple performance improvements URL: https://github.com/apache/myfaces/pull/8#issuecomment-399464821 ok, i see i'm ok for it if you use the SharedStringBuilder This is an

[GitHub] tandraschko commented on issue #8: MYFACES-4239: Multiple performance improvements

2018-06-22 Thread GitBox
tandraschko commented on issue #8: MYFACES-4239: Multiple performance improvements URL: https://github.com/apache/myfaces/pull/8#issuecomment-399465655 JFYI: we avoided new objects so much in the past that we even switched from for-each to for loops, so the SharedStringBuilder is IMO a

[GitHub] tandraschko commented on issue #8: MYFACES-4239: Multiple performance improvements

2018-06-22 Thread GitBox
tandraschko commented on issue #8: MYFACES-4239: Multiple performance improvements URL: https://github.com/apache/myfaces/pull/8#issuecomment-399465769 All other changes looks fine of course. This is an automated message

[GitHub] tandraschko edited a comment on issue #8: MYFACES-4239: Multiple performance improvements

2018-06-22 Thread GitBox
tandraschko edited a comment on issue #8: MYFACES-4239: Multiple performance improvements URL: https://github.com/apache/myfaces/pull/8#issuecomment-399465655 JFYI: we avoided new objects so much in the past that we even switched from for-each to for loops, so the SharedStringBuilder is

[GitHub] pnicolucci closed pull request #8: MYFACES-4239: Multiple performance improvements

2018-06-26 Thread GitBox
pnicolucci closed pull request #8: MYFACES-4239: Multiple performance improvements URL: https://github.com/apache/myfaces/pull/8 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] wtlucy opened a new pull request #16: MYFACES-3629 add context attr for case when faces servlet is found by SCI

2018-08-13 Thread GitBox
wtlucy opened a new pull request #16: MYFACES-3629 add context attr for case when faces servlet is found by SCI URL: https://github.com/apache/myfaces/pull/16 Fix the web-fragment issue described in MYFACES-3629 This is an

[GitHub] pnicolucci closed pull request #10: MYFACES-4244:Use StringBuilder rather than calling write multiple times

2018-08-06 Thread GitBox
pnicolucci closed pull request #10: MYFACES-4244:Use StringBuilder rather than calling write multiple times URL: https://github.com/apache/myfaces/pull/10 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] pnicolucci commented on issue #10: MYFACES-4244:Use StringBuilder rather than calling write multiple times

2018-08-06 Thread GitBox
pnicolucci commented on issue #10: MYFACES-4244:Use StringBuilder rather than calling write multiple times URL: https://github.com/apache/myfaces/pull/10#issuecomment-410808355 After additional investigation we've determined this change is not necessary so I'm closing this Pull request.

[GitHub] pnicolucci opened a new pull request #14: MYFACES-4249: Don't call charAt more than needed

2018-08-06 Thread GitBox
pnicolucci opened a new pull request #14: MYFACES-4249: Don't call charAt more than needed URL: https://github.com/apache/myfaces/pull/14 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] pnicolucci opened a new pull request #15: MYFACES-4249: Don't call charAt more than needed

2018-08-06 Thread GitBox
pnicolucci opened a new pull request #15: MYFACES-4249: Don't call charAt more than needed URL: https://github.com/apache/myfaces/pull/15 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] pnicolucci closed pull request #14: MYFACES-4249: Don't call charAt more than needed

2018-08-06 Thread GitBox
pnicolucci closed pull request #14: MYFACES-4249: Don't call charAt more than needed URL: https://github.com/apache/myfaces/pull/14 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] pnicolucci closed pull request #15: MYFACES-4249: Don't call charAt more than needed

2018-08-06 Thread GitBox
pnicolucci closed pull request #15: MYFACES-4249: Don't call charAt more than needed URL: https://github.com/apache/myfaces/pull/15 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] wtlucy closed pull request #16: MYFACES-3629 add context attr for case when faces servlet is found by SCI

2018-08-23 Thread GitBox
wtlucy closed pull request #16: MYFACES-3629 add context attr for case when faces servlet is found by SCI URL: https://github.com/apache/myfaces/pull/16 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] wtlucy opened a new pull request #17: MYFACES-3629 add context attr for case when faces servlet is found by SCI - 2.2.x

2018-08-23 Thread GitBox
wtlucy opened a new pull request #17: MYFACES-3629 add context attr for case when faces servlet is found by SCI - 2.2.x URL: https://github.com/apache/myfaces/pull/17 Fixing this issue on the 2.2 branch This is an automated

[GitHub] wtlucy closed pull request #17: MYFACES-3629 add context attr for case when faces servlet is found by SCI - 2.2.x

2018-08-23 Thread GitBox
wtlucy closed pull request #17: MYFACES-3629 add context attr for case when faces servlet is found by SCI - 2.2.x URL: https://github.com/apache/myfaces/pull/17 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] luigiJsonar opened a new pull request #18: MYFACES-4082 Fix 'binding' when referencing composite components

2018-08-26 Thread GitBox
luigiJsonar opened a new pull request #18: MYFACES-4082 Fix 'binding' when referencing composite components URL: https://github.com/apache/myfaces/pull/18 Code that 'sets' the value of the binding attribute for composite components. Inspired on:

[GitHub] pnicolucci closed pull request #12: MYFACES-4247: reduce number of char[] objects and CommonPropertyUtils…

2018-07-16 Thread GitBox
pnicolucci closed pull request #12: MYFACES-4247: reduce number of char[] objects and CommonPropertyUtils… URL: https://github.com/apache/myfaces/pull/12 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] pnicolucci closed pull request #11: MYFACES-4247: reduce number of char[] objects and CommonPropertyUtils…

2018-07-16 Thread GitBox
pnicolucci closed pull request #11: MYFACES-4247: reduce number of char[] objects and CommonPropertyUtils… URL: https://github.com/apache/myfaces/pull/11 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] pnicolucci edited a comment on issue #11: MYFACES-4247: reduce number of char[] objects and CommonPropertyUtils…

2018-07-16 Thread GitBox
pnicolucci edited a comment on issue #11: MYFACES-4247: reduce number of char[] objects and CommonPropertyUtils… URL: https://github.com/apache/myfaces/pull/11#issuecomment-405272258 I'll add a couple unit tests and ensure the behavior is the same before and after the changes just to be

[GitHub] pnicolucci opened a new pull request #12: MYFACES-4247: reduce number of char[] objects and CommonPropertyUtils…

2018-07-16 Thread GitBox
pnicolucci opened a new pull request #12: MYFACES-4247: reduce number of char[] objects and CommonPropertyUtils… URL: https://github.com/apache/myfaces/pull/12 … calls This is an automated message from the Apache Git

[GitHub] tandraschko commented on issue #11: MYFACES-4247: reduce number of char[] objects and CommonPropertyUtils…

2018-07-16 Thread GitBox
tandraschko commented on issue #11: MYFACES-4247: reduce number of char[] objects and CommonPropertyUtils… URL: https://github.com/apache/myfaces/pull/11#issuecomment-405244998 +1 for the CommonProperties stuff +0 for the changes in write could you explain them before?

[GitHub] pnicolucci commented on issue #11: MYFACES-4247: reduce number of char[] objects and CommonPropertyUtils…

2018-07-16 Thread GitBox
pnicolucci commented on issue #11: MYFACES-4247: reduce number of char[] objects and CommonPropertyUtils… URL: https://github.com/apache/myfaces/pull/11#issuecomment-405247268 @tandraschko : String.toCharArray() is what is not called now The string uses its internal char[] instead of a

[GitHub] tandraschko commented on issue #11: MYFACES-4247: reduce number of char[] objects and CommonPropertyUtils…

2018-07-16 Thread GitBox
tandraschko commented on issue #11: MYFACES-4247: reduce number of char[] objects and CommonPropertyUtils… URL: https://github.com/apache/myfaces/pull/11#issuecomment-405248399 if it works fine, i'm ok with it it would be just better if we would have a unittest for it?

[GitHub] pnicolucci commented on issue #11: MYFACES-4247: reduce number of char[] objects and CommonPropertyUtils…

2018-07-16 Thread GitBox
pnicolucci commented on issue #11: MYFACES-4247: reduce number of char[] objects and CommonPropertyUtils… URL: https://github.com/apache/myfaces/pull/11#issuecomment-405272258 I'll add a couple unit tests and ensure the behavior is the same before an after the changes just to be extra

[GitHub] pnicolucci closed pull request #13: MYFACES-4248

2018-07-16 Thread GitBox
pnicolucci closed pull request #13: MYFACES-4248 URL: https://github.com/apache/myfaces/pull/13 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the

[GitHub] pnicolucci opened a new pull request #13: MYFACES-4248

2018-07-16 Thread GitBox
pnicolucci opened a new pull request #13: MYFACES-4248 URL: https://github.com/apache/myfaces/pull/13 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL

[GitHub] pnicolucci opened a new pull request #10: MYFACES-4244:Use StringBuilder rather than calling write multiple times

2018-07-11 Thread GitBox
pnicolucci opened a new pull request #10: MYFACES-4244:Use StringBuilder rather than calling write multiple times URL: https://github.com/apache/myfaces/pull/10 Creating this PR for discussion on the dev list for MYFACES-4244: https://issues.apache.org/jira/browse/MYFACES-4244

[GitHub] pnicolucci opened a new pull request #11: MYFACES-4247: reduce number of char[] objects and CommonPropertyUtils…

2018-07-12 Thread GitBox
pnicolucci opened a new pull request #11: MYFACES-4247: reduce number of char[] objects and CommonPropertyUtils… URL: https://github.com/apache/myfaces/pull/11 … calls This is an automated message from the Apache Git

[GitHub] pnicolucci commented on issue #11: MYFACES-4247: reduce number of char[] objects and CommonPropertyUtils…

2018-07-12 Thread GitBox
pnicolucci commented on issue #11: MYFACES-4247: reduce number of char[] objects and CommonPropertyUtils… URL: https://github.com/apache/myfaces/pull/11#issuecomment-404571508 @tandraschko can you review these changes and let me know if you have any concerns? If not I'll merge this PR.

[GitHub] bohmber closed pull request #5: converted readme.txt to markdown

2018-03-06 Thread GitBox
bohmber closed pull request #5: converted readme.txt to markdown URL: https://github.com/apache/myfaces-tobago/pull/5 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull

[GitHub] bohmber opened a new pull request #5: converted readme.txt to markdown

2018-03-06 Thread GitBox
bohmber opened a new pull request #5: converted readme.txt to markdown URL: https://github.com/apache/myfaces-tobago/pull/5 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] bohmber closed pull request #6: improved markdown

2018-03-06 Thread GitBox
bohmber closed pull request #6: improved markdown URL: https://github.com/apache/myfaces-tobago/pull/6 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a

[GitHub] bohmber opened a new pull request #6: improved markdown

2018-03-06 Thread GitBox
bohmber opened a new pull request #6: improved markdown URL: https://github.com/apache/myfaces-tobago/pull/6 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use

[GitHub] deki commented on a change in pull request #8: fix Meecrowave sample

2018-03-11 Thread GitBox
deki commented on a change in pull request #8: fix Meecrowave sample URL: https://github.com/apache/myfaces-tobago/pull/8#discussion_r173650522 ## File path: tobago-example/tobago-example-demo/src/main/webapp/WEB-INF/web.xml ## @@ -68,16 +68,16 @@ -

[GitHub] bohmber commented on a change in pull request #8: fix Meecrowave sample

2018-03-11 Thread GitBox
bohmber commented on a change in pull request #8: fix Meecrowave sample URL: https://github.com/apache/myfaces-tobago/pull/8#discussion_r173650474 ## File path: tobago-example/tobago-example-demo/src/main/webapp/WEB-INF/web.xml ## @@ -68,16 +68,16 @@ -

[GitHub] asfgit closed pull request #8: fix Meecrowave sample

2018-03-11 Thread GitBox
asfgit closed pull request #8: fix Meecrowave sample URL: https://github.com/apache/myfaces-tobago/pull/8 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a

[GitHub] bohmber opened a new pull request #9: fixed demo for mojarra

2018-03-12 Thread GitBox
bohmber opened a new pull request #9: fixed demo for mojarra URL: https://github.com/apache/myfaces-tobago/pull/9 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and

[GitHub] bohmber closed pull request #9: fixed demo for mojarra

2018-03-12 Thread GitBox
bohmber closed pull request #9: fixed demo for mojarra URL: https://github.com/apache/myfaces-tobago/pull/9 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from

[GitHub] bohmber commented on a change in pull request #8: fix Meecrowave sample

2018-03-11 Thread GitBox
bohmber commented on a change in pull request #8: fix Meecrowave sample URL: https://github.com/apache/myfaces-tobago/pull/8#discussion_r173647614 ## File path: tobago-example/tobago-example-demo/pom.xml ## @@ -39,7 +39,10 @@ phantomjs 3.7.1 7.0.4 +

[GitHub] bohmber commented on issue #8: fix Meecrowave sample

2018-03-11 Thread GitBox
bohmber commented on issue #8: fix Meecrowave sample URL: https://github.com/apache/myfaces-tobago/pull/8#issuecomment-372100254 Nice addtion This is an automated message from the Apache Git Service. To respond to the

[GitHub] struberg commented on a change in pull request #8: fix Meecrowave sample

2018-03-11 Thread GitBox
struberg commented on a change in pull request #8: fix Meecrowave sample URL: https://github.com/apache/myfaces-tobago/pull/8#discussion_r173648220 ## File path: tobago-example/tobago-example-demo/pom.xml ## @@ -39,7 +39,10 @@ phantomjs 3.7.1 7.0.4 +

[GitHub] deki commented on a change in pull request #8: fix Meecrowave sample

2018-03-11 Thread GitBox
deki commented on a change in pull request #8: fix Meecrowave sample URL: https://github.com/apache/myfaces-tobago/pull/8#discussion_r173648854 ## File path: tobago-example/tobago-example-demo/pom.xml ## @@ -39,7 +39,10 @@ phantomjs 3.7.1 7.0.4 +

[GitHub] bohmber commented on issue #2: Tobago 1589

2018-02-28 Thread GitBox
bohmber commented on issue #2: Tobago 1589 URL: https://github.com/apache/myfaces-tobago/pull/2#issuecomment-369352423 There is still an issue with mojarra 2.0 PostAddToViewEvent, Head and StateHandling in mojarra 2.0. No more energy to find a workaround for the crap mojarra impl.

[GitHub] bohmber closed pull request #2: Tobago 1589

2018-02-28 Thread GitBox
bohmber closed pull request #2: Tobago 1589 URL: https://github.com/apache/myfaces-tobago/pull/2 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork),

[GitHub] bohmber opened a new pull request #10: Tobago-1870

2018-03-13 Thread GitBox
bohmber opened a new pull request #10: Tobago-1870 URL: https://github.com/apache/myfaces-tobago/pull/10 MyFaces core is removing the component resources in the head if the view will be recreated before rendering. The view will be recreated because of expressions. For example

[GitHub] struberg opened a new pull request #8: fix Meecrowave sample

2018-03-10 Thread GitBox
struberg opened a new pull request #8: fix Meecrowave sample URL: https://github.com/apache/myfaces-tobago/pull/8 this now needs a -Pmeecrowave Could certainly need some polishing still - feel free to amend as needed!

[GitHub] bohmber closed pull request #10: Tobago-1870

2018-03-15 Thread GitBox
bohmber closed pull request #10: Tobago-1870 URL: https://github.com/apache/myfaces-tobago/pull/10 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork),

[GitHub] henningn opened a new pull request #7: TOBAGO-1852 Sheet row to open a popup does not work

2018-03-07 Thread GitBox
henningn opened a new pull request #7: TOBAGO-1852 Sheet row to open a popup does not work URL: https://github.com/apache/myfaces-tobago/pull/7 * can now have children of type and * Fix a NPE for merging command maps * Fix log message when evaluateClientId * EventBehavior now

[GitHub] lofwyr14 commented on a change in pull request #7: TOBAGO-1852 Sheet row to open a popup does not work

2018-03-07 Thread GitBox
lofwyr14 commented on a change in pull request #7: TOBAGO-1852 Sheet row to open a popup does not work URL: https://github.com/apache/myfaces-tobago/pull/7#discussion_r172821754 ## File path: tobago-core/src/main/java/org/apache/myfaces/tobago/internal/renderkit/CommandMap.java

[GitHub] henningn commented on issue #7: TOBAGO-1852 Sheet row to open a popup does not work

2018-03-14 Thread GitBox
henningn commented on issue #7: TOBAGO-1852 Sheet row to open a popup does not work URL: https://github.com/apache/myfaces-tobago/pull/7#issuecomment-373041616 Already committed in myfaces-tobago:

[GitHub] bohmber opened a new pull request #11: Tobago 1870

2018-03-31 Thread GitBox
bohmber opened a new pull request #11: Tobago 1870 URL: https://github.com/apache/myfaces-tobago/pull/11 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the

[GitHub] lofwyr14 closed pull request #11: Tobago 1870

2018-04-04 Thread GitBox
lofwyr14 closed pull request #11: Tobago 1870 URL: https://github.com/apache/myfaces-tobago/pull/11 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork),

[GitHub] bohmber opened a new pull request #4: Misc

2018-03-02 Thread GitBox
bohmber opened a new pull request #4: Misc URL: https://github.com/apache/myfaces-tobago/pull/4 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above

[GitHub] bohmber closed pull request #4: Misc

2018-03-02 Thread GitBox
bohmber closed pull request #4: Misc URL: https://github.com/apache/myfaces-tobago/pull/4 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff

[GitHub] bohmber opened a new pull request #3: improved component template

2018-03-02 Thread GitBox
bohmber opened a new pull request #3: improved component template URL: https://github.com/apache/myfaces-tobago/pull/3 added generated annotation This is an automated message from the Apache Git Service. To respond to the

[GitHub] bohmber closed pull request #3: improved component template

2018-03-02 Thread GitBox
bohmber closed pull request #3: improved component template URL: https://github.com/apache/myfaces-tobago/pull/3 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request

[GitHub] bohmber opened a new pull request #2: Tobago 1589

2018-02-28 Thread GitBox
bohmber opened a new pull request #2: Tobago 1589 URL: https://github.com/apache/myfaces-tobago/pull/2 Fix for the mojarra issue. Created the components transient and move decode to sheet back. The explicit remove of the component is needed for mojarra 2.3 (they have the

[GitHub] bohmber commented on issue #2: Tobago 1589

2018-02-28 Thread GitBox
bohmber commented on issue #2: Tobago 1589 URL: https://github.com/apache/myfaces-tobago/pull/2#issuecomment-369297478 Added more fixes for Mojarra. Mojarra is like Klendathu This is an automated message from the Apache Git

[GitHub] bohmber commented on issue #2: Tobago 1589

2018-02-28 Thread GitBox
bohmber commented on issue #2: Tobago 1589 URL: https://github.com/apache/myfaces-tobago/pull/2#issuecomment-369291178 Checkstyle errors are fixed now. This is an automated message from the Apache Git Service. To respond to

[GitHub] lofwyr14 commented on a change in pull request #2: Tobago 1589

2018-02-28 Thread GitBox
lofwyr14 commented on a change in pull request #2: Tobago 1589 URL: https://github.com/apache/myfaces-tobago/pull/2#discussion_r171195827 ## File path: tobago-core/src/main/java/org/apache/myfaces/tobago/internal/renderkit/renderer/SheetRenderer.java ## @@ -132,13 +139,86

[GitHub] lofwyr14 commented on a change in pull request #2: Tobago 1589

2018-02-28 Thread GitBox
lofwyr14 commented on a change in pull request #2: Tobago 1589 URL: https://github.com/apache/myfaces-tobago/pull/2#discussion_r171195751 ## File path: tobago-core/src/main/java/org/apache/myfaces/tobago/internal/renderkit/renderer/SheetRenderer.java ## @@ -132,13 +139,86

[GitHub] lofwyr14 commented on a change in pull request #2: Tobago 1589

2018-02-28 Thread GitBox
lofwyr14 commented on a change in pull request #2: Tobago 1589 URL: https://github.com/apache/myfaces-tobago/pull/2#discussion_r171195972 ## File path: tobago-core/src/main/java/org/apache/myfaces/tobago/internal/renderkit/renderer/SheetRenderer.java ## @@ -132,13 +139,86

[GitHub] pnicolucci closed pull request #9: MYFACES-4239: Multiple performance improvements

2018-06-28 Thread GitBox
pnicolucci closed pull request #9: MYFACES-4239: Multiple performance improvements URL: https://github.com/apache/myfaces/pull/9 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] pnicolucci opened a new pull request #9: MYFACES-4239

2018-06-28 Thread GitBox
pnicolucci opened a new pull request #9: MYFACES-4239 URL: https://github.com/apache/myfaces/pull/9 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL

[GitHub] pnicolucci opened a new pull request #8: MYFACES-4239: Multiple performance improvements

2018-06-22 Thread GitBox
pnicolucci opened a new pull request #8: MYFACES-4239: Multiple performance improvements URL: https://github.com/apache/myfaces/pull/8 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] pnicolucci commented on issue #8: MYFACES-4239: Multiple performance improvements

2018-06-22 Thread GitBox
pnicolucci commented on issue #8: MYFACES-4239: Multiple performance improvements URL: https://github.com/apache/myfaces/pull/8#issuecomment-399469835 I'll refactor a bit to use the SharedStringBuilder. Thanks for the information / review!

[GitHub] tandraschko commented on issue #18: MYFACES-4082 Fix 'binding' when referencing composite components

2018-10-22 Thread GitBox
tandraschko commented on issue #18: MYFACES-4082 Fix 'binding' when referencing composite components URL: https://github.com/apache/myfaces/pull/18#issuecomment-431913183 @luigiJsonar the ComponentTagHandlerDelegate contains the following, before setting the value: if

[GitHub] tandraschko commented on issue #18: MYFACES-4082 Fix 'binding' when referencing composite components

2018-10-22 Thread GitBox
tandraschko commented on issue #18: MYFACES-4082 Fix 'binding' when referencing composite components URL: https://github.com/apache/myfaces/pull/18#issuecomment-431914558 @luigiJsonar Could you please try this:

[GitHub] ebreijo opened a new pull request #24: MYFACES-4260: Context map from CDI ViewScope is not being cleared at …

2018-10-23 Thread GitBox
ebreijo opened a new pull request #24: MYFACES-4260: Context map from CDI ViewScope is not being cleared at … URL: https://github.com/apache/myfaces/pull/24 …destroy time This is an automated message from the Apache Git

[GitHub] ebreijo opened a new pull request #23: MYFACES-4260: Context map from CDI ViewScope is not being cleared at …

2018-10-23 Thread GitBox
ebreijo opened a new pull request #23: MYFACES-4260: Context map from CDI ViewScope is not being cleared at … URL: https://github.com/apache/myfaces/pull/23 …destroy time This is an automated message from the Apache Git

[GitHub] ebreijo opened a new pull request #25: MYFACES-4260: Context map from CDI ViewScope is not being cleared at …

2018-10-23 Thread GitBox
ebreijo opened a new pull request #25: MYFACES-4260: Context map from CDI ViewScope is not being cleared at … URL: https://github.com/apache/myfaces/pull/25 …destroy time This is an automated message from the Apache Git

[GitHub] ebreijo closed pull request #25: MYFACES-4260: Context map from CDI ViewScope is not being cleared at …

2018-10-25 Thread GitBox
ebreijo closed pull request #25: MYFACES-4260: Context map from CDI ViewScope is not being cleared at … URL: https://github.com/apache/myfaces/pull/25 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] ebreijo closed pull request #24: MYFACES-4260: Context map from CDI ViewScope is not being cleared at …

2018-10-25 Thread GitBox
ebreijo closed pull request #24: MYFACES-4260: Context map from CDI ViewScope is not being cleared at … URL: https://github.com/apache/myfaces/pull/24 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] ebreijo closed pull request #23: MYFACES-4260: Context map from CDI ViewScope is not being cleared at …

2018-10-25 Thread GitBox
ebreijo closed pull request #23: MYFACES-4260: Context map from CDI ViewScope is not being cleared at … URL: https://github.com/apache/myfaces/pull/23 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] luigiJsonar commented on issue #18: MYFACES-4082 Fix 'binding' when referencing composite components

2018-11-07 Thread GitBox
luigiJsonar commented on issue #18: MYFACES-4082 Fix 'binding' when referencing composite components URL: https://github.com/apache/myfaces/pull/18#issuecomment-436758724 I'd be more than happy to apply any other suggestions, open more PRs for previous versions, test it... I don't

[GitHub] tandraschko edited a comment on issue #18: MYFACES-4082 Fix 'binding' when referencing composite components

2018-11-07 Thread GitBox
tandraschko edited a comment on issue #18: MYFACES-4082 Fix 'binding' when referencing composite components URL: https://github.com/apache/myfaces/pull/18#issuecomment-436766191 Sorry, please don't take it personally. I didn't see that you applied my changes, so i commited my version,

[GitHub] tandraschko commented on issue #18: MYFACES-4082 Fix 'binding' when referencing composite components

2018-11-07 Thread GitBox
tandraschko commented on issue #18: MYFACES-4082 Fix 'binding' when referencing composite components URL: https://github.com/apache/myfaces/pull/18#issuecomment-436766191 Sorry, please don't take it personally. I didn't see that you applied my changes, so i commited my version, which was

  1   2   >