[jira] [Commented] (TOBAGO-1852) Sheet row to open a popup does not work
[ https://issues.apache.org/jira/browse/TOBAGO-1852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16398670#comment-16398670 ] ASF GitHub Bot commented on TOBAGO-1852: henningn commented on issue #7: TOBAGO-1852 Sheet row to open a popup does not work URL: https://github.com/apache/myfaces-tobago/pull/7#issuecomment-373041616 Already committed in myfaces-tobago: [fa9d600c94068b46d3508e88065bd100fb80effd](https://github.com/apache/myfaces-tobago/commit/fa9d600c94068b46d3508e88065bd100fb80effd) [6a8602f538e7b7f0b2e16c19df02dcb21fceef14](https://github.com/apache/myfaces-tobago/commit/6a8602f538e7b7f0b2e16c19df02dcb21fceef14) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Sheet row to open a popup does not work > --- > > Key: TOBAGO-1852 > URL: https://issues.apache.org/jira/browse/TOBAGO-1852 > Project: MyFaces Tobago > Issue Type: Bug > Components: Core, Demo >Reporter: Udo Schnurpfeil >Assignee: Henning Noeth >Priority: Major > Fix For: 4.2.0 > > > # open > http://tobago-vm.apache.org/demo-4-snapshot/content/20-component/080-sheet/30-event/sheet-event.xhtml > # Select radio: open popup on click with AJAX > # Klick on a row -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (TOBAGO-1852) Sheet row to open a popup does not work
[ https://issues.apache.org/jira/browse/TOBAGO-1852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16398473#comment-16398473 ] Hudson commented on TOBAGO-1852: SUCCESS: Integrated in Jenkins build Tobago Trunk #1341 (See [https://builds.apache.org/job/Tobago%20Trunk/1341/]) TOBAGO-1852 Sheet row to open a popup does not work (hnoeth: rev 6a8602f538e7b7f0b2e16c19df02dcb21fceef14) * (edit) tobago-core/src/main/java/org/apache/myfaces/tobago/internal/behavior/EventBehavior.java * (edit) tobago-core/src/main/java/org/apache/myfaces/tobago/facelets/EventHandler.java * (edit) tobago-example/tobago-example-demo/src/test/java/org/apache/myfaces/tobago/example/demo/QUnitTests.java * (edit) tobago-example/tobago-example-demo/src/main/webapp/content/20-component/070-tab/tab.xhtml * (edit) tobago-core/src/main/java/org/apache/myfaces/tobago/internal/util/RenderUtils.java * (edit) tobago-core/src/main/java/org/apache/myfaces/tobago/internal/renderkit/renderer/TabGroupRenderer.java * (add) tobago-example/tobago-example-demo/src/main/webapp/content/20-component/070-tab/tab.test.js > Sheet row to open a popup does not work > --- > > Key: TOBAGO-1852 > URL: https://issues.apache.org/jira/browse/TOBAGO-1852 > Project: MyFaces Tobago > Issue Type: Bug > Components: Core, Demo >Reporter: Udo Schnurpfeil >Assignee: Henning Noeth >Priority: Major > Fix For: 4.2.0 > > > # open > http://tobago-vm.apache.org/demo-4-snapshot/content/20-component/080-sheet/30-event/sheet-event.xhtml > # Select radio: open popup on click with AJAX > # Klick on a row -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (TOBAGO-1852) Sheet row to open a popup does not work
[ https://issues.apache.org/jira/browse/TOBAGO-1852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16397467#comment-16397467 ] Hudson commented on TOBAGO-1852: FAILURE: Integrated in Jenkins build Tobago Trunk #1339 (See [https://builds.apache.org/job/Tobago%20Trunk/1339/]) TOBAGO-1852 Sheet row to open a popup does not work (hnoeth: rev fa9d600c94068b46d3508e88065bd100fb80effd) * (edit) tobago-core/src/main/java/org/apache/myfaces/tobago/internal/renderkit/renderer/RowRenderer.java * (edit) tobago-example/tobago-example-demo/src/test/java/org/apache/myfaces/tobago/example/demo/QUnitTests.java * (edit) tobago-core/src/main/java/org/apache/myfaces/tobago/internal/taglib/component/EventTagDeclaration.java * (edit) tobago-core/src/main/java/org/apache/myfaces/tobago/util/ComponentUtils.java * (edit) tobago-core/src/main/java/org/apache/myfaces/tobago/internal/behavior/EventBehavior.java * (add) tobago-example/tobago-example-demo/src/main/java/org/apache/myfaces/tobago/example/demo/BehaviorTestController.java * (add) tobago-example/tobago-example-demo/src/main/webapp/content/40-test/6500-behavior/behavior.test.js * (edit) tobago-core/src/main/java/org/apache/myfaces/tobago/internal/renderkit/renderer/TobagoClientBehaviorRenderer.java * (edit) tobago-core/src/main/java/org/apache/myfaces/tobago/facelets/EventHandler.java * (edit) tobago-core/src/main/java/org/apache/myfaces/tobago/internal/component/AbstractUIEvent.java * (edit) tobago-example/tobago-example-demo/src/main/java/org/apache/myfaces/tobago/example/demo/BehaviorController.java * (edit) tobago-example/tobago-example-demo/src/main/webapp/content/20-component/080-sheet/30-event/sheet-event.test.js * (edit) tobago-example/tobago-example-demo/src/main/webapp/content/20-component/080-sheet/30-event/sheet-event.xhtml * (edit) tobago-example/tobago-example-demo/src/main/webapp/content/30-concept/30-behavior/behavior.xhtml * (edit) tobago-core/src/main/java/org/apache/myfaces/tobago/internal/renderkit/CommandMap.java * (edit) tobago-core/src/main/java/org/apache/myfaces/tobago/internal/util/RenderUtils.java * (add) tobago-example/tobago-example-demo/src/main/webapp/content/40-test/6500-behavior/behavior.xhtml > Sheet row to open a popup does not work > --- > > Key: TOBAGO-1852 > URL: https://issues.apache.org/jira/browse/TOBAGO-1852 > Project: MyFaces Tobago > Issue Type: Bug > Components: Core, Demo >Reporter: Udo Schnurpfeil >Assignee: Henning Noeth >Priority: Major > Fix For: 4.2.0 > > > # open > http://tobago-vm.apache.org/demo-4-snapshot/content/20-component/080-sheet/30-event/sheet-event.xhtml > # Select radio: open popup on click with AJAX > # Klick on a row -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (TOBAGO-1852) Sheet row to open a popup does not work
[
https://issues.apache.org/jira/browse/TOBAGO-1852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16389460#comment-16389460
]
ASF GitHub Bot commented on TOBAGO-1852:
lofwyr14 commented on a change in pull request #7: TOBAGO-1852 Sheet row to
open a popup does not work
URL: https://github.com/apache/myfaces-tobago/pull/7#discussion_r172821754
##
File path:
tobago-core/src/main/java/org/apache/myfaces/tobago/internal/renderkit/CommandMap.java
##
@@ -104,14 +104,16 @@ public static CommandMap merge(final CommandMap m1,
final CommandMap m2) {
c1.merge(c2);
}
} else {
- for (final Map.Entry entry :
m2.getOther().entrySet()) {
-final ClientBehaviors key = entry.getKey();
-final Command value = entry.getValue();
-if (m1.other.containsKey(key)) {
- final Command command = m1.other.get(key);
- command.merge(value);
-} else {
- m1.addCommand(key, value);
+ if (m1.getOther() != null && m2.getOther() != null) {
Review comment:
Please use "other" instead of "getOther()" for internal calls (performance).
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Sheet row to open a popup does not work
> ---
>
> Key: TOBAGO-1852
> URL: https://issues.apache.org/jira/browse/TOBAGO-1852
> Project: MyFaces Tobago
> Issue Type: Bug
> Components: Core, Demo
>Reporter: Udo Schnurpfeil
>Assignee: Henning Noeth
>Priority: Major
> Fix For: 4.2.0
>
>
> # open
> http://tobago-vm.apache.org/demo-4-snapshot/content/20-component/080-sheet/30-event/sheet-event.xhtml
> # Select radio: open popup on click with AJAX
> # Klick on a row
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (TOBAGO-1852) Sheet row to open a popup does not work
[ https://issues.apache.org/jira/browse/TOBAGO-1852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16389271#comment-16389271 ] ASF GitHub Bot commented on TOBAGO-1852: henningn opened a new pull request #7: TOBAGO-1852 Sheet row to open a popup does not work URL: https://github.com/apache/myfaces-tobago/pull/7 * can now have children of type and * Fix a NPE for merging command maps * Fix log message when evaluateClientId * EventBehavior now have an id to identify related component * 'disabled' attribute of is now supported - does the same as rendered * A component can now have both and if only one is enabled This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Sheet row to open a popup does not work > --- > > Key: TOBAGO-1852 > URL: https://issues.apache.org/jira/browse/TOBAGO-1852 > Project: MyFaces Tobago > Issue Type: Bug > Components: Core, Demo >Reporter: Udo Schnurpfeil >Assignee: Henning Noeth >Priority: Major > Fix For: 4.2.0 > > > # open > http://tobago-vm.apache.org/demo-4-snapshot/content/20-component/080-sheet/30-event/sheet-event.xhtml > # Select radio: open popup on click with AJAX > # Klick on a row -- This message was sent by Atlassian JIRA (v7.6.3#76005)
