[jira] [Commented] (TOBAGO-1881) Label-Facet of tc:section and tc:box are different
[ https://issues.apache.org/jira/browse/TOBAGO-1881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16434103#comment-16434103 ] Hudson commented on TOBAGO-1881: FAILURE: Integrated in Jenkins build Tobago Trunk #1364 (See [https://builds.apache.org/job/Tobago%20Trunk/1364/]) TOBAGO-1881 Label-Facet of tc:section and tc:box are different (hnoeth: rev 5aee33d4973a07b70cd69ac6af41d6731660) * (add) tobago-example/tobago-example-demo/src/main/webapp/content/20-component/050-container/10-box/box.test.js * (edit) tobago-core/src/main/java/org/apache/myfaces/tobago/internal/taglib/component/SectionTagDeclaration.java * (edit) tobago-example/tobago-example-demo/src/test/java/org/apache/myfaces/tobago/example/demo/QUnitTests.java * (edit) tobago-example/tobago-example-demo/src/main/webapp/content/20-component/050-container/10-box/box.xhtml * (edit) tobago-core/src/main/java/org/apache/myfaces/tobago/internal/component/AbstractUICollapsiblePanel.java > Label-Facet of tc:section and tc:box are different > -- > > Key: TOBAGO-1881 > URL: https://issues.apache.org/jira/browse/TOBAGO-1881 > Project: MyFaces Tobago > Issue Type: Improvement > Components: Core >Affects Versions: 4.1.0 >Reporter: Henning Noeth >Assignee: Henning Noeth >Priority: Major > Fix For: 4.2.0 > > > The label-facet of tc:section is different compared with tc:box. > On tc:section the facet only allows tc:out. > On tc:box, all added components are rendered in the label-facet such as: > tc:button, tc:link, tc:out... > The rendering of tc:out is also different. > On tc:section it replaces the label-attribute. No surrounding DIV, no ID... > In tc:box, the tc:out component is rendered with surrounding DIV and an ID. > You should use labelLayout=skip and compact=true to avoid unnecessary margins. > What should be done? > tc:out should be rendered as in tc:section. > All other components should be rendered as in tc:box. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (TOBAGO-1881) Label-Facet of tc:section and tc:box are different
[ https://issues.apache.org/jira/browse/TOBAGO-1881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16425549#comment-16425549 ] Hudson commented on TOBAGO-1881: SUCCESS: Integrated in Jenkins build Tobago Trunk #1354 (See [https://builds.apache.org/job/Tobago%20Trunk/1354/]) TOBAGO-1881 Label-Facet of tc:section and tc:box are different (hnoeth: rev 245fa3bfdd6671cf11ee4e3e5dc5372a2e28228e) * (add) tobago-core/src/main/java/org/apache/myfaces/tobago/internal/renderkit/renderer/OutInsideSectionLabelRenderer.java * (edit) tobago-core/src/main/java/org/apache/myfaces/tobago/internal/component/AbstractUISection.java * (edit) tobago-core/src/main/java/org/apache/myfaces/tobago/internal/renderkit/renderer/BoxRenderer.java * (edit) tobago-core/src/main/java/org/apache/myfaces/tobago/internal/util/RenderUtils.java * (add) tobago-example/tobago-example-demo/src/main/java/org/apache/myfaces/tobago/example/demo/BoxController.java * (add) tobago-example/tobago-example-demo/src/main/webapp/content/40-test/4-style/100-headings/headings.xhtml * (edit) tobago-core/src/main/java/org/apache/myfaces/tobago/internal/taglib/component/OutTagDeclaration.java * (edit) tobago-example/tobago-example-demo/src/main/webapp/content/20-component/050-container/10-box/box.xhtml * (edit) tobago-core/src/main/java/org/apache/myfaces/tobago/component/RendererTypes.java * (add) tobago-example/tobago-example-demo/src/main/webapp/content/40-test/4-style/style.xhtml * (edit) tobago-core/src/main/java/org/apache/myfaces/tobago/internal/renderkit/renderer/InRenderer.java * (add) tobago-core/src/main/java/org/apache/myfaces/tobago/internal/renderkit/renderer/OutInsideBoxLabelRenderer.java * (edit) tobago-core/src/main/java/org/apache/myfaces/tobago/internal/renderkit/renderer/SectionRenderer.java * (edit) tobago-core/src/main/resources/scss/_tobago.scss * (add) tobago-example/tobago-example-demo/src/main/webapp/content/40-test/4-style/100-headings/headings.test.js > Label-Facet of tc:section and tc:box are different > -- > > Key: TOBAGO-1881 > URL: https://issues.apache.org/jira/browse/TOBAGO-1881 > Project: MyFaces Tobago > Issue Type: Improvement > Components: Core >Affects Versions: 4.1.0 >Reporter: Henning Noeth >Assignee: Henning Noeth >Priority: Major > Fix For: 4.2.0 > > > The label-facet of tc:section is different compared with tc:box. > On tc:section the facet only allows tc:out. > On tc:box, all added components are rendered in the label-facet such as: > tc:button, tc:link, tc:out... > The rendering of tc:out is also different. > On tc:section it replaces the label-attribute. No surrounding DIV, no ID... > In tc:box, the tc:out component is rendered with surrounding DIV and an ID. > You should use labelLayout=skip and compact=true to avoid unnecessary margins. > What should be done? > tc:out should be rendered as in tc:section. > All other components should be rendered as in tc:box. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
