Re: [PR] MYFACES-4695: Allow searching for ids with separator character [5.0] [myfaces]
volosied merged PR #806: URL: https://github.com/apache/myfaces/pull/806 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] MYFACES-4695: Allow searching for ids with separator character [5.0] [myfaces]
tandraschko commented on PR #806: URL: https://github.com/apache/myfaces/pull/806#issuecomment-2493947255 +1 just proceed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] MYFACES-4695: Allow searching for ids with separator character [5.0] [myfaces]
tandraschko commented on code in PR #806:
URL: https://github.com/apache/myfaces/pull/806#discussion_r1853594913
##
impl/src/main/java/org/apache/myfaces/component/search/SearchExpressionHandlerImpl.java:
##
@@ -534,8 +534,8 @@ public void invokeContextCallback(FacesContext context,
UIComponent target)
// At this point if the algorithm hasn't returned and the
topExpression does not have any separator char
// we need to do the search backward using findComponent.
if (target == null
-&& searchExpressionContext.getSource() == previous
-&& (topExpression.indexOf(separatorChar) == -1) )
+&& searchExpressionContext.getSource() == previous )
+// && (topExpression.indexOf(separatorChar) == -1) )
removed for MYFACES-4695
Review Comment:
if you replace it with
`&& (topExpression.indexOf(":@") == -1))`
im fine with it; please dont forget all other branches
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] MYFACES-4695: Allow searching for ids with separator character [5.0] [myfaces]
tandraschko commented on PR #806: URL: https://github.com/apache/myfaces/pull/806#issuecomment-2492317685 Then let me check it In mojarra they use a invokeOnComponent Fallback, Leo optimized the algorithm in mf -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] MYFACES-4695: Allow searching for ids with separator character [5.0] [myfaces]
volosied commented on PR #806: URL: https://github.com/apache/myfaces/pull/806#issuecomment-2491884871 Mojarra 4.1.2 works without needing the prepended `:` -- it find the component. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] MYFACES-4695: Allow searching for ids with separator character [5.0] [myfaces]
tandraschko commented on PR #806: URL: https://github.com/apache/myfaces/pull/806#issuecomment-2491867541 Can you Test it in mojarra? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] MYFACES-4695: Allow searching for ids with separator character [5.0] [myfaces]
tandraschko commented on PR #806: URL: https://github.com/apache/myfaces/pull/806#issuecomment-2491655683 i think it was a hack around it, it matches your example: https://github.com/apache/myfaces/blob/2.2.x/impl/src/main/java/org/apache/myfaces/renderkit/html/HtmlAjaxBehaviorRenderer.java#L498 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] MYFACES-4695: Allow searching for ids with separator character [5.0] [myfaces]
volosied commented on PR #806: URL: https://github.com/apache/myfaces/pull/806#issuecomment-2491647936 One more data point -- this previously worked in 2.2, but then changed in 2.3 due to addition of the SearchExpressionHandler API. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] MYFACES-4695: Allow searching for ids with separator character [5.0] [myfaces]
tandraschko commented on PR #806: URL: https://github.com/apache/myfaces/pull/806#issuecomment-2491638116 and its like this for ages either we dont support it or we add a config, disabled per default, to allow this -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] MYFACES-4695: Allow searching for ids with separator character [5.0] [myfaces]
tandraschko commented on PR #806: URL: https://github.com/apache/myfaces/pull/806#issuecomment-2491636192 its clearly described in the specs: `Otherwise, search up the parents of this component. If a [NamingContainer](https://docs.oracle.com/javaee/7/api/javax/faces/component/NamingContainer.html) is encountered, it will be the base.` https://docs.oracle.com/javaee/7/api/javax/faces/component/UIComponentBase.html#findComponent-java.lang.String- -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] MYFACES-4695: Allow searching for ids with separator character [5.0] [myfaces]
volosied commented on PR #806: URL: https://github.com/apache/myfaces/pull/806#issuecomment-2491598928 I see this as more of a convenience. The spec describes the search algorithm here: https://jakarta.ee/specifications/faces/4.1/apidocs/jakarta.faces/jakarta/faces/component/search/searchexpressionhandler However, it also states "The search algorithm must operate as follows, **though alternate algorithms may be used as long as the end result is the same:**" If the component can't be found, then it will throw an exception, but, in my opinion, it should keep searching, if possible to find the component. As for the code, we do a bottom - up search (see this [line](https://github.com/apache/myfaces/blob/173739656b99a06b67aa493084db5c2a41c1f4cf/impl/src/main/java/org/apache/myfaces/component/search/SearchExpressionHandlerImpl.java#L535C1-L535C70)) if we can't find the component, should we use try from the root instead? Let me know what you think. Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] MYFACES-4695: Allow searching for ids with separator character [5.0] [myfaces]
tandraschko commented on PR #806: URL: https://github.com/apache/myfaces/pull/806#issuecomment-2490409715 i dont think the case is valid, it needs to be `` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] MYFACES-4695: Allow searching for ids with separator character [5.0] [myfaces]
volosied commented on PR #806: URL: https://github.com/apache/myfaces/pull/806#issuecomment-2489805142 Added a test -- without my fix it fails with ``` [ERROR] Errors: [ERROR] SearchExpressionImplTest.testMyFaces4695:423 ยป ComponentNotFound Cannot find component for expression "form1:one" referenced from "form2:submit". [INFO] ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
