Re: Packaging JRE in RCP installer

2019-09-13 Thread Oliver Rettig
Hi all, very thanks to figure it out and solve this old problem. best regards Oliver > Christian, the bitness of cleaner.exe makes absolutely no difference > to your aim of enforcing 64Bit. I do not plan to change anything > buildwise, only the C code, meaning it will still be a 32 bit > executable

Re: Packaging JRE in RCP installer

2019-09-12 Thread Lars Bruun-Hansen
Christian, the bitness of cleaner.exe makes absolutely no difference to your aim of enforcing 64Bit. I do not plan to change anything buildwise, only the C code, meaning it will still be a 32 bit executable. In fact I dread if I would have to look into the build system in Apache NetBeans of this th

Re: Packaging JRE in RCP installer

2019-09-12 Thread Emilian Bold
> @Emilian Bold: Where would I document? Please point me in right direction. Thanks. I see these pages https://netbeans.apache.org/wiki/index.asciidoc are on GitHub here https://github.com/apache/netbeans-website/tree/master/netbeans.apache.org/src/content/wiki So you could make a PR against Gi

Re: Packaging JRE in RCP installer

2019-09-12 Thread Christian Oyarzun
Lars, Is the plan to continue to keep the cleaner as a 32bit exe? $ file cleaner.exe cleaner.exe: PE32 executable (GUI) Intel 80386, for MS Windows The nlw.exe executable was built as a 64bit exe, which used to be 32bit in previous NetBeans releases. This would prevent using the NBI to create a

Re: Packaging JRE in RCP installer

2019-09-12 Thread Lars Bruun-Hansen
I've filed a Jira ticket : https://issues.apache.org/jira/browse/NETBEANS-3094 with the aim to change the C code for the cleaner.exe to be able to delete read-only files too. It is rather trivial. I've assigned it to myself. @Emilian Bold: Where would I document? Please point me in right directio

Re: Packaging JRE in RCP installer

2019-09-12 Thread Christian Oyarzun
Oliver, it is just a question of changing the permissions on the files before zipping the JRE. I'm using a modified version (JRE instead of JDK) of jMonkeyEngine's script to create the JRE unzipsfx files. It's a question of adding the following to https://github.com/jMonkeyEngine/sdk/blob/d722640

Re: Packaging JRE in RCP installer

2019-09-12 Thread Oliver Rettig
Hi, I remember on such problems also with Netbeans 8.2. It had todo with access rights. I am interested in if you can figure it out. best regards Oliver > Is anyone packaging the JRE in a RCP installer using Netbeans 11.1 > following these instructions? > https://dzone.com/articles/including-jre-

Re: Packaging JRE in RCP installer

2019-09-12 Thread Emilian Bold
Lars, those notes do deserve a wiki page indeed. --emi joi, 12 sept. 2019, 20:45 Lars Bruun-Hansen a scris: > Hi Christian > > I once wrote some notes on how the cleaner works. (yes, they are > probably worthy of a Wiki page, but currently the only exist here). It > was written about 5 years ag

Re: Packaging JRE in RCP installer

2019-09-12 Thread Christian Oyarzun
Hi Lars, Thanks for the information. Your guess was correct, those files had the read-only attribute set. Unsetting those attributes allowed the clearer to remove the files and top-level directory. Thanks, Christian On Thu, Sep 12, 2019 at 1:45 PM Lars Bruun-Hansen wrote: > Hi Christian > > I

Re: Packaging JRE in RCP installer

2019-09-12 Thread Lars Bruun-Hansen
Hi Christian I once wrote some notes on how the cleaner works. (yes, they are probably worthy of a Wiki page, but currently the only exist here). It was written about 5 years ago, but I doubt it has changed. The notes are below and I think they are worth the read because I'm guessing they implicit