[jira] [Commented] (NUTCH-2520) Wrong Accept-Charset sent when http.accept.charset is not defined

2018-03-06 Thread Hudson (JIRA) 

[ 
https://issues.apache.org/jira/browse/NUTCH-2520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16387473#comment-16387473
 ] 

Hudson commented on NUTCH-2520:
---

SUCCESS: Integrated in Jenkins build Nutch-trunk #3504 (See 
[https://builds.apache.org/job/Nutch-trunk/3504/])
NUTCH-2520 Use default value for Accept-Charset if http.accept.charset (snagel: 
[https://github.com/apache/nutch/commit/100816fac9cddf99759fe1fc9d22adcf7a2ed4fa])
* (edit) 
src/plugin/lib-http/src/java/org/apache/nutch/protocol/http/api/HttpBase.java


> Wrong Accept-Charset sent when http.accept.charset is not defined
> -
>
> Key: NUTCH-2520
> URL: https://issues.apache.org/jira/browse/NUTCH-2520
> Project: Nutch
>  Issue Type: Bug
>  Components: protocol
>Affects Versions: 2.4, 1.14
>Reporter: Sebastian Nagel
>Assignee: Sebastian Nagel
>Priority: Minor
> Fix For: 2.4, 1.15
>
>
> When the property http.accept.charset is not defined, instead of the 
> hard-wired default value {{utf-8,iso-8859-1;q=0.7,*;q=0.7}} that of the 
> "Accept" field is used. Introduced by NUTCH-2376 
> ([HttpBase|https://github.com/apache/nutch/pull/186/files#diff-432a58c46ab1e686ef05a84cace29790R164]).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (NUTCH-2520) Wrong Accept-Charset sent when http.accept.charset is not defined

2018-03-06 Thread Hudson (JIRA) 

[ 
https://issues.apache.org/jira/browse/NUTCH-2520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16387464#comment-16387464
 ] 

Hudson commented on NUTCH-2520:
---

SUCCESS: Integrated in Jenkins build Nutch-nutchgora #1602 (See 
[https://builds.apache.org/job/Nutch-nutchgora/1602/])
NUTCH-2520 Use default value for Accept-Charset if http.accept.charset (snagel: 
[https://github.com/apache/nutch/commit/4c7275684d5b88cedc39a212e5867d80643f26c3])
* (edit) 
src/plugin/lib-http/src/java/org/apache/nutch/protocol/http/api/HttpBase.java


> Wrong Accept-Charset sent when http.accept.charset is not defined
> -
>
> Key: NUTCH-2520
> URL: https://issues.apache.org/jira/browse/NUTCH-2520
> Project: Nutch
>  Issue Type: Bug
>  Components: protocol
>Affects Versions: 2.4, 1.14
>Reporter: Sebastian Nagel
>Assignee: Sebastian Nagel
>Priority: Minor
> Fix For: 2.4, 1.15
>
>
> When the property http.accept.charset is not defined, instead of the 
> hard-wired default value {{utf-8,iso-8859-1;q=0.7,*;q=0.7}} that of the 
> "Accept" field is used. Introduced by NUTCH-2376 
> ([HttpBase|https://github.com/apache/nutch/pull/186/files#diff-432a58c46ab1e686ef05a84cace29790R164]).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (NUTCH-2520) Wrong Accept-Charset sent when http.accept.charset is not defined

2018-03-06 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/NUTCH-2520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16387461#comment-16387461
 ] 

ASF GitHub Bot commented on NUTCH-2520:
---

sebastian-nagel closed pull request #288: NUTCH-2520 Use default value for 
Accept-Charset
URL: https://github.com/apache/nutch/pull/288
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git 
a/src/plugin/lib-http/src/java/org/apache/nutch/protocol/http/api/HttpBase.java 
b/src/plugin/lib-http/src/java/org/apache/nutch/protocol/http/api/HttpBase.java
index b8d2c6fa5..d218cbc98 100644
--- 
a/src/plugin/lib-http/src/java/org/apache/nutch/protocol/http/api/HttpBase.java
+++ 
b/src/plugin/lib-http/src/java/org/apache/nutch/protocol/http/api/HttpBase.java
@@ -161,7 +161,7 @@ public void setConf(Configuration conf) {
 conf.get("http.agent.url"), conf.get("http.agent.email"));
 this.acceptLanguage = conf.get("http.accept.language", acceptLanguage)
 .trim();
-this.acceptCharset = conf.get("http.accept.charset", accept).trim();
+this.acceptCharset = conf.get("http.accept.charset", acceptCharset).trim();
 this.accept = conf.get("http.accept", accept).trim();
 // backward-compatible default setting
 this.useHttp11 = conf.getBoolean("http.useHttp11", false);


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Wrong Accept-Charset sent when http.accept.charset is not defined
> -
>
> Key: NUTCH-2520
> URL: https://issues.apache.org/jira/browse/NUTCH-2520
> Project: Nutch
>  Issue Type: Bug
>  Components: protocol
>Affects Versions: 2.4, 1.14
>Reporter: Sebastian Nagel
>Priority: Minor
> Fix For: 2.4, 1.15
>
>
> When the property http.accept.charset is not defined, instead of the 
> hard-wired default value {{utf-8,iso-8859-1;q=0.7,*;q=0.7}} that of the 
> "Accept" field is used. Introduced by NUTCH-2376 
> ([HttpBase|https://github.com/apache/nutch/pull/186/files#diff-432a58c46ab1e686ef05a84cace29790R164]).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (NUTCH-2520) Wrong Accept-Charset sent when http.accept.charset is not defined

2018-03-05 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/NUTCH-2520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16386336#comment-16386336
 ] 

ASF GitHub Bot commented on NUTCH-2520:
---

lewismc commented on issue #288: NUTCH-2520 Use default value for Accept-Charset
URL: https://github.com/apache/nutch/pull/288#issuecomment-370484879
 
 
   +1


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Wrong Accept-Charset sent when http.accept.charset is not defined
> -
>
> Key: NUTCH-2520
> URL: https://issues.apache.org/jira/browse/NUTCH-2520
> Project: Nutch
>  Issue Type: Bug
>  Components: protocol
>Affects Versions: 1.14
>Reporter: Sebastian Nagel
>Priority: Minor
> Fix For: 1.15
>
>
> When the property http.accept.charset is not defined, instead of the 
> hard-wired default value {{utf-8,iso-8859-1;q=0.7,*;q=0.7}} that of the 
> "Accept" field is used. Introduced by NUTCH-2376 
> ([HttpBase|https://github.com/apache/nutch/pull/186/files#diff-432a58c46ab1e686ef05a84cace29790R164]).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (NUTCH-2520) Wrong Accept-Charset sent when http.accept.charset is not defined

2018-03-05 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/NUTCH-2520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16386018#comment-16386018
 ] 

ASF GitHub Bot commented on NUTCH-2520:
---

sebastian-nagel opened a new pull request #288: NUTCH-2520 Use default value 
for Accept-Charset
URL: https://github.com/apache/nutch/pull/288
 
 
if http.accept.charset is undefined


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Wrong Accept-Charset sent when http.accept.charset is not defined
> -
>
> Key: NUTCH-2520
> URL: https://issues.apache.org/jira/browse/NUTCH-2520
> Project: Nutch
>  Issue Type: Bug
>  Components: protocol
>Affects Versions: 1.14
>Reporter: Sebastian Nagel
>Priority: Minor
> Fix For: 1.15
>
>
> When the property http.accept.charset is not defined, instead of the 
> hard-wired default value {{utf-8,iso-8859-1;q=0.7,*;q=0.7}} that of the 
> "Accept" field is used. Introduced by NUTCH-2376 
> ([HttpBase|https://github.com/apache/nutch/pull/186/files#diff-432a58c46ab1e686ef05a84cace29790R164]).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)