Re: [PR] NUTCH-3032 Code for an ArbitraryIndexingFilter to index values resolved by user POJO code at index time [nutch]

lewismc merged PR #810: URL: https://github.com/apache/nutch/pull/810 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@nutch.apache.org

Re: [PR] NUTCH-3032 Code for an ArbitraryIndexingFilter to index values resolved by user POJO code at index time [nutch]

CatChullain commented on PR #810: URL: https://github.com/apache/nutch/pull/810#issuecomment-2028497765 Thanks again, @lewismc. I did add those INFO messages, but I found an extra call to setIndexedConf from setConf that the filter() method handles more cleanly, so I removed that,

Re: [PR] NUTCH-3032 Code for an ArbitraryIndexingFilter to index values resolved by user POJO code at index time [nutch]

lewismc commented on PR #810: URL: https://github.com/apache/nutch/pull/810#issuecomment-2028343327 Hi @CatChullain I associated this Jira ticket to the 1.20 release and made you assignee  We will get it merged soon and roll the release. -- This is an automated message from the

Re: [PR] NUTCH-3032 Code for an ArbitraryIndexingFilter to index values resolved by user POJO code at index time [nutch]

lewismc commented on PR #810: URL: https://github.com/apache/nutch/pull/810#issuecomment-2028304406 @CatChullain thanks for your patience whilst we work this one  > … I wonder where might be good spots for INFO level messages The reason I suggested that the log level be

Re: [PR] NUTCH-3032 Code for an ArbitraryIndexingFilter to index values resolved by user POJO code at index time [nutch]

CatChullain commented on PR #810: URL: https://github.com/apache/nutch/pull/810#issuecomment-2028122038 Thanks, Lewis! I moved all four to DEBUG, but I wonder where might be good spots for INFO level messages. I'm thinking of the operator or tech who doesn't dig into code and has an issue

Re: [PR] NUTCH-3032 Code for an ArbitraryIndexingFilter to index values resolved by user POJO code at index time [nutch]

lewismc commented on code in PR #810: URL: https://github.com/apache/nutch/pull/810#discussion_r1544806230 ## src/plugin/index-arbitrary/src/java/org/apache/nutch/indexer/arbitrary/ArbitraryIndexingFilter.java: ## @@ -0,0 +1,284 @@ +/* + * Licensed to the Apache Software

Re: [PR] NUTCH-3032 Code for an ArbitraryIndexingFilter to index values resolved by user POJO code at index time [nutch]

CatChullain commented on PR #810: URL: https://github.com/apache/nutch/pull/810#issuecomment-2021774505 Thanks, Lewis! I got some of it done today. I'll consolidate the LOG statements a bit more tomorrow. -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] NUTCH-3032 Code for an ArbitraryIndexingFilter to index values resolved by user POJO code at index time [nutch]

lewismc commented on code in PR #810: URL: https://github.com/apache/nutch/pull/810#discussion_r1539452666 ## src/plugin/index-arbitrary/src/java/org/apache/nutch/indexer/arbitrary/ArbitraryIndexingFilter.java: ## @@ -0,0 +1,266 @@ +package org.apache.nutch.indexer.arbitrary; +

Re: [PR] NUTCH-3032 Code for an ArbitraryIndexingFilter to index values resolved by user POJO code at index time [nutch]

lewismc commented on code in PR #810: URL: https://github.com/apache/nutch/pull/810#discussion_r1539390873 ## src/plugin/index-arbitrary/ivy.xml: ## @@ -0,0 +1,41 @@ + + + + Review Comment: Please remove whitespace. ##