Re: Build errors with inline functions

Does anyone have any thoughts on this? I can start implementing the changes and set up a PR. John Rippetoe Software Engineer Robotic Research, LLC (240) 631-0008 - Original Message - From: "John Rippetoe" To: "dev" Sent: Monday, March 23, 2020 6:17:05 PM Subject: Re: Build errors with

Re: Build errors with inline functions

1. For each chip, files that include mpu support need to add a conditional to two included files #ifdef CONFIG_ARM_MPU #  include "mpu.h" #  include "_mpuinit.h" #endif Wouldn't it make more sense to put #ifdef CONFIG_ARM_MPU inside of mpu.h and _mpuinit.h.  That way, the problem is fixed i

Re: Build errors with inline functions

1. For each chip, files that include mpu support need to add a conditional to two included files #ifdef CONFIG_ARM_MPU #  include "mpu.h" #  include "_mpuinit.h" #endif Wouldn't it make more sense to put #ifdef CONFIG_ARM_MPU inside of mpu.h and _mpuinit.h.  That way, the problem is fixed i

Re: Build errors with inline functions

On Wed, Mar 25, 2020 at 11:33 PM John Rippetoe wrote: > > > >> 1. For each chip, files that include mpu support need to add a > >> conditional to two included files > >> > >> #ifdef CONFIG_ARM_MPU > >> # include "mpu.h" > >> # include "_mpuinit.h" > >> #endif > > > > Wouldn't it make more sense

Re: Build errors with inline functions

On Wed, Mar 25, 2020 at 11:38 AM Xiang Xiao wrote: > On Wed, Mar 25, 2020 at 11:33 PM John Rippetoe > wrote: > > > > > > >> 1. For each chip, files that include mpu support need to add a > > >> conditional to two included files > > >> > > >> #ifdef CONFIG_ARM_MPU > > >> # include "mpu.h" > > >>

Re: Build errors with inline functions

Converting them to macros certainly reduces the amount of code that needs to change. Thanks for the link Nathan, I will take a look at that. John On 3/25/20 11:45 AM, Nathan Hartman wrote: On Wed, Mar 25, 2020 at 11:38 AM Xiang Xiao wrote: On Wed, Mar 25, 2020 at 11:33 PM John Rippetoe wr

Re: Build errors with inline functions

I moved forward with converting inline functions to macros and thought I would share a little before moving on. Things I did 1. Per Greg's suggestion, I added #ifdef CONFIG_ARM_MPU to mpu.h and _mpuinit.h 2. Moved static inline functions mpu_control and mpu_configure_region to up_mpu.c.  I

Re: Build errors with inline functions

I also took a look at the coding standard guide to make sure I was in compliance, but I'm unsure of where I should put the 'do' #define mpu_priv_stronglyordered(base, size) do \ { \   /* The configure the region */ \ == OR == #define mpu_user_flash(base, size) \ do { \   /* The configure th

Re: Build errors with inline functions

See, I was thinking that it should be treated like all other functions with no indention of the first pair of curly brackets. I didn't look for other multi-line macro functions to compare with though. I'll go with whatever is consistent with existing code in the repo. - John On 3/25/20 4:29

Re: Error during building the latest nuttx

On Wed, Mar 25, 2020 at 5:20 PM Deepak Sharma wrote: > i am new to nuttx and i was trying to build latest nuttx(8.2) with apps(in > which micropython was supported, commit > abcb66cb20d85b910d5585de51b197eaa468e8b) and it was almost about to finish > but i got the following error. > > please fi

Podling Nuttx Report Reminder - April 2020

Dear podling, This email was sent by an automated system on behalf of the Apache Incubator PMC. It is an initial reminder to give you plenty of time to prepare your quarterly board report. The board meeting is scheduled for Wed, 15 April 2020, 10:30 am PDT. The report for your podling will form a

Build failed in Jenkins: NuttX-Nightly-Build #76

See Changes: -- [...truncated 513.60 KB...] find: '