Re: [Breaking change] Echo character by serial driver

2023-03-10 Thread
I'm Qi Huang, changed to a new mailbox to avoid messing massge in mail titile. > If isconsole is set and TERMIOS is not, then it will always echo the > input. The CR-LF behavior only depends on isconsole and can't be > changed even if TERMIOS is enabled. If TERMIOS enabled, the CR-LF

Changes in Common Line Editor

2023-03-10 Thread Qi3 Huang
Hi all: I've submitted a new patch to GitHub (https://github.com/apache/nuttx-apps/pull/1650), in this is to maintain the cursor position in cle's internal instead of query from terminal, this avoid the query operation before each line read operation. Then the cle's behavior is much

[Breaking change] Echo character by serial driver

2023-03-10 Thread Qi3 Huang
Hello everyone: I had submit a PR in last week https://github.com/apache/nuttx/pull/8691, this change makes NuttX align with other posix compatible system like linux. This improved experience like telnet and WAMR's repl, but also introduced some issues: 1. Don't echo again in

答复: 答复: [External Mail]Re: [Breaking change] Echo character by serial driver

2023-03-10 Thread Qi3 Huang
Emm, I confirmed that one of my test platform (esp32c3), its cdcacm driver implement the uart_ops, but rp2040 seems not. CLE should works since it will override the content from driver ECHO if over serial driver, but readline shouldn't echo input. I'll test more to confirm it.

答复: 答复: [External Mail]Re: [Breaking change] Echo character by serial driver

2023-03-10 Thread Qi3 Huang
> Telnet is the same. It does not use any of the changes to serial.c. It > redirects stdin and stdout to the socket interface exchages raw data > with the host. It has now TERMIOS support. I'm sure telnet will echo input itself, so it works with some display issues before.

答复: 答复: 答复: [External Mail]Re: [Breaking change] Echo character by serial driver

2023-03-10 Thread Qi3 Huang
Thanks for point that, so my change will affect them by serial.c since it's in common logic (excatly, is in uart_read()). 发件人: Gregory Nutt 发送时间: 2023年3月10日 23:58:29 收件人: dev@nuttx.apache.org 主题: Re: 答复: 答复: [External Mail]Re: [Breaking change] Echo character by

答复: [External Mail]Re: [Breaking change] Echo character by serial driver

2023-03-10 Thread Qi3 Huang
I think I should give a simple brief of questions mentioned: 1. How to handle so many vt100 commands ? There aren't many vt100 commands actually used, current implementation can meet nearly all requirment in apps (only pdcurse need test, I'll have a test soon). If we really need to handle

答复: [External Mail]Re: [Breaking change] Echo character by serial driver

2023-03-10 Thread Qi3 Huang
nsh over usb works with readline/cle now. In face, isconsole in current implementation is more like a very tiny `line driver` inside the serial driver. 发件人: Gregory Nutt 发送时间: 2023年3月10日 23:09:12 收件人: dev@nuttx.apache.org 主题: [External Mail]Re: [Breaking

答复: 答复: 答复: [External Mail]Re: [Breaking change] Echo character by serial driver

2023-03-10 Thread Qi3 Huang
echo itself, such as readline/cle/bas. But the bigge problem is, for some software ported from other posix compatible system, they don't do echo by themself, for these applications like WAMR's repl (respacially with REPL) you can't see the input unless you modify the source to adapt it to Nut