Re: widgetVerbose

2011-09-15 Thread Jacopo Cappellato
I am going to feel bad if I don't add my 2 cents to this thread :-) I agree with Jacques that the formatting of boundary comments should be output specific (i.e no output for CSV etc...) instead of always rendering as html comments. As regards the logic to determine if comments should be enabled

Re: discussion: video rentals

2011-10-03 Thread Jacopo Cappellato
Hi Hans, I have read the threads and the blog posts, and considering the requirements: * the need to maintain (serialized) inventory items and ship/receive them * the need to depreciate the items as assets I am wondering if you have considered the design of: * using product/inventory items

Re: discussion: video rentals

2011-10-05 Thread Jacopo Cappellato
of fields duplicated (cost, serial number etc) and we do not know where the asset is stored in inventory when not in use. Regards, Hans On Mon, 2011-10-03 at 12:35 +0200, Jacopo Cappellato wrote: Hi Hans, I have read the threads and the blog posts, and considering the requirements

Re: svn commit: r1167015 - in /ofbiz/trunk: applications/accounting/entitydef/ applications/order/config/ applications/order/data/ applications/order/entitydef/ applications/order/script/org/ofbiz/ord

2011-10-05 Thread Jacopo Cappellato
It would be nice if the code could be enhanced so that the new ASSET_USAGE_OUT_IN type and the old ASSET_USAGE are children of a common type, e.g.: ASSET |___ ASSET_USAGE | |___ ASSET_USAGE_OUT_IN and then, when specific behavior is required, the

Short term plans for official releases

2011-10-05 Thread Jacopo Cappellato
Hi to all contributors. With this email I just want to check if we are interested in issuing one or more official releases soon (this or next month). If we are, I will be more than happy to support the process as usual. Here is what we could release: * the first stable release of the 11.04

Re: Short term plans for official releases

2011-10-05 Thread Jacopo Cappellato
Thank you Jacques, please see my note below: On Oct 5, 2011, at 3:55 PM, Jacques Le Roux wrote: Maybe we should make more clear somewhere that releases like 10.04.01 or 09.04.02 are only tagged revisions in respective branches (or did I miss some places where this is clearly explained?). In

Steve Jobs, 1955-2011

2011-10-06 Thread Jacopo Cappellato
Thanks

Re: Short term plans for official releases

2011-10-09 Thread Jacopo Cappellato
) and a link to repo (vs downloads mirrors)? I'm currently in vacation for a week, so I will not work on this soon... Jacques From: Jacopo Cappellato jacopo.cappell...@hotwaxmedia.com Thank you Jacques, please see my note below: On Oct 5, 2011, at 3:55 PM, Jacques Le Roux wrote: Maybe we

Re: Short term plans for official releases

2011-10-18 Thread Jacopo Cappellato
a link to the snapshot page from the https://cwiki.apache.org/OFBADMIN/ofbiz-source-repository-and-access.html instead. Jacopo Thanks Jacques From: Jacopo Cappellato jacopo.cappell...@hotwaxmedia.com Jacques, all, I did a series of changes (rev. 1180638) to the text and formatting

Re: Short term plans for official releases

2011-10-18 Thread Jacopo Cappellato
Hi Jacques, On Oct 18, 2011, at 10:10 AM, Jacques Le Roux wrote: The same (than Bruno) was also asked later by Ruth later (in another thread) BTW... What don't you like in the release name convention? The Ubuntu way? It is not a big deal but, since we have very few releases an old

Re: Short term plans for official releases

2011-10-19 Thread Jacopo Cappellato
released in 2009.April). Jacques From: Jacopo Cappellato jacopo.cappell...@hotwaxmedia.com Hi Jacques, On Oct 18, 2011, at 10:10 AM, Jacques Le Roux wrote: The same (than Bruno) was also asked later by Ruth later (in another thread) BTW... What don't you like in the release name

Re: discussion: be able to add tags

2011-11-28 Thread Jacopo Cappellato
Hi Hans, On Nov 26, 2011, at 12:32 AM, Hans Bakker wrote: Hi All, We have the need to be able to add pre-approved tags to products, content and workeffort. My guess is that you are implementing a backend workflow to approve products/contents/workefforts before they are allowed to be

Re: discussion: be able to add tags

2011-11-29 Thread Jacopo Cappellato
On Nov 29, 2011, at 7:39 AM, Hans Bakker wrote: My guess is that you are implementing a backend workflow to approve products/contents/workefforts before they are allowed to be sold/published/used in production. Then i explained myself badly. The approval of the tags is important, not

Re: svn commit: r1213650 - /ofbiz/trunk/applications/accounting/testdef/accountingtests.xml

2011-12-13 Thread Jacopo Cappellato
Hans, could you please be more specific on the errors/failures you are getting? It seems I was able to run successfully all the tests. Jacopo On Dec 13, 2011, at 3:41 PM, Hans Bakker wrote: Yes a good idea: https://issues.apache.org/jira/browse/OFBIZ-4624 Regards, Hans On

Re: svn commit: r1213650 - /ofbiz/trunk/applications/accounting/testdef/accountingtests.xml

2011-12-13 Thread Jacopo Cappellato
) at org.ofbiz.base.start.Start.start(Start.java:289) at org.ofbiz.base.start.Start.main(Start.java:119) Regards, Hans On 12/13/2011 10:52 PM, Jacopo Cappellato wrote: Hans, could you please be more specific on the errors/failures you are getting? It seems I was able

Re: svn commit: r1213650 - /ofbiz/trunk/applications/accounting/testdef/accountingtests.xml

2011-12-14 Thread Jacopo Cappellato
(Start.java:310) at org.ofbiz.base.start.Start.start(Start.java:289) at org.ofbiz.base.start.Start.main(Start.java:119) Regards, Hans On 12/13/2011 10:52 PM, Jacopo Cappellato wrote: Hans, could you please be more specific on the errors/failures you are getting? It seems I

Re: svn commit: r1213650 - /ofbiz/trunk/applications/accounting/testdef/accountingtests.xml

2011-12-14 Thread Jacopo Cappellato
the ./ant run-tests locally ? It looks like buildbot is missing these tests Regards, Hans On 12/14/2011 01:56 PM, Jacopo Cappellato wrote: Hans, did you run ant run-install before ant run-tests? I suspect that you are getting this error because in your db the order DEMO10091

Re: svn commit: r1213650 - /ofbiz/trunk/applications/accounting/testdef/accountingtests.xml

2011-12-14 Thread Jacopo Cappellato
FailuresTime(s) Time Stamp accountingtests 17 0 0 8.868 2011-12-14T08:43:16 Jacopo On Dec 14, 2011, at 9:47 AM, Jacopo Cappellato wrote: Thanks Jacques, but I am running my tests locally and I get a 100% success rate

Re: svn commit: r1213650 - /ofbiz/trunk/applications/accounting/testdef/accountingtests.xml

2011-12-15 Thread Jacopo Cappellato
Hi Hans, any update on this? Thanks, Jacopo On Dec 14, 2011, at 9:37 AM, Jacopo Cappellato wrote: Hi Hans, please see inline: On Dec 14, 2011, at 8:55 AM, Hans Bakker wrote: Hi Jacopo, thank you for looking into this. yes sure i did run ./ant run-install The test below

Re: svn commit: r1213650 - /ofbiz/trunk/applications/accounting/testdef/accountingtests.xml

2011-12-15 Thread Jacopo Cappellato
No problem: can I re-enable the tests in the meantime? Jacopo On Dec 15, 2011, at 2:30 PM, Hans Bakker wrote: At the moment pretty busy with other things, will have time this weekend or next week, On 12/15/2011 08:28 PM, Jacopo Cappellato wrote: Hi Hans, any update on this? Thanks

Re: svn commit: r1213650 - /ofbiz/trunk/applications/accounting/testdef/accountingtests.xml

2011-12-15 Thread Jacopo Cappellato
and make a lot of noise to that committer. I'm pretty sure that everyone agrees that we have a responsibility as committers to ensure that we won't cause the tests to fail. Regards Scott On 15/12/2011, at 6:46 AM, Jacopo Cappellato wrote: No problem: can I re-enable the tests

Re: svn commit: r1213650 - /ofbiz/trunk/applications/accounting/testdef/accountingtests.xml

2011-12-16 Thread Jacopo Cappellato
=test/ env key=LC_ALL value=C/ /java On Dec 16, 2011, at 8:59 AM, Jacopo Cappellato wrote: ok, this is useful... it is a locale related issue and I am working on it. Jacopo On Dec 16, 2011, at 5:45 AM, Jacques Le Roux wrote: Hi, on XP 32bits here (*French

Re: svn commit: r1213650 - /ofbiz/trunk/applications/accounting/testdef/accountingtests.xml

2011-12-16 Thread Jacopo Cappellato
setting in start.properties. I can duplicate the test failures by changing that setting to some other locale. That is why I thought it is a local issue - the tests are based on OOTB settings, and if you change the settings the tests will fail. -Adrian On 12/16/2011 9:12 AM, Jacopo

Re: svn commit: r1213650 - /ofbiz/trunk/applications/accounting/testdef/accountingtests.xml

2011-12-16 Thread Jacopo Cappellato
settings, and if you change the settings the tests will fail. -Adrian On 12/16/2011 9:12 AM, Jacopo Cappellato wrote: Jacques, Hans, could you please try if with the below modifications the tests are successful? Thanks, Jacopo

Re: svn commit: r1213650 - /ofbiz/trunk/applications/accounting/testdef/accountingtests.xml

2011-12-16 Thread Jacopo Cappellato
on OOTB settings, and if you change the settings the tests will fail. -Adrian On 12/16/2011 9:12 AM, Jacopo Cappellato wrote: Jacques, Hans, could you please try if with the below modifications the tests are successful? Thanks, Jacopo

Re: svn commit: r1213650 - /ofbiz/trunk/applications/accounting/testdef/accountingtests.xml

2011-12-16 Thread Jacopo Cappellato
/2011 11:15 AM, Jacopo Cappellato wrote: Adrian, I doubt that that code is executed when run-tests is called. Jacopo On Dec 16, 2011, at 11:14 AM, Adrian Crum wrote: Jacopo, Setting the language on the command line should not have any effect because OFBiz sets the language when

Re: svn commit: r1213650 - /ofbiz/trunk/applications/accounting/testdef/accountingtests.xml

2011-12-16 Thread Jacopo Cappellato
: There is no need to investigate - I wrote that code and I can assure you the locale and time zone is always set when OFBiz starts. The problem is an incorrect (or missing) setting in one of the properties files - see my previous reply to Jacques. -Adrian On 12/16/2011 1:43 PM, Jacopo Cappellato

Re: svn commit: r1213650 - /ofbiz/trunk/applications/accounting/testdef/accountingtests.xml

2011-12-16 Thread Jacopo Cappellato
: Adrian Crum adrian.c...@sandglass-software.com I believe the base test failures are a timing issue, but I can't be sure because I haven't looked into it thoroughly. I am confident they have nothing to do with locale, however. -Adrian On 12/16/2011 2:25 PM, Jacopo Cappellato wrote: Yes

Re: svn commit: r1213650 - /ofbiz/trunk/applications/accounting/testdef/accountingtests.xml

2011-12-17 Thread Jacopo Cappellato
today :/ Jacques From: Jacopo Cappellato jacopo.cappell...@hotwaxmedia.com Hi Jacques, I suspect this is a problem with the end of line... are you running on Windows? Could you please try if the patch below fixes the test? Thanks, Jacopo Index: framework/base/src/org/ofbiz/base/util

Re: svn commit: r1220622 - in /ofbiz/trunk: applications/manufacturing/data/ applications/order/src/org/ofbiz/order/order/ applications/order/src/org/ofbiz/order/shoppingcart/ applications/order/webap

2011-12-19 Thread Jacopo Cappellato
Yep, the problem was the line: -ProductFeatureCategory productFeatureCategoryId=IMAGE description=Image/ +ProductFeatureCategory productFeatureCategoryI=IMAGE description=Image/ I have fixed it. Even without reviewing this big commit, this kind of errors (that imply that very few tests

Re: remove ant from ofbiz

2011-12-21 Thread Jacopo Cappellato
Hi Hans, what I don't like is that this will add a new system requirement for the user. Why not upgrading the embedded version instead? Jacopo On Dec 22, 2011, at 4:23 AM, Hans Bakker wrote: Hi community, the version of Ant distributed with ofbiz is pretty old and has some disadvantages:

Re: buildbot failure in ASF Buildbot on ofbiz-trunk

2012-01-01 Thread Jacopo Cappellato
Hi Jacques, the failure could be related to the year switch... this happens every year and it needs some updates to demo fiscal periods to fix; or you could try with a patch like: Index: applications/accounting/data/DemoGlSetupData.xml

Re: svn commit: r1226367 - in /ofbiz/trunk/applications/accounting/script/org/ofbiz/accounting/test: AutoInvoiceTests.xml AutoPaymentTests.xml

2012-01-02 Thread Jacopo Cappellato
Jacques, I am going to commit a different fix that should make the tests good for the years to come. Jacopo On Jan 2, 2012, at 9:29 AM, jler...@apache.org wrote: Author: jleroux Date: Mon Jan 2 08:29:59 2012 New Revision: 1226367 URL: http://svn.apache.org/viewvc?rev=1226367view=rev

Re: releases

2012-01-05 Thread Jacopo Cappellato
Hi Erwan, I agree it would be nice to release. We could release: * a new bug fix release for the 09 series (named 09.04.02) * a new bug fix release for the 10 series (named 10.04.01) * the first release for the 11 series (named 11.04) To avoid confusion we could do one release per month or

Re: releases

2012-01-06 Thread Jacopo Cappellato
On Jan 6, 2012, at 3:39 PM, Erwan de FERRIERES wrote: If we are adding the 11.04, then there will be 4 different versions. It may be useful to help the user to decide which one to take. And reducing the choice can be one way to do it. This is a good point and I agree that we should improve

Re: Stop The Madness: Indexing keyword EECAs

2012-01-14 Thread Jacopo Cappellato
There is a flag in the Product entity that can beused to prevent the creation of product keywords; unfortunately the flag is ignored by the eca associated to the features of the product (imo this is something we should fix). Kind regards, Jacopo On Jan 14, 2012, at 1:59 AM, Adrian Crum wrote:

Re: The Apache Software Foundation Projects

2012-01-23 Thread Jacopo Cappellato
Hi Jacques, sorry for the late reply; Erwan is right about the tag: we create it when we tag a release. As regards you patch, please commit it and then deploy (as you would do with a standard html page of the OFBiz website); the ASF server will then fetch it from there. Thanks, Jacopo On

Re: svn commit: r1230793 - in /ofbiz/trunk/specialpurpose/scrum: ./ config/ data/ data/hookscripts/ entitydef/ servicedef/ src/org/ofbiz/scrum/ templates/ testdef/ webapp/demotest/ webapp/demotest/WEB

2012-01-23 Thread Jacopo Cappellato
I agree, it is useful and I use it a lot before tagging a release. Jacopo On Jan 12, 2012, at 11:13 PM, Jacques Le Roux wrote: Yes a great tool really! At least for Apache committers... Jacques From: Adrian Crum adrian.c...@sandglass-software.com I'm familiar with RAT - I use it for the

Welcome Erwan De Ferrieres as a new OFBiz PMC member

2012-02-06 Thread Jacopo Cappellato
Welcome to Erwan as our new OFBiz PMC member. The current members of the OFBiz PMC have voted in favour of inviting Erwan to join the PMC, the vote has been approved by the ASF Board and Erwan has accepted our invitation. Thank you Erwan and thank you Jacques for your proposal. Kind regards,

Re: Alternatives to using UserLoginId as a primary key

2012-02-20 Thread Jacopo Cappellato
I like Adrian's proposal to make the UserLogin entity more flexible. Brett, as regards your proposal about the extension mechanism (i.e. the UserCredentials), I think it would be better an approach where each specific security implementation defines its own *Credentials (or *UserLogin or

Proposal about a time based release plan

2012-02-21 Thread Jacopo Cappellato
Hi all, I would like to share some ideas I have to make our release plan more clearer, public and well defined. This plan doesn't require additional work from the community (apart from the due diligence when we will call for votes) because I will take care about preparing release candidate

Proposal to slightly change the naming convention for releases

2012-02-21 Thread Jacopo Cappellato
Hi all, I would like to propose a small change to the way we name releases, specifically the first release in a branch. The current naming convention is the following: a) the name of the release branch is apache-ofbiz-YY.MM where YY.MM is the year and month of when the branch was created b)

Re: Alternatives to using UserLoginId as a primary key

2012-02-21 Thread Jacopo Cappellato
look at an extension of the UserLogin entity with a specific type. Is the current LDAP implementation following that model or would this be something new? Thanks, Brett On Mon, Feb 20, 2012 at 5:59 AM, Jacopo Cappellato jacopo.cappell...@hotwaxmedia.com wrote: I like Adrian's

[VOTE] [RELEASE] Apache OFBiz 09.04.02

2012-02-22 Thread Jacopo Cappellato
This is the vote thread to release a new (bug fix) release for the 09.04 branch. This new release, Apache OFBiz 09.04.02 (major release number: 09.04; minor release number: 02), will supersede the release Apache OFBiz 09.04.01. The release files can be downloaded from here:

Proposal to close the 4.0 and 09.04 release branches

2012-02-23 Thread Jacopo Cappellato
Hi devs, I would like to propose to officially close the two oldest branches: release4.0 release09.04 When the branches will be closed: * we will no more backport fixes to them (no commits in general will be done) * if a user will submit a patch for the branch in Jira we will resolve as won't

Re: mailing-lists/Jira stats for 2011

2012-02-24 Thread Jacopo Cappellato
I would like to add the following information, that appears to be in contrast with the trend that seems implied by the stats based on the number of posts that Erwan provided: on March 2010 (2010-03-09) the numbers of subscribers to the lists were: user list: 717 + 116 digest = 833 dev list:

Migration of site and dist/ to svnpubsub

2012-02-24 Thread Jacopo Cappellato
Today I have created the ticket for Infra to migrate the publishing mechanism for the OFBiz site and dist/ folder (releases) to svnpubsub: https://issues.apache.org/jira/browse/INFRA-4485 As you may have read from the announcements from Infra, this is a required task as the current mechanism

Re: Migration of site and dist/ to svnpubsub

2012-02-24 Thread Jacopo Cappellato
you very much for taking care of this. -Adrian On 2/24/2012 3:56 PM, Jacopo Cappellato wrote: Today I have created the ticket for Infra to migrate the publishing mechanism for the OFBiz site and dist/ folder (releases) to svnpubsub: https://issues.apache.org/jira/browse/INFRA-4485

Re: [VOTE] [RELEASE] Apache OFBiz 09.04.02

2012-02-25 Thread Jacopo Cappellato
+1 Jacopo On Feb 22, 2012, at 9:08 AM, Jacopo Cappellato wrote: This is the vote thread to release a new (bug fix) release for the 09.04 branch. This new release, Apache OFBiz 09.04.02 (major release number: 09.04; minor release number: 02), will supersede the release Apache OFBiz

[VOTE] [RESULT] Apache OFBiz 09.04.02

2012-02-25 Thread Jacopo Cappellato
, Jacopo I will proceed with the remaining steps required to release the package. Jacopo On Feb 22, 2012, at 9:08 AM, Jacopo Cappellato wrote: This is the vote thread to release a new (bug fix) release for the 09.04 branch. This new release, Apache OFBiz 09.04.02 (major release number

Please review the text in the OFBiz download page

2012-02-26 Thread Jacopo Cappellato
This is mainly a request for committers that are native English speaker: today I have edited/cleaned a lot of information in the download page: http://ofbiz.apache.org/download.html could you please review what I wrote and improve the English? Thank you, Jacopo

Re: [VOTE] [RESULT] Apache OFBiz 09.04.02

2012-02-26 Thread Jacopo Cappellato
On Feb 25, 2012, at 1:54 PM, Jacopo Cappellato wrote: I will proceed with the remaining steps required to release the package. Ok, everything should be done now: * created release tag * archived old 09.04.01 release * added new 09.04.01 to the dist folder and propagated to all mirrors

Some thoughts on OFBiz demo instances

2012-02-26 Thread Jacopo Cappellato
Hi Jacques, On Feb 26, 2012, at 11:34 AM, Jacques Le Roux wrote: So, to be consistent, we should swap our stable demo from 09.4 to 10.04 and keep 09.04 as old demo like Christian began to work on it. We will see ASAP I guess... We will then also update the index page to let people know

Re: Proposal to close the 4.0 and 09.04 release branches

2012-02-26 Thread Jacopo Cappellato
this to the dev list if you see a good reason for backporting the fix * we should resolve as won't fix all issues that are specific to 4.0 or 09.04 only Of course we could revisit this decision in the future. Kind regards, Jacopo On Feb 23, 2012, at 9:35 AM, Jacopo Cappellato wrote: Hi devs

Summary of some recent discussions around the OFBiz release roadmap and some proposals

2012-02-26 Thread Jacopo Cappellato
We have recently discussed in a few threads some strategies for the definition of a release roadmap for OFBiz; I am summarizing here the main points (old and new) because there seems to be a general agreement around them and we should be ready to officialize them and then stick to this plan: *

Re: Summary of some recent discussions around the OFBiz release roadmap and some proposals

2012-02-26 Thread Jacopo Cappellato
differently now and then should the need arise. -Adrian On 2/26/2012 3:29 PM, Jacopo Cappellato wrote: We have recently discussed in a few threads some strategies for the definition of a release roadmap for OFBiz; I am summarizing here the main points (old and new) because there seems

Re: Some thoughts on OFBiz demo instances

2012-02-27 Thread Jacopo Cappellato
On Feb 26, 2012, at 8:20 PM, Jacques Le Roux wrote: From: Jacopo Cappellato jacopo.cappell...@hotwaxmedia.com Hi Jacques, On Feb 26, 2012, at 11:34 AM, Jacques Le Roux wrote: So, to be consistent, we should swap our stable demo from 09.4 to 10.04 and keep 09.04 as old demo like

Re: svn commit: r1294095 - /ofbiz/branches/release09.04/applications/order/src/org/ofbiz/order/order/OrderListState.java

2012-02-27 Thread Jacopo Cappellato
Hi Jacques, why are you still backporting fixes to the 09.04 branch? this is the second one you commit after the release 09.04.02 has beed released and there seems to be general consensus to consider it the last release in the branch. Of course we can change decision and plan for another

Re: Summary of some recent discussions around the OFBiz release roadmap and some proposals

2012-02-27 Thread Jacopo Cappellato
On Feb 26, 2012, at 8:04 PM, Jacques Le Roux wrote: For me also 6 months seems long enough for the 1st official release. I'm just afraid: will we have not a lot of work to release so often (relases themself, annunciations, site update and especially demos updates) Anyway it seems we need

Re: svn commit: r1293999 [1/2] - in /ofbiz/trunk: ./ framework/base/config/ framework/birt/ framework/birt/config/ framework/birt/data/helpdata/ framework/birt/documents/ framework/birt/lib/ framework

2012-02-27 Thread Jacopo Cappellato
Hans, are all these jars really needed? Jacopo On Feb 27, 2012, at 3:37 AM, hans...@apache.org wrote: Added: ofbiz/trunk/framework/birt/lib/Tidy.jar (with props) ofbiz/trunk/framework/birt/lib/flute.jar (with props) ofbiz/trunk/framework/birt/lib/js.jar (with props)

Re: Some thoughts on OFBiz demo instances

2012-02-27 Thread Jacopo Cappellato
On Feb 27, 2012, at 12:46 PM, Hans Bakker wrote: On 02/27/2012 06:15 PM, Jacques Le Roux wrote: - Original Message - From: Jacopo Cappellato jacopo.cappell...@hotwaxmedia.com To: dev@ofbiz.apache.org Sent: Monday, February 27, 2012 10:48 AM Subject: Re: Some thoughts on OFBiz

Re: Some thoughts on OFBiz demo instances

2012-02-27 Thread Jacopo Cappellato
Please stay with your opinion Jacopo On Feb 27, 2012, at 1:22 PM, Hans Bakker wrote: Jacopo, there is, as you state no rule against it, i gave you my reasons and stay with my opinion that it should stay on the main page. Regards, Hans On 02/27/2012 07:09 PM, Jacopo Cappellato wrote

bin folder for executable files/scripts

2012-02-27 Thread Jacopo Cappellato
The number of executable files (*.sh and *bat) in the OFBiz home folder is rather big: what if we create a bin folder and we move all of them there? In this way users will have a place where they will find all the executable files only and the main folder will be cleaner. Jacopo

Re: svn commit: r1294450 - /ofbiz/trunk/framework/birt/lib/

2012-02-27 Thread Jacopo Cappellato
Hans, do not forget to remove them from the LICENSE file as well. Jacopo On Feb 28, 2012, at 3:48 AM, hans...@apache.org wrote: Author: hansbak Date: Tue Feb 28 02:48:54 2012 New Revision: 1294450 URL: http://svn.apache.org/viewvc?rev=1294450view=rev Log: related to Jacopo's query we

Fixing bad patterns widely used to check role based permission

2012-02-28 Thread Jacopo Cappellato
On Feb 27, 2012, at 8:47 PM, Adrian Crum wrote: I would welcome a discussion of wrong (or bad) patterns. Lately I spend about half my development time fixing things that are done wrong. -Adrian Thank you Adrian, here is what I would like to address: I see a lot of code that checks ROLE

Re: Fixing bad patterns widely used to check role based permission

2012-02-28 Thread Jacopo Cappellato
On Feb 28, 2012, at 11:49 AM, Adrian Crum wrote: An example is your description of the CATALOGADMIN_LTD security group. The permission check is based on a party role, not a user role. Party roles and user roles are not the same thing. Yes, that is an example of a party role that is

Re: svn commit: r1295029 - in /ofbiz/trunk: applications/product/src/org/ofbiz/product/category/OfbizCatalogAltUrlTransform.java specialpurpose/ecommerce/widget/EmailOrderScreens.xml

2012-02-29 Thread Jacopo Cappellato
Hi Hans, I don't like the assumption about the string control: this is a configurable value (in web.xml) and we should not have it hardcoded in our code. I know there are already few examples of this bad pattern and in fact we should work and fix them as well. Jacopo On Feb 29, 2012, at

Re: Please review the text in the OFBiz download page

2012-02-29 Thread Jacopo Cappellato
is a two digits sequential number should be Minor Release Number is a two digit sequential number (singular, not plural, for digit) Cheers, Anne. On 27 February 2012 00:46, Jacopo Cappellato jacopo.cappell...@hotwaxmedia.com wrote: This is mainly a request for committers that are native

Re: bin folder for executable files/scripts

2012-02-29 Thread Jacopo Cappellato
PM, Jacopo Cappellato wrote: The number of executable files (*.sh and *bat) in the OFBiz home folder is rather big: what if we create a bin folder and we move all of them there? In this way users will have a place where they will find all the executable files only and the main folder

OFBiz website compliance with ASF Brand policy

2012-02-29 Thread Jacopo Cappellato
As some of you may already know, being part of the Apache Software Foundation, the OFBiz project is asked to comply with the ASF Brand policy: http://www.apache.org/foundation/marks/responsibility.html http://www.apache.org/foundation/marks/pmcs.html Every quarter, as part of the report to the

Re: svn commit: r1295344 [1/5] - in /ofbiz/trunk/framework/images/webapp/images/jquery/jquery.mobile-1.1.0-rc.1: ./ images/

2012-02-29 Thread Jacopo Cappellato
Hi Anil, please update also the LICENSE (and NOTICE, if needed) file. Thanks, Jacopo On Mar 1, 2012, at 12:56 AM, apa...@apache.org wrote: Author: apatel Date: Wed Feb 29 23:56:40 2012 New Revision: 1295344 URL: http://svn.apache.org/viewvc?rev=1295344view=rev Log: Adding JQuery

Re: Definitively remove beanshell from OFBiz

2012-03-01 Thread Jacopo Cappellato
Implementing JSR-223 should be rather easy but if I am not wrong it would prevent the ability to cache the scripts (task that is currently done in org.ofbiz.base.util.GroovyUtil, that is using the the more flexible GroovyClassLoader mechanism); we could probably use the javax.script.Compilable

Re: Definitively remove beanshell from OFBiz

2012-03-01 Thread Jacopo Cappellato
. Regarding a slimmed down framework, I proposed one some time ago: https://cwiki.apache.org/confluence/display/OFBADMIN/Another+Framework+Vision and that document was in response to David's proposal to base OFBiz on Moqui (another option). -Adrian On 3/1/2012 8:53 AM, Jacopo

Re: svn commit: r1295344 [1/5] - in /ofbiz/trunk/framework/images/webapp/images/jquery/jquery.mobile-1.1.0-rc.1: ./ images/

2012-03-01 Thread Jacopo Cappellato
have added is in a folder under this (jquery) folder. Also the framework uses same license as jquery (MIT), so I did not see need for adding new entry. Do you think I should still do it? Thanks and Regards Anil Patel HotWax Media Inc On Mar 1, 2012, at 12:52 AM, Jacopo Cappellato

Re: Framework refactor (was: Definitively remove beanshell from OFBiz)

2012-03-01 Thread Jacopo Cappellato
On Mar 1, 2012, at 11:39 AM, Adrian Crum wrote: I understand the workflow you are suggesting - cut down the size of the existing framework and then switch to something else. In an ideal world we could do that. Unfortunately, we have a lot of committers who believe more is better, so while

Applying the Configuration By Exception concept more extensively

2012-03-01 Thread Jacopo Cappellato
A decent description of the Configuration By Exception concept is the following [*]: Java EE 5 introduced the idea of configuration by exception (sometimes referred to as programming by exception or convention over configuration). This means, unless specified differently, the container or

Re: Framework refactor

2012-03-01 Thread Jacopo Cappellato
wrote: You are a lot more optimistic than I am. Despite the best efforts of PMC members to provide advice/guidance/suggestions, committers still do what they please. It's worth a try, but I don't have much hope for success. -Adrian On 3/1/2012 1:48 PM, Jacopo Cappellato wrote: On Mar 1

Re: Framework refactor

2012-03-01 Thread Jacopo Cappellato
. Why not have all people interested refactoring the OFBiz framework join the Moqui project? David, what do you think? Regards, Hans On 03/02/2012 10:31 AM, Jacques Le Roux wrote: From: Jacopo Cappellato jacopo.cappell...@hotwaxmedia.com I don't think it will be easy and actually

Re: Who is using the seleniumxml and why?

2012-03-01 Thread Jacopo Cappellato
Moving to the dev list: On Mar 1, 2012, at 11:51 AM, Erwan de FERRIERES wrote: what I'm planning to include is just the basics : jars and tasks. Maybe some tests as an example, like a basic login, and some actions with the example component. If there is time remaining, the selenium tests

Re: Framework refactor

2012-03-01 Thread Jacopo Cappellato
On Mar 2, 2012, at 7:50 AM, Hans Bakker wrote: Jacopo, You would even consider forking? This sounds more that you want to be in control than going for the best and work together. me? I would like to propose to join the Moqui framework and when ready, use in OFBiz the jars only as

Re: Framework refactor

2012-03-01 Thread Jacopo Cappellato
this as the first optionnot sound good.. Regards On 03/02/2012 02:05 PM, Jacopo Cappellato wrote: On Mar 2, 2012, at 7:50 AM, Hans Bakker wrote: Jacopo, You would even consider forking? This sounds more that you want to be in control than going for the best and work together

Re: Applying the Configuration By Exception concept more extensively

2012-03-02 Thread Jacopo Cappellato
in some name_seed.xml and all records for demo in some name_demo.xml Jacopo On Mar 2, 2012, at 9:06 AM, Adrian Crum wrote: I don't think we can eliminate the seed/demo data readers. In most cases, data loading must be done in a certain order. -Adrian On 3/1/2012 2:53 PM, Jacopo

Re: Framework refactor

2012-03-02 Thread Jacopo Cappellato
On Mar 2, 2012, at 7:50 AM, Hans Bakker wrote: Jacopo, You would even consider forking? From Wikipedia [*]: [...] More recently, distributed revision control (DVCS) tools have popularised a less emotive use of the term fork, blurring the distinction with branch. With a DVCS such as

Proposal for some changes to the layout of the OFBiz svn repository

2012-03-02 Thread Jacopo Cappellato
In preparation for bigger changes :-) I would like to propose the addition of two new folders to the OFBiz svn repository: branches/ tags/ archive/ (NEW) trunk/ trunk/extras (NEW) The archive folder will be used for keeping an archive of no more used components or pieces of code: for example

Re: Service alert: ofbiz-vm.apache.org/HTTP - Ofbiz Demo Trunk is WARNING

2012-03-03 Thread Jacopo Cappellato
On Mar 3, 2012, at 11:44 AM, Jacques Le Roux wrote: And the trunk demo has been (it seems) normally stopped Not sure why... Yeah, I know why but can't tell you at the moment (not in this public list) Jacopo

Re: Definitively remove beanshell from OFBiz

2012-03-03 Thread Jacopo Cappellato
On Mar 1, 2012, at 10:51 AM, Adrian Crum wrote: As far as I know, most scripting engines have some sort of embedded cache. The problem will be that we can't clear the embedded cache like we can with our own cache implementation. I don't see that as a show stopper - it's mostly

Re: Definitively remove beanshell from OFBiz

2012-03-03 Thread Jacopo Cappellato
My changes are in commit 1296762 Help with reviews and tests will be very much appreciated. Jacopo On Mar 3, 2012, at 1:45 PM, Jacopo Cappellato wrote: On Mar 1, 2012, at 10:51 AM, Adrian Crum wrote: As far as I know, most scripting engines have some sort of embedded cache. The problem

Re: Implementing JSR-223 (Was: Definitively remove beanshell from OFBiz)

2012-03-04 Thread Jacopo Cappellato
think that? -Adrian On 3/4/2012 7:27 AM, Jacopo Cappellato wrote: My changes are in commit 1296762 Help with reviews and tests will be very much appreciated. Jacopo On Mar 3, 2012, at 1:45 PM, Jacopo Cappellato wrote: On Mar 1, 2012, at 10:51 AM, Adrian Crum wrote: As far as I

Re: Implementing JSR-223 (Was: Definitively remove beanshell from OFBiz)

2012-03-04 Thread Jacopo Cappellato
-Adrian On 3/4/2012 7:27 AM, Jacopo Cappellato wrote: My changes are in commit 1296762 Help with reviews and tests will be very much appreciated. Jacopo On Mar 3, 2012, at 1:45 PM, Jacopo Cappellato wrote: On Mar 1, 2012, at 10:51 AM, Adrian Crum wrote: As far as I know, most

Re: Implementing JSR-223

2012-03-04 Thread Jacopo Cappellato
for a string followed by a colon can lead to errors. -Adrian On 3/5/2012 6:22 AM, Jacopo Cappellato wrote: I would like to clarify that in this first pass I focused on moving code around keeping the same exact behavior currently implemented: now all the code that had a dependency on Groovy

Re: Implementing JSR-223

2012-03-05 Thread Jacopo Cappellato
-Adrian On 3/5/2012 6:46 AM, Jacopo Cappellato wrote: On Mar 4, 2012, at 9:16 PM, Adrian Crum wrote: The code changes tested fine. I noticed in your code comments that Groovy should be handled independently from other scripting languages. Why do you think that? First of all, I apologize

Re: Implementing JSR-223

2012-03-05 Thread Jacopo Cappellato
On Mar 5, 2012, at 8:57 AM, Adrian Crum wrote: Btw, expressions should go in the from-field attribute, not the value attribute. Well, the mechanism value=${groovy: ...} is actually used a lot currently; and in the from-field attribute the ${groovy: is not required. Jacopo

Re: svn commit: r1295029 - in /ofbiz/trunk: applications/product/src/org/ofbiz/product/category/OfbizCatalogAltUrlTransform.java specialpurpose/ecommerce/widget/EmailOrderScreens.xml

2012-03-05 Thread Jacopo Cappellato
: every time we do a commit we should be ready to receive feedback and improve the code; only at that point the code will become official. I hope this is the last time I have to state this fundamental rule, Jacopo On Feb 29, 2012, at 10:40 AM, Jacopo Cappellato wrote: Hi Hans, I don't like

Re: svn commit: r1295029 - in /ofbiz/trunk: applications/product/src/org/ofbiz/product/category/OfbizCatalogAltUrlTransform.java specialpurpose/ecommerce/widget/EmailOrderScreens.xml

2012-03-05 Thread Jacopo Cappellato
On 03/05/2012 05:57 PM, Jacopo Cappellato wrote: Hey Hans, (and all OFBiz committers in general) I would like to stress the importance to address reviews on commits (especially if they come from committers, like me, because we have veto on commits) asap by improving the code or reverting

Re: svn commit: r1295029 - in /ofbiz/trunk: applications/product/src/org/ofbiz/product/category/OfbizCatalogAltUrlTransform.java specialpurpose/ecommerce/widget/EmailOrderScreens.xml

2012-03-05 Thread Jacopo Cappellato
Yes, *reverting* and then sending a word back that an improved version is in progress would also be fine. Jacopo On Mar 5, 2012, at 12:10 PM, Jacques Le Roux wrote: Maybe then sending back a word saying that it's a WIP would help ;o) Jacques

Re: Discussion: Mini-language Overhaul

2012-03-05 Thread Jacopo Cappellato
I am a big fan of Minilang too. The evolution strategy that I would like to see implemented for Minilang is actually the same one I would liketo see applied to OFBiz framework in general: review the current usage of the tool, fix existing usage for consistency (upgrade old code to use newer

Re: Implementing JSR-223

2012-03-05 Thread Jacopo Cappellato
words, have an object in the context that gives us the convenience of mini-language. -Adrian On 3/5/2012 8:01 AM, Jacopo Cappellato wrote: On Mar 5, 2012, at 8:46 AM, Adrian Crum wrote: It seems to me if there is a security issue using Groovy, then there would be an issue using any

Re: Discussion: Mini-language Overhaul

2012-03-06 Thread Jacopo Cappellato
}/ +1 Jacopo -Adrian On 3/6/2012 7:31 AM, Jacopo Cappellato wrote: I am a big fan of Minilang too. The evolution strategy that I would like to see implemented for Minilang is actually the same one I would liketo see applied to OFBiz framework in general: review the current usage

Re: Implementing JSR-223

2012-03-06 Thread Jacopo Cappellato
the ScriptContext object - not the context Map. I'm not sure how to proceed from here. -Adrian On 3/6/2012 7:58 AM, Jacopo Cappellato wrote: This could work but I was thinking to something more like having some core packages (like entity and service) always imported in groovy scripts/services

Re: Discussion: Mini-language Overhaul

2012-03-06 Thread Jacopo Cappellato
: parameters.inputField1 + 10}/ +1 Jacopo -Adrian On 3/6/2012 7:31 AM, Jacopo Cappellato wrote: I am a big fan of Minilang too. The evolution strategy that I would like to see implemented for Minilang is actually the same one I would liketo see applied to OFBiz framework in general

  1   2   3   4   5   6   7   8   9   10   >