Re: [Discussion] Introduction of Bootstrap and Vue.js

2018-05-15 Thread Mathieu Lirzin
seems hardly avoidable to decouple the JS framework from the Renderer, but maybe I am overlooking something? FYI I am currently working on finding a solution to let external applications access OFBiz services/entities via a REST API [1]. [1] https://mail-archives.apache.org/mod_mbox/ofbiz-dev/201804.mbox/

Re: svn commit: r1832199 - /ofbiz/ofbiz-framework/trunk/framework/webapp/src/main/java/org/apache/ofbiz/webapp/event/JavaEventHandler.java

2018-05-27 Thread Mathieu Lirzin
re you puzzled by a specific scenario? Thanks. [1] https://docs.oracle.com/javase/8/docs/api/java/util/concurrent/ConcurrentHashMap.html#computeIfAbsent-K-java.util.function.Function- -- Mathieu Lirzin GPG: F2A3 8D7E EB2B 6640 5761 070D 0ADE E100 9460 4D37

Re: [Discussion]: Add method attribute to request-map

2018-07-03 Thread Mathieu Lirzin
t; If you or Mathieu would like to start a discussion I'd recommend a new thread I will open a new thread summarizing the goal/intent of adding a ‘method’ attribute to ‘request-map’ elements, and describing the proposed changes. Thanks. -- Mathieu Lirzin GPG: F2A3 8D7E EB2B 6640 5761 070D 0ADE E100 9460 4D37

Contributing/Coding guidelines (was: svn commit: r1834662 - /ofbiz/ofbiz-framework/trunk/framework/webapp/src/main/java/org/apache/ofbiz/webapp/control/ConfigXMLReader.java)

2018-07-03 Thread Mathieu Lirzin
ache.org/repos/asf/ofbiz/tools/wiki-files/OFBizJavaFormatter.xml OK I will adjust my code. Maybe the line length of 120 could be explicitly stated as an exception to the Sun standard [1]? Thanks. [1] http://www.oracle.com/technetwork/java/javase/documentation/codeconventions-136091.html#313 -- Mathieu Lirzin GPG: F2A3 8D7E EB2B 6640 5761 070D 0ADE E100 9460 4D37

Re: Oracle Java release model changes and consequences for the project

2018-07-28 Thread Mathieu Lirzin
eased, OFBiz should keep compatibity with the previous LTS release meaning java 8. Of course This does not mean that OFBiz should not be tested with more recent Java releases too. Having an extra branch has a maintenance burden that should be balanced with the benefits it provides. What benefits

Gradle ‘gretty’ Plugin

2018-07-26 Thread Mathieu Lirzin
/gretty-doc/Hot-deployment.html -- Mathieu Lirzin GPG: F2A3 8D7E EB2B 6640 5761 070D 0ADE E100 9460 4D37

Re: Gradle ‘gretty’ Plugin

2018-07-26 Thread Mathieu Lirzin
Hello James, James Yong writes: > Have you looked into http://dcevm.github.io/ ? > > No comment about gretty as I haven't tried. I didn't know about it. I will take a look. Thanks. -- Mathieu Lirzin GPG: F2A3 8D7E EB2B 6640 5761 070D 0ADE E100 9460 4D37

Re: Plugin install process pb

2018-08-14 Thread Mathieu Lirzin
hat. Thanks for commiting the fix. -- Mathieu Lirzin GPG: F2A3 8D7E EB2B 6640 5761 070D 0ADE E100 9460 4D37

Re: Plugin install process pb

2018-08-13 Thread Mathieu Lirzin
lspoint' > } > } > > > > with the previous version of taskExistsInproject it works > > └─$ ./gradlew installPlugin -PpluginId=testPlugin1 > :plugins:testPlugin1:install > install task for my plugin test1 > Bonjour > :installPlugin > installed plugin testPlugin1 > > BUILD SUCCESSFUL > > Total time: 3.134 secs -- Mathieu Lirzin GPG: F2A3 8D7E EB2B 6640 5761 070D 0ADE E100 9460 4D37

Re: svn commit: r1837697 - /ofbiz/ofbiz-framework/trunk/framework/webapp/src/main/java/org/apache/ofbiz/webapp/event/XmlRpcEventHandler.java

2018-08-10 Thread Mathieu Lirzin
eHandlerMapping implements XmlRpcHandler { Feel free to do whatever you want with it. I am not sure to understand what is the purpose of the ‘getRequest’ method so it would be nice if you could provide a docstring for it. Thanks. [1] https://forax.github.io/ [2] https://www.youtube.com/watch?v=aC1wGHDOQic -- Mathieu Lirzin GPG: F2A3 8D7E EB2B 6640 5761 070D 0ADE E100 9460 4D37

Re: Plugin install process pb

2018-08-13 Thread Mathieu Lirzin
Hello again, Mathieu Lirzin writes: >> In my environment (Linux, openjdk version "1.8.0_171") plugin install >> process does not work any more since this commit (june, 20) >> >> def taskExistsInproject(fullyQualifiedProject, taskName) { >> -def tas

Re: [PROPOSITION] Extend the screen engine via plugins

2018-08-23 Thread Mathieu Lirzin
k, identify clearly what > change has been made and a failure support when the extend can't be > applied. > > Currently I didn't found a solution to surcharge ftl. > > If you feel that it's a good way to explore, I will start a new thread. I guess I have started the thread :-) [1] https://en.wikipedia.org/wiki/Monkey_patch -- Mathieu Lirzin GPG: F2A3 8D7E EB2B 6640 5761 070D 0ADE E100 9460 4D37

Re: Gradle, Less, Css : Transpile and minify

2018-08-27 Thread Mathieu Lirzin
(without minification) and in production mode (with minification) to ease the Javascript debugging. Since this is a very common requirement, I guess those Gradle plugins already provide such facility or describe how to customize the impacted tasks. Thanks. -- Mathieu Lirzin GPG: F2A3 8D7E EB2B 6640 5761 070D 0ADE E100 9460 4D37

Re: Editing comments in Jira

2018-08-27 Thread Mathieu Lirzin
using JIRA Web Interface instead which doesn't have this updated comment issue. should only be mentioned as an alternative in “degraded” mode. [1] https://issues.apache.org/jira/projects/OFBIZ/summary -- Mathieu Lirzin GPG: F2A3 8D7E EB2B 6640 5761 070D 0ADE E100 9460 4D37

Re: Issue with opening a bookmarked page when the user is logged out

2018-08-26 Thread Mathieu Lirzin
a opening a ticket. -- Mathieu Lirzin GPG: F2A3 8D7E EB2B 6640 5761 070D 0ADE E100 9460 4D37

‘MapStack’ weirdness.

2018-07-18 Thread Mathieu Lirzin
} return super.put(key, value); } --8<---cut here---end--->8--- I don't understand the purpose of such thing. So if someone has some rationale to share, I would be grateful. Thanks. -- Mathieu Lirzin GPG: F2A3 8D7E EB2B 6640 5761 070D 0ADE E100 9460 4D37

Re: Add ‘method’ attribute to ‘request-map’ elements

2018-07-16 Thread Mathieu Lirzin
e what is done for ‘org.apache.commons.cli.*’ in ‘StartupCommandUtil’. Not depending on it is still a viable option however it will mean having to maintain a non-negligeable amount of non-trivial code in OFBiz. WDYT? Thank you for your insightful review. -- Mathieu Lirzin GPG: F2A3 8D7E EB2B 6640 5761 070D 0ADE E100 9460 4D37

Re: Add ‘method’ attribute to ‘request-map’ elements

2018-07-16 Thread Mathieu Lirzin
Mathieu Lirzin writes: > Taher Alkhateeb writes: > >> - I still don't understand your answer on the new data structure >> "MultiValuedMapContext". This is essentially a whole new data >> structure designed by you and it overrides nearly all standard >&

Re: Add ‘method’ attribute to ‘request-map’ elements

2018-07-16 Thread Mathieu Lirzin
Hello, Just wanted to correct a mistake I have made. Mathieu Lirzin writes: > I needed a MultiMap meaning a map which associates a key to a List of > values not to a scalar. What is nice is that “MultivaluedMap::put” is > not destructive, it just appends the new value to th

Re: ‘MapStack’ weirdness.

2018-07-21 Thread Mathieu Lirzin
onment instance and // use it to process the template with the user's settings. WDYT? -- Mathieu Lirzin GPG: F2A3 8D7E EB2B 6640 5761 070D 0ADE E100 9460 4D37

Re: ‘MapStack’ weirdness.

2018-07-21 Thread Mathieu Lirzin
-start->8--- The ‘context’ Map is added to the ‘Binding’ as a variable called "context" so that variables can be passed back to the caller. --8<---cut here---end--->8--- Thanks for your input. -- Mathieu Lirzin GPG: F2A3 8D7E EB2B 6640 5761 070D 0ADE E100 9460 4D37

Re: Impersonation and Documentation

2018-09-10 Thread Mathieu Lirzin
ybe Asciidoc provides a way to define variables? If so, file name prefixes could be defined with a variable with a meaningful name that could then be reused when referring to an external file. -- Mathieu Lirzin GPG: F2A3 8D7E EB2B 6640 5761 070D 0ADE E100 9460 4D37

Re: Add ‘method’ attribute to ‘request-map’ elements

2018-07-04 Thread Mathieu Lirzin
. Thank you for the explanation. -- Mathieu Lirzin GPG: F2A3 8D7E EB2B 6640 5761 070D 0ADE E100 9460 4D37

Re: Add ‘method’ attribute to ‘request-map’ elements

2018-07-04 Thread Mathieu Lirzin
Shi Jinghai writes: > Yeah, I forgot the site-conf.xsd, now I reverted it in rev. 1835043. Thanks, I have updated the patches from OFBIZ-10438 to re-add those :-) -- Mathieu Lirzin GPG: F2A3 8D7E EB2B 6640 5761 070D 0ADE E100 9460 4D37

Re: Contributing/Coding guidelines

2018-07-10 Thread Mathieu Lirzin
Jacques Le Roux writes: > Le 05/07/2018 à 17:41, Jacques Le Roux a écrit : >> Yes, good idea, I'll do so >> >> Thanks > Done Thanks Jacques. -- Mathieu Lirzin GPG: F2A3 8D7E EB2B 6640 5761 070D 0ADE E100 9460 4D37

Re: Add ‘method’ attribute to ‘request-map’ elements

2018-07-07 Thread Mathieu Lirzin
nd example help? Thanks for the feedback. [1] https://www.restapitutorial.com/lessons/httpmethods.html -- Mathieu Lirzin GPG: F2A3 8D7E EB2B 6640 5761 070D 0ADE E100 9460 4D37

Re: Add ‘method’ attribute to ‘request-map’ elements

2018-07-07 Thread Mathieu Lirzin
ssues.apache.org/jira/browse/OFBIZ-4274 Thanks. [1] https://cxf.apache.org/javadoc/latest/org/apache/cxf/jaxrs/model/URITemplate.html [2] https://www.martinfowler.com/articles/richardsonMaturityModel.html -- Mathieu Lirzin GPG: F2A3 8D7E EB2B 6640 5761 070D 0ADE E100 9460 4D37

Re: Add ‘method’ attribute to ‘request-map’ elements

2018-07-12 Thread Mathieu Lirzin
Hello, Taher Alkhateeb writes: > Examining your patch I have a few comments / questions: FYI I have updated the third patch on OFBIZ-10438 [1] to improve the tests for the ‘resolveMethod’ static method. [1] https://issues.apache.org/jira/browse/OFBIZ-10438 Thanks. -- Mathieu Lirzin

Add ‘method’ attribute to ‘request-map’ elements

2018-07-03 Thread Mathieu Lirzin
Hello, Following revert of rev 1834917, I want to “properly” propose adding a ‘method’ attribute to ‘request-map’ elements. I am currently working on adding REST based Web APIs to OFBiz [1]. In order to do that, it is important for the HTTP controller to handle various HTTP methods differently,

HTTP based API using REST architectural style

2018-04-10 Thread Mathieu Lirzin
il.org/message/ai6q2fbksowaayn4 [2] https://issues.apache.org/jira/browse/OFBIZ-4274 -- Mathieu Lirzin

Re: HTTP based API using REST architectural style

2018-04-14 Thread Mathieu Lirzin
Hello Paul, Paul Foxworthy <p...@cohsoft.com.au> writes: > This might be of interest too: > > https://martinfowler.com/articles/richardsonMaturityModel.html Thanks for the link. -- Mathieu Lirzin GPG: F2A3 8D7E EB2B 6640 5761 070D 0ADE E100 9460 4D37

Re: HTTP based API using REST architectural style

2018-04-13 Thread Mathieu Lirzin
Hello Jacques, Jacques Le Roux <jacques.le.r...@les7arts.com> writes: > Le 10/04/2018 à 11:05, Mathieu Lirzin a écrit : >> >> I have recently started a 5 month internship at Néréide >> <https://nereide.fr/> during which I will work on implementing a >>

Re: Confusing entity names

2018-04-15 Thread Mathieu Lirzin
is to know if changing an entity name is an acceptable breaking change and how it should be handled. Is there a way to deprecate the old entity name, while introducing the new one? -- Mathieu Lirzin GPG: F2A3 8D7E EB2B 6640 5761 070D 0ADE E100 9460 4D37

Re: [Discussion]: Add method attribute to request-map

2018-06-28 Thread Mathieu Lirzin
sometimes hard to define, so I just want to emphasize the *try and avoid* part. > 2- I think it would be better to revert this work. I noticed in the > JIRA for example that Mathieu Lirzin asked for some time to review his > work when you just committed his work without checking what he want

Using alternate dispatcher and delegator for integration tests

2018-10-21 Thread Mathieu Lirzin
and introduces a ton of complexity since we can't assume that there is only one dispatcher and delegator shared by all the tests cases. As a consequence I would like to know if we could agree on removing this unused feature? Thanks. -- Mathieu Lirzin GPG: F2A3 8D7E EB2B 6640 5761 070D 0ADE E100 9460 4D37

Re: Using alternate dispatcher and delegator for integration tests

2018-10-21 Thread Mathieu Lirzin
Here is what I precisely want to remove. >From 66150cc98d2b7b84ee5aa4dee1e25f60556577e6 Mon Sep 17 00:00:00 2001 From: Mathieu Lirzin Date: Sun, 21 Oct 2018 16:02:38 +0200 Subject: [PATCH] Disallow using alternate dispatcher and delegator for integration tests --- framework/testtools

Does ‘StartupControlPanel#loadStartupLoaders’ really require introspection?

2018-10-21 Thread Mathieu Lirzin
inline comment giving a rationale for the current implementation. If that's not the case, I can open a JIRA with a proper patch if needed. Thanks. -- Mathieu Lirzin GPG: F2A3 8D7E EB2B 6640 5761 070D 0ADE E100 9460 4D37

Re: Does ‘StartupControlPanel#loadStartupLoaders’ really require introspection?

2018-10-28 Thread Mathieu Lirzin
en more details. :-) I will be looking into deleting the startup loaders API. Thanks. -- Mathieu Lirzin GPG: F2A3 8D7E EB2B 6640 5761 070D 0ADE E100 9460 4D37

Re: Using alternate dispatcher and delegator for integration tests

2018-10-29 Thread Mathieu Lirzin
rnate model constructors which doesn't impose passing an XML element - removing abuse of inheritance and replace it with delegation - injecting dependencies instead of embedding them So Strong +1! -- Mathieu Lirzin GPG: F2A3 8D7E EB2B 6640 5761 070D 0ADE E100 9460 4D37

Re: svn commit: r1844729 - in /ofbiz/ofbiz-framework/trunk/framework/webapp: dtd/site-conf.xsd src/main/java/org/apache/ofbiz/webapp/control/RequestHandler.java

2018-10-25 Thread Mathieu Lirzin
->8--- Joke aside :-), it would be *really* great if people could make an effort sticking to the convention of using no more than 120 characters per line which is already enough to make my eyes bleed. Thanks. -- Mathieu Lirzin GPG: F2A3 8D7E EB2B 6640 5761 070D 0ADE E100 9460 4D37

Re: Pursuing the “120 chars max” guideline

2018-10-26 Thread Mathieu Lirzin
Jacques Le Roux writes: > Le 26/10/2018 à 11:13, Mathieu Lirzin a écrit : >> I sympathise but I am not sure about this strategy, which depending on >> the capabilities of your VCS might obscure the commit history. I would >> recommend to simply use the “120 chars max” guid

Pursuing the “120 chars max” guideline (was: svn commit: r1844729 - in /ofbiz/ofbiz-framework/trunk/framework/webapp: dtd/site-conf.xsd src/main/java/org/apache/ofbiz/webapp/control/RequestHandler.jav

2018-10-26 Thread Mathieu Lirzin
e the “120 chars max” guideline for newly added code and when refactoring existing one. WDYT? -- Mathieu Lirzin GPG: F2A3 8D7E EB2B 6640 5761 070D 0ADE E100 9460 4D37

Re: svn commit: r1846159 [1/2] - in /ofbiz/tools: ./ wiki-files/ wiki-files/birt/

2018-11-08 Thread Mathieu Lirzin
velopper manual instead of simply deleting the page. This helps people keeping bookmarks on some important Wiki pages which could be hard to retrieve otherwise. Additionally this would help avoiding both internal and external links breakage. WDYT? -- Mathieu Lirzin GPG: F2A3 8D7E EB2B 6640 5761 070D

Re: svn commit: r1845933 - /ofbiz/ofbiz-framework/trunk/framework/base/src/main/java/org/apache/ofbiz/base/util/GroovyUtil.java

2018-11-11 Thread Mathieu Lirzin
ovy plugin for supporting unit tests written in Groovy beforehand, it should work gracefully. Otherwise looks good to me. [1] https://issues.apache.org/jira/projects/OFBIZ/issues/OFBIZ-10611 -- Mathieu Lirzin GPG: F2A3 8D7E EB2B 6640 5761 070D 0ADE E100 9460 4D37

Using plain Groovy classes for services.

2018-11-11 Thread Mathieu Lirzin
people think? Thanks. -- Mathieu Lirzin GPG: F2A3 8D7E EB2B 6640 5761 070D 0ADE E100 9460 4D37

Re: Using plain Groovy classes for services.

2018-11-13 Thread Mathieu Lirzin
which could reads like the current ‘run’ method of the DSL and provide the same semantics (throwing an exception upon failure). Something like: dispatcher.run service: "fooService" with: [...] Thanks for your questions. -- Mathieu Lirzin GPG: F2A3 8D7E EB2B 6640 5761 070D 0ADE E100 9460 4D37

Re: svn commit: r1846159 [1/2] - in /ofbiz/tools: ./ wiki-files/ wiki-files/birt/

2018-11-09 Thread Mathieu Lirzin
Jacques Le Roux writes: > Le 08/11/2018 à 23:26, Mathieu Lirzin a écrit : >> Even if IME a majority of links are already broken in the Wiki (which is >> part of the reason why I am strongly convinced that Wikis as a main >> documentation are a bad idea), I would sugge

Re: svn commit: r1845933 - /ofbiz/ofbiz-framework/trunk/framework/base/src/main/java/org/apache/ofbiz/base/util/GroovyUtil.java

2018-11-08 Thread Mathieu Lirzin
t/groovyScripts ./framework/webtools/groovyScripts ./framework/common/groovyScripts ./framework/base/groovyScript --8<---cut here---end--->8--- -- Mathieu Lirzin GPG: F2A3 8D7E EB2B 6640 5761 070D 0ADE E100 9460 4D37

Re: Using plain Groovy classes for services.

2018-11-14 Thread Mathieu Lirzin
presentations/Simple-Made-Easy-QCon-London-2012 -- Mathieu Lirzin GPG: F2A3 8D7E EB2B 6640 5761 070D 0ADE E100 9460 4D37

Re: Does ‘StartupControlPanel#loadStartupLoaders’ really require introspection?

2018-11-02 Thread Mathieu Lirzin
Hello, Mathieu Lirzin writes: > I will be looking into deleting the startup loaders API. As a citizen of the *Start-Up Nation* [1], I am proud to announce that the startup loader abstraction has finally been concretized! :-) I have opened OFBIZ-10638 [2] for review. Thanks. [1] ht

Re: svn commit: r1841664 - /ofbiz/branches/release16.11/framework/base/src/main/java/org/apache/ofbiz/base/util/UtilValidate.java

2018-09-22 Thread Mathieu Lirzin
; numbers either start with the numbers 51 through 55 or with the numbers 2221 > through 2720. All have 16 digits; Sample number: 5500 0004(16 > digits) > * @return true, if the credit card number is a valid MasterCard > number, false otherwise > */ Next ti

Re: svn commit: r1841675 - /ofbiz/tools/verify-ofbiz-release.sh

2018-09-22 Thread Mathieu Lirzin
_EN.UTF-8 export LC_MESSAGES Thanks. -- Mathieu Lirzin GPG: F2A3 8D7E EB2B 6640 5761 070D 0ADE E100 9460 4D37

Re: svn commit: r1848673 [1/4] - in /ofbiz: ofbiz-framework/trunk/ ofbiz-framework/trunk/applications/accounting/src/main/java/org/apache/ofbiz/accounting/invoice/ ofbiz-framework/trunk/applications/a

2018-12-11 Thread Mathieu Lirzin
ur processes to achieve both review scalabity and commit atomicity, but in any case I am grateful to Jacques for the important and useful work he is doing by reviewing other people patches. [1] https://issues.apache.org/jira/browse/OFBIZ-10701 -- Mathieu Lirzin GPG: F2A3 8D7E EB2B 6640 5761 070D 0A

Re: [DISCUSSION] Checking debug levels in Java and Groovy files

2018-12-11 Thread Mathieu Lirzin
by an actual measurement, and this has not been the case in this discussion. Personnally I care about the readability of the code and choosing the option 2 is not helping in that regard. [1] https://youtu.be/z5UkoLaW6ME?t=213 -- Mathieu Lirzin GPG: F2A3 8D7E EB2B 6640 5761 070D 0ADE E100 9460 4D37

Re: [Discussion] Upgrading OFBiz to work with Java 11

2018-12-27 Thread Mathieu Lirzin
1 is still not available on the GNU/Linux distro I am using. So upgrading it right now would make my life harder. -- Mathieu Lirzin GPG: F2A3 8D7E EB2B 6640 5761 070D 0ADE E100 9460 4D37

Re: [DOCUMENTATION] TOCs level and numbers

2018-12-02 Thread Mathieu Lirzin
e of content level to 3, However I strongly disagree with the removal of section numbers which IME helps both in understanding the structure of the manual and in making references to a specific section. -- Mathieu Lirzin GPG: F2A3 8D7E EB2B 6640 5761 070D 0ADE E100 9460 4D37

Re: Using plain Groovy classes for services.

2018-11-22 Thread Mathieu Lirzin
Hello Jacques, Jacques Le Roux writes: > Le 21/11/2018 à 17:43, Jacques Le Roux a écrit : >> Le 17/11/2018 à 20:12, Mathieu Lirzin a écrit : >>> For services I think the business logic and validation of data contained >>> in services could often be extracted in sep

Re: Using plain Groovy classes for services.

2018-11-17 Thread Mathieu Lirzin
ch would allow cheap better case coverage to complement the integration test which is about checking that the service has the expected effect on the database. -- Mathieu Lirzin GPG: F2A3 8D7E EB2B 6640 5761 070D 0ADE E100 9460 4D37

Re: Unable to set the autoLogin Cookie when mount-point is set as an empty string

2019-01-10 Thread Mathieu Lirzin
[1] https://issues.apache.org/jira/browse/OFBIZ-10606 -- Mathieu Lirzin GPG: F2A3 8D7E EB2B 6640 5761 070D 0ADE E100 9460 4D37

Re: git commit workflow for ofbiz

2019-01-12 Thread Mathieu Lirzin
lem. :-) Joke aside I think the question should rather be: Is there anyone here opposing to the move from SVN to Git? Thanks for reviving this topic! -- Mathieu Lirzin GPG: F2A3 8D7E EB2B 6640 5761 070D 0ADE E100 9460 4D37

OFBiz shell

2019-01-12 Thread Mathieu Lirzin
to interactively execute commands and check their results instantly. I have implemented such feature in OFBIZ-10805 [1] which might be interested to follow/review for those who care about interactive development. Thanks. [1] https://issues.apache.org/jira/browse/OFBIZ-10805 -- Mathieu Lirzin GPG: F2A3 8D7E

Re: OFBiz shell

2019-01-12 Thread Mathieu Lirzin
lications of using the current thread class loader. What kind of scenario of non-clean termination of shells have you in mind? Thanks for your comment. -- Mathieu Lirzin GPG: F2A3 8D7E EB2B 6640 5761 070D 0ADE E100 9460 4D37

Getting rid of the Script helper abstractions

2019-01-13 Thread Mathieu Lirzin
/docs/api/java/util/ServiceLoader.html -- Mathieu Lirzin GPG: F2A3 8D7E EB2B 6640 5761 070D 0ADE E100 9460 4D37

Defining multi-segment routes in the controller.

2019-03-23 Thread Mathieu Lirzin
OFBIZ-4274 [2] https://tools.ietf.org/html/rfc6570 -- Mathieu Lirzin GPG: F2A3 8D7E EB2B 6640 5761 070D 0ADE E100 9460 4D37

Re: svn commit: r1857084 - /ofbiz/ofbiz-framework/trunk/framework/widget/src/main/java/org/apache/ofbiz/widget/renderer/FormRenderer.java

2019-04-08 Thread Mathieu Lirzin
r.java >>> > (original) >>> > +++ >>> > >>> ofbiz/ofbiz-framework/trunk/framework/widget/src/main/java/org/apache/ofbiz/widget/renderer/FormRenderer.java >>> > Sun Apr 7 19:38:09 2019 >>> > @@ -1215,8 +1215,7 @@ public class FormRenderer { >>> > } >>> > int itemIndex = -1; >>> > if (iter instanceof EntityListIterator) { >>> > -EntityListIterator eli = (EntityListIterator) iter; >>> > -try { >>> > +try (EntityListIterator eli = (EntityListIterator) iter) { >>> > if(eli.getResultsSizeAfterPartialList() > 0){ >>> > itemIndex++; >>> > } >>> > >>> > >>> > >>> >> -- Mathieu Lirzin GPG: F2A3 8D7E EB2B 6640 5761 070D 0ADE E100 9460 4D37

Re: buildbot exception in on ofbizTrunkFramework

2019-04-07 Thread Mathieu Lirzin
e changes I made has introduced unexpected regression. I have reverted them in revision 1857091. -- Mathieu Lirzin GPG: F2A3 8D7E EB2B 6640 5761 070D 0ADE E100 9460 4D37

Re: JobManager/JobPoller issues

2019-02-25 Thread Mathieu Lirzin
Hello Scott, Scott Gray writes: > I'm working on implementing the priority queue approach at the moment for a > client. All things going well it will be in production in a couple of > weeks and I'll report back then with a patch. Sounds great! -- Mathieu Lirzin GPG: F2A3 8D7E EB2B

Re: Welcome to Mathieu Lirzin as new committer!

2019-02-25 Thread Mathieu Lirzin
Hello, Taher Alkhateeb writes: > The OFBiz PMC has invited Mathieu Lirzin to become a new committer and > we are happy to announce that he has accepted this role. Thanks everybody for the congratulations and welcoming me as a committer in this project. -- Mathieu Lirzin GPG: F2A3 8D7

Re: [REMOVE?] OWASP Dependency Check feature (Gradle plugin)

2019-03-03 Thread Mathieu Lirzin
ine (See OFBIZ-10700) I can hardly see any reason to keep it. -- Mathieu Lirzin GPG: F2A3 8D7E EB2B 6640 5761 070D 0ADE E100 9460 4D37

Re: svn commit: r1854366 - /ofbiz/ofbiz-framework/trunk/framework/entity/src/main/java/org/apache/ofbiz/entity/connection/DebugManagedDataSource.java

2019-02-26 Thread Mathieu Lirzin
ures that the close() method does not throw an >> InterruptedException >> // to conform to the AutoCloseable interface. >> -// This is fixing what should be down in >> org.apache.commons.dbcp2.PoolingDataSource. >> +// This is fixing what should be done

Using Gradle ‘application’ and ‘distribution’ plugins

2019-03-16 Thread Mathieu Lirzin
on the target or a convoluted/brittle shell script. If nobody disagree I will commit this in a week. Thanks. [1] https://issues.apache.org/jira/browse/OFBIZ-10866 -- Mathieu Lirzin GPG: F2A3 8D7E EB2B 6640 5761 070D 0ADE E100 9460 4D37

Removing the ‘:terminateOfbiz’ Gradle task

2019-03-17 Thread Mathieu Lirzin
of a desperate endeavour which is to guess how the system of a user is managing its processes. As a consequence I will suggest to simply remove this task to not make false promises to users and let them manage the processes on their system by themselves. :-) What do people think? -- Mathieu Lirz

Re: gradlew generateOfbizDocumentation error

2019-03-18 Thread Mathieu Lirzin
se 1854593 generation seems correct >> with 1854595 generation works but with a lot of messages >> with 1854818 generation failed >> >> on trunk , if I remove line >>     id 'org.owasp.dependencycheck' version '3.0.2' apply false >> >> generation works but with a lot of messages. >> >> > -- Mathieu Lirzin GPG: F2A3 8D7E EB2B 6640 5761 070D 0ADE E100 9460 4D37

Re: svn commit: r1855798 - /ofbiz/ofbiz-framework/trunk/build.gradle

2019-03-20 Thread Mathieu Lirzin
de. Sure I agree that's an important guideline to follow. Thanks. [1] https://cwiki.apache.org/confluence/display/OFBIZ/OFBiz+Contributors+Best+Practices [2] https://issues.apache.org/jira/browse/OFBIZ-10866 -- Mathieu Lirzin GPG: F2A3 8D7E EB2B 6640 5761 070D 0ADE E100 9460 4D37

When do we need a JIRA? (was: svn commit: r1855798 - /ofbiz/ofbiz-framework/trunk/build.gradle)

2019-03-22 Thread Mathieu Lirzin
Hello, In the same spirit, I want to know if it is OK to improve or add some Javadoc without opening a ticket on JIRA? Thanks. Mathieu Lirzin writes: > Hello Michael, > > Michael Brohl writes: > >> don't we have Jira's for all these changes? >> >> If yes, p

Re: future of OFBiz: REST is essential.

2019-01-29 Thread Mathieu Lirzin
support (architecture, advantages, drawbacks, limitations, …) and give some pointers to the implementation? Additionally what would be your recommended strategy to port this work? Are you willing to do the work? Thanks. [1] https://guide.elm-lang.org/architecture/ -- Mathieu Lirzin GPG: F2A3 8D7E EB2B 6640 5761 070D 0ADE E100 9460 4D37

Re: [OPTIONS] Java 11 and Java JDK origin

2019-04-14 Thread Mathieu Lirzin
ot’) Thanks. -- Mathieu Lirzin GPG: F2A3 8D7E EB2B 6640 5761 070D 0ADE E100 9460 4D37

Re: svn commit: r1856609 - in /ofbiz/ofbiz-framework/trunk/applications/order: groovyScripts/test/OrderTests.groovy testdef/data/OrderTestData.xml

2019-04-19 Thread Mathieu Lirzin
this issue this evening, and after some hours I still do not understand the bug. It is depressing to see how hard it is to work with OFBiz integration tests. If you don't find a solution before the end of the week, please revert revision 1856596 which introduces the issue (meaning removing “OrderTests.gr

Re: svn commit: r1856609 - in /ofbiz/ofbiz-framework/trunk/applications/order: groovyScripts/test/OrderTests.groovy testdef/data/OrderTestData.xml

2019-04-20 Thread Mathieu Lirzin
r because of that. Currently only the following syntax is “working”: --8<---cut here---start->8--- --8<---cut here---end--->8--- -- Mathieu Lirzin GPG: F2A3 8D7E EB2B 6640 5761 070D 0ADE E100 9460 4D37

Re: svn commit: r1856609 - in /ofbiz/ofbiz-framework/trunk/applications/order: groovyScripts/test/OrderTests.groovy testdef/data/OrderTestData.xml

2019-04-20 Thread Mathieu Lirzin
against > jdk8? > *Caveat: I recently set this up, so there may still be some configuration > issues in the jdk11-test setup.. * I have just tested the “ordertests” test-suite with Icedtea 3.7 (jdk-8) and it is still failing, so it seems unrelated in that case. Thanks. -- Mathieu Lirzin GPG: F2A3 8D7E EB2B 6640 5761 070D 0ADE E100 9460 4D37