Re: svn commit: r1804224 - /ofbiz/ofbiz-plugins/trunk/birt/src/main/java/org/apache/ofbiz/birt/flexible/BirtUtil.java

2017-08-06 Thread Aditya Sharma
Pardon me for the typo *Deepak Thanks and Regards, *Aditya Sharma* | Enterprise Software Engineer HotWax Systems On Sun, Aug 6, 2017 at 1:01 PM, Aditya Sharma wrote: > Hi

Re: svn commit: r1804224 - /ofbiz/ofbiz-plugins/trunk/birt/src/main/java/org/apache/ofbiz/birt/flexible/BirtUtil.java

2017-08-06 Thread Aditya Sharma
Hi Depak, I think we can just remove these lines instead of replacing them as these field types are already mapped with Birt data type & got redundant now. private final static Map entityFieldTypeBirtTypeMap = MapUtils.unmodifiableMap(UtilMisc.toMap( *"id",

Re: Rule to deprecated a service

2017-08-06 Thread Taher Alkhateeb
Hmmm I am not sure if comments are the most appropriate form for deprecation. Usually deprecation is useful when it is programmatic because it goes beyond raw text to logging warnings and highlighting by tools. You want the system to constantly remind you (both the developer and author) to get rid

Re: Rule to deprecated a service

2017-08-06 Thread Jacques Le Roux
I agree with Nicolas and Taher, A POC would help to remove hesitations Jacques Le 06/08/2017 à 08:03, Taher Alkhateeb a écrit : Hmmm I am not sure if comments are the most appropriate form for deprecation. Usually deprecation is useful when it is programmatic because it goes beyond raw text

Re: Rule to deprecated a service

2017-08-06 Thread Nicolas Malin
Thanks for your return Deepak and Taher. I suggested to use comment to deprecated because it's really fast to implement with a combination of process and small modification code. Like Taher, just I found not enough just a comment. What do you think about add a new xml element to service

Re: Rule to deprecated a service

2017-08-06 Thread Jacques Le Roux
+1 Jacques Le 06/08/2017 à 19:04, Nicolas Malin a écrit : Thanks for your return Deepak and Taher. I suggested to use comment to deprecated because it's really fast to implement with a combination of process and small modification code. Like Taher, just I found not enough just a comment.

Re: Rule to deprecated a service

2017-08-06 Thread Scott Gray
+1 for logging a warning instead of an error +1 for using an element to deprecate. Although I'd prefer "deprecated" for the element name and I'd prefer "use-instead" for the attribute name. Would keep us consistent with java conventions, @deprecated and the text is often "use X instead". I think