Are tests failing for createAcctgTransForPurchaseInvoice and createAcctgTransForCustomerReturnInvoice?

On 20 February 2018 at 00:48, Jacques Le Roux wrote: > It could be related with Paul's last commit r1824740. I see a lot of error > at https://ci.apache.org/projects/ofbiz/logs/trunk/framework/html/ Hi Jacques, I see 100% pass when I look there. If you are seeing

Re: svn commit: r1824807 - /ofbiz/branches/release16.11/framework/webapp/src/main/java/org/apache/ofbi z/webapp/control/LoginWorker.java

Jacques, as a first step, please consider not using "no functional change" any longer. It used to be that it was simply used for basic formatting fixes, but now that I look closer, I notice you've had a trend going for a while now that you're using it for anything you consider to be minor.

Re: Admin Login not working for Framework Trunk

Hi Sharan, it seems that you have not loaded the seed data. Did you run ./gradle loadAll ? Best regards, Michael Brohl ecomify GmbH www.ecomify.de Am 19.02.18 um 13:43 schrieb Sharan Foga: Hi All Not sure if this is related to any of the discussions happening, but I've just done a fresh

Re: Admin Login not working for Framework Trunk

Hi All Yep - thanks. That was it! I think I'm trying to do a bit too much multi tasking to forget something as basic as that. I am definitely going to slow down a bit now :-) Thanks Sharan On 2018/02/19 13:15:02, Michael Brohl wrote: > Hi Sharan, > > it seems that

Re: Admin Login not working for Framework Trunk

Hi Sharan, It could be related with Paul's last commit r1824740. I see a lot of error at https://ci.apache.org/projects/ofbiz/logs/trunk/framework/html/ I updated this morning, before Paul's last commit, and it still work locally here. You could try to revert his commits and see if it works.

Re: Admin Login not working for Framework Trunk

Yes I think it's more something like that, I don't see how Paul's commit could entail a such issue. Jacques Le 19/02/2018 à 14:15, Michael Brohl a écrit : Hi Sharan, it seems that you have not loaded the seed data. Did you run ./gradle loadAll ? Best regards, Michael Brohl ecomify GmbH

Admin Login not working for Framework Trunk

Hi All Not sure if this is related to any of the discussions happening, but I've just done a fresh checkout and build of the framework trunk and am getting errors when I try to login with the default admin user. This is error that is showing: The datamodel data has not been loaded; cannot

Re: svn commit: r1824807 - /ofbiz/branches/release16.11/framework/webapp/src/main/java/org/apache/ofbi z/webapp/control/LoginWorker.java

Jacques, I won't correct you commit messages. This is a repeating issue. From now on, we will just not include those commits in the blog dev details. Am 19.02.18 um 22:07 schrieb Jacques Le Roux: Please Michael, I had a very rude day, we are a team, if you fill it needs a log change

Re: [OFBIZ-4959] Logout do not remove autoLogin

I proposed a 1st patch, we discussed it, it was not OK, I agreed, I implemented the way Taher proposed, we use the RTC, please now review Thanks Jacques Le 19/02/2018 à 20:57, Michael Brohl a écrit : +1 We are discussing this over and over again. I wonder what's so difficult to stick to

Re: svn commit: r1824807 - /ofbiz/branches/release16.11/framework/webapp/src/main/java/org/apache/ofbi z/webapp/control/LoginWorker.java

Please Michael, I had a very rude day, we are a team, if you fill it needs a log change please do Thanks Jacques Le 19/02/2018 à 20:59, Michael Brohl a écrit : So this is a bugfix and should read "Fixed: ..." *sigh* Am 19.02.18 um 20:43 schrieb jler...@apache.org: Author: jleroux Date:

Re: [OFBIZ-4959] Logout do not remove autoLogin

Done Jacques Le 18/02/2018 à 20:33, Jacques Le Roux a écrit : Taher, I agree using a property is hackish. I'll try to implement what you suggest using a keep-autologin-cookie webapp attribute which will be false by default and true for the applications mentioned below. I'll check it make

Re: [OFBIZ-4959] Logout do not remove autoLogin

Thank you for the work Jacques. I was hoping as stated earlier that you share the work before committing it since it is an architectural decision that requires community consensus. On Feb 19, 2018 10:29 PM, "Jacques Le Roux" wrote: Done Jacques Le 18/02/2018 à

Re: [OFBIZ-4959] Logout do not remove autoLogin

+1 We are discussing this over and over again. I wonder what's so difficult to stick to some basic rules of collaboration. Am 19.02.18 um 20:48 schrieb Taher Alkhateeb: Thank you for the work Jacques. I was hoping as stated earlier that you share the work before committing it since it is an

Re: svn commit: r1824807 - /ofbiz/branches/release16.11/framework/webapp/src/main/java/org/apache/ofbiz/webapp/control/LoginWorker.java

So this is a bugfix and should read "Fixed: ..." *sigh* Am 19.02.18 um 20:43 schrieb jler...@apache.org: Author: jleroux Date: Mon Feb 19 19:43:15 2018 New Revision: 1824807 URL: http://svn.apache.org/viewvc?rev=1824807=rev Log: No functional change, this missed an import in last backported