Re: Demo Trunk Break

2018-03-18 Thread Taher Alkhateeb
What you are mentioning has nothing to do with ant / gradle, but rather with the design of our build script, which BTW I prefer the way it is designed now because it provides consistency and uniform access for all components. Also what we gained from the switch far outweighs any set backs.

Re: Documentation commits (.adoc file type)

2018-03-18 Thread Taher Alkhateeb
That was quick! Great work Michael On Sun, Mar 18, 2018, 4:06 PM Michael Brohl wrote: > Done. > > Michael > > Am 18.03.18 um 13:27 schrieb Michael Brohl: > > Thanks for the hint, Pierre. > > > > I will take care of it and complete the existing .adoc files, also > >

.adoc and ASL2

2018-03-18 Thread Jacques Le Roux
Hi, Some (all it seems) of .adoc files miss the ASL2 header license. As you can see it's not the case: https://ci.apache.org/projects/ofbiz/rat-output.html Was it done by purpose? If it's the case what are the rationales? Jacques

Re: Documentation commits (.adoc file type)

2018-03-18 Thread Jacques Le Roux
Hi Pierre, We crossed on wire, I guess because of https://s.apache.org/hsXA :) Jacques Le 18/03/2018 à 12:28, Pierre Smits a écrit : Hi All, Please be aware that when an .adoc artefact is committed to the repo that the file has the Apache header in place. Best regards, Pierre Smits

Documentation commits (.adoc file type)

2018-03-18 Thread Pierre Smits
Hi All, Please be aware that when an .adoc artefact is committed to the repo that the file has the Apache header in place. Best regards, Pierre Smits ORRTIZ.COM OFBiz based solutions & services OEM - The OFBiz Extensions Marketplace1 http://oem.ofbizci.net/oci-2/ 1 not

Re: Documentation commits (.adoc file type)

2018-03-18 Thread Jacques Le Roux
Thanks Michael, Weirdly Buildbot did not grasp the commit Let's wait, it's OK anyway Jacques Le 18/03/2018 à 14:06, Michael Brohl a écrit : Done. Michael Am 18.03.18 um 13:27 schrieb Michael Brohl: Thanks for the hint, Pierre. I will take care of it and complete the existing .adoc

Re: Documentation commits (.adoc file type)

2018-03-18 Thread Michael Brohl
Thanks for the hint, Pierre. I will take care of it and complete the existing .adoc files, also leave a notice in the wiki. Thanks, Michael Am 18.03.18 um 12:28 schrieb Pierre Smits: Hi All, Please be aware that when an .adoc artefact is committed to the repo that the file has the Apache

Re: Documentation commits (.adoc file type)

2018-03-18 Thread Michael Brohl
Done. Michael Am 18.03.18 um 13:27 schrieb Michael Brohl: Thanks for the hint, Pierre. I will take care of it and complete the existing .adoc files, also leave a notice in the wiki. Thanks, Michael Am 18.03.18 um 12:28 schrieb Pierre Smits: Hi All, Please be aware that when an .adoc

Re: Demo Trunk Break

2018-03-18 Thread Jacques Le Roux
I have created https://issues.apache.org/jira/browse/OFBIZ-10287 for that Just apart: sincerely there are some times I regret Ant for being able to stop and start a sole instance, and compile a component only. Just a matter of time, but time is ultimately all what we have... Jacques Le

Re: Documentation commits (.adoc file type)

2018-03-18 Thread Michael Brohl
Thanks Taher, for file in $( find . -name "*.adoc" ); do cat ../license.txt ${file} > ${file}.tmp; mv ${file}.tmp ${file}; done did the trick ;-) Regards, Michael Am 18.03.18 um 14:23 schrieb Taher Alkhateeb: That was quick! Great work Michael On Sun, Mar 18, 2018, 4:06 PM Michael Brohl

[DOC] Example asciidoc file as guideline

2018-03-18 Thread Michael Brohl
Heyho, I played around with asciidoc a bit and did some minor changes to display a nice title page and did some configurations for the user/developer manuals. I studied a few example .adoc files and wonder if we should provide a best practice example .adoc file. This could contain all

Re: [DOC] Example asciidoc file as guideline

2018-03-18 Thread Taher Alkhateeb
Hmmm, Sounds like a good idea, but perhaps maybe a bit early? We might be still evolving and learning how to structure our documents. Also, maybe if we keep our documents clean and consistent, then they themselves offer an example for how to write stuff? Examples usually run out of date quickly

Re: svn commit: r1827146 - in /ofbiz/ofbiz-framework/trunk/docs/asciidoc: developer-manual.adoc images/OFBiz-Logo.svg user-manual.adoc

2018-03-18 Thread Michael Brohl
Hi Taher, thank you :-) The release number is just meant as an example in the course of playing with the documentation framework. I know it's wrong and should be adjusted. I think it might be helpful to have the exact release version (if in a release branch) so we can provide generated pdf

Re: [DOC] Example asciidoc file as guideline

2018-03-18 Thread Michael Brohl
Maybe I was not clear enough... I am suggesting some kind of style guide. I think if we provide it in the early stage, people might get inspired from it and have examples in a very compressed form. I find the several examples that I've studied very helpful but they are cluttered all over the

Re: svn commit: r1827146 - in /ofbiz/ofbiz-framework/trunk/docs/asciidoc: developer-manual.adoc images/OFBiz-Logo.svg user-manual.adoc

2018-03-18 Thread Taher Alkhateeb
Beautiful :) I love it Release 17.12 though? Shouldn't we call it trunk / snapshot for now and then rename it for each release? On Sun, Mar 18, 2018 at 7:24 PM, wrote: > Author: mbrohl > Date: Sun Mar 18 16:24:31 2018 > New Revision: 1827146 > > URL:

Re: svn commit: r1827146 - in /ofbiz/ofbiz-framework/trunk/docs/asciidoc: developer-manual.adoc images/OFBiz-Logo.svg user-manual.adoc

2018-03-18 Thread Taher Alkhateeb
Now that I think about it, maybe we can actually even go as far as publishing the subversion revision number on each call to generateOfbizDocumentation if you folks think this is useful? On Sun, Mar 18, 2018 at 7:29 PM, Taher Alkhateeb wrote: > Beautiful :) I love it

Re: [DOC] Example asciidoc file as guideline

2018-03-18 Thread Taher Alkhateeb
Ahh I see, sounds cool. Looking forward On Sun, Mar 18, 2018 at 7:55 PM, Michael Brohl wrote: > Maybe I was not clear enough... I am suggesting some kind of style guide. > > I think if we provide it in the early stage, people might get inspired from > it and have

Re: svn commit: r1827146 - in /ofbiz/ofbiz-framework/trunk/docs/asciidoc: developer-manual.adoc images/OFBiz-Logo.svg user-manual.adoc

2018-03-18 Thread Taher Alkhateeb
Yeah, I think it is doable (revision number) without much of a hassle. Not sure what others think though? I'll wait for some feedback from the community perhaps? On Sun, Mar 18, 2018 at 7:43 PM, Michael Brohl wrote: > Hi Taher, > > thank you :-) > > The release number

Re: 17.12 backports for UI improvements, was: (OFBIZ-10242) Standardise Layout throughout Applications

2018-03-18 Thread Deepak Dixit
I think we can backport both ticket changes to R17.12, they are UX improvement, I don't think this can be cause any functional issue. Thanks & Regards -- Deepak Dixit www.hotwaxsystems.com www.hotwax.co On Sun, Mar 18, 2018 at 1:45 AM, Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: >