Re: svn commit: r1536324

2019-05-15 Thread Jacques Le Roux
Hi Scott, Jacopo, All, I have finally reopened OFBIZ-5254 as I propose a solution for this issue in a new patch. checkStringForHtmlSafeOnly() is still a WIP and can be improved, fortunately by using extendible policies Jacques Le 03/09/2016 à 11:27, Jacopo Cappellato a écrit : I am

Re: Code Improvement for Groovy

2019-05-15 Thread Jacques Le Roux
Hi Pawan, Sure, we use that from start a lot. But some don't it seems. A Jira fits with me Le 15/05/2019 à 14:29, Pawan Verma a écrit : Hello Devs, As we all know, Groovy is a powerful language with great built-in functions. Groovy Truth[1] is one of them, which is not used properly in our

Re: Code Improvement for Groovy

2019-05-15 Thread Rishi Solanki
+1 Best Regards, -- *Rishi Solanki* | Sr Manager, Enterprise Software Development HotWax Systems Linkedin: *Rishi Solanki* Direct: +91-9893287847 On Wed, May 15, 2019 at 8:33 PM Jacques Le Roux <

Re: svn commit: r1858270 [1/3] - in /ofbiz/ofbiz-framework/trunk/applications: datamodel/data/demo/ datamodel/data/seed/ datamodel/entitydef/ order/config/ order/data/ order/entitydef/ order/groovyScr

2019-05-15 Thread Suraj Khurana
Thanks Deepak. Yes, it is due to same block that Deepak has mentioned. I checked on my local machine and everything works fine after handling this code block. I will modify the condition little bit and commit in sometime. -- Best Regards, Suraj Khurana Technical Consultant On Wed, May 15,

Re: svn commit: r1856609 - in /ofbiz/ofbiz-framework/trunk/applications/order: groovyScripts/test/OrderTests.groovy testdef/data/OrderTestData.xml

2019-05-15 Thread Suraj Khurana
I hope this is fixed after rev #1859267. -- Best Regards, Suraj Khurana Technical Consultant On Tue, May 14, 2019 at 3:10 PM Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > Thanks Rishi, > > It seems it's something else now. > > I'll also have a look, hopefully today > > Jacques >

Re: svn commit: r1856609 - in /ofbiz/ofbiz-framework/trunk/applications/order: groovyScripts/test/OrderTests.groovy testdef/data/OrderTestData.xml

2019-05-15 Thread Jacques Le Roux
Great news, it's resolved with r1859267 Le 14/05/2019 à 11:38, Jacques Le Roux a écrit : Thanks Rishi, It seems it's something else now. I'll also have a look, hopefully today Jacques Le 14/05/2019 à 11:22, Rishi Solanki a écrit : Below are the test cases failure list on running "cleanAll

Re: svn commit: r1858270 [1/3] - in /ofbiz/ofbiz-framework/trunk/applications: datamodel/data/demo/ datamodel/data/seed/ datamodel/entitydef/ order/config/ order/data/ order/entitydef/ order/groovyScr

2019-05-15 Thread Suraj Khurana
Done at rev #1859267 -- Best Regards, Suraj Khurana Technical Consultant On Wed, May 15, 2019 at 11:31 AM Suraj Khurana wrote: > Thanks Deepak. Yes, it is due to same block that Deepak has mentioned. > > I checked on my local machine and everything works fine after handling > this code

Re: svn commit: r1858270 [1/3] - in /ofbiz/ofbiz-framework/trunk/applications: datamodel/data/demo/ datamodel/data/seed/ datamodel/entitydef/ order/config/ order/data/ order/entitydef/ order/groovyScr

2019-05-15 Thread Deepak Dixit
Thanks Suraj. Thanks & Regards -- Deepak Dixit On Wed, May 15, 2019 at 11:49 AM Suraj Khurana wrote: > Done at rev #1859267 > > -- > Best Regards, > Suraj Khurana > Technical Consultant > > > > > > On Wed, May 15, 2019 at 11:31 AM Suraj Khurana > wrote: > > > Thanks Deepak. Yes, it is due to

Re: svn commit: r1856609 - in /ofbiz/ofbiz-framework/trunk/applications/order: groovyScripts/test/OrderTests.groovy testdef/data/OrderTestData.xml

2019-05-15 Thread Jacques Le Roux
Hi Suraj, We crossed on wire :) Buildbot is still recalcitrant (works locally here too), but I'll force it! Le 15/05/2019 à 08:17, Suraj Khurana a écrit : I hope this is fixed after rev #1859267. -- Best Regards, Suraj Khurana Technical Consultant On Tue, May 14, 2019 at 3:10 PM Jacques

Re: Re-designing the ‘Security’ interface

2019-05-15 Thread Jacques Le Roux
Hi Michael, Thanks for mentioning this which came already on the table several times. We had this discussion in the past[1] (the last one?). But AFAIK only about services and came to this agreement[2] [1] https://markmail.org/message/gqultbcgbonph5ax [2] https://s.apache.org/12Uq I don't

Re: Reviving the OFBiz community day

2019-05-15 Thread Swapnil M Mane
Thanks team! I will post the detailed information about upcoming community day on the user mailing list. - Best Regards, Swapnil M Mane, ofbiz.apache.org On Fri, May 10, 2019 at 12:33 PM Devanshu Vyas wrote: > Great initiative and love to be a part of it. +1 > > > Thanks & Regards, > Devanshu

Re: buildbot success in on ofbizTrunkFrameworkPlugins

2019-05-15 Thread Jacques Le Roux
All is OK now :) Le 15/05/2019 à 12:41, build...@apache.org a écrit : The Buildbot has detected a restored build on builder ofbizTrunkFrameworkPlugins while building . Full details are available at: https://ci.apache.org/builders/ofbizTrunkFrameworkPlugins/builds/788 Buildbot URL:

Code Improvement for Groovy

2019-05-15 Thread Pawan Verma
Hello Devs, As we all know, Groovy is a powerful language with great built-in functions. Groovy Truth[1] is one of them, which is not used properly in our code base. We have used UtilValidate Class to validate arguments for Empty or NotEmpty, which can easily be done in groovy with built-in