Re: [PROPOSAL] Replace Inline Javascript with External Javascript

2017-07-08 Thread Aditya Sharma
Thanks everyone for the suggestions and appreciations. I have created the ticket here . Thanks and Regards, *Aditya Sharma* | Enterprise Software Engineer HotWax Systems

Re: [PROPOSAL] Replace Inline Javascript with External Javascript

2017-07-08 Thread Michael Brohl
Hi developers, good to see so much action today, thanks all! Best regards, Michael Brohl ecomify GmbH www.ecomify.de Am 08.07.17 um 12:27 schrieb Deepak Dixit: +1 nice initiative Aditya. Could you please open a ticket for this improvement? Thanks & Regards -- Deepak Dixit

Re: [PROPOSAL] Replace Inline Javascript with External Javascript

2017-07-08 Thread Deepak Dixit
+1 nice initiative Aditya. Could you please open a ticket for this improvement? Thanks & Regards -- Deepak Dixit www.hotwaxsystems.com www.hotwax.co On Sat, Jul 8, 2017 at 3:16 PM, Taher Alkhateeb wrote: > Big +1, thank you for the initiative. > > I wish everyone

Re: [PROPOSAL] Replace Inline Javascript with External Javascript

2017-07-08 Thread Taher Alkhateeb
Big +1, thank you for the initiative. I wish everyone reading this to take an active role too, there is so much refactoring needed in the project and we need your help. It's not hard to find an area you're comfortable with and start cleaning it up a bit. On Sat, Jul 8, 2017 at 12:16 PM, Michael

Re: [PROPOSAL] Replace Inline Javascript with External Javascript

2017-07-08 Thread Michael Brohl
+1, great idea, Aditya! This seems to correspond partly with https://issues.apache.org/jira/browse/OFBIZ-8300 Best regards, Michael Brohl ecomify GmbH www.ecomify.de Am 08.07.17 um 11:00 schrieb Aditya Sharma: Hello all, We are currently using inline javascript for various macros like

Re: [PROPOSAL] Replace Inline Javascript with External Javascript

2017-07-08 Thread Jacques Le Roux
Hi Aditya, Good idea, I think we should also look at require.js as I suggested some time ago: https://s.apache.org/y8P1 Jacques Le 08/07/2017 à 11:00, Aditya Sharma a écrit : Hello all, We are currently using inline javascript for various macros like renderLookupField,

[PROPOSAL] Replace Inline Javascript with External Javascript

2017-07-08 Thread Aditya Sharma
Hello all, We are currently using inline javascript for various macros like renderLookupField, makeHyperlinkString,shortDateInput etc in HtmlFormMacroLibrary.ftl which can be replaced with a generic code written as external javascript. We can add generic javascript code in OfbizUtil.js and add