[jira] [Commented] (OFBIZ-6576) Pricing error in Variant Products when setup with VAT-Tax and price set on Virtual Product
[ https://issues.apache.org/jira/browse/OFBIZ-6576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15361674#comment-15361674 ] Divesh Dutta commented on OFBIZ-6576: - Thanks [~ankush.upadhyay] for your patch and thanks [~paul_foxworthy] for reporting this issue . Its committed in revision number 1751362 in trunk. release 14.12 - 1751363 release 15.12 - 1751364 > Pricing error in Variant Products when setup with VAT-Tax and price set on > Virtual Product > -- > > Key: OFBIZ-6576 > URL: https://issues.apache.org/jira/browse/OFBIZ-6576 > Project: OFBiz > Issue Type: Bug > Components: product >Affects Versions: Release Branch 13.07, Release Branch 14.12, Trunk, > Release Branch 15.12 >Reporter: Peter Arnold >Assignee: Divesh Dutta > Labels: VAT > Fix For: 14.12.01, 15.12.01 > > Attachments: OFBIZ-6576.patch > > > In a VAT-Tax setup (i.e. sales-tax does not apply) and when using virtual- > variant- products and the price is defined only on the virtual product and > with "Tax in Price" set to "Y", its variants should inherit the set price > without adding any further taxes. > This is currently not the case when in the e-commerce shop a variant product > is added to the shopping cart. Currently sales-tax is added to the product > price. > Here is a detailed procedure to reproduce the error: > In Party Manager: > # Create new Party Group with Name "SII_CHL" > (Leave all settings for group creation as per standard) > # Assign Role "Tax Authority" to party "SII_CHL" > In Accounting Module / Tax Autorities: > # Create New Tax Authority with following settings: > Geo:CHL > Party: SII_CHL > Include Tax in Price: Y > Leave other setting as is > # Under "Product Rates" create new tax with following settings: > Type: Value Added Tax > Tax Percentage: 19 > From Date: Now > Leave other settings as is > # Expire the Sales Tax created under tax authority _NA_ by setting its > corresponding thru date to NOW. > # Under Catalog Manager / Stores: > Modify following Settings for OFBiz Ecommerce Store (ID:9000) > Tax settings: > Show Prices with VAT tax included: Y > VAT Tax Auth Geo Id: CHL > VAT Tax Auth Party Id: 1 (Or the Party ID corresponding to the > created Tax Authority SII_CHL) > # Expire all Promotions for OFBIZ E-Commerce Store [ID:9000] by setting all > thru-dates to NOW > # Under Catalog Manager / Products: Create New Product with following > settings: > Internal Name: T-Shirt > Is Virtual Product: Y > # Under Catalog Manager / Products / Categories > Assign the virtual product "T-Shirt" to the products category ID 200 > (Widgets) > Product Category ID: 200 > From Date: Now > Add > # Under Catalog Manager / Products / Content > In override Simple Fields > Set Product Name to: "T-Shirt Virtual" > Update > # Under Catalog Manager / Features: > Create New Feature Category. > Description: "T-Shirt Colors" > Submit > # Create new Feature within feature Category "T-Shirt Colors": > Create New Feature > Feature Type: Color > Description: Red > Update > Create New Feature > Feature Type: Color > Description: Blue > Update > # Create 2 variant products under the virtual product "T-Shirt" > Under Catalog Manager / Products > Find T-Shirt Product > Once T-Shirt Product is selected: > Press Features Tab > Under Add product features from Category or Group > Choose T-Shirt Colors Category > Feature Application Type: Selectable > Add > Screen with Blue and Red T-Shirt Colors appears. > Set for both colors From Date: Now > Sequence:1 for blue > Sequence:2 for red > Set a tick on each feature in order to select the feature for adding it. > Apply > # Under Catalog Manager / Products with "T-Shirt" virtual product selected > press the Variants > tab > The Quick add Variants screen appears. > Define Product IDs for Blue and Red features. > Blue: T-Shirt Blue > Red: T-Shirt Red > Set tick on both features in order to select for variant product creation. > Create > # Under Catalog Manager / Products / Prices set 2 new product prices for the > created virtual > product "T-Shirt": > Default Price > From Date: Now > Price: 11.9 > Tax Percentage: 19 > Tax in price: Y > Create > List Price > From Date: Now > Price: 11.9 > Tax Percentage: 19 > Tax in price: Y > Create > Now the products should be visible in the E-Shop. > The Virtual Products Price appears at USD 14.16 If I Select the blue or the > red T-Shirt Price is 11.9USD > Now I
[jira] [Commented] (OFBIZ-6576) Pricing error in Variant Products when setup with VAT-Tax and price set on Virtual Product
[ https://issues.apache.org/jira/browse/OFBIZ-6576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15348054#comment-15348054 ] Divesh Dutta commented on OFBIZ-6576: - [~Peter Arnold] we can create a separate ticket for this problem . > Pricing error in Variant Products when setup with VAT-Tax and price set on > Virtual Product > -- > > Key: OFBIZ-6576 > URL: https://issues.apache.org/jira/browse/OFBIZ-6576 > Project: OFBiz > Issue Type: Bug > Components: product >Affects Versions: Release Branch 13.07, Release Branch 14.12, Trunk >Reporter: Peter Arnold >Assignee: Divesh Dutta > Labels: VAT > Fix For: 14.12.01, Upcoming Branch > > Attachments: OFBIZ-6576.patch > > > In a VAT-Tax setup (i.e. sales-tax does not apply) and when using virtual- > variant- products and the price is defined only on the virtual product and > with "Tax in Price" set to "Y", its variants should inherit the set price > without adding any further taxes. > This is currently not the case when in the e-commerce shop a variant product > is added to the shopping cart. Currently sales-tax is added to the product > price. > Here is a detailed procedure to reproduce the error: > In Party Manager: > # Create new Party Group with Name "SII_CHL" > (Leave all settings for group creation as per standard) > # Assign Role "Tax Authority" to party "SII_CHL" > In Accounting Module / Tax Autorities: > # Create New Tax Authority with following settings: > Geo:CHL > Party: SII_CHL > Include Tax in Price: Y > Leave other setting as is > # Under "Product Rates" create new tax with following settings: > Type: Value Added Tax > Tax Percentage: 19 > From Date: Now > Leave other settings as is > # Expire the Sales Tax created under tax authority _NA_ by setting its > corresponding thru date to NOW. > # Under Catalog Manager / Stores: > Modify following Settings for OFBiz Ecommerce Store (ID:9000) > Tax settings: > Show Prices with VAT tax included: Y > VAT Tax Auth Geo Id: CHL > VAT Tax Auth Party Id: 1 (Or the Party ID corresponding to the > created Tax Authority SII_CHL) > # Expire all Promotions for OFBIZ E-Commerce Store [ID:9000] by setting all > thru-dates to NOW > # Under Catalog Manager / Products: Create New Product with following > settings: > Internal Name: T-Shirt > Is Virtual Product: Y > # Under Catalog Manager / Products / Categories > Assign the virtual product "T-Shirt" to the products category ID 200 > (Widgets) > Product Category ID: 200 > From Date: Now > Add > # Under Catalog Manager / Products / Content > In override Simple Fields > Set Product Name to: "T-Shirt Virtual" > Update > # Under Catalog Manager / Features: > Create New Feature Category. > Description: "T-Shirt Colors" > Submit > # Create new Feature within feature Category "T-Shirt Colors": > Create New Feature > Feature Type: Color > Description: Red > Update > Create New Feature > Feature Type: Color > Description: Blue > Update > # Create 2 variant products under the virtual product "T-Shirt" > Under Catalog Manager / Products > Find T-Shirt Product > Once T-Shirt Product is selected: > Press Features Tab > Under Add product features from Category or Group > Choose T-Shirt Colors Category > Feature Application Type: Selectable > Add > Screen with Blue and Red T-Shirt Colors appears. > Set for both colors From Date: Now > Sequence:1 for blue > Sequence:2 for red > Set a tick on each feature in order to select the feature for adding it. > Apply > # Under Catalog Manager / Products with "T-Shirt" virtual product selected > press the Variants > tab > The Quick add Variants screen appears. > Define Product IDs for Blue and Red features. > Blue: T-Shirt Blue > Red: T-Shirt Red > Set tick on both features in order to select for variant product creation. > Create > # Under Catalog Manager / Products / Prices set 2 new product prices for the > created virtual > product "T-Shirt": > Default Price > From Date: Now > Price: 11.9 > Tax Percentage: 19 > Tax in price: Y > Create > List Price > From Date: Now > Price: 11.9 > Tax Percentage: 19 > Tax in price: Y > Create > Now the products should be visible in the E-Shop. > The Virtual Products Price appears at USD 14.16 If I Select the blue or the > red T-Shirt Price is 11.9USD > Now I modify the Product Pricing on the Virtual Product. > On Default- and List- Prices add: > - Tax Percentage:19 > - Tax Authority Party
[jira] [Commented] (OFBIZ-6576) Pricing error in Variant Products when setup with VAT-Tax and price set on Virtual Product
[ https://issues.apache.org/jira/browse/OFBIZ-6576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15348052#comment-15348052 ] Divesh Dutta commented on OFBIZ-6576: - Dear [~Peter Arnold] , You are right in terms of business definitions of VAT_TAX and SALES_TAX. My comment was may be confusing, sorry for that. When I say that they are different I say in terms of how system will handle them in terms of Sales. In terms of sales, revenue is generated on product sales and sales tax is recorded as liability that needs to be remitted off. Same is the case with Vat tax. It should be recorded as liability. So I mean for system, both are liability and should be posted on general ledger accounts of liability nature. Currently VAT_TAX amounts are not recorded as liability when invoices are generated in OFBIZ. Here is the JIRA ticket for it: https://issues.apache.org/jira/browse/OFBIZ-7012 In OFBiz, there is only one place where if else is written for SALES_TAX and VAT_TAX and that ie for recording order adjustment and deciding type of orderAdjustment when sales order is recorded. So if Product's price have vat tax included in it, adjustment is recorded with type VAT_TAX else its recorded as SALES_TAX. That is it. So when invoice is generated for sales order, you want to record tax as liability in general ledgers. So it does not matter for system if its VAT_TAX or SALES_TAX . System should simply post tax as liability in case of sales. That is why I was saying that we can remove the if and else statements because its only at one place. However after thinking more, I agree that may be we should not remove the if and else because some countries collect both taxes, and for reporting point of view it will be helpful to track them separately. In case of PO, sales tax is currently not calculated in OFBiz . User can manually add sales tax as order adjustment if user want to match total of PO near the invoice which supplier will send. When VAT is added in product' price and you place PO for those products, order total already have VAT included in it. And the total amount is just accounts payable for user. They don't want to separate out VAT amount here. So as [~paul_foxworthy] was saying that difference is only in case of purchases because VAT applies to purchases as well, and your tax liability is reduced by the tax you have paid on purchases. So here I was saying that in case of PO, you can also add Sales tax manually in PO. And in that case, both the taxes are reducing the liability. So this is not the actual difference between them IMO. And you have already explained their actual difference in terms of business in very descriptive way . I hope my points are making sense. Issue in this ticket is already resolved. We were just discussing this additional thing for knowledge purpose :) . > Pricing error in Variant Products when setup with VAT-Tax and price set on > Virtual Product > -- > > Key: OFBIZ-6576 > URL: https://issues.apache.org/jira/browse/OFBIZ-6576 > Project: OFBiz > Issue Type: Bug > Components: product >Affects Versions: Release Branch 13.07, Release Branch 14.12, Trunk >Reporter: Peter Arnold >Assignee: Divesh Dutta > Labels: VAT > Fix For: 14.12.01, Upcoming Branch > > Attachments: OFBIZ-6576.patch > > > In a VAT-Tax setup (i.e. sales-tax does not apply) and when using virtual- > variant- products and the price is defined only on the virtual product and > with "Tax in Price" set to "Y", its variants should inherit the set price > without adding any further taxes. > This is currently not the case when in the e-commerce shop a variant product > is added to the shopping cart. Currently sales-tax is added to the product > price. > Here is a detailed procedure to reproduce the error: > In Party Manager: > # Create new Party Group with Name "SII_CHL" > (Leave all settings for group creation as per standard) > # Assign Role "Tax Authority" to party "SII_CHL" > In Accounting Module / Tax Autorities: > # Create New Tax Authority with following settings: > Geo:CHL > Party: SII_CHL > Include Tax in Price: Y > Leave other setting as is > # Under "Product Rates" create new tax with following settings: > Type: Value Added Tax > Tax Percentage: 19 > From Date: Now > Leave other settings as is > # Expire the Sales Tax created under tax authority _NA_ by setting its > corresponding thru date to NOW. > # Under Catalog Manager / Stores: > Modify following Settings for OFBiz Ecommerce Store (ID:9000) > Tax settings: > Show Prices with VAT tax included: Y > VAT Tax Auth Geo Id: CHL > VAT Tax Auth Party Id: 1 (Or the
[jira] [Commented] (OFBIZ-6576) Pricing error in Variant Products when setup with VAT-Tax and price set on Virtual Product
[ https://issues.apache.org/jira/browse/OFBIZ-6576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15348053#comment-15348053 ] Divesh Dutta commented on OFBIZ-6576: - Dear [~Peter Arnold] , You are right in terms of business definitions of VAT_TAX and SALES_TAX. My comment was may be confusing, sorry for that. When I say that they are different I say in terms of how system will handle them in terms of Sales. In terms of sales, revenue is generated on product sales and sales tax is recorded as liability that needs to be remitted off. Same is the case with Vat tax. It should be recorded as liability. So I mean for system, both are liability and should be posted on general ledger accounts of liability nature. Currently VAT_TAX amounts are not recorded as liability when invoices are generated in OFBIZ. Here is the JIRA ticket for it: https://issues.apache.org/jira/browse/OFBIZ-7012 In OFBiz, there is only one place where if else is written for SALES_TAX and VAT_TAX and that ie for recording order adjustment and deciding type of orderAdjustment when sales order is recorded. So if Product's price have vat tax included in it, adjustment is recorded with type VAT_TAX else its recorded as SALES_TAX. That is it. So when invoice is generated for sales order, you want to record tax as liability in general ledgers. So it does not matter for system if its VAT_TAX or SALES_TAX . System should simply post tax as liability in case of sales. That is why I was saying that we can remove the if and else statements because its only at one place. However after thinking more, I agree that may be we should not remove the if and else because some countries collect both taxes, and for reporting point of view it will be helpful to track them separately. In case of PO, sales tax is currently not calculated in OFBiz . User can manually add sales tax as order adjustment if user want to match total of PO near the invoice which supplier will send. When VAT is added in product' price and you place PO for those products, order total already have VAT included in it. And the total amount is just accounts payable for user. They don't want to separate out VAT amount here. So as [~paul_foxworthy] was saying that difference is only in case of purchases because VAT applies to purchases as well, and your tax liability is reduced by the tax you have paid on purchases. So here I was saying that in case of PO, you can also add Sales tax manually in PO. And in that case, both the taxes are reducing the liability. So this is not the actual difference between them IMO. And you have already explained their actual difference in terms of business in very descriptive way . I hope my points are making sense. Issue in this ticket is already resolved. We were just discussing this additional thing for knowledge purpose :) . > Pricing error in Variant Products when setup with VAT-Tax and price set on > Virtual Product > -- > > Key: OFBIZ-6576 > URL: https://issues.apache.org/jira/browse/OFBIZ-6576 > Project: OFBiz > Issue Type: Bug > Components: product >Affects Versions: Release Branch 13.07, Release Branch 14.12, Trunk >Reporter: Peter Arnold >Assignee: Divesh Dutta > Labels: VAT > Fix For: 14.12.01, Upcoming Branch > > Attachments: OFBIZ-6576.patch > > > In a VAT-Tax setup (i.e. sales-tax does not apply) and when using virtual- > variant- products and the price is defined only on the virtual product and > with "Tax in Price" set to "Y", its variants should inherit the set price > without adding any further taxes. > This is currently not the case when in the e-commerce shop a variant product > is added to the shopping cart. Currently sales-tax is added to the product > price. > Here is a detailed procedure to reproduce the error: > In Party Manager: > # Create new Party Group with Name "SII_CHL" > (Leave all settings for group creation as per standard) > # Assign Role "Tax Authority" to party "SII_CHL" > In Accounting Module / Tax Autorities: > # Create New Tax Authority with following settings: > Geo:CHL > Party: SII_CHL > Include Tax in Price: Y > Leave other setting as is > # Under "Product Rates" create new tax with following settings: > Type: Value Added Tax > Tax Percentage: 19 > From Date: Now > Leave other settings as is > # Expire the Sales Tax created under tax authority _NA_ by setting its > corresponding thru date to NOW. > # Under Catalog Manager / Stores: > Modify following Settings for OFBiz Ecommerce Store (ID:9000) > Tax settings: > Show Prices with VAT tax included: Y > VAT Tax Auth Geo Id: CHL > VAT Tax Auth Party Id: 1 (Or the
[jira] [Commented] (OFBIZ-6576) Pricing error in Variant Products when setup with VAT-Tax and price set on Virtual Product
[ https://issues.apache.org/jira/browse/OFBIZ-6576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15347151#comment-15347151 ] Peter Arnold commented on OFBIZ-6576: - Dear Paul and Divesh, I agree with Pauls explanation of the difference between Sales Tax and VAT TAX. Sales tax is applied as a percentage of the sales amount. VAT is as the name says (Value Added Tax) only applied as a percentage on the added value. For example: You buy something for 1USD and sell it for 2USD. The added value is calculated as Sales Price minus Cost, i.e. 2USD-1USD= 1USD. Finally the VAT is paid only on the added value even though you declare tax for the sales amount and for your cost separately. Divesh, When you say that both, Sales Tax and VAT are the same you are commiting a big error from an accounting point of view since you are not considering that for VAT declaration you also declare the VAT for your cost, not just for your sales. So in my opinion VAT and Sales tax certainly need to be treated in a different way. Therefore the if and else statements should not be removed. If Sales-Tax treatment works correctly through all OFBiz modules, (Accounting included) then we simply should try to get to the same level with VAT-Tax Treatment. Accounting wise the treatment should be different since for Vat-taxed sales you also have vat-credits which are originated by taxes paid on your purchases. Maybe an option would be to configure the system via a flag which is set in tax setup, that defines which one is to be used, either VAT-Tax or Sales-Tax as probably in no country both tax systems exist in parallel. However I don't know what such a change would mean in terms of coding. > Pricing error in Variant Products when setup with VAT-Tax and price set on > Virtual Product > -- > > Key: OFBIZ-6576 > URL: https://issues.apache.org/jira/browse/OFBIZ-6576 > Project: OFBiz > Issue Type: Bug > Components: product >Affects Versions: Release Branch 13.07, Release Branch 14.12, Trunk >Reporter: Peter Arnold >Assignee: Divesh Dutta > Labels: VAT > Fix For: 14.12.01, Upcoming Branch > > Attachments: OFBIZ-6576.patch > > > In a VAT-Tax setup (i.e. sales-tax does not apply) and when using virtual- > variant- products and the price is defined only on the virtual product and > with "Tax in Price" set to "Y", its variants should inherit the set price > without adding any further taxes. > This is currently not the case when in the e-commerce shop a variant product > is added to the shopping cart. Currently sales-tax is added to the product > price. > Here is a detailed procedure to reproduce the error: > In Party Manager: > # Create new Party Group with Name "SII_CHL" > (Leave all settings for group creation as per standard) > # Assign Role "Tax Authority" to party "SII_CHL" > In Accounting Module / Tax Autorities: > # Create New Tax Authority with following settings: > Geo:CHL > Party: SII_CHL > Include Tax in Price: Y > Leave other setting as is > # Under "Product Rates" create new tax with following settings: > Type: Value Added Tax > Tax Percentage: 19 > From Date: Now > Leave other settings as is > # Expire the Sales Tax created under tax authority _NA_ by setting its > corresponding thru date to NOW. > # Under Catalog Manager / Stores: > Modify following Settings for OFBiz Ecommerce Store (ID:9000) > Tax settings: > Show Prices with VAT tax included: Y > VAT Tax Auth Geo Id: CHL > VAT Tax Auth Party Id: 1 (Or the Party ID corresponding to the > created Tax Authority SII_CHL) > # Expire all Promotions for OFBIZ E-Commerce Store [ID:9000] by setting all > thru-dates to NOW > # Under Catalog Manager / Products: Create New Product with following > settings: > Internal Name: T-Shirt > Is Virtual Product: Y > # Under Catalog Manager / Products / Categories > Assign the virtual product "T-Shirt" to the products category ID 200 > (Widgets) > Product Category ID: 200 > From Date: Now > Add > # Under Catalog Manager / Products / Content > In override Simple Fields > Set Product Name to: "T-Shirt Virtual" > Update > # Under Catalog Manager / Features: > Create New Feature Category. > Description: "T-Shirt Colors" > Submit > # Create new Feature within feature Category "T-Shirt Colors": > Create New Feature > Feature Type: Color > Description: Red > Update > Create New Feature > Feature Type: Color > Description: Blue > Update > # Create 2 variant products under the virtual product "T-Shirt" > Under Catalog Manager / Products > Find T-Shirt Product > Once
[jira] [Commented] (OFBIZ-6576) Pricing error in Variant Products when setup with VAT-Tax and price set on Virtual Product
[ https://issues.apache.org/jira/browse/OFBIZ-6576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15347109#comment-15347109 ] Peter Arnold commented on OFBIZ-6576: - Dear Ankush and Divesh; thank you for the suggestions and the patch. I think your solution is correct since the variant should inherit information from its corresponding virtual product, if not specified directly on the variant. I have tested the patch and it works fine up to the "Final Check-Out Review" where still some strange values are indicateed: Decrease zoom in order to see proper format. Order Items Product Qty Ordered Unit Price Adjustments Subtotal DA-DA163 - DecoArt Americana Honey Brown 2Oz 1CLP1,690 CLP0 CLP2,011.1 Adjustment: VAT Tax (not added to totals) CLP321.1 DA-DA01 - DecoArt Americana Snow White Titanium 2Oz 1CLP1,690 CLP0 CLP1,690 Adjustment: VAT Tax (not added to totals) CLP0 Subtotal CLP3,380 Shipping and Handling CLP0 Sales Tax CLP0 Grand Total CLP3,380 The first Product has the price inherited from its corresponding Virtual product. The second product has the price defined directly in the variant. Difference is that for the product which inherits price information from its virtual product still a Sales Tax is calculated which is rather confusing, even though it is not added to the Grand Total amount which is fine. This screen still needs further improvement. I will investigate this problem but it will take me some time. > Pricing error in Variant Products when setup with VAT-Tax and price set on > Virtual Product > -- > > Key: OFBIZ-6576 > URL: https://issues.apache.org/jira/browse/OFBIZ-6576 > Project: OFBiz > Issue Type: Bug > Components: product >Affects Versions: Release Branch 13.07, Release Branch 14.12, Trunk >Reporter: Peter Arnold >Assignee: Divesh Dutta > Labels: VAT > Fix For: 14.12.01, Upcoming Branch > > Attachments: OFBIZ-6576.patch > > > In a VAT-Tax setup (i.e. sales-tax does not apply) and when using virtual- > variant- products and the price is defined only on the virtual product and > with "Tax in Price" set to "Y", its variants should inherit the set price > without adding any further taxes. > This is currently not the case when in the e-commerce shop a variant product > is added to the shopping cart. Currently sales-tax is added to the product > price. > Here is a detailed procedure to reproduce the error: > In Party Manager: > # Create new Party Group with Name "SII_CHL" > (Leave all settings for group creation as per standard) > # Assign Role "Tax Authority" to party "SII_CHL" > In Accounting Module / Tax Autorities: > # Create New Tax Authority with following settings: > Geo:CHL > Party: SII_CHL > Include Tax in Price: Y > Leave other setting as is > # Under "Product Rates" create new tax with following settings: > Type: Value Added Tax > Tax Percentage: 19 > From Date: Now > Leave other settings as is > # Expire the Sales Tax created under tax authority _NA_ by setting its > corresponding thru date to NOW. > # Under Catalog Manager / Stores: > Modify following Settings for OFBiz Ecommerce Store (ID:9000) > Tax settings: > Show Prices with VAT tax included: Y > VAT Tax Auth Geo Id: CHL > VAT Tax Auth Party Id: 1 (Or the Party ID corresponding to the > created Tax Authority SII_CHL) > # Expire all Promotions for OFBIZ E-Commerce Store [ID:9000] by setting all > thru-dates to NOW > # Under Catalog Manager / Products: Create New Product with following > settings: > Internal Name: T-Shirt > Is Virtual Product: Y > # Under Catalog Manager / Products / Categories > Assign the virtual product "T-Shirt" to the products category ID 200 > (Widgets) > Product Category ID: 200 > From Date: Now > Add > # Under Catalog Manager / Products / Content > In override Simple Fields > Set Product Name to: "T-Shirt Virtual" > Update > # Under Catalog Manager / Features: > Create New Feature Category. > Description: "T-Shirt Colors" > Submit > # Create new Feature within feature Category "T-Shirt Colors": > Create
[jira] [Commented] (OFBIZ-6576) Pricing error in Variant Products when setup with VAT-Tax and price set on Virtual Product
[ https://issues.apache.org/jira/browse/OFBIZ-6576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15343967#comment-15343967 ] Jacques Le Roux commented on OFBIZ-6576: Ah yes good point, too used to it :D > Pricing error in Variant Products when setup with VAT-Tax and price set on > Virtual Product > -- > > Key: OFBIZ-6576 > URL: https://issues.apache.org/jira/browse/OFBIZ-6576 > Project: OFBiz > Issue Type: Bug > Components: product >Affects Versions: Release Branch 13.07, Release Branch 14.12, Trunk >Reporter: Peter Arnold >Assignee: Divesh Dutta > Labels: VAT > Fix For: 14.12.01, Upcoming Branch > > Attachments: OFBIZ-6576.patch > > > In a VAT-Tax setup (i.e. sales-tax does not apply) and when using virtual- > variant- products and the price is defined only on the virtual product and > with "Tax in Price" set to "Y", its variants should inherit the set price > without adding any further taxes. > This is currently not the case when in the e-commerce shop a variant product > is added to the shopping cart. Currently sales-tax is added to the product > price. > Here is a detailed procedure to reproduce the error: > In Party Manager: > # Create new Party Group with Name "SII_CHL" > (Leave all settings for group creation as per standard) > # Assign Role "Tax Authority" to party "SII_CHL" > In Accounting Module / Tax Autorities: > # Create New Tax Authority with following settings: > Geo:CHL > Party: SII_CHL > Include Tax in Price: Y > Leave other setting as is > # Under "Product Rates" create new tax with following settings: > Type: Value Added Tax > Tax Percentage: 19 > From Date: Now > Leave other settings as is > # Expire the Sales Tax created under tax authority _NA_ by setting its > corresponding thru date to NOW. > # Under Catalog Manager / Stores: > Modify following Settings for OFBiz Ecommerce Store (ID:9000) > Tax settings: > Show Prices with VAT tax included: Y > VAT Tax Auth Geo Id: CHL > VAT Tax Auth Party Id: 1 (Or the Party ID corresponding to the > created Tax Authority SII_CHL) > # Expire all Promotions for OFBIZ E-Commerce Store [ID:9000] by setting all > thru-dates to NOW > # Under Catalog Manager / Products: Create New Product with following > settings: > Internal Name: T-Shirt > Is Virtual Product: Y > # Under Catalog Manager / Products / Categories > Assign the virtual product "T-Shirt" to the products category ID 200 > (Widgets) > Product Category ID: 200 > From Date: Now > Add > # Under Catalog Manager / Products / Content > In override Simple Fields > Set Product Name to: "T-Shirt Virtual" > Update > # Under Catalog Manager / Features: > Create New Feature Category. > Description: "T-Shirt Colors" > Submit > # Create new Feature within feature Category "T-Shirt Colors": > Create New Feature > Feature Type: Color > Description: Red > Update > Create New Feature > Feature Type: Color > Description: Blue > Update > # Create 2 variant products under the virtual product "T-Shirt" > Under Catalog Manager / Products > Find T-Shirt Product > Once T-Shirt Product is selected: > Press Features Tab > Under Add product features from Category or Group > Choose T-Shirt Colors Category > Feature Application Type: Selectable > Add > Screen with Blue and Red T-Shirt Colors appears. > Set for both colors From Date: Now > Sequence:1 for blue > Sequence:2 for red > Set a tick on each feature in order to select the feature for adding it. > Apply > # Under Catalog Manager / Products with "T-Shirt" virtual product selected > press the Variants > tab > The Quick add Variants screen appears. > Define Product IDs for Blue and Red features. > Blue: T-Shirt Blue > Red: T-Shirt Red > Set tick on both features in order to select for variant product creation. > Create > # Under Catalog Manager / Products / Prices set 2 new product prices for the > created virtual > product "T-Shirt": > Default Price > From Date: Now > Price: 11.9 > Tax Percentage: 19 > Tax in price: Y > Create > List Price > From Date: Now > Price: 11.9 > Tax Percentage: 19 > Tax in price: Y > Create > Now the products should be visible in the E-Shop. > The Virtual Products Price appears at USD 14.16 If I Select the blue or the > red T-Shirt Price is 11.9USD > Now I modify the Product Pricing on the Virtual Product. > On Default- and List- Prices add: > - Tax Percentage:19 > - Tax Authority Party (ID):1 (Or whatever
[jira] [Commented] (OFBIZ-6576) Pricing error in Variant Products when setup with VAT-Tax and price set on Virtual Product
[ https://issues.apache.org/jira/browse/OFBIZ-6576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15343962#comment-15343962 ] Ankush Upadhyay commented on OFBIZ-6576: I have updated patch with null check improvements. > Pricing error in Variant Products when setup with VAT-Tax and price set on > Virtual Product > -- > > Key: OFBIZ-6576 > URL: https://issues.apache.org/jira/browse/OFBIZ-6576 > Project: OFBiz > Issue Type: Bug > Components: product >Affects Versions: Release Branch 13.07, Release Branch 14.12, Trunk >Reporter: Peter Arnold >Assignee: Divesh Dutta > Labels: VAT > Fix For: 14.12.01, Upcoming Branch > > Attachments: OFBIZ-6576.patch > > > In a VAT-Tax setup (i.e. sales-tax does not apply) and when using virtual- > variant- products and the price is defined only on the virtual product and > with "Tax in Price" set to "Y", its variants should inherit the set price > without adding any further taxes. > This is currently not the case when in the e-commerce shop a variant product > is added to the shopping cart. Currently sales-tax is added to the product > price. > Here is a detailed procedure to reproduce the error: > In Party Manager: > # Create new Party Group with Name "SII_CHL" > (Leave all settings for group creation as per standard) > # Assign Role "Tax Authority" to party "SII_CHL" > In Accounting Module / Tax Autorities: > # Create New Tax Authority with following settings: > Geo:CHL > Party: SII_CHL > Include Tax in Price: Y > Leave other setting as is > # Under "Product Rates" create new tax with following settings: > Type: Value Added Tax > Tax Percentage: 19 > From Date: Now > Leave other settings as is > # Expire the Sales Tax created under tax authority _NA_ by setting its > corresponding thru date to NOW. > # Under Catalog Manager / Stores: > Modify following Settings for OFBiz Ecommerce Store (ID:9000) > Tax settings: > Show Prices with VAT tax included: Y > VAT Tax Auth Geo Id: CHL > VAT Tax Auth Party Id: 1 (Or the Party ID corresponding to the > created Tax Authority SII_CHL) > # Expire all Promotions for OFBIZ E-Commerce Store [ID:9000] by setting all > thru-dates to NOW > # Under Catalog Manager / Products: Create New Product with following > settings: > Internal Name: T-Shirt > Is Virtual Product: Y > # Under Catalog Manager / Products / Categories > Assign the virtual product "T-Shirt" to the products category ID 200 > (Widgets) > Product Category ID: 200 > From Date: Now > Add > # Under Catalog Manager / Products / Content > In override Simple Fields > Set Product Name to: "T-Shirt Virtual" > Update > # Under Catalog Manager / Features: > Create New Feature Category. > Description: "T-Shirt Colors" > Submit > # Create new Feature within feature Category "T-Shirt Colors": > Create New Feature > Feature Type: Color > Description: Red > Update > Create New Feature > Feature Type: Color > Description: Blue > Update > # Create 2 variant products under the virtual product "T-Shirt" > Under Catalog Manager / Products > Find T-Shirt Product > Once T-Shirt Product is selected: > Press Features Tab > Under Add product features from Category or Group > Choose T-Shirt Colors Category > Feature Application Type: Selectable > Add > Screen with Blue and Red T-Shirt Colors appears. > Set for both colors From Date: Now > Sequence:1 for blue > Sequence:2 for red > Set a tick on each feature in order to select the feature for adding it. > Apply > # Under Catalog Manager / Products with "T-Shirt" virtual product selected > press the Variants > tab > The Quick add Variants screen appears. > Define Product IDs for Blue and Red features. > Blue: T-Shirt Blue > Red: T-Shirt Red > Set tick on both features in order to select for variant product creation. > Create > # Under Catalog Manager / Products / Prices set 2 new product prices for the > created virtual > product "T-Shirt": > Default Price > From Date: Now > Price: 11.9 > Tax Percentage: 19 > Tax in price: Y > Create > List Price > From Date: Now > Price: 11.9 > Tax Percentage: 19 > Tax in price: Y > Create > Now the products should be visible in the E-Shop. > The Virtual Products Price appears at USD 14.16 If I Select the blue or the > red T-Shirt Price is 11.9USD > Now I modify the Product Pricing on the Virtual Product. > On Default- and List- Prices add: > - Tax Percentage:19 > - Tax Authority Party (ID):
[jira] [Commented] (OFBIZ-6576) Pricing error in Variant Products when setup with VAT-Tax and price set on Virtual Product
[ https://issues.apache.org/jira/browse/OFBIZ-6576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15343939#comment-15343939 ] Divesh Dutta commented on OFBIZ-6576: - Thanks Ankush for the improvement. One more minor thing, we are already discussing in community about directly checking null or not null for GenericValue instead of using isNotEmpty method of GenericValue . So in this patch, please change it accordingly and then we should be good, > Pricing error in Variant Products when setup with VAT-Tax and price set on > Virtual Product > -- > > Key: OFBIZ-6576 > URL: https://issues.apache.org/jira/browse/OFBIZ-6576 > Project: OFBiz > Issue Type: Bug > Components: product >Affects Versions: Release Branch 13.07, Release Branch 14.12, Trunk >Reporter: Peter Arnold >Assignee: Divesh Dutta >Priority: Minor > Labels: VAT > Fix For: 14.12.01, Upcoming Branch > > Attachments: OFBIZ-6576.patch > > > In a VAT-Tax setup (i.e. sales-tax does not apply) and when using virtual- > variant- products and the price is defined only on the virtual product and > with "Tax in Price" set to "Y", its variants should inherit the set price > without adding any further taxes. > This is currently not the case when in the e-commerce shop a variant product > is added to the shopping cart. Currently sales-tax is added to the product > price. > Here is a detailed procedure to reproduce the error: > In Party Manager: > # Create new Party Group with Name "SII_CHL" > (Leave all settings for group creation as per standard) > # Assign Role "Tax Authority" to party "SII_CHL" > In Accounting Module / Tax Autorities: > # Create New Tax Authority with following settings: > Geo:CHL > Party: SII_CHL > Include Tax in Price: Y > Leave other setting as is > # Under "Product Rates" create new tax with following settings: > Type: Value Added Tax > Tax Percentage: 19 > From Date: Now > Leave other settings as is > # Expire the Sales Tax created under tax authority _NA_ by setting its > corresponding thru date to NOW. > # Under Catalog Manager / Stores: > Modify following Settings for OFBiz Ecommerce Store (ID:9000) > Tax settings: > Show Prices with VAT tax included: Y > VAT Tax Auth Geo Id: CHL > VAT Tax Auth Party Id: 1 (Or the Party ID corresponding to the > created Tax Authority SII_CHL) > # Expire all Promotions for OFBIZ E-Commerce Store [ID:9000] by setting all > thru-dates to NOW > # Under Catalog Manager / Products: Create New Product with following > settings: > Internal Name: T-Shirt > Is Virtual Product: Y > # Under Catalog Manager / Products / Categories > Assign the virtual product "T-Shirt" to the products category ID 200 > (Widgets) > Product Category ID: 200 > From Date: Now > Add > # Under Catalog Manager / Products / Content > In override Simple Fields > Set Product Name to: "T-Shirt Virtual" > Update > # Under Catalog Manager / Features: > Create New Feature Category. > Description: "T-Shirt Colors" > Submit > # Create new Feature within feature Category "T-Shirt Colors": > Create New Feature > Feature Type: Color > Description: Red > Update > Create New Feature > Feature Type: Color > Description: Blue > Update > # Create 2 variant products under the virtual product "T-Shirt" > Under Catalog Manager / Products > Find T-Shirt Product > Once T-Shirt Product is selected: > Press Features Tab > Under Add product features from Category or Group > Choose T-Shirt Colors Category > Feature Application Type: Selectable > Add > Screen with Blue and Red T-Shirt Colors appears. > Set for both colors From Date: Now > Sequence:1 for blue > Sequence:2 for red > Set a tick on each feature in order to select the feature for adding it. > Apply > # Under Catalog Manager / Products with "T-Shirt" virtual product selected > press the Variants > tab > The Quick add Variants screen appears. > Define Product IDs for Blue and Red features. > Blue: T-Shirt Blue > Red: T-Shirt Red > Set tick on both features in order to select for variant product creation. > Create > # Under Catalog Manager / Products / Prices set 2 new product prices for the > created virtual > product "T-Shirt": > Default Price > From Date: Now > Price: 11.9 > Tax Percentage: 19 > Tax in price: Y > Create > List Price > From Date: Now > Price: 11.9 > Tax Percentage: 19 > Tax in price: Y > Create > Now the products should be visible in the E-Shop. > The Virtual Products
[jira] [Commented] (OFBIZ-6576) Pricing error in Variant Products when setup with VAT-Tax and price set on Virtual Product
[ https://issues.apache.org/jira/browse/OFBIZ-6576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15343930#comment-15343930 ] Jacques Le Roux commented on OFBIZ-6576: I agree with Divesh, +1 for Ankush's patch! > Pricing error in Variant Products when setup with VAT-Tax and price set on > Virtual Product > -- > > Key: OFBIZ-6576 > URL: https://issues.apache.org/jira/browse/OFBIZ-6576 > Project: OFBiz > Issue Type: Bug > Components: product >Affects Versions: Release Branch 13.07, Release Branch 14.12, Trunk >Reporter: Peter Arnold >Assignee: Divesh Dutta >Priority: Minor > Labels: VAT > Fix For: 14.12.01, Upcoming Branch > > Attachments: OFBIZ-6576.patch > > > In a VAT-Tax setup (i.e. sales-tax does not apply) and when using virtual- > variant- products and the price is defined only on the virtual product and > with "Tax in Price" set to "Y", its variants should inherit the set price > without adding any further taxes. > This is currently not the case when in the e-commerce shop a variant product > is added to the shopping cart. Currently sales-tax is added to the product > price. > Here is a detailed procedure to reproduce the error: > In Party Manager: > # Create new Party Group with Name "SII_CHL" > (Leave all settings for group creation as per standard) > # Assign Role "Tax Authority" to party "SII_CHL" > In Accounting Module / Tax Autorities: > # Create New Tax Authority with following settings: > Geo:CHL > Party: SII_CHL > Include Tax in Price: Y > Leave other setting as is > # Under "Product Rates" create new tax with following settings: > Type: Value Added Tax > Tax Percentage: 19 > From Date: Now > Leave other settings as is > # Expire the Sales Tax created under tax authority _NA_ by setting its > corresponding thru date to NOW. > # Under Catalog Manager / Stores: > Modify following Settings for OFBiz Ecommerce Store (ID:9000) > Tax settings: > Show Prices with VAT tax included: Y > VAT Tax Auth Geo Id: CHL > VAT Tax Auth Party Id: 1 (Or the Party ID corresponding to the > created Tax Authority SII_CHL) > # Expire all Promotions for OFBIZ E-Commerce Store [ID:9000] by setting all > thru-dates to NOW > # Under Catalog Manager / Products: Create New Product with following > settings: > Internal Name: T-Shirt > Is Virtual Product: Y > # Under Catalog Manager / Products / Categories > Assign the virtual product "T-Shirt" to the products category ID 200 > (Widgets) > Product Category ID: 200 > From Date: Now > Add > # Under Catalog Manager / Products / Content > In override Simple Fields > Set Product Name to: "T-Shirt Virtual" > Update > # Under Catalog Manager / Features: > Create New Feature Category. > Description: "T-Shirt Colors" > Submit > # Create new Feature within feature Category "T-Shirt Colors": > Create New Feature > Feature Type: Color > Description: Red > Update > Create New Feature > Feature Type: Color > Description: Blue > Update > # Create 2 variant products under the virtual product "T-Shirt" > Under Catalog Manager / Products > Find T-Shirt Product > Once T-Shirt Product is selected: > Press Features Tab > Under Add product features from Category or Group > Choose T-Shirt Colors Category > Feature Application Type: Selectable > Add > Screen with Blue and Red T-Shirt Colors appears. > Set for both colors From Date: Now > Sequence:1 for blue > Sequence:2 for red > Set a tick on each feature in order to select the feature for adding it. > Apply > # Under Catalog Manager / Products with "T-Shirt" virtual product selected > press the Variants > tab > The Quick add Variants screen appears. > Define Product IDs for Blue and Red features. > Blue: T-Shirt Blue > Red: T-Shirt Red > Set tick on both features in order to select for variant product creation. > Create > # Under Catalog Manager / Products / Prices set 2 new product prices for the > created virtual > product "T-Shirt": > Default Price > From Date: Now > Price: 11.9 > Tax Percentage: 19 > Tax in price: Y > Create > List Price > From Date: Now > Price: 11.9 > Tax Percentage: 19 > Tax in price: Y > Create > Now the products should be visible in the E-Shop. > The Virtual Products Price appears at USD 14.16 If I Select the blue or the > red T-Shirt Price is 11.9USD > Now I modify the Product Pricing on the Virtual Product. > On Default- and List- Prices add: > - Tax Percentage:19 > - Tax
[jira] [Commented] (OFBIZ-6576) Pricing error in Variant Products when setup with VAT-Tax and price set on Virtual Product
[ https://issues.apache.org/jira/browse/OFBIZ-6576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15343908#comment-15343908 ] Ankush Upadhyay commented on OFBIZ-6576: Thanks for the patch review and suggestion, I have updated patch with suggested improvements. > Pricing error in Variant Products when setup with VAT-Tax and price set on > Virtual Product > -- > > Key: OFBIZ-6576 > URL: https://issues.apache.org/jira/browse/OFBIZ-6576 > Project: OFBiz > Issue Type: Bug > Components: product >Affects Versions: Release Branch 13.07, Release Branch 14.12, Trunk >Reporter: Peter Arnold >Assignee: Divesh Dutta >Priority: Minor > Labels: VAT > Fix For: 14.12.01, Upcoming Branch > > Attachments: OFBIZ-6576.patch > > > In a VAT-Tax setup (i.e. sales-tax does not apply) and when using virtual- > variant- products and the price is defined only on the virtual product and > with "Tax in Price" set to "Y", its variants should inherit the set price > without adding any further taxes. > This is currently not the case when in the e-commerce shop a variant product > is added to the shopping cart. Currently sales-tax is added to the product > price. > Here is a detailed procedure to reproduce the error: > In Party Manager: > # Create new Party Group with Name "SII_CHL" > (Leave all settings for group creation as per standard) > # Assign Role "Tax Authority" to party "SII_CHL" > In Accounting Module / Tax Autorities: > # Create New Tax Authority with following settings: > Geo:CHL > Party: SII_CHL > Include Tax in Price: Y > Leave other setting as is > # Under "Product Rates" create new tax with following settings: > Type: Value Added Tax > Tax Percentage: 19 > From Date: Now > Leave other settings as is > # Expire the Sales Tax created under tax authority _NA_ by setting its > corresponding thru date to NOW. > # Under Catalog Manager / Stores: > Modify following Settings for OFBiz Ecommerce Store (ID:9000) > Tax settings: > Show Prices with VAT tax included: Y > VAT Tax Auth Geo Id: CHL > VAT Tax Auth Party Id: 1 (Or the Party ID corresponding to the > created Tax Authority SII_CHL) > # Expire all Promotions for OFBIZ E-Commerce Store [ID:9000] by setting all > thru-dates to NOW > # Under Catalog Manager / Products: Create New Product with following > settings: > Internal Name: T-Shirt > Is Virtual Product: Y > # Under Catalog Manager / Products / Categories > Assign the virtual product "T-Shirt" to the products category ID 200 > (Widgets) > Product Category ID: 200 > From Date: Now > Add > # Under Catalog Manager / Products / Content > In override Simple Fields > Set Product Name to: "T-Shirt Virtual" > Update > # Under Catalog Manager / Features: > Create New Feature Category. > Description: "T-Shirt Colors" > Submit > # Create new Feature within feature Category "T-Shirt Colors": > Create New Feature > Feature Type: Color > Description: Red > Update > Create New Feature > Feature Type: Color > Description: Blue > Update > # Create 2 variant products under the virtual product "T-Shirt" > Under Catalog Manager / Products > Find T-Shirt Product > Once T-Shirt Product is selected: > Press Features Tab > Under Add product features from Category or Group > Choose T-Shirt Colors Category > Feature Application Type: Selectable > Add > Screen with Blue and Red T-Shirt Colors appears. > Set for both colors From Date: Now > Sequence:1 for blue > Sequence:2 for red > Set a tick on each feature in order to select the feature for adding it. > Apply > # Under Catalog Manager / Products with "T-Shirt" virtual product selected > press the Variants > tab > The Quick add Variants screen appears. > Define Product IDs for Blue and Red features. > Blue: T-Shirt Blue > Red: T-Shirt Red > Set tick on both features in order to select for variant product creation. > Create > # Under Catalog Manager / Products / Prices set 2 new product prices for the > created virtual > product "T-Shirt": > Default Price > From Date: Now > Price: 11.9 > Tax Percentage: 19 > Tax in price: Y > Create > List Price > From Date: Now > Price: 11.9 > Tax Percentage: 19 > Tax in price: Y > Create > Now the products should be visible in the E-Shop. > The Virtual Products Price appears at USD 14.16 If I Select the blue or the > red T-Shirt Price is 11.9USD > Now I modify the Product Pricing on the Virtual Product. > On Default- and List- Prices
[jira] [Commented] (OFBIZ-6576) Pricing error in Variant Products when setup with VAT-Tax and price set on Virtual Product
[ https://issues.apache.org/jira/browse/OFBIZ-6576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15343832#comment-15343832 ] Divesh Dutta commented on OFBIZ-6576: - Hi [~paul_foxworthy] , I agree that SALES_TAX and VAT_TAX are same , they are both taxes levied by tax authority on a sale. I guess we can remove the if and else statements in code for SALES_TAX or VAT_TAX. Also I think Sales tax also be put on Purchase order, when you want to put approximate tax which supplier will take from you. So I think VAT and Sales tax does not differ . > Pricing error in Variant Products when setup with VAT-Tax and price set on > Virtual Product > -- > > Key: OFBIZ-6576 > URL: https://issues.apache.org/jira/browse/OFBIZ-6576 > Project: OFBiz > Issue Type: Bug > Components: product >Affects Versions: Release Branch 13.07, Release Branch 14.12, Trunk >Reporter: Peter Arnold >Priority: Minor > Labels: VAT > Fix For: 14.12.01, Upcoming Branch > > Attachments: OFBIZ-6576.patch > > > In a VAT-Tax setup (i.e. sales-tax does not apply) and when using virtual- > variant- products and the price is defined only on the virtual product and > with "Tax in Price" set to "Y", its variants should inherit the set price > without adding any further taxes. > This is currently not the case when in the e-commerce shop a variant product > is added to the shopping cart. Currently sales-tax is added to the product > price. > Here is a detailed procedure to reproduce the error: > In Party Manager: > # Create new Party Group with Name "SII_CHL" > (Leave all settings for group creation as per standard) > # Assign Role "Tax Authority" to party "SII_CHL" > In Accounting Module / Tax Autorities: > # Create New Tax Authority with following settings: > Geo:CHL > Party: SII_CHL > Include Tax in Price: Y > Leave other setting as is > # Under "Product Rates" create new tax with following settings: > Type: Value Added Tax > Tax Percentage: 19 > From Date: Now > Leave other settings as is > # Expire the Sales Tax created under tax authority _NA_ by setting its > corresponding thru date to NOW. > # Under Catalog Manager / Stores: > Modify following Settings for OFBiz Ecommerce Store (ID:9000) > Tax settings: > Show Prices with VAT tax included: Y > VAT Tax Auth Geo Id: CHL > VAT Tax Auth Party Id: 1 (Or the Party ID corresponding to the > created Tax Authority SII_CHL) > # Expire all Promotions for OFBIZ E-Commerce Store [ID:9000] by setting all > thru-dates to NOW > # Under Catalog Manager / Products: Create New Product with following > settings: > Internal Name: T-Shirt > Is Virtual Product: Y > # Under Catalog Manager / Products / Categories > Assign the virtual product "T-Shirt" to the products category ID 200 > (Widgets) > Product Category ID: 200 > From Date: Now > Add > # Under Catalog Manager / Products / Content > In override Simple Fields > Set Product Name to: "T-Shirt Virtual" > Update > # Under Catalog Manager / Features: > Create New Feature Category. > Description: "T-Shirt Colors" > Submit > # Create new Feature within feature Category "T-Shirt Colors": > Create New Feature > Feature Type: Color > Description: Red > Update > Create New Feature > Feature Type: Color > Description: Blue > Update > # Create 2 variant products under the virtual product "T-Shirt" > Under Catalog Manager / Products > Find T-Shirt Product > Once T-Shirt Product is selected: > Press Features Tab > Under Add product features from Category or Group > Choose T-Shirt Colors Category > Feature Application Type: Selectable > Add > Screen with Blue and Red T-Shirt Colors appears. > Set for both colors From Date: Now > Sequence:1 for blue > Sequence:2 for red > Set a tick on each feature in order to select the feature for adding it. > Apply > # Under Catalog Manager / Products with "T-Shirt" virtual product selected > press the Variants > tab > The Quick add Variants screen appears. > Define Product IDs for Blue and Red features. > Blue: T-Shirt Blue > Red: T-Shirt Red > Set tick on both features in order to select for variant product creation. > Create > # Under Catalog Manager / Products / Prices set 2 new product prices for the > created virtual > product "T-Shirt": > Default Price > From Date: Now > Price: 11.9 > Tax Percentage: 19 > Tax in price: Y > Create > List Price > From Date: Now > Price: 11.9 > Tax Percentage: 19 > Tax in price: Y > Create > Now
[jira] [Commented] (OFBIZ-6576) Pricing error in Variant Products when setup with VAT-Tax and price set on Virtual Product
[ https://issues.apache.org/jira/browse/OFBIZ-6576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15343818#comment-15343818 ] Divesh Dutta commented on OFBIZ-6576: - Your solutions looks good to me that when we don't have price for variant then look for virtual product's price. This pattern is mostly followed every where in OFBiz. I also reviewed your patch and I think you can use getParentProduct method of ProductWorker class to fetch virtual of variant product. Rest all looks good. > Pricing error in Variant Products when setup with VAT-Tax and price set on > Virtual Product > -- > > Key: OFBIZ-6576 > URL: https://issues.apache.org/jira/browse/OFBIZ-6576 > Project: OFBiz > Issue Type: Bug > Components: product >Affects Versions: Release Branch 13.07, Release Branch 14.12, Trunk >Reporter: Peter Arnold >Priority: Minor > Labels: VAT > Fix For: 14.12.01, Upcoming Branch > > Attachments: OFBIZ-6576.patch > > > In a VAT-Tax setup (i.e. sales-tax does not apply) and when using virtual- > variant- products and the price is defined only on the virtual product and > with "Tax in Price" set to "Y", its variants should inherit the set price > without adding any further taxes. > This is currently not the case when in the e-commerce shop a variant product > is added to the shopping cart. Currently sales-tax is added to the product > price. > Here is a detailed procedure to reproduce the error: > In Party Manager: > # Create new Party Group with Name "SII_CHL" > (Leave all settings for group creation as per standard) > # Assign Role "Tax Authority" to party "SII_CHL" > In Accounting Module / Tax Autorities: > # Create New Tax Authority with following settings: > Geo:CHL > Party: SII_CHL > Include Tax in Price: Y > Leave other setting as is > # Under "Product Rates" create new tax with following settings: > Type: Value Added Tax > Tax Percentage: 19 > From Date: Now > Leave other settings as is > # Expire the Sales Tax created under tax authority _NA_ by setting its > corresponding thru date to NOW. > # Under Catalog Manager / Stores: > Modify following Settings for OFBiz Ecommerce Store (ID:9000) > Tax settings: > Show Prices with VAT tax included: Y > VAT Tax Auth Geo Id: CHL > VAT Tax Auth Party Id: 1 (Or the Party ID corresponding to the > created Tax Authority SII_CHL) > # Expire all Promotions for OFBIZ E-Commerce Store [ID:9000] by setting all > thru-dates to NOW > # Under Catalog Manager / Products: Create New Product with following > settings: > Internal Name: T-Shirt > Is Virtual Product: Y > # Under Catalog Manager / Products / Categories > Assign the virtual product "T-Shirt" to the products category ID 200 > (Widgets) > Product Category ID: 200 > From Date: Now > Add > # Under Catalog Manager / Products / Content > In override Simple Fields > Set Product Name to: "T-Shirt Virtual" > Update > # Under Catalog Manager / Features: > Create New Feature Category. > Description: "T-Shirt Colors" > Submit > # Create new Feature within feature Category "T-Shirt Colors": > Create New Feature > Feature Type: Color > Description: Red > Update > Create New Feature > Feature Type: Color > Description: Blue > Update > # Create 2 variant products under the virtual product "T-Shirt" > Under Catalog Manager / Products > Find T-Shirt Product > Once T-Shirt Product is selected: > Press Features Tab > Under Add product features from Category or Group > Choose T-Shirt Colors Category > Feature Application Type: Selectable > Add > Screen with Blue and Red T-Shirt Colors appears. > Set for both colors From Date: Now > Sequence:1 for blue > Sequence:2 for red > Set a tick on each feature in order to select the feature for adding it. > Apply > # Under Catalog Manager / Products with "T-Shirt" virtual product selected > press the Variants > tab > The Quick add Variants screen appears. > Define Product IDs for Blue and Red features. > Blue: T-Shirt Blue > Red: T-Shirt Red > Set tick on both features in order to select for variant product creation. > Create > # Under Catalog Manager / Products / Prices set 2 new product prices for the > created virtual > product "T-Shirt": > Default Price > From Date: Now > Price: 11.9 > Tax Percentage: 19 > Tax in price: Y > Create > List Price > From Date: Now > Price: 11.9 > Tax Percentage: 19 > Tax in price: Y > Create > Now the products should be visible in the E-Shop. > The Virtual
[jira] [Commented] (OFBIZ-6576) Pricing error in Variant Products when setup with VAT-Tax and price set on Virtual Product
[ https://issues.apache.org/jira/browse/OFBIZ-6576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15343736#comment-15343736 ] Paul Foxworthy commented on OFBIZ-6576: --- Hi all, See this discussion from 2011: http://ofbiz.135035.n4.nabble.com/Display-VAT-on-checkout-pages-td3386374.html There are several places in the OFBiz code where there is an if statement testing for SALES_TAX, where it should probably be SALES_TAX or VAT_TAX. To me, there is very little difference between the two for a sale: they are both taxes levied by a tax authority on a sale. the key difference is VAT applies to purchases as well, and your tax liability is reduced by the tax you have paid on purchases. In contrast, sales tax only applies to sales. Cheers Paul > Pricing error in Variant Products when setup with VAT-Tax and price set on > Virtual Product > -- > > Key: OFBIZ-6576 > URL: https://issues.apache.org/jira/browse/OFBIZ-6576 > Project: OFBiz > Issue Type: Bug > Components: product >Affects Versions: Release Branch 13.07, Release Branch 14.12, Trunk >Reporter: Peter Arnold >Priority: Minor > Labels: VAT > Fix For: 14.12.01, Upcoming Branch > > Attachments: OFBIZ-6576.patch > > > In a VAT-Tax setup (i.e. sales-tax does not apply) and when using virtual- > variant- products and the price is defined only on the virtual product and > with "Tax in Price" set to "Y", its variants should inherit the set price > without adding any further taxes. > This is currently not the case when in the e-commerce shop a variant product > is added to the shopping cart. Currently sales-tax is added to the product > price. > Here is a detailed procedure to reproduce the error: > In Party Manager: > # Create new Party Group with Name "SII_CHL" > (Leave all settings for group creation as per standard) > # Assign Role "Tax Authority" to party "SII_CHL" > In Accounting Module / Tax Autorities: > # Create New Tax Authority with following settings: > Geo:CHL > Party: SII_CHL > Include Tax in Price: Y > Leave other setting as is > # Under "Product Rates" create new tax with following settings: > Type: Value Added Tax > Tax Percentage: 19 > From Date: Now > Leave other settings as is > # Expire the Sales Tax created under tax authority _NA_ by setting its > corresponding thru date to NOW. > # Under Catalog Manager / Stores: > Modify following Settings for OFBiz Ecommerce Store (ID:9000) > Tax settings: > Show Prices with VAT tax included: Y > VAT Tax Auth Geo Id: CHL > VAT Tax Auth Party Id: 1 (Or the Party ID corresponding to the > created Tax Authority SII_CHL) > # Expire all Promotions for OFBIZ E-Commerce Store [ID:9000] by setting all > thru-dates to NOW > # Under Catalog Manager / Products: Create New Product with following > settings: > Internal Name: T-Shirt > Is Virtual Product: Y > # Under Catalog Manager / Products / Categories > Assign the virtual product "T-Shirt" to the products category ID 200 > (Widgets) > Product Category ID: 200 > From Date: Now > Add > # Under Catalog Manager / Products / Content > In override Simple Fields > Set Product Name to: "T-Shirt Virtual" > Update > # Under Catalog Manager / Features: > Create New Feature Category. > Description: "T-Shirt Colors" > Submit > # Create new Feature within feature Category "T-Shirt Colors": > Create New Feature > Feature Type: Color > Description: Red > Update > Create New Feature > Feature Type: Color > Description: Blue > Update > # Create 2 variant products under the virtual product "T-Shirt" > Under Catalog Manager / Products > Find T-Shirt Product > Once T-Shirt Product is selected: > Press Features Tab > Under Add product features from Category or Group > Choose T-Shirt Colors Category > Feature Application Type: Selectable > Add > Screen with Blue and Red T-Shirt Colors appears. > Set for both colors From Date: Now > Sequence:1 for blue > Sequence:2 for red > Set a tick on each feature in order to select the feature for adding it. > Apply > # Under Catalog Manager / Products with "T-Shirt" virtual product selected > press the Variants > tab > The Quick add Variants screen appears. > Define Product IDs for Blue and Red features. > Blue: T-Shirt Blue > Red: T-Shirt Red > Set tick on both features in order to select for variant product creation. > Create > # Under Catalog Manager / Products / Prices set 2 new product prices for the > created virtual > product "T-Shirt": > Default Price > From Date: Now >
[jira] [Commented] (OFBIZ-6576) Pricing error in Variant Products when setup with VAT-Tax and price set on Virtual Product
[ https://issues.apache.org/jira/browse/OFBIZ-6576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15343728#comment-15343728 ] Ankush Upadhyay commented on OFBIZ-6576: Thanks [~Peter Arnold] for reporting the issue and research notes. I have also noticed the same issue and about to going to create JIRA ticket for the same to provide the solution. But it seems instead of duplicating tickets I am attaching patch to fix this issue. Please review the changes and let me know if anything else need to be taken care under this. > Pricing error in Variant Products when setup with VAT-Tax and price set on > Virtual Product > -- > > Key: OFBIZ-6576 > URL: https://issues.apache.org/jira/browse/OFBIZ-6576 > Project: OFBiz > Issue Type: Bug > Components: product >Affects Versions: Release Branch 13.07, Release Branch 14.12, Trunk >Reporter: Peter Arnold >Priority: Minor > Labels: VAT > Fix For: 14.12.01, Upcoming Branch > > Attachments: OFBIZ-6576.patch > > > In a VAT-Tax setup (i.e. sales-tax does not apply) and when using virtual- > variant- products and the price is defined only on the virtual product and > with "Tax in Price" set to "Y", its variants should inherit the set price > without adding any further taxes. > This is currently not the case when in the e-commerce shop a variant product > is added to the shopping cart. Currently sales-tax is added to the product > price. > Here is a detailed procedure to reproduce the error: > In Party Manager: > # Create new Party Group with Name "SII_CHL" > (Leave all settings for group creation as per standard) > # Assign Role "Tax Authority" to party "SII_CHL" > In Accounting Module / Tax Autorities: > # Create New Tax Authority with following settings: > Geo:CHL > Party: SII_CHL > Include Tax in Price: Y > Leave other setting as is > # Under "Product Rates" create new tax with following settings: > Type: Value Added Tax > Tax Percentage: 19 > From Date: Now > Leave other settings as is > # Expire the Sales Tax created under tax authority _NA_ by setting its > corresponding thru date to NOW. > # Under Catalog Manager / Stores: > Modify following Settings for OFBiz Ecommerce Store (ID:9000) > Tax settings: > Show Prices with VAT tax included: Y > VAT Tax Auth Geo Id: CHL > VAT Tax Auth Party Id: 1 (Or the Party ID corresponding to the > created Tax Authority SII_CHL) > # Expire all Promotions for OFBIZ E-Commerce Store [ID:9000] by setting all > thru-dates to NOW > # Under Catalog Manager / Products: Create New Product with following > settings: > Internal Name: T-Shirt > Is Virtual Product: Y > # Under Catalog Manager / Products / Categories > Assign the virtual product "T-Shirt" to the products category ID 200 > (Widgets) > Product Category ID: 200 > From Date: Now > Add > # Under Catalog Manager / Products / Content > In override Simple Fields > Set Product Name to: "T-Shirt Virtual" > Update > # Under Catalog Manager / Features: > Create New Feature Category. > Description: "T-Shirt Colors" > Submit > # Create new Feature within feature Category "T-Shirt Colors": > Create New Feature > Feature Type: Color > Description: Red > Update > Create New Feature > Feature Type: Color > Description: Blue > Update > # Create 2 variant products under the virtual product "T-Shirt" > Under Catalog Manager / Products > Find T-Shirt Product > Once T-Shirt Product is selected: > Press Features Tab > Under Add product features from Category or Group > Choose T-Shirt Colors Category > Feature Application Type: Selectable > Add > Screen with Blue and Red T-Shirt Colors appears. > Set for both colors From Date: Now > Sequence:1 for blue > Sequence:2 for red > Set a tick on each feature in order to select the feature for adding it. > Apply > # Under Catalog Manager / Products with "T-Shirt" virtual product selected > press the Variants > tab > The Quick add Variants screen appears. > Define Product IDs for Blue and Red features. > Blue: T-Shirt Blue > Red: T-Shirt Red > Set tick on both features in order to select for variant product creation. > Create > # Under Catalog Manager / Products / Prices set 2 new product prices for the > created virtual > product "T-Shirt": > Default Price > From Date: Now > Price: 11.9 > Tax Percentage: 19 > Tax in price: Y > Create > List Price > From Date: Now > Price: 11.9 > Tax Percentage: 19 > Tax in price: Y > Create > Now the products should be
[jira] [Commented] (OFBIZ-6576) Pricing error in Variant Products when setup with VAT-Tax and price set on Virtual Product
[
https://issues.apache.org/jira/browse/OFBIZ-6576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15342285#comment-15342285
]
Peter Arnold commented on OFBIZ-6576:
-
Issue is caused by the code further below in TaxAuthorityServices.java:
_
Since for a variant product the "productPrice" and "taxInPrice" is set only on
the corresponding virtual product, the Else part of below code becomes active
and does the following:
taxAdjValue.set("orderAdjustmentTypeId", "SALES_TAX");
Therewith Sales tax is added later on to the Variant Product.
By temporary replacing in above mentioned code line "SALES_TAX" by "VAT_TAX"
the issue seems to be resolved.
However this can only be a temporary fix.
___
Code:
___
GenericValue taxAdjValue = delegator.makeValue("OrderAdjustment");
if (productPrice != null &&
"Y".equals(productPrice.getString("taxInPrice"))) {
// tax is in the price already, so we want the adjustment
to be a VAT_TAX adjustment to be subtracted instead of a SALES_TAX adjustment
to be added
taxAdjValue.set("orderAdjustmentTypeId", "VAT_TAX");
// the amount will be different because we want to figure
out how much of the price was tax, and not how much tax needs to be added
// the formula is: taxAmount = priceWithTax -
(priceWithTax/(1+taxPercentage/100))
BigDecimal taxAmountIncluded =
itemAmount.subtract(itemAmount.divide(BigDecimal.ONE.add(taxRate.divide(PERCENT_SCALE,
4, BigDecimal.ROUND_HALF_UP)), 3, BigDecimal.ROUND_HALF_UP));
taxAdjValue.set("amountAlreadyIncluded", taxAmountIncluded);
taxAdjValue.set("amount", BigDecimal.ZERO);
} else {
taxAdjValue.set("orderAdjustmentTypeId", "SALES_TAX");
taxAdjValue.set("amount", taxAmount);
}
> Pricing error in Variant Products when setup with VAT-Tax and price set on
> Virtual Product
> --
>
> Key: OFBIZ-6576
> URL: https://issues.apache.org/jira/browse/OFBIZ-6576
> Project: OFBiz
> Issue Type: Bug
> Components: product
>Affects Versions: Release Branch 13.07, Release Branch 14.12, Trunk
>Reporter: Peter Arnold
>Priority: Minor
> Labels: VAT
> Fix For: 14.12.01, Upcoming Branch
>
>
> In a VAT-Tax setup (i.e. sales-tax does not apply) and when using virtual-
> variant- products and the price is defined only on the virtual product and
> with "Tax in Price" set to "Y", its variants should inherit the set price
> without adding any further taxes.
> This is currently not the case when in the e-commerce shop a variant product
> is added to the shopping cart. Currently sales-tax is added to the product
> price.
> Here is a detailed procedure to reproduce the error:
> In Party Manager:
> # Create new Party Group with Name "SII_CHL"
> (Leave all settings for group creation as per standard)
> # Assign Role "Tax Authority" to party "SII_CHL"
> In Accounting Module / Tax Autorities:
> # Create New Tax Authority with following settings:
> Geo:CHL
> Party: SII_CHL
> Include Tax in Price: Y
> Leave other setting as is
> # Under "Product Rates" create new tax with following settings:
> Type: Value Added Tax
> Tax Percentage: 19
> From Date: Now
> Leave other settings as is
> # Expire the Sales Tax created under tax authority _NA_ by setting its
> corresponding thru date to NOW.
> # Under Catalog Manager / Stores:
> Modify following Settings for OFBiz Ecommerce Store (ID:9000)
> Tax settings:
> Show Prices with VAT tax included: Y
> VAT Tax Auth Geo Id: CHL
> VAT Tax Auth Party Id: 1 (Or the Party ID corresponding to the
> created Tax Authority SII_CHL)
> # Expire all Promotions for OFBIZ E-Commerce Store [ID:9000] by setting all
> thru-dates to NOW
> # Under Catalog Manager / Products: Create New Product with following
> settings:
> Internal Name: T-Shirt
> Is Virtual Product: Y
> # Under Catalog Manager / Products / Categories
> Assign the virtual product "T-Shirt" to the products category ID 200
> (Widgets)
> Product Category ID: 200
> From Date: Now
> Add
> # Under Catalog Manager / Products / Content
> In override Simple Fields
> Set Product Name to: "T-Shirt Virtual"
> Update
> # Under Catalog Manager / Features:
> Create New Feature Category.
> Description: "T-Shirt Colors"
> Submit
> # Create new Feature within feature Category "T-Shirt Colors":
> Create New Feature
> Feature Type: Color
> Description: Red
> Update
> Create New Feature
> Feature Type: Color
>
[jira] [Commented] (OFBIZ-6576) Pricing error in Variant Products when setup with VAT-Tax and price set on Virtual Product
[ https://issues.apache.org/jira/browse/OFBIZ-6576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14704594#comment-14704594 ] Jacques Le Roux commented on OFBIZ-6576: Thanks Sharan! Pricing error in Variant Products when setup with VAT-Tax and price set on Virtual Product -- Key: OFBIZ-6576 URL: https://issues.apache.org/jira/browse/OFBIZ-6576 Project: OFBiz Issue Type: Bug Components: product Affects Versions: Release Branch 13.07, Release Branch 14.12, Trunk Reporter: Peter Arnold Priority: Minor Fix For: 14.12.01, 13.07.03, Upcoming Branch In a VAT-Tax setup (i.e. sales-tax does not apply) and when using virtual- variant- products and the price is defined only on the virtual product and with Tax in Price set to Y, its variants should inherit the set price without adding any further taxes. This is currently not the case when in the e-commerce shop a variant product is added to the shopping cart. Currently sales-tax is added to the product price. Here is a detailed procedure to reproduce the error: In Party Manager: 1. Create new Party Group with Name SII_CHL (Leave all settings for group creation as per standard) 2. Assign Role Tax Authority to party SII_CHL In Accounting Module / Tax Autorities: 3. Create New Tax Authority with following settings: Geo:CHL Party: SII_CHL Include Tax in Price: Y Leave other setting as is 4. Under Product Rates create new tax with following settings: Type: Value Added Tax Tax Percentage: 19 From Date: Now Leave other settings as is 5. Expire the Sales Tax created under tax authority _NA_ by setting its corresponding thru date to NOW. 6. Under Catalog Manager / Stores: Modify following Settings for OFBiz Ecommerce Store (ID:9000) Tax settings: Show Prices with VAT tax included: Y VAT Tax Auth Geo Id: CHL VAT Tax Auth Party Id: 1 (Or the Party ID corresponding to the created Tax Authority SII_CHL) 7. Expire all Promotions for OFBIZ E-Commerce Store [ID:9000] by setting all thru-dates to NOW 8. Under Catalog Manager / Products: Create New Product with following settings: Internal Name: T-Shirt Is Virtual Product: Y 9. Under Catalog Manager / Products / Categories Assign the virtual product T-Shirt to the products category ID 200 (Widgets) - Product Category ID: 200 - From Date: Now Add 10 Under Catalog Manager / Products / Content In override Simple Fields Set Product Name to: T-Shirt Virtual Update 11. Under Catalog Manager / Features: Create New Feature Category. - Description: T-Shirt Colors Submit 12. Create new Feature within feature Category T-Shirt Colors: Create New Feature - Feature Type: Color - Description: Red Update Create New Feature - Feature Type: Color - Description: Blue Update 13. Create 2 variant products under the virtual product T-Shirt Under Catalog Manager / Products Find T-Shirt Product Once T-Shirt Product is selected: Press Features Tab Under Add product features from Category or Group - Choose T-Shirt Colors Category - Feature Application Type: Selectable Add Screen with Blue and Red T-Shirt Colors appears. Set for both colors From Date: Now Sequence:1 for blue Sequence:2 for red Set a tick on each feature in order to select the feature for adding it. Apply 14. Under Catalog Manager / Products with T-Shirt virtual product selected press the Variants tab The Quick add Variants screen appears. Define Product IDs for Blue and Red features. Blue: T-Shirt Blue Red: T-Shirt Red Set tick on both features in order to select for variant product creation. Create 15. Under Catalog Manager / Products / Prices set 2 new product prices for the created virtual product T-Shirt: - Default Price - From Date: Now - Price: 11.9 - Tax Percentage: 19 - Tax in price: Y Create - List Price - From Date: Now - Price: 11.9 - Tax Percentage: 19 - Tax in price: Y Create Now the products should be visible in the E-Shop. The Virtual Products Price appears at USD 14.16 If I Select the blue or the red T-Shirt Price is 11.9USD Now I modify the Product Pricing on the Virtual Product. On
[jira] [Commented] (OFBIZ-6576) Pricing error in Variant Products when setup with VAT-Tax and price set on Virtual Product
[ https://issues.apache.org/jira/browse/OFBIZ-6576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14702919#comment-14702919 ] Sharan Foga commented on OFBIZ-6576: Hi Jacques - I will run a test on 12.04 and let you know. Thanks Pricing error in Variant Products when setup with VAT-Tax and price set on Virtual Product -- Key: OFBIZ-6576 URL: https://issues.apache.org/jira/browse/OFBIZ-6576 Project: OFBiz Issue Type: Bug Components: product Affects Versions: Release Branch 13.07, Release Branch 14.12, Trunk Reporter: Peter Arnold Priority: Minor Fix For: 14.12.01, 13.07.03, Upcoming Branch In a VAT-Tax setup (i.e. sales-tax does not apply) and when using virtual- variant- products and the price is defined only on the virtual product and with Tax in Price set to Y, its variants should inherit the set price without adding any further taxes. This is currently not the case when in the e-commerce shop a variant product is added to the shopping cart. Currently sales-tax is added to the product price. Here is a detailed procedure to reproduce the error: In Party Manager: 1. Create new Party Group with Name SII_CHL (Leave all settings for group creation as per standard) 2. Assign Role Tax Authority to party SII_CHL In Accounting Module / Tax Autorities: 3. Create New Tax Authority with following settings: Geo:CHL Party: SII_CHL Include Tax in Price: Y Leave other setting as is 4. Under Product Rates create new tax with following settings: Type: Value Added Tax Tax Percentage: 19 From Date: Now Leave other settings as is 5. Expire the Sales Tax created under tax authority _NA_ by setting its corresponding thru date to NOW. 6. Under Catalog Manager / Stores: Modify following Settings for OFBiz Ecommerce Store (ID:9000) Tax settings: Show Prices with VAT tax included: Y VAT Tax Auth Geo Id: CHL VAT Tax Auth Party Id: 1 (Or the Party ID corresponding to the created Tax Authority SII_CHL) 7. Expire all Promotions for OFBIZ E-Commerce Store [ID:9000] by setting all thru-dates to NOW 8. Under Catalog Manager / Products: Create New Product with following settings: Internal Name: T-Shirt Is Virtual Product: Y 9. Under Catalog Manager / Products / Categories Assign the virtual product T-Shirt to the products category ID 200 (Widgets) - Product Category ID: 200 - From Date: Now Add 10 Under Catalog Manager / Products / Content In override Simple Fields Set Product Name to: T-Shirt Virtual Update 11. Under Catalog Manager / Features: Create New Feature Category. - Description: T-Shirt Colors Submit 12. Create new Feature within feature Category T-Shirt Colors: Create New Feature - Feature Type: Color - Description: Red Update Create New Feature - Feature Type: Color - Description: Blue Update 13. Create 2 variant products under the virtual product T-Shirt Under Catalog Manager / Products Find T-Shirt Product Once T-Shirt Product is selected: Press Features Tab Under Add product features from Category or Group - Choose T-Shirt Colors Category - Feature Application Type: Selectable Add Screen with Blue and Red T-Shirt Colors appears. Set for both colors From Date: Now Sequence:1 for blue Sequence:2 for red Set a tick on each feature in order to select the feature for adding it. Apply 14. Under Catalog Manager / Products with T-Shirt virtual product selected press the Variants tab The Quick add Variants screen appears. Define Product IDs for Blue and Red features. Blue: T-Shirt Blue Red: T-Shirt Red Set tick on both features in order to select for variant product creation. Create 15. Under Catalog Manager / Products / Prices set 2 new product prices for the created virtual product T-Shirt: - Default Price - From Date: Now - Price: 11.9 - Tax Percentage: 19 - Tax in price: Y Create - List Price - From Date: Now - Price: 11.9 - Tax Percentage: 19 - Tax in price: Y Create Now the products should be visible in the E-Shop. The Virtual Products Price appears at USD 14.16 If I Select the blue or the red T-Shirt Price is 11.9USD Now I modify the Product
