[jira] Updated: (OFBIZ-633) Remove redunant style decarations from maincss.css
[ https://issues.apache.org/jira/browse/OFBIZ-633?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Crum updated OFBIZ-633: -- Attachment: experimental_7.patch Menu widget refactor. No need to apply the patch from OFBIZ-685 - it's now a part of the project. Just apply this patch to the latest svn and do an ant build in the framework/widget folder. > Remove redunant style decarations from maincss.css > -- > > Key: OFBIZ-633 > URL: https://issues.apache.org/jira/browse/OFBIZ-633 > Project: OFBiz (The Open for Business Project) > Issue Type: Sub-task >Reporter: Chris Howe >Priority: Minor > Attachments: createCustomer.jpg, experimental_1.patch, > experimental_2.patch, experimental_3.patch, experimental_4.patch, > experimental_6.patch, experimental_6.patch, experimental_7.patch, > findAfter.jpg, findBefore.jpg, HtmlFormRenderer.patch, maincss.css, > profileAfter.jpg, profileBefore.jpg > > > This will be used to contain comments regarding the consolidated maincss.css > file that are rather unrelated to the combining of maincss.css and > tabstyles.css -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-633) Remove redunant style decarations from maincss.css
[ https://issues.apache.org/jira/browse/OFBIZ-633?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Crum updated OFBIZ-633: -- Attachment: experimental_6.patch Better element nesting in the tree widget. Simplified navigation styles. > Remove redunant style decarations from maincss.css > -- > > Key: OFBIZ-633 > URL: https://issues.apache.org/jira/browse/OFBIZ-633 > Project: OFBiz (The Open for Business Project) > Issue Type: Sub-task >Reporter: Chris Howe >Priority: Minor > Attachments: createCustomer.jpg, experimental_1.patch, > experimental_2.patch, experimental_3.patch, experimental_4.patch, > experimental_6.patch, experimental_6.patch, findAfter.jpg, findBefore.jpg, > HtmlFormRenderer.patch, maincss.css, profileAfter.jpg, profileBefore.jpg > > > This will be used to contain comments regarding the consolidated maincss.css > file that are rather unrelated to the combining of maincss.css and > tabstyles.css -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-633) Remove redunant style decarations from maincss.css
[ https://issues.apache.org/jira/browse/OFBIZ-633?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Crum updated OFBIZ-633: -- Attachment: experimental_6.patch experimental_6.patch demonstrates two new features - component-level style sheets, and component-level java script files. First apply the patch from OFBIZ-685, then apply this patch. Next, do an ant build in the framework/widget folder. Browse to https://localhost:8443/accounting/control/GlAccountNavigate to see the demo of the new tree widget and the component-level style sheet. Browse to https://localhost:8443/partymgr/control/findparty to see the demo of the component-level java script file. The java scripts that had been embedded in findparty.ftl are now in their own java script (.js) file. > Remove redunant style decarations from maincss.css > -- > > Key: OFBIZ-633 > URL: https://issues.apache.org/jira/browse/OFBIZ-633 > Project: OFBiz (The Open for Business Project) > Issue Type: Sub-task >Reporter: Chris Howe >Priority: Minor > Attachments: createCustomer.jpg, experimental_1.patch, > experimental_2.patch, experimental_3.patch, experimental_4.patch, > experimental_6.patch, findAfter.jpg, findBefore.jpg, HtmlFormRenderer.patch, > maincss.css, profileAfter.jpg, profileBefore.jpg > > > This will be used to contain comments regarding the consolidated maincss.css > file that are rather unrelated to the combining of maincss.css and > tabstyles.css -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-633) Remove redunant style decarations from maincss.css
[ https://issues.apache.org/jira/browse/OFBIZ-633?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Crum updated OFBIZ-633: -- Attachment: HtmlFormRenderer.patch Jacopo, The Form Widget is one of those HTML "element collections" that works best with a table based layout. If you look at a typical data entry form it is, in essence, a table. The basicTable CSS class I created will style a form widget table and all of its contained elements, so there is very little markup needed. Sure, we could replace the table with nested s, but we wouldn't gain anything. The end result would be the same amount of HTML and less control of layout. I started work on the HtmlFormRenderer class. I have attached a patch so you can take a look at it. Keep in mind that it isn't finished yet. Btw, could you take a look at OFBIZ-685 please? > Remove redunant style decarations from maincss.css > -- > > Key: OFBIZ-633 > URL: https://issues.apache.org/jira/browse/OFBIZ-633 > Project: OFBiz (The Open for Business Project) > Issue Type: Sub-task >Reporter: Chris Howe >Priority: Minor > Attachments: createCustomer.jpg, experimental_1.patch, > experimental_2.patch, experimental_3.patch, experimental_4.patch, > findAfter.jpg, findBefore.jpg, HtmlFormRenderer.patch, maincss.css, > profileAfter.jpg, profileBefore.jpg > > > This will be used to contain comments regarding the consolidated maincss.css > file that are rather unrelated to the combining of maincss.css and > tabstyles.css -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-633) Remove redunant style decarations from maincss.css
[ https://issues.apache.org/jira/browse/OFBIZ-633?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Crum updated OFBIZ-633: -- Attachment: profileAfter.jpg > Remove redunant style decarations from maincss.css > -- > > Key: OFBIZ-633 > URL: https://issues.apache.org/jira/browse/OFBIZ-633 > Project: OFBiz (The Open for Business Project) > Issue Type: Sub-task >Reporter: Chris Howe >Priority: Minor > Attachments: createCustomer.jpg, experimental_1.patch, > experimental_2.patch, experimental_3.patch, experimental_4.patch, > findAfter.jpg, findBefore.jpg, maincss.css, profileAfter.jpg, > profileBefore.jpg > > > This will be used to contain comments regarding the consolidated maincss.css > file that are rather unrelated to the combining of maincss.css and > tabstyles.css -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-633) Remove redunant style decarations from maincss.css
[ https://issues.apache.org/jira/browse/OFBIZ-633?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Crum updated OFBIZ-633: -- Attachment: profileBefore.jpg > Remove redunant style decarations from maincss.css > -- > > Key: OFBIZ-633 > URL: https://issues.apache.org/jira/browse/OFBIZ-633 > Project: OFBiz (The Open for Business Project) > Issue Type: Sub-task >Reporter: Chris Howe >Priority: Minor > Attachments: createCustomer.jpg, experimental_1.patch, > experimental_2.patch, experimental_3.patch, experimental_4.patch, > findAfter.jpg, findBefore.jpg, maincss.css, profileBefore.jpg > > > This will be used to contain comments regarding the consolidated maincss.css > file that are rather unrelated to the combining of maincss.css and > tabstyles.css -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-633) Remove redunant style decarations from maincss.css
[ https://issues.apache.org/jira/browse/OFBIZ-633?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Crum updated OFBIZ-633: -- Attachment: findAfter.jpg > Remove redunant style decarations from maincss.css > -- > > Key: OFBIZ-633 > URL: https://issues.apache.org/jira/browse/OFBIZ-633 > Project: OFBiz (The Open for Business Project) > Issue Type: Sub-task >Reporter: Chris Howe >Priority: Minor > Attachments: createCustomer.jpg, experimental_1.patch, > experimental_2.patch, experimental_3.patch, experimental_4.patch, > findAfter.jpg, findBefore.jpg, maincss.css, profileBefore.jpg > > > This will be used to contain comments regarding the consolidated maincss.css > file that are rather unrelated to the combining of maincss.css and > tabstyles.css -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-633) Remove redunant style decarations from maincss.css
[ https://issues.apache.org/jira/browse/OFBIZ-633?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Crum updated OFBIZ-633: -- Attachment: findBefore.jpg I'm attaching some "before and after" screen shots, so those who don't have time to try out the patches can see the differences in the UI. The "before" screen shots demonstrate how content doesn't scale well. The "after" screen shots demonstrate the new practices. > Remove redunant style decarations from maincss.css > -- > > Key: OFBIZ-633 > URL: https://issues.apache.org/jira/browse/OFBIZ-633 > Project: OFBiz (The Open for Business Project) > Issue Type: Sub-task >Reporter: Chris Howe >Priority: Minor > Attachments: createCustomer.jpg, experimental_1.patch, > experimental_2.patch, experimental_3.patch, experimental_4.patch, > findAfter.jpg, findBefore.jpg, maincss.css, profileBefore.jpg > > > This will be used to contain comments regarding the consolidated maincss.css > file that are rather unrelated to the combining of maincss.css and > tabstyles.css -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-633) Remove redunant style decarations from maincss.css
[ https://issues.apache.org/jira/browse/OFBIZ-633?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Crum updated OFBIZ-633: -- Attachment: createCustomer.jpg I was playing around with form widget styles and I came up with some ideas. I have attached a screenshot of the create customer screen in Party Manager so you can take a look. I made one small modification to HtmlFormRenderer.java's tooltip code to use this basic logic: if tooltip style is specified use the specified tooltip style else use the funky -[ ]- characters. All of the styling in this screenshot was done purely with CSS. > Remove redunant style decarations from maincss.css > -- > > Key: OFBIZ-633 > URL: https://issues.apache.org/jira/browse/OFBIZ-633 > Project: OFBiz (The Open for Business Project) > Issue Type: Sub-task >Reporter: Chris Howe >Priority: Minor > Attachments: createCustomer.jpg, experimental_1.patch, > experimental_2.patch, experimental_3.patch, experimental_4.patch, maincss.css > > > This will be used to contain comments regarding the consolidated maincss.css > file that are rather unrelated to the combining of maincss.css and > tabstyles.css -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-633) Remove redunant style decarations from maincss.css
[ https://issues.apache.org/jira/browse/OFBIZ-633?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Crum updated OFBIZ-633: -- Attachment: experimental_4.patch experimental_4.patch builds upon experimental_3.patch. This patch will require an ant build in the framework/widget component. I refactored the UI for the Party Manager "create new" screens - which utilize form widgets. So, I had to make some modifications to HtmlFormRenderer.java to clean up the messy markup it output. In this patch, the form widget uses the default styles in the new maincss.css file - which causes a slight change in layout. I'm thinking about making a formWidget CSS class that the form widget can default to - which will make the form appearance match a little closer. I also added some HTML comments and indentation to help make the markup easier to read. Those can be taken back out after the refactoring. The createparty.ftl file was added to demonstrate what I talked about on the dev mailing list. The ftl code is smaller than the corresponding widget code, but it requires a new file - which contains the license, etc. I would really like to see the widgets support HTML "snippets" so that little HTML code fragments like the one in createparty.ftl can be put right in the widget. As with the previous experimental_x patches, it's best to spend time playing with the UI on the refactored pages and look at the markup. Change your browser's default font, resize the browser window, etc to see how well the UI behaves. URLs of the refactored pages: https://127.0.0.1:8443/partymgr/control/findparty https://127.0.0.1:8443/partymgr/control/createnew https://127.0.0.1:8443/partymgr/control/editpartygroup?create_new=Y https://127.0.0.1:8443/partymgr/control/editperson?create_new=Y https://127.0.0.1:8443/partymgr/control/NewCustomer https://127.0.0.1:8443/partymgr/control/NewProspect https://127.0.0.1:8443/partymgr/control/NewEmployee This latest patch demonstrates the direction I'd like to see things go in. I probably won't submit any more experimental patches unless I come across something truly noteworthy. > Remove redunant style decarations from maincss.css > -- > > Key: OFBIZ-633 > URL: https://issues.apache.org/jira/browse/OFBIZ-633 > Project: OFBiz (The Open for Business Project) > Issue Type: Sub-task >Reporter: Chris Howe >Priority: Minor > Attachments: experimental_1.patch, experimental_2.patch, > experimental_3.patch, experimental_4.patch, maincss.css > > > This will be used to contain comments regarding the consolidated maincss.css > file that are rather unrelated to the combining of maincss.css and > tabstyles.css -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-633) Remove redunant style decarations from maincss.css
[ https://issues.apache.org/jira/browse/OFBIZ-633?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Crum updated OFBIZ-633: -- Attachment: experimental_3.patch experimental_3.patch builds upon and improves the experimental_2.patch. (Let's just pretend experimental_1.patch never happened, okay?) I refactored the party manager viewProfile page as a test for the new CSS classes. The existing viewProfile page looks terrible and the layout is easily broken when the browser window is resized. This patch makes the page look neat and organized regardless of window size. I continued the CSS class decorator pattern with the button bars located at the top of the viewProfile page. Look for the line in partyMenus.ftl and add the "toolBar" decorator to it. It's not fancy, but it demonstrates what can be done with the button bars. View the page source (HTML markup) of the patched pages. The markup contains minimal styling information and it's well structured. Also notice the screenlet IDs. These can be used as named anchors. Try this link in a patched installation: https://localhost:8443/partymgr/control/viewprofile?partyId=DemoCustomer#partyNotes Now you can link directly to a screenlet! > Remove redunant style decarations from maincss.css > -- > > Key: OFBIZ-633 > URL: https://issues.apache.org/jira/browse/OFBIZ-633 > Project: OFBiz (The Open for Business Project) > Issue Type: Sub-task >Reporter: Chris Howe >Priority: Minor > Attachments: experimental_1.patch, experimental_2.patch, > experimental_3.patch, maincss.css > > > This will be used to contain comments regarding the consolidated maincss.css > file that are rather unrelated to the combining of maincss.css and > tabstyles.css -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-633) Remove redunant style decarations from maincss.css
[ https://issues.apache.org/jira/browse/OFBIZ-633?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Crum updated OFBIZ-633: -- Attachment: experimental_2.patch experimental_2.patch is a scaled down version of the previous patch. The only files modified are maincss.css and findParty.ftl. I've been refining the new css classes and I have come up with a decorator pattern that I think is really cool. This patch can be used to demonstrate the decorator pattern. If you want to style a table, just use the tag This will give you a basic table with header and cell styling built in. If you want to add a dark grid to the table, just use the tag or, for a light grid If you want the rows to highlight when the cursor moves over them, use the tag And you can combine decorators - Try it out for yourself. Look for the line in findParty.ftl and add the decorators. Let me know what you think. > Remove redunant style decarations from maincss.css > -- > > Key: OFBIZ-633 > URL: https://issues.apache.org/jira/browse/OFBIZ-633 > Project: OFBiz (The Open for Business Project) > Issue Type: Sub-task >Reporter: Chris Howe >Priority: Minor > Attachments: experimental_1.patch, experimental_2.patch, maincss.css > > > This will be used to contain comments regarding the consolidated maincss.css > file that are rather unrelated to the combining of maincss.css and > tabstyles.css -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-633) Remove redunant style decarations from maincss.css
[ https://issues.apache.org/jira/browse/OFBIZ-633?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Crum updated OFBIZ-633: -- Attachment: experimental_1.patch I attached experimental_1.patch to this issue for people to try out. Apply the patch to an installed and recent copy of OFBiz. The patch continues to build upon the maincss.css file changes. The purpose of the patch is to try out some new CSS classes and HTML coding practices before the big UI refactor gets started. My hope is that several developers will try it out and post comments here. The patch expands the maincss.css file with a set of new classes. I kept the old ones intact for backward compatibility. I put plenty of comments in the file to explain things. The end result is a huge maincss.css file. Keep in mind it is not intended to be put in the main project - it's just there to try out ideas. I used the Party Manager component to try out the improved layout methods. I like it because it has a lot of content and a good assortment of HTML elements. Only two screens are used for the demo - findParty and viewProfile. There are two things I need help with at this stage: 1. There is a bug with IE (any version) and how it handles ULs. I tried a popular hack to fix the bug, but it's not working. If any CSS gurus out there could take a look at it I would appreciate it very much. The bug is clearly commented in the maincss.css file. 2. I need some Mac users to try out this patch. I've tested it with Windows Mozilla, Firefox, and IE7. They all render well. I don't have access to a Mac, so I'm depending on someone with a Mac to spend a few minutes playing around with this patch. I tried to keep the OFBiz look and feel the same, but there are a few HTML element collections that I took the liberty to restyle. It's not my intention to introduce the style changes into the main project, they are just there for demonstration purposes. I've been too busy with this effort to install, configure, and learn how to use a new IDE, so the patch will contain unintentional formatting changes that are caused by my current IDE. Examining file differences line-by-line probably won't give you much insight anyway. I commented everything that was worth looking at. Take some time to tinker with the UI. Shrink the browser window down, reverse the direction, try to break the layout. So far, it seems to work pretty well for me. Spend some time looking at the page source - it's much cleaner in the changed areas. > Remove redunant style decarations from maincss.css > -- > > Key: OFBIZ-633 > URL: https://issues.apache.org/jira/browse/OFBIZ-633 > Project: Apache OFBiz (The Open for Business Project) > Issue Type: Sub-task >Reporter: Chris Howe >Priority: Minor > Attachments: experimental_1.patch, maincss.css > > > This will be used to contain comments regarding the consolidated maincss.css > file that are rather unrelated to the combining of maincss.css and > tabstyles.css -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-633) Remove redunant style decarations from maincss.css
[ https://issues.apache.org/jira/browse/OFBIZ-633?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux updated OFBIZ-633: -- Attachment: (was: maincss.css) > Remove redunant style decarations from maincss.css > -- > > Key: OFBIZ-633 > URL: https://issues.apache.org/jira/browse/OFBIZ-633 > Project: Apache OFBiz (The Open for Business Project) > Issue Type: Sub-task >Reporter: Chris Howe >Priority: Minor > Attachments: maincss.css > > > This will be used to contain comments regarding the consolidated maincss.css > file that are rather unrelated to the combining of maincss.css and > tabstyles.css -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (OFBIZ-633) Remove redunant style decarations from maincss.css
[ https://issues.apache.org/jira/browse/OFBIZ-633?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Howe updated OFBIZ-633: - Attachment: maincss.css > Remove redunant style decarations from maincss.css > -- > > Key: OFBIZ-633 > URL: https://issues.apache.org/jira/browse/OFBIZ-633 > Project: Apache OFBiz (The Open for Business Project) > Issue Type: Sub-task >Reporter: Chris Howe >Priority: Minor > Attachments: maincss.css, maincss.css > > > This will be used to contain comments regarding the consolidated maincss.css > file that are rather unrelated to the combining of maincss.css and > tabstyles.css -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (OFBIZ-633) Remove redunant style decarations from maincss.css
[ https://issues.apache.org/jira/browse/OFBIZ-633?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Howe updated OFBIZ-633: - Attachment: maincss.css > Remove redunant style decarations from maincss.css > -- > > Key: OFBIZ-633 > URL: https://issues.apache.org/jira/browse/OFBIZ-633 > Project: Apache OFBiz (The Open for Business Project) > Issue Type: Sub-task >Reporter: Chris Howe >Priority: Minor > Attachments: maincss.css > > > This will be used to contain comments regarding the consolidated maincss.css > file that are rather unrelated to the combining of maincss.css and > tabstyles.css -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
