Re: Checkstyle error: Files does not end with newline

2020-02-28 Thread Jacques Le Roux
Daniel, This: https://ci.apache.org/projects/ofbiz/logs/ Jacques Le 28/02/2020 à 14:41, Daniel Watford a écrit : Hi Jacques, If I follow the link to the ofbiz builds in Buildbot ( https://ci.apache.org/builders/ofbizTrunkFramework) I can see a list of recent builds. How do I navigate from

Re: Checkstyle error: Files does not end with newline

2020-02-28 Thread Daniel Watford
Hi Jacques, If I follow the link to the ofbiz builds in Buildbot ( https://ci.apache.org/builders/ofbizTrunkFramework) I can see a list of recent builds. How do I navigate from the list of recent builds to view the test reports - e.g. view build/reports/checkstyle/test.html for

Re: Checkstyle error: Files does not end with newline

2020-02-28 Thread Jacques Le Roux
Thanks Daniel, It works in Buildbot, so it's OK with me ;) https://ci.apache.org/builders/ofbizTrunkFramework Cheers Jacques Le 28/02/2020 à 11:24, Daniel Watford a écrit : Hi Jacques, I haven't been able to come up with an explanation for what you're seeing, so through I'd post some of my

Re: Checkstyle error: Files does not end with newline

2020-02-28 Thread Daniel Watford
Issue https://issues.apache.org/jira/browse/OFBIZ-11428 raised and PR https://github.com/apache/ofbiz-framework/pull/36 created On Fri, 28 Feb 2020 at 10:24, Daniel Watford wrote: > Hi Jacques, > > I haven't been able to come up with an explanation for what you're seeing, > so through I'd

Re: Checkstyle error: Files does not end with newline

2020-02-28 Thread Daniel Watford
Hi Jacques, I haven't been able to come up with an explanation for what you're seeing, so through I'd post some of my configuration and results to see if we can spot anything odd. Building on a Windows 10 host. Executing builds from Git Bash running in Windows terminal: $ git log -1 commit

Re: Checkstyle error: Files does not end with newline

2020-02-28 Thread Jacques Le Roux
Le 28/02/2020 à 10:22, Jacques Le Roux a écrit : Le 28/02/2020 à 10:07, Daniel Watford a écrit : Hello, In my dev environment (Windows 10, IntelliJ, Git checking out with LF line endings) I see 39 checkstyle errors for our tests related to java files not ending with a newline. However on

Re: Checkstyle error: Files does not end with newline

2020-02-28 Thread Jacques Le Roux
Le 28/02/2020 à 10:07, Daniel Watford a écrit : Hello, In my dev environment (Windows 10, IntelliJ, Git checking out with LF line endings) I see 39 checkstyle errors for our tests related to java files not ending with a newline. However on inspecting one of the files, ModelFormFieldTest, I can