Re: HashCrypt is deprecated: is this an issue?

2012-04-19 Thread Adrian Crum
No, those are deprecations that were introduced in a recent commit. Most 
likely the warnings will be fixed in a future commit.


-Adrian

On 4/19/2012 8:06 AM, Pierre Smits wrote:

When building the trunk I get (amonst others) following notifications:

classes:
   [javac16] Compiling 140 source files to
/ci/ofbiz/framework/entity/build/classes
   [javac16] 
/ci/ofbiz/framework/entity/src/org/ofbiz/entity/GenericEntity.java:1299:
warning: [deprecation] getDigestHash(java.lang.String) in
org.ofbiz.base.crypto.HashCrypt has been deprecated
   [javac16] curValue = HashCrypt.getDigestHash(encryptField);
   [javac16] ^
   [javac16] 
/ci/ofbiz/framework/entity/src/org/ofbiz/entity/util/EntityCrypto.java:122:
warning: [deprecation]
getDigestHashOldFunnyHexEncode(java.lang.String,java.lang.String) in
org.ofbiz.base.crypto.HashCrypt has been deprecated
   [javac16] String hashedKeyName = useOldFunnyKeyHash?
HashCrypt.getDigestHashOldFunnyHexEncode(originalKeyName, null) :
HashCrypt.getDigestHash(originalKeyName);
   [javac16] ^
   [javac16] 
/ci/ofbiz/framework/entity/src/org/ofbiz/entity/util/EntityCrypto.java:122:
warning: [deprecation] getDigestHash(java.lang.String) in
org.ofbiz.base.crypto.HashCrypt has been deprecated
   [javac16] String hashedKeyName = useOldFunnyKeyHash?
HashCrypt.getDigestHashOldFunnyHexEncode(originalKeyName, null) :
HashCrypt.getDigestHash(originalKeyName);
   [javac16]
^
   [javac16] 3 warnings


Do we have an issue here?

Regards,


Pierre



Re: HashCrypt is deprecated: is this an issue?

2012-04-19 Thread Pierre Smits
So a JIRA would be in order?

Op 19 april 2012 11:14 schreef Adrian Crum 
adrian.c...@sandglass-software.com het volgende:

 No, those are deprecations that were introduced in a recent commit. Most
 likely the warnings will be fixed in a future commit.

 -Adrian


 On 4/19/2012 8:06 AM, Pierre Smits wrote:

 When building the trunk I get (amonst others) following notifications:

 classes:
   [javac16] Compiling 140 source files to
 /ci/ofbiz/framework/entity/**build/classes
   [javac16] /ci/ofbiz/framework/entity/**src/org/ofbiz/entity/**
 GenericEntity.java:1299:
 warning: [deprecation] getDigestHash(java.lang.**String) in
 org.ofbiz.base.crypto.**HashCrypt has been deprecated
   [javac16] curValue = HashCrypt.getDigestHash(**
 encryptField);
   [javac16] ^
   [javac16] /ci/ofbiz/framework/entity/**src/org/ofbiz/entity/util/**
 EntityCrypto.java:122:
 warning: [deprecation]
 getDigestHashOldFunnyHexEncode**(java.lang.String,java.lang.**String) in
 org.ofbiz.base.crypto.**HashCrypt has been deprecated
   [javac16] String hashedKeyName = useOldFunnyKeyHash?
 HashCrypt.**getDigestHashOldFunnyHexEncode**(originalKeyName, null) :
 HashCrypt.getDigestHash(**originalKeyName);
   [javac16] ^
   [javac16] /ci/ofbiz/framework/entity/**src/org/ofbiz/entity/util/**
 EntityCrypto.java:122:
 warning: [deprecation] getDigestHash(java.lang.**String) in
 org.ofbiz.base.crypto.**HashCrypt has been deprecated
   [javac16] String hashedKeyName = useOldFunnyKeyHash?
 HashCrypt.**getDigestHashOldFunnyHexEncode**(originalKeyName, null) :
 HashCrypt.getDigestHash(**originalKeyName);
   [javac16]
^
   [javac16] 3 warnings


 Do we have an issue here?

 Regards,


 Pierre




Re: HashCrypt is deprecated: is this an issue?

2012-04-19 Thread Adrian Crum
Yes. Just a guess:  Fixing the deprecations might fix the demo user 
login problem experienced recently.


-Adrian

On 4/19/2012 10:27 AM, Pierre Smits wrote:

So a JIRA would be in order?

Op 19 april 2012 11:14 schreef Adrian Crum
adrian.c...@sandglass-software.com  het volgende:


No, those are deprecations that were introduced in a recent commit. Most
likely the warnings will be fixed in a future commit.

-Adrian


On 4/19/2012 8:06 AM, Pierre Smits wrote:


When building the trunk I get (amonst others) following notifications:

classes:
   [javac16] Compiling 140 source files to
/ci/ofbiz/framework/entity/**build/classes
   [javac16] /ci/ofbiz/framework/entity/**src/org/ofbiz/entity/**
GenericEntity.java:1299:
warning: [deprecation] getDigestHash(java.lang.**String) in
org.ofbiz.base.crypto.**HashCrypt has been deprecated
   [javac16] curValue = HashCrypt.getDigestHash(**
encryptField);
   [javac16] ^
   [javac16] /ci/ofbiz/framework/entity/**src/org/ofbiz/entity/util/**
EntityCrypto.java:122:
warning: [deprecation]
getDigestHashOldFunnyHexEncode**(java.lang.String,java.lang.**String) in
org.ofbiz.base.crypto.**HashCrypt has been deprecated
   [javac16] String hashedKeyName = useOldFunnyKeyHash?
HashCrypt.**getDigestHashOldFunnyHexEncode**(originalKeyName, null) :
HashCrypt.getDigestHash(**originalKeyName);
   [javac16] ^
   [javac16] /ci/ofbiz/framework/entity/**src/org/ofbiz/entity/util/**
EntityCrypto.java:122:
warning: [deprecation] getDigestHash(java.lang.**String) in
org.ofbiz.base.crypto.**HashCrypt has been deprecated
   [javac16] String hashedKeyName = useOldFunnyKeyHash?
HashCrypt.**getDigestHashOldFunnyHexEncode**(originalKeyName, null) :
HashCrypt.getDigestHash(**originalKeyName);
   [javac16]
^
   [javac16] 3 warnings


Do we have an issue here?

Regards,


Pierre




Re: HashCrypt is deprecated: is this an issue?

2012-04-19 Thread Pierre Smits
Ok. Will do.

Op 19 april 2012 11:30 schreef Adrian Crum 
adrian.c...@sandglass-software.com het volgende:

 Yes. Just a guess:  Fixing the deprecations might fix the demo user login
 problem experienced recently.

 -Adrian


 On 4/19/2012 10:27 AM, Pierre Smits wrote:

 So a JIRA would be in order?

 Op 19 april 2012 11:14 schreef Adrian Crum
 adrian.crum@sandglass-**software.com adrian.c...@sandglass-software.com
  het volgende:

  No, those are deprecations that were introduced in a recent commit. Most
 likely the warnings will be fixed in a future commit.

 -Adrian


 On 4/19/2012 8:06 AM, Pierre Smits wrote:

  When building the trunk I get (amonst others) following notifications:

 classes:
   [javac16] Compiling 140 source files to
 /ci/ofbiz/framework/entity/build/classes
   [javac16] /ci/ofbiz/framework/entity/src/org/ofbiz/entity/**
 GenericEntity.java:1299:
 warning: [deprecation] getDigestHash(java.lang.String) in
 org.ofbiz.base.crypto.HashCrypt has been deprecated
   [javac16] curValue = HashCrypt.getDigestHash(**
 encryptField);
   [javac16] ^
   [javac16] /ci/ofbiz/framework/entity/src/org/ofbiz/entity/util/**
 EntityCrypto.java:122:
 warning: [deprecation]
 getDigestHashOldFunnyHexEncode(java.lang.String,java.lang.String)
 in
 org.ofbiz.base.crypto.HashCrypt has been deprecated

   [javac16] String hashedKeyName = useOldFunnyKeyHash?
 HashCrypt.getDigestHashOldFunnyHexEncode(originalKeyName,
 null) :
 HashCrypt.getDigestHash(originalKeyName);
   [javac16]
 ^
   [javac16] /ci/ofbiz/framework/entity/src/org/ofbiz/entity/util/**
 EntityCrypto.java:122:
 warning: [deprecation] getDigestHash(java.lang.String) in
 org.ofbiz.base.crypto.HashCrypt has been deprecated

   [javac16] String hashedKeyName = useOldFunnyKeyHash?
 HashCrypt.getDigestHashOldFunnyHexEncode(originalKeyName,
 null) :
 HashCrypt.getDigestHash(originalKeyName);

   [javac16]
^
   [javac16] 3 warnings


 Do we have an issue here?

 Regards,


 Pierre





Re: HashCrypt is deprecated: is this an issue?

2012-04-19 Thread Jacques Le Roux

I wanted to review the related commits, but did not get enough time. I 'm 
interested because of
https://issues.apache.org/jira/browse/OFBIZ-1151
https://issues.apache.org/jira/browse/OFBIZ-2729
https://issues.apache.org/jira/browse/OFBIZ-3006

Jacques

From: Pierre Smits pierre.sm...@gmail.com

Ok. Will do.

Op 19 april 2012 11:30 schreef Adrian Crum 
adrian.c...@sandglass-software.com het volgende:


Yes. Just a guess:  Fixing the deprecations might fix the demo user login
problem experienced recently.

-Adrian


On 4/19/2012 10:27 AM, Pierre Smits wrote:


So a JIRA would be in order?

Op 19 april 2012 11:14 schreef Adrian Crum
adrian.crum@sandglass-**software.com adrian.c...@sandglass-software.com
 het volgende:

 No, those are deprecations that were introduced in a recent commit. Most

likely the warnings will be fixed in a future commit.

-Adrian


On 4/19/2012 8:06 AM, Pierre Smits wrote:

 When building the trunk I get (amonst others) following notifications:


classes:
  [javac16] Compiling 140 source files to
/ci/ofbiz/framework/entity/build/classes
  [javac16] /ci/ofbiz/framework/entity/src/org/ofbiz/entity/**
GenericEntity.java:1299:
warning: [deprecation] getDigestHash(java.lang.String) in
org.ofbiz.base.crypto.HashCrypt has been deprecated
  [javac16] curValue = HashCrypt.getDigestHash(**
encryptField);
  [javac16] ^
  [javac16] /ci/ofbiz/framework/entity/src/org/ofbiz/entity/util/**
EntityCrypto.java:122:
warning: [deprecation]
getDigestHashOldFunnyHexEncode(java.lang.String,java.lang.String)
in
org.ofbiz.base.crypto.HashCrypt has been deprecated

  [javac16] String hashedKeyName = useOldFunnyKeyHash?
HashCrypt.getDigestHashOldFunnyHexEncode(originalKeyName,
null) :
HashCrypt.getDigestHash(originalKeyName);
  [javac16]
^
  [javac16] /ci/ofbiz/framework/entity/src/org/ofbiz/entity/util/**
EntityCrypto.java:122:
warning: [deprecation] getDigestHash(java.lang.String) in
org.ofbiz.base.crypto.HashCrypt has been deprecated

  [javac16] String hashedKeyName = useOldFunnyKeyHash?
HashCrypt.getDigestHashOldFunnyHexEncode(originalKeyName,
null) :
HashCrypt.getDigestHash(originalKeyName);

  [javac16]
   ^
  [javac16] 3 warnings


Do we have an issue here?

Regards,


Pierre







Re: HashCrypt is deprecated: is this an issue?

2012-04-19 Thread Adam Heath
On 04/19/2012 02:06 AM, Pierre Smits wrote:
 When building the trunk I get (amonst others) following notifications:
 
 classes:
   [javac16] Compiling 140 source files to
 /ci/ofbiz/framework/entity/build/classes
   [javac16] 
 /ci/ofbiz/framework/entity/src/org/ofbiz/entity/GenericEntity.java:1299:
 warning: [deprecation] getDigestHash(java.lang.String) in
 org.ofbiz.base.crypto.HashCrypt has been deprecated
   [javac16] curValue = HashCrypt.getDigestHash(encryptField);
   [javac16] ^
   [javac16] 
 /ci/ofbiz/framework/entity/src/org/ofbiz/entity/util/EntityCrypto.java:122:
 warning: [deprecation]
 getDigestHashOldFunnyHexEncode(java.lang.String,java.lang.String) in
 org.ofbiz.base.crypto.HashCrypt has been deprecated
   [javac16] String hashedKeyName = useOldFunnyKeyHash?
 HashCrypt.getDigestHashOldFunnyHexEncode(originalKeyName, null) :
 HashCrypt.getDigestHash(originalKeyName);
   [javac16] ^
   [javac16] 
 /ci/ofbiz/framework/entity/src/org/ofbiz/entity/util/EntityCrypto.java:122:
 warning: [deprecation] getDigestHash(java.lang.String) in
 org.ofbiz.base.crypto.HashCrypt has been deprecated
   [javac16] String hashedKeyName = useOldFunnyKeyHash?
 HashCrypt.getDigestHashOldFunnyHexEncode(originalKeyName, null) :
 HashCrypt.getDigestHash(originalKeyName);
   [javac16]
^
   [javac16] 3 warnings
 
 
 Do we have an issue here?

Working on it.