Thanks Deepak!
I have updated the commit log.
Rishi Solanki
Sr Manager, Enterprise Software Development
HotWax Systems Pvt. Ltd.
Direct: +91-9893287847
http://www.hotwaxsystems.com
www.hotwax.co
On Wed, Mar 14, 2018 at 11:03 AM, Deepak Dixit <
deepak.di...@hotwaxsystems.com> wrote:
> Hi Rishi,
>
> Could you please update commit log and use "Reverted: as prefix?
> https://cwiki.apache.org/confluence/x/TxjtAw
>
> Thanks & Regards
> --
> Deepak Dixit
> www.hotwaxsystems.com
> www.hotwax.co
>
> On Tue, Mar 13, 2018 at 7:19 PM, wrote:
>
> > Author: rishi
> > Date: Tue Mar 13 13:49:23 2018
> > New Revision: 1826633
> >
> > URL: http://svn.apache.org/viewvc?rev=1826633&view=rev
> > Log:
> > Improved: Improve GeneralLedgerServices to set transaction date as
> > payment's effective date. Reverting my commit due to buildbot failure
> > message will check and commit it back.
> > (OFBIZ-10239)
> >
> > Modified:
> > ofbiz/ofbiz-framework/trunk/applications/accounting/minilang/ledger/
> > GeneralLedgerServices.xml
> >
> > Modified: ofbiz/ofbiz-framework/trunk/applications/accounting/
> > minilang/ledger/GeneralLedgerServices.xml
> > URL: http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/
> > applications/accounting/minilang/ledger/GeneralLedgerServices.xml?rev=
> > 1826633&r1=1826632&r2=1826633&view=diff
> >
> > ==
> > --- ofbiz/ofbiz-framework/trunk/applications/accounting/minilang/ledger/
> GeneralLedgerServices.xml
> > (original)
> > +++ ofbiz/ofbiz-framework/trunk/applications/accounting/minilang/ledger/
> GeneralLedgerServices.xml
> > Tue Mar 13 13:49:23 2018
> > @@ -2404,7 +2404,6 @@ under the License.
> > > value="OUTGOING_PAYMENT"/>
> > > from-field="partyId"/>
> > > from-field="payment.paymentId"/>
> > - > from-field="payment.effectiveDate"/>
> > > from-field="acctgTransEntries"/>
> > > in-map-name="createAcctgTransAndEntriesInMap">
> >
> > @@ -2649,7 +2648,6 @@ under the License.
> > > from-field="acctgTransEntries"/>
> > > value="PAYMENT_APPL"/>
> > > value="ACTUAL"/>
> > - > from-field="payment.effectiveDate"/>
> > > from-field="paymentApplication.paymentId"/>
> > > from-field="paymentApplication.invoiceId"/>
> > > value="true">
> >
> >
> >
>
