[jira] [Commented] (OLINGO-752) Add support for "+" sign as a separator in addition to %20 for URLs
[ https://issues.apache.org/jira/browse/OLINGO-752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16334225#comment-16334225 ] Archana Rai commented on OLINGO-752: [~kristiyanm] sure I will update. Thanks, Archana > Add support for "+" sign as a separator in addition to %20 for URLs > --- > > Key: OLINGO-752 > URL: https://issues.apache.org/jira/browse/OLINGO-752 > Project: Olingo > Issue Type: New Feature > Components: odata2-core >Affects Versions: V2 2.0.4, (Java) V4 4.0.0-beta-03 >Reporter: Ronny Bremer >Priority: Minor > Attachments: 0002-OLINGO-752-Treat-as-space-in-Decoder.patch > > > Some well-known OData client libraries, such as JQuery, are using the > incorrect encoding for URLs sent to OLingo based OData v2 services. > According to the OData V2 standard, the separator for encoded URLs is %20. > However, in many cases when developers talk about "URL encoding", they use > Java functions like "URLEncoder.encode()" to encode the parameters for their > HTTP request. JQuery seems to utilise a similar function in JavaScript. > Now these functions are based on the HTTP forms encoding standard, so they > use "+" as a separator. > If would be small but grateful addition to the OLingo URI parser to accept > both separator characters. Maybe with a config option to follow the standard > (so only accept %20) or to be more relaxed (and accept both). -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OLINGO-752) Add support for "+" sign as a separator in addition to %20 for URLs
[ https://issues.apache.org/jira/browse/OLINGO-752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16334207#comment-16334207 ] Kristiyan Marinov commented on OLINGO-752: -- [~archanarai], is it possible to include it in the release notes? They don't seem to link to this issue & the issue does not have a Fix Version(s) label set. I had to go through 5 versions until I got the proper one. > Add support for "+" sign as a separator in addition to %20 for URLs > --- > > Key: OLINGO-752 > URL: https://issues.apache.org/jira/browse/OLINGO-752 > Project: Olingo > Issue Type: New Feature > Components: odata2-core >Affects Versions: V2 2.0.4, (Java) V4 4.0.0-beta-03 >Reporter: Ronny Bremer >Priority: Minor > Attachments: 0002-OLINGO-752-Treat-as-space-in-Decoder.patch > > > Some well-known OData client libraries, such as JQuery, are using the > incorrect encoding for URLs sent to OLingo based OData v2 services. > According to the OData V2 standard, the separator for encoded URLs is %20. > However, in many cases when developers talk about "URL encoding", they use > Java functions like "URLEncoder.encode()" to encode the parameters for their > HTTP request. JQuery seems to utilise a similar function in JavaScript. > Now these functions are based on the HTTP forms encoding standard, so they > use "+" as a separator. > If would be small but grateful addition to the OLingo URI parser to accept > both separator characters. Maybe with a config option to follow the standard > (so only accept %20) or to be more relaxed (and accept both). -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OLINGO-752) Add support for "+" sign as a separator in addition to %20 for URLs
[ https://issues.apache.org/jira/browse/OLINGO-752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16334199#comment-16334199 ] Archana Rai commented on OLINGO-752: Hi Kristiyan, Yes, the fix is part of 2.0.10. Thanks, Archana > Add support for "+" sign as a separator in addition to %20 for URLs > --- > > Key: OLINGO-752 > URL: https://issues.apache.org/jira/browse/OLINGO-752 > Project: Olingo > Issue Type: New Feature > Components: odata2-core >Affects Versions: V2 2.0.4, (Java) V4 4.0.0-beta-03 >Reporter: Ronny Bremer >Priority: Minor > Attachments: 0002-OLINGO-752-Treat-as-space-in-Decoder.patch > > > Some well-known OData client libraries, such as JQuery, are using the > incorrect encoding for URLs sent to OLingo based OData v2 services. > According to the OData V2 standard, the separator for encoded URLs is %20. > However, in many cases when developers talk about "URL encoding", they use > Java functions like "URLEncoder.encode()" to encode the parameters for their > HTTP request. JQuery seems to utilise a similar function in JavaScript. > Now these functions are based on the HTTP forms encoding standard, so they > use "+" as a separator. > If would be small but grateful addition to the OLingo URI parser to accept > both separator characters. Maybe with a config option to follow the standard > (so only accept %20) or to be more relaxed (and accept both). -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OLINGO-752) Add support for "+" sign as a separator in addition to %20 for URLs
[ https://issues.apache.org/jira/browse/OLINGO-752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16334195#comment-16334195 ] Kristiyan Marinov commented on OLINGO-752: -- Hi all, Just ran into this issue and wanted to confirm it is fixed in 2.0.10. Cheers, Kristiyan > Add support for "+" sign as a separator in addition to %20 for URLs > --- > > Key: OLINGO-752 > URL: https://issues.apache.org/jira/browse/OLINGO-752 > Project: Olingo > Issue Type: New Feature > Components: odata2-core >Affects Versions: V2 2.0.4, (Java) V4 4.0.0-beta-03 >Reporter: Ronny Bremer >Priority: Minor > Attachments: 0002-OLINGO-752-Treat-as-space-in-Decoder.patch > > > Some well-known OData client libraries, such as JQuery, are using the > incorrect encoding for URLs sent to OLingo based OData v2 services. > According to the OData V2 standard, the separator for encoded URLs is %20. > However, in many cases when developers talk about "URL encoding", they use > Java functions like "URLEncoder.encode()" to encode the parameters for their > HTTP request. JQuery seems to utilise a similar function in JavaScript. > Now these functions are based on the HTTP forms encoding standard, so they > use "+" as a separator. > If would be small but grateful addition to the OLingo URI parser to accept > both separator characters. Maybe with a config option to follow the standard > (so only accept %20) or to be more relaxed (and accept both). -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OLINGO-752) Add support for "+" sign as a separator in addition to %20 for URLs
[ https://issues.apache.org/jira/browse/OLINGO-752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16260536#comment-16260536 ] Dmitry Tretyakov commented on OLINGO-752: - [~archanarai], thank you, for our use case fix in v2 is enough. > Add support for "+" sign as a separator in addition to %20 for URLs > --- > > Key: OLINGO-752 > URL: https://issues.apache.org/jira/browse/OLINGO-752 > Project: Olingo > Issue Type: New Feature > Components: odata2-core >Affects Versions: V2 2.0.4, (Java) V4 4.0.0-beta-03 >Reporter: Ronny Bremer >Priority: Minor > Attachments: 0002-OLINGO-752-Treat-as-space-in-Decoder.patch > > > Some well-known OData client libraries, such as JQuery, are using the > incorrect encoding for URLs sent to OLingo based OData v2 services. > According to the OData V2 standard, the separator for encoded URLs is %20. > However, in many cases when developers talk about "URL encoding", they use > Java functions like "URLEncoder.encode()" to encode the parameters for their > HTTP request. JQuery seems to utilise a similar function in JavaScript. > Now these functions are based on the HTTP forms encoding standard, so they > use "+" as a separator. > If would be small but grateful addition to the OLingo URI parser to accept > both separator characters. Maybe with a config option to follow the standard > (so only accept %20) or to be more relaxed (and accept both). -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (OLINGO-752) Add support for "+" sign as a separator in addition to %20 for URLs
[ https://issues.apache.org/jira/browse/OLINGO-752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16260307#comment-16260307 ] Archana Rai commented on OLINGO-752: Hi [~dtretyakov], I have done the changes for v2: https://git-wip-us.apache.org/repos/asf?p=olingo-odata2.git;a=commit;h=5d88b96e805303bf2c04aa4f93291e074b736910 You can now put this as init parameter in you web.xml: org.apache.olingo.odata.accept.forms.encoding true Thanks, Archana > Add support for "+" sign as a separator in addition to %20 for URLs > --- > > Key: OLINGO-752 > URL: https://issues.apache.org/jira/browse/OLINGO-752 > Project: Olingo > Issue Type: New Feature > Components: odata2-core >Affects Versions: V2 2.0.4, (Java) V4 4.0.0-beta-03 >Reporter: Ronny Bremer >Priority: Minor > Attachments: 0002-OLINGO-752-Treat-as-space-in-Decoder.patch > > > Some well-known OData client libraries, such as JQuery, are using the > incorrect encoding for URLs sent to OLingo based OData v2 services. > According to the OData V2 standard, the separator for encoded URLs is %20. > However, in many cases when developers talk about "URL encoding", they use > Java functions like "URLEncoder.encode()" to encode the parameters for their > HTTP request. JQuery seems to utilise a similar function in JavaScript. > Now these functions are based on the HTTP forms encoding standard, so they > use "+" as a separator. > If would be small but grateful addition to the OLingo URI parser to accept > both separator characters. Maybe with a config option to follow the standard > (so only accept %20) or to be more relaxed (and accept both). -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (OLINGO-752) Add support for "+" sign as a separator in addition to %20 for URLs
[ https://issues.apache.org/jira/browse/OLINGO-752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16259187#comment-16259187 ] Archana Rai commented on OLINGO-752: Hi [~dtretyakov], We would like to know if providing such a provision in version 2 be sufficient for your scenario? Regards, Archana > Add support for "+" sign as a separator in addition to %20 for URLs > --- > > Key: OLINGO-752 > URL: https://issues.apache.org/jira/browse/OLINGO-752 > Project: Olingo > Issue Type: New Feature > Components: odata2-core >Affects Versions: V2 2.0.4, (Java) V4 4.0.0-beta-03 >Reporter: Ronny Bremer >Priority: Minor > Attachments: 0002-OLINGO-752-Treat-as-space-in-Decoder.patch > > > Some well-known OData client libraries, such as JQuery, are using the > incorrect encoding for URLs sent to OLingo based OData v2 services. > According to the OData V2 standard, the separator for encoded URLs is %20. > However, in many cases when developers talk about "URL encoding", they use > Java functions like "URLEncoder.encode()" to encode the parameters for their > HTTP request. JQuery seems to utilise a similar function in JavaScript. > Now these functions are based on the HTTP forms encoding standard, so they > use "+" as a separator. > If would be small but grateful addition to the OLingo URI parser to accept > both separator characters. Maybe with a config option to follow the standard > (so only accept %20) or to be more relaxed (and accept both). -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (OLINGO-752) Add support for "+" sign as a separator in addition to %20 for URLs
[ https://issues.apache.org/jira/browse/OLINGO-752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16241526#comment-16241526 ] Archana Rai commented on OLINGO-752: Hi [~dtretyakov] , We evaluate the approach, try it out and get back to you. Thanks, Archana > Add support for "+" sign as a separator in addition to %20 for URLs > --- > > Key: OLINGO-752 > URL: https://issues.apache.org/jira/browse/OLINGO-752 > Project: Olingo > Issue Type: New Feature > Components: odata2-core >Affects Versions: V2 2.0.4, (Java) V4 4.0.0-beta-03 >Reporter: Ronny Bremer >Priority: Minor > Attachments: 0002-OLINGO-752-Treat-as-space-in-Decoder.patch > > > Some well-known OData client libraries, such as JQuery, are using the > incorrect encoding for URLs sent to OLingo based OData v2 services. > According to the OData V2 standard, the separator for encoded URLs is %20. > However, in many cases when developers talk about "URL encoding", they use > Java functions like "URLEncoder.encode()" to encode the parameters for their > HTTP request. JQuery seems to utilise a similar function in JavaScript. > Now these functions are based on the HTTP forms encoding standard, so they > use "+" as a separator. > If would be small but grateful addition to the OLingo URI parser to accept > both separator characters. Maybe with a config option to follow the standard > (so only accept %20) or to be more relaxed (and accept both). -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (OLINGO-752) Add support for "+" sign as a separator in addition to %20 for URLs
[ https://issues.apache.org/jira/browse/OLINGO-752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16240125#comment-16240125 ] Dmitry Tretyakov commented on OLINGO-752: - [~archanarai] [~chrisam], this fix works, but enabling this mode via query parameter does not work in our case, because we could not rewrite all clients of OData2 feed. In my mind the better way to enable this mode would be to use http request attribute like `org.apache.olingo.odata2.path.split` or Java system property. > Add support for "+" sign as a separator in addition to %20 for URLs > --- > > Key: OLINGO-752 > URL: https://issues.apache.org/jira/browse/OLINGO-752 > Project: Olingo > Issue Type: New Feature > Components: odata2-core >Affects Versions: V2 2.0.4, (Java) V4 4.0.0-beta-03 >Reporter: Ronny Bremer >Priority: Minor > Attachments: 0002-OLINGO-752-Treat-as-space-in-Decoder.patch > > > Some well-known OData client libraries, such as JQuery, are using the > incorrect encoding for URLs sent to OLingo based OData v2 services. > According to the OData V2 standard, the separator for encoded URLs is %20. > However, in many cases when developers talk about "URL encoding", they use > Java functions like "URLEncoder.encode()" to encode the parameters for their > HTTP request. JQuery seems to utilise a similar function in JavaScript. > Now these functions are based on the HTTP forms encoding standard, so they > use "+" as a separator. > If would be small but grateful addition to the OLingo URI parser to accept > both separator characters. Maybe with a config option to follow the standard > (so only accept %20) or to be more relaxed (and accept both). -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (OLINGO-752) Add support for "+" sign as a separator in addition to %20 for URLs
[ https://issues.apache.org/jira/browse/OLINGO-752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16119614#comment-16119614 ] Ronny Bremer commented on OLINGO-752: - Thank you very much Archana for your fix. It looks great to me and I will give you feedback after we tried it. Yours, Ronny > Add support for "+" sign as a separator in addition to %20 for URLs > --- > > Key: OLINGO-752 > URL: https://issues.apache.org/jira/browse/OLINGO-752 > Project: Olingo > Issue Type: New Feature > Components: odata2-core >Affects Versions: V2 2.0.4, (Java) V4 4.0.0-beta-03 >Reporter: Ronny Bremer >Priority: Minor > Attachments: 0002-OLINGO-752-Treat-as-space-in-Decoder.patch > > > Some well-known OData client libraries, such as JQuery, are using the > incorrect encoding for URLs sent to OLingo based OData v2 services. > According to the OData V2 standard, the separator for encoded URLs is %20. > However, in many cases when developers talk about "URL encoding", they use > Java functions like "URLEncoder.encode()" to encode the parameters for their > HTTP request. JQuery seems to utilise a similar function in JavaScript. > Now these functions are based on the HTTP forms encoding standard, so they > use "+" as a separator. > If would be small but grateful addition to the OLingo URI parser to accept > both separator characters. Maybe with a config option to follow the standard > (so only accept %20) or to be more relaxed (and accept both). -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (OLINGO-752) Add support for "+" sign as a separator in addition to %20 for URLs
[ https://issues.apache.org/jira/browse/OLINGO-752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16089995#comment-16089995 ] Dmitry Tretyakov commented on OLINGO-752: - Hey [~chrisam], [~mirbo], [~archanarai], [~ramya.vasanth]! It's quite critical to us to have this issue solved. Do you have a chance to look at it and at the attached patch to resolve it? Thanks. > Add support for "+" sign as a separator in addition to %20 for URLs > --- > > Key: OLINGO-752 > URL: https://issues.apache.org/jira/browse/OLINGO-752 > Project: Olingo > Issue Type: New Feature > Components: odata2-core >Affects Versions: V2 2.0.4, (Java) V4 4.0.0-beta-03 >Reporter: Ronny Bremer >Priority: Minor > Attachments: 0002-OLINGO-752-Treat-as-space-in-Decoder.patch > > > Some well-known OData client libraries, such as JQuery, are using the > incorrect encoding for URLs sent to OLingo based OData v2 services. > According to the OData V2 standard, the separator for encoded URLs is %20. > However, in many cases when developers talk about "URL encoding", they use > Java functions like "URLEncoder.encode()" to encode the parameters for their > HTTP request. JQuery seems to utilise a similar function in JavaScript. > Now these functions are based on the HTTP forms encoding standard, so they > use "+" as a separator. > If would be small but grateful addition to the OLingo URI parser to accept > both separator characters. Maybe with a config option to follow the standard > (so only accept %20) or to be more relaxed (and accept both). -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (OLINGO-752) Add support for "+" sign as a separator in addition to %20 for URLs
[ https://issues.apache.org/jira/browse/OLINGO-752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15968870#comment-15968870 ] Dmitry Tretyakov commented on OLINGO-752: - Hi [~chrisam]! This issue relates to OLINGO-1107 and breaks some of OData clients, see [TW-49634|https://youtrack.jetbrains.com/issue/TW-49634]. Please take a look at the attached patch. > Add support for "+" sign as a separator in addition to %20 for URLs > --- > > Key: OLINGO-752 > URL: https://issues.apache.org/jira/browse/OLINGO-752 > Project: Olingo > Issue Type: New Feature > Components: odata2-core >Affects Versions: V2 2.0.4, (Java) V4 4.0.0-beta-03 >Reporter: Ronny Bremer >Priority: Minor > Attachments: 0002-OLINGO-752-Treat-as-space-in-Decoder.patch > > > Some well-known OData client libraries, such as JQuery, are using the > incorrect encoding for URLs sent to OLingo based OData v2 services. > According to the OData V2 standard, the separator for encoded URLs is %20. > However, in many cases when developers talk about "URL encoding", they use > Java functions like "URLEncoder.encode()" to encode the parameters for their > HTTP request. JQuery seems to utilise a similar function in JavaScript. > Now these functions are based on the HTTP forms encoding standard, so they > use "+" as a separator. > If would be small but grateful addition to the OLingo URI parser to accept > both separator characters. Maybe with a config option to follow the standard > (so only accept %20) or to be more relaxed (and accept both). -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (OLINGO-752) Add support for + sign as a separator in addition to %20 for URLs
[ https://issues.apache.org/jira/browse/OLINGO-752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14695088#comment-14695088 ] Ronny Bremer commented on OLINGO-752: - Thank you Christian. However, I need to correct you on one small item: the createResponse method was called all the time, as I stated in my original request: Quote: I just duplicated the ODataServlet class and put in a debug line at the beginning of createResponse. The DELETE request does indeed call that method after my DeleteProcessor got called. Yours, Ronny Add support for + sign as a separator in addition to %20 for URLs --- Key: OLINGO-752 URL: https://issues.apache.org/jira/browse/OLINGO-752 Project: Olingo Issue Type: New Feature Components: odata2-core Affects Versions: V2 2.0.4, (Java) V4 4.0.0-beta-03 Reporter: Ronny Bremer Priority: Minor Some well-known OData client libraries, such as JQuery, are using the incorrect encoding for URLs sent to OLingo based OData v2 services. According to the OData V2 standard, the separator for encoded URLs is %20. However, in many cases when developers talk about URL encoding, they use Java functions like URLEncoder.encode() to encode the parameters for their HTTP request. JQuery seems to utilise a similar function in JavaScript. Now these functions are based on the HTTP forms encoding standard, so they use + as a separator. If would be small but grateful addition to the OLingo URI parser to accept both separator characters. Maybe with a config option to follow the standard (so only accept %20) or to be more relaxed (and accept both). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OLINGO-752) Add support for + sign as a separator in addition to %20 for URLs
[ https://issues.apache.org/jira/browse/OLINGO-752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14680239#comment-14680239 ] Ralf Handl commented on OLINGO-752: --- The + character is a valid character in URLs that does not have to be percent-encoded. In OData-URLs it can appear - within numbers, e.g. +3.14, 1e+2 - within strings, e.g. 'Divide+Conquer' How can the server safely decide whether the client is using form-URL-encoding, or standard URL-encoding? Add support for + sign as a separator in addition to %20 for URLs --- Key: OLINGO-752 URL: https://issues.apache.org/jira/browse/OLINGO-752 Project: Olingo Issue Type: New Feature Components: odata2-core Affects Versions: V2 2.0.4, (Java) V4 4.0.0-beta-03 Reporter: Ronny Bremer Priority: Minor Some well-known OData client libraries, such as JQuery, are using the incorrect encoding for URLs sent to OLingo based OData v2 services. According to the OData V2 standard, the separator for encoded URLs is %20. However, in many cases when developers talk about URL encoding, they use Java functions like URLEncoder.encode() to encode the parameters for their HTTP request. JQuery seems to utilise a similar function in JavaScript. Now these functions are based on the HTTP forms encoding standard, so they use + as a separator. If would be small but grateful addition to the OLingo URI parser to accept both separator characters. Maybe with a config option to follow the standard (so only accept %20) or to be more relaxed (and accept both). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
