[jira] [Commented] (OMID-86) Add Tx info in RollbackException

2018-02-13 Thread Ohad Shacham (JIRA)
[ https://issues.apache.org/jira/browse/OMID-86?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16362229#comment-16362229 ] Ohad Shacham commented on OMID-86: -- LGTM +1 > Add Tx info in RollbackException > --

[jira] [Commented] (OMID-89) Fix metrics in PersistenceProcesssorHandlers

2018-02-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/OMID-89?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16362275#comment-16362275 ] ASF GitHub Bot commented on OMID-89: Github user ohadshacham commented on a diff in the p

[jira] [Commented] (OMID-89) Fix metrics in PersistenceProcesssorHandlers

2018-02-13 Thread Ohad Shacham (JIRA)
[ https://issues.apache.org/jira/browse/OMID-89?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16362300#comment-16362300 ] Ohad Shacham commented on OMID-89: -- LGTM, just as a general comment. These metrics significa

[jira] [Commented] (OMID-87) Fix BatchPool initialization

2018-02-13 Thread Ohad Shacham (JIRA)
[ https://issues.apache.org/jira/browse/OMID-87?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16362301#comment-16362301 ] Ohad Shacham commented on OMID-87: -- LGTM > Fix BatchPool initialization > -

[jira] [Commented] (OMID-88) Add 0.9.0.0 and phoenix-integration branches to Travis

2018-02-13 Thread Ohad Shacham (JIRA)
[ https://issues.apache.org/jira/browse/OMID-88?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16362302#comment-16362302 ] Ohad Shacham commented on OMID-88: -- LGTM > Add 0.9.0.0 and phoenix-integration branches to

[GitHub] incubator-omid pull request #23: [OMID-89] Fix metrics in Persistence proces...

2018-02-13 Thread ohadshacham
Github user ohadshacham commented on a diff in the pull request: https://github.com/apache/incubator-omid/pull/23#discussion_r167857492 --- Diff: tso-server/src/test/java/org/apache/omid/tso/TestPersistenceProcessorHandler.java --- @@ -126,6 +126,36 @@ void afterMethod() {