[jira] [Commented] (OMID-102) Implement visibility filter as pure HBase Filter

2018-08-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/OMID-102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16570293#comment-16570293 ] ASF GitHub Bot commented on OMID-102: - Github user JamesRTaylor commented on a diff in the pull

[jira] [Commented] (OMID-102) Implement visibility filter as pure HBase Filter

2018-08-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/OMID-102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16570300#comment-16570300 ] ASF GitHub Bot commented on OMID-102: - Github user JamesRTaylor commented on a diff in the pull

[jira] [Commented] (OMID-102) Implement visibility filter as pure HBase Filter

2018-08-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/OMID-102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16570303#comment-16570303 ] ASF GitHub Bot commented on OMID-102: - Github user JamesRTaylor commented on a diff in the pull

[GitHub] incubator-omid pull request #41: [OMID-102] Support for user Filter when usi...

2018-08-06 Thread JamesRTaylor
Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/incubator-omid/pull/41#discussion_r207919955 --- Diff: hbase-coprocessor/src/test/java/org/apache/omid/transaction/TestSnapshotFilter.java --- @@ -226,8 +222,115 @@ public void

[GitHub] incubator-omid issue #41: [OMID-102] Support for user Filter when using copr...

2018-08-06 Thread JamesRTaylor
Github user JamesRTaylor commented on the issue: https://github.com/apache/incubator-omid/pull/41 Nice work, @yonigottesman. I made a few minor comments, @ohadshacham. My main question is do the Phoenix unit tests FlappingTransactionIT.testInflightUpdateNotSeen() and

[GitHub] incubator-omid pull request #41: [OMID-102] Support for user Filter when usi...

2018-08-06 Thread JamesRTaylor
Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/incubator-omid/pull/41#discussion_r207918920 --- Diff: hbase-client/src/main/java/org/apache/omid/transaction/HTableAccessWrapper.java --- @@ -20,10 +20,7 @@ import