[GitHub] incubator-omid issue #35: [OMID-100] James Taylor's patch to: https://issues...

Github user JamesRTaylor commented on the issue: https://github.com/apache/incubator-omid/pull/35 +1 ---

[GitHub] incubator-omid issue #36: [OMID-72] bug fix, accessed tables should be sent ...

Github user JamesRTaylor commented on the issue: https://github.com/apache/incubator-omid/pull/36 +1 ---

[GitHub] incubator-omid pull request #41: [OMID-102] Support for user Filter when usi...

Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/incubator-omid/pull/41#discussion_r206927180 --- Diff: hbase-coprocessor/src/main/java/org/apache/omid/transaction/TransactionVisibilityFilter.java --- @@ -0,0 +1,248

[GitHub] incubator-omid issue #41: [OMID-102] Support for user Filter when using copr...

Github user JamesRTaylor commented on the issue: https://github.com/apache/incubator-omid/pull/41 This is great, @yonigottesman! Do the Phoenix unit tests FlappingTransactionIT.testInflightUpdateNotSeen() and testInflightDeleteNotSeen() pass with this change? You can try running them

[GitHub] incubator-omid pull request #41: [OMID-102] Support for user Filter when usi...

Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/incubator-omid/pull/41#discussion_r206934998 --- Diff: hbase-coprocessor/src/test/java/org/apache/omid/transaction/TestSnapshotFilter.java --- @@ -226,8 +222,115 @@ public void

[GitHub] incubator-omid pull request #41: [OMID-102] Support for user Filter when usi...

Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/incubator-omid/pull/41#discussion_r206935434 --- Diff: hbase-coprocessor/src/main/java/org/apache/omid/transaction/TransactionVisibilityFilter.java --- @@ -0,0 +1,248

[GitHub] incubator-omid pull request #41: [OMID-102] Support for user Filter when usi...

Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/incubator-omid/pull/41#discussion_r206936274 --- Diff: hbase-common/src/main/java/org/apache/omid/transaction/CellUtils.java --- @@ -52,6 +52,7 @@ static byte[] DELETE_TOMBSTONE

[GitHub] incubator-omid pull request #41: [OMID-102] Support for user Filter when usi...

Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/incubator-omid/pull/41#discussion_r207919955 --- Diff: hbase-coprocessor/src/test/java/org/apache/omid/transaction/TestSnapshotFilter.java --- @@ -226,8 +222,115 @@ public void

[GitHub] incubator-omid issue #41: [OMID-102] Support for user Filter when using copr...

Github user JamesRTaylor commented on the issue: https://github.com/apache/incubator-omid/pull/41 Nice work, @yonigottesman. I made a few minor comments, @ohadshacham. My main question is do the Phoenix unit tests FlappingTransactionIT.testInflightUpdateNotSeen

[GitHub] incubator-omid pull request #41: [OMID-102] Support for user Filter when usi...

Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/incubator-omid/pull/41#discussion_r207918920 --- Diff: hbase-client/src/main/java/org/apache/omid/transaction/HTableAccessWrapper.java --- @@ -20,10 +20,7 @@ import

[GitHub] incubator-omid pull request #46: [OMID-90] Integrate omid low latency to pho...

Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/incubator-omid/pull/46#discussion_r224179421 --- Diff: hbase-client/src/test/java/org/apache/omid/transaction/TestOmidLLRaces.java --- @@ -0,0 +1,243 @@ +/* + * Licensed