[GitHub] incubator-omid issue #41: [OMID-102] Support for user Filter when using copr...

2018-08-06 Thread JamesRTaylor 
Github user JamesRTaylor commented on the issue:

https://github.com/apache/incubator-omid/pull/41
  
Nice work, @yonigottesman. I made a few minor comments, @ohadshacham. My 
main question is do the Phoenix unit tests 
FlappingTransactionIT.testInflightUpdateNotSeen() and 
testInflightDeleteNotSeen() pass with this change? You can try running them 
from the omid2 feature branch in Phoenix against the phoenix-integration branch 
in omid2 with your patch applied.


---

[GitHub] incubator-omid issue #41: [OMID-102] Support for user Filter when using copr...

2018-08-01 Thread JamesRTaylor 
Github user JamesRTaylor commented on the issue:

https://github.com/apache/incubator-omid/pull/41
  
This is great, @yonigottesman! Do the Phoenix unit tests 
FlappingTransactionIT.testInflightUpdateNotSeen() and 
testInflightDeleteNotSeen() pass with this change? You can try running them 
from the omid2 feature branch.


---