[jira] [Comment Edited] (OOZIE-3479) Build pre-commit pipeline for pull requests.
[ https://issues.apache.org/jira/browse/OOZIE-3479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17651197#comment-17651197 ] Janos Makai edited comment on OOZIE-3479 at 12/22/22 9:40 AM: -- Thank you for the inputs [~gezapeti] and [~dionusos]. Acquiring and printing the outputs of the test results and surefire reports (of the failed tests at least) should be straight forward according to my research. Regarding the release log, I agree on executing it automatically based on the PR's title, this should be done easily in the container as well by modifying the release log file, and then by using a GitHub push action. was (Author: jmakai): Thank you for the inputs [~gezapeti] and [~dionusos]. Acquiring and printing the outputs of the test results and surefire reports (of the failed ones at least) should be straight forward according to my research. Regarding the release log, I agree on executing it automatically based on the PR's title, this should be done easily in the container as well by modifying the release log file, and then by using a GitHub push action. > Build pre-commit pipeline for pull requests. > > > Key: OOZIE-3479 > URL: https://issues.apache.org/jira/browse/OOZIE-3479 > Project: Oozie > Issue Type: Task >Reporter: Gézapeti >Priority: Major > > I think it would be great to accept pull requests for Oozie as well. > We should build the pre-commit system out first to see how it works for us > before updating the site and changing the rules. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Comment Edited] (OOZIE-3479) Build pre-commit pipeline for pull requests.
[ https://issues.apache.org/jira/browse/OOZIE-3479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17651197#comment-17651197 ] Janos Makai edited comment on OOZIE-3479 at 12/22/22 9:40 AM: -- Thank you for the inputs [~gezapeti] and [~dionusos]. Acquiring and printing the outputs of the test results and surefire reports (of the failed ones at least) should be straight forward according to my research. Regarding the release log, I agree on executing it automatically based on the PR's title, this should be done easily in the container as well by modifying the release log file, and then by using a GitHub push action. was (Author: jmakai): Thank you for the inputs [~gezapeti] and [~dionusos]. Acquiring and printing the outputs of the test results and surefire reports (for the failed ones at least) should be straight forward according to my research. Regarding the release log, I agree on executing it automatically based on the PR's title, this should be done easily in the container as well by modifying the release log file, and then by using a GitHub push action. > Build pre-commit pipeline for pull requests. > > > Key: OOZIE-3479 > URL: https://issues.apache.org/jira/browse/OOZIE-3479 > Project: Oozie > Issue Type: Task >Reporter: Gézapeti >Priority: Major > > I think it would be great to accept pull requests for Oozie as well. > We should build the pre-commit system out first to see how it works for us > before updating the site and changing the rules. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Comment Edited] (OOZIE-3479) Build pre-commit pipeline for pull requests.
[ https://issues.apache.org/jira/browse/OOZIE-3479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17044523#comment-17044523 ] Gézapeti edited comment on OOZIE-3479 at 2/25/20 2:44 PM: -- We could execute tests in github actions with no issues. The issue is that we're doing a bunch of other checks, many of which relies on comparing the status of master with the current patch (like counting findbugs issues). Those scripts would have to be modified as we don't start from a clean state unfortunately. If you have ideas on how we can modify our current precommit scripts, I'd be happy to listen was (Author: gezapeti): We could execute tests in github actions with no issues. The issue is that we're doing a bunch of other checks, many of which relies on comparing the status of master with the current patch (like counting findbugs issues). Those scripts would have to be modified as we don't start from a clean state unfortunately. > Build pre-commit pipeline for pull requests. > > > Key: OOZIE-3479 > URL: https://issues.apache.org/jira/browse/OOZIE-3479 > Project: Oozie > Issue Type: Task >Reporter: Gézapeti >Priority: Major > > I think it would be great to accept pull requests for Oozie as well. > We should build the pre-commit system out first to see how it works for us > before updating the site and changing the rules. -- This message was sent by Atlassian Jira (v8.3.4#803005)
