[jira] [Commented] (OOZIE-2473) Connection pool for SMTP connection
[
https://issues.apache.org/jira/browse/OOZIE-2473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16396190#comment-16396190
]
Hadoop QA commented on OOZIE-2473:
--
Testing JIRA OOZIE-2473
Cleaning local git workspace
{color:red}-1{color} Patch failed to apply to head of branch
> Connection pool for SMTP connection
> ---
>
> Key: OOZIE-2473
> URL: https://issues.apache.org/jira/browse/OOZIE-2473
> Project: Oozie
> Issue Type: Bug
>Reporter: Satish Subhashrao Saley
>Assignee: Satish Subhashrao Saley
>Priority: Major
> Fix For: trunk
>
> Attachments: OOZIE-2473-1.patch, OOZIE-2473-1.patch,
> OOZIE-2473-2.patch
>
>
> Currently, to send an email we setup new connection every time which seems
> costly. It would be good to have a connection pool.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OOZIE-2473) Connection pool for SMTP connection
[ https://issues.apache.org/jira/browse/OOZIE-2473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16396171#comment-16396171 ] Hadoop QA commented on OOZIE-2473: -- PreCommit-OOZIE-Build started > Connection pool for SMTP connection > --- > > Key: OOZIE-2473 > URL: https://issues.apache.org/jira/browse/OOZIE-2473 > Project: Oozie > Issue Type: Bug >Reporter: Satish Subhashrao Saley >Assignee: Satish Subhashrao Saley >Priority: Major > Fix For: trunk > > Attachments: OOZIE-2473-1.patch, OOZIE-2473-1.patch, > OOZIE-2473-2.patch > > > Currently, to send an email we setup new connection every time which seems > costly. It would be good to have a connection pool. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OOZIE-2473) Connection pool for SMTP connection
[
https://issues.apache.org/jira/browse/OOZIE-2473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15408698#comment-15408698
]
Hadoop QA commented on OOZIE-2473:
--
Testing JIRA OOZIE-2473
Cleaning local git workspace
{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:red}-1 RAW_PATCH_ANALYSIS{color}
.{color:green}+1{color} the patch does not introduce any @author tags
.{color:green}+1{color} the patch does not introduce any tabs
.{color:red}-1{color} the patch contains 2 line(s) with trailing spaces
.{color:red}-1{color} the patch contains 1 line(s) longer than 132
characters
.{color:green}+1{color} the patch does adds/modifies 2 testcase(s)
{color:green}+1 RAT{color}
.{color:green}+1{color} the patch does not seem to introduce new RAT
warnings
{color:green}+1 JAVADOC{color}
.{color:green}+1{color} the patch does not seem to introduce new Javadoc
warnings
{color:green}+1 COMPILE{color}
.{color:green}+1{color} HEAD compiles
.{color:green}+1{color} patch compiles
.{color:green}+1{color} the patch does not seem to introduce new javac
warnings
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
.{color:green}+1{color} the patch does not change any JPA
Entity/Colum/Basic/Lob/Transient annotations
.{color:green}+1{color} the patch does not modify JPA files
{color:green}+1 TESTS{color}
.Tests run: 1802
{color:green}+1 DISTRO{color}
.{color:green}+1{color} distro tarball builds with the patch
{color:red}*-1 Overall result, please check the reported -1(s)*{color}
The full output of the test-patch run is available at
. https://builds.apache.org/job/oozie-trunk-precommit-build/3194/
> Connection pool for SMTP connection
> ---
>
> Key: OOZIE-2473
> URL: https://issues.apache.org/jira/browse/OOZIE-2473
> Project: Oozie
> Issue Type: Bug
>Reporter: Satish Subhashrao Saley
>Assignee: Satish Subhashrao Saley
> Fix For: 4.4.0
>
> Attachments: OOZIE-2473-1.patch, OOZIE-2473-1.patch,
> OOZIE-2473-2.patch
>
>
> Currently, to send an email we setup new connection every time which seems
> costly. It would be good to have a connection pool.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OOZIE-2473) Connection pool for SMTP connection
[
https://issues.apache.org/jira/browse/OOZIE-2473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15397998#comment-15397998
]
Hadoop QA commented on OOZIE-2473:
--
Testing JIRA OOZIE-2473
Cleaning local git workspace
{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:red}-1 RAW_PATCH_ANALYSIS{color}
.{color:green}+1{color} the patch does not introduce any @author tags
.{color:green}+1{color} the patch does not introduce any tabs
.{color:red}-1{color} the patch contains 2 line(s) with trailing spaces
.{color:red}-1{color} the patch contains 1 line(s) longer than 132
characters
.{color:green}+1{color} the patch does adds/modifies 2 testcase(s)
{color:green}+1 RAT{color}
.{color:green}+1{color} the patch does not seem to introduce new RAT
warnings
{color:green}+1 JAVADOC{color}
.{color:green}+1{color} the patch does not seem to introduce new Javadoc
warnings
{color:red}-1 COMPILE{color}
.{color:red}-1{color} HEAD does not compile
.{color:red}-1{color} patch does not compile
.{color:red}-1{color} the patch seems to introduce 2 new javac warning(s)
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
.{color:green}+1{color} the patch does not change any JPA
Entity/Colum/Basic/Lob/Transient annotations
.{color:green}+1{color} the patch does not modify JPA files
{color:red}-1 TESTS{color} - patch does not compile, cannot run testcases
{color:green}+1 DISTRO{color}
.{color:green}+1{color} distro tarball builds with the patch
{color:red}*-1 Overall result, please check the reported -1(s)*{color}
The full output of the test-patch run is available at
. https://builds.apache.org/job/oozie-trunk-precommit-build/3163/
> Connection pool for SMTP connection
> ---
>
> Key: OOZIE-2473
> URL: https://issues.apache.org/jira/browse/OOZIE-2473
> Project: Oozie
> Issue Type: Bug
>Reporter: Satish Subhashrao Saley
>Assignee: Satish Subhashrao Saley
> Attachments: OOZIE-2473-1.patch, OOZIE-2473-1.patch,
> OOZIE-2473-2.patch
>
>
> Currently, to send an email we setup new connection every time which seems
> costly. It would be good to have a connection pool.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OOZIE-2473) Connection pool for SMTP connection
[
https://issues.apache.org/jira/browse/OOZIE-2473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15396858#comment-15396858
]
Hadoop QA commented on OOZIE-2473:
--
Testing JIRA OOZIE-2473
Cleaning local git workspace
{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:red}-1 RAW_PATCH_ANALYSIS{color}
.{color:green}+1{color} the patch does not introduce any @author tags
.{color:green}+1{color} the patch does not introduce any tabs
.{color:red}-1{color} the patch contains 2 line(s) with trailing spaces
.{color:red}-1{color} the patch contains 1 line(s) longer than 132
characters
.{color:green}+1{color} the patch does adds/modifies 2 testcase(s)
{color:green}+1 RAT{color}
.{color:green}+1{color} the patch does not seem to introduce new RAT
warnings
{color:green}+1 JAVADOC{color}
.{color:green}+1{color} the patch does not seem to introduce new Javadoc
warnings
{color:red}-1 COMPILE{color}
.{color:red}-1{color} HEAD does not compile
.{color:red}-1{color} patch does not compile
.{color:red}-1{color} the patch seems to introduce 2 new javac warning(s)
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
.{color:green}+1{color} the patch does not change any JPA
Entity/Colum/Basic/Lob/Transient annotations
.{color:green}+1{color} the patch does not modify JPA files
{color:red}-1 TESTS{color}
.Tests run: 1801
.Tests failed: 7
.Tests errors: 2
.The patch failed the following testcases:
.
testBundlePauseExtendMaterializesCoordinator(org.apache.oozie.command.bundle.TestBundleChangeXCommand)
. testConnectionDrop(org.apache.oozie.jms.TestJMSJobEventListener)
. testMain(org.apache.oozie.action.hadoop.TestHiveMain)
. testPigScript(org.apache.oozie.action.hadoop.TestPigMainWithOldAPI)
. testPigScript(org.apache.oozie.action.hadoop.TestPigMain)
. testEmbeddedPigWithinPython(org.apache.oozie.action.hadoop.TestPigMain)
. testPig_withNullExternalID(org.apache.oozie.action.hadoop.TestPigMain)
{color:green}+1 DISTRO{color}
.{color:green}+1{color} distro tarball builds with the patch
{color:red}*-1 Overall result, please check the reported -1(s)*{color}
The full output of the test-patch run is available at
. https://builds.apache.org/job/oozie-trunk-precommit-build/3074/
> Connection pool for SMTP connection
> ---
>
> Key: OOZIE-2473
> URL: https://issues.apache.org/jira/browse/OOZIE-2473
> Project: Oozie
> Issue Type: Bug
>Reporter: Satish Subhashrao Saley
>Assignee: Satish Subhashrao Saley
> Attachments: OOZIE-2473-1.patch, OOZIE-2473-1.patch,
> OOZIE-2473-2.patch
>
>
> Currently, to send an email we setup new connection every time which seems
> costly. It would be good to have a connection pool.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OOZIE-2473) Connection pool for SMTP connection
[
https://issues.apache.org/jira/browse/OOZIE-2473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15394954#comment-15394954
]
Hadoop QA commented on OOZIE-2473:
--
Testing JIRA OOZIE-2473
Cleaning local git workspace
{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:red}-1 RAW_PATCH_ANALYSIS{color}
.{color:green}+1{color} the patch does not introduce any @author tags
.{color:green}+1{color} the patch does not introduce any tabs
.{color:red}-1{color} the patch contains 2 line(s) with trailing spaces
.{color:red}-1{color} the patch contains 1 line(s) longer than 132
characters
.{color:green}+1{color} the patch does adds/modifies 2 testcase(s)
{color:green}+1 RAT{color}
.{color:green}+1{color} the patch does not seem to introduce new RAT
warnings
{color:green}+1 JAVADOC{color}
.{color:green}+1{color} the patch does not seem to introduce new Javadoc
warnings
{color:red}-1 COMPILE{color}
.{color:green}+1{color} HEAD compiles
.{color:green}+1{color} patch compiles
.{color:red}-1{color} the patch seems to introduce 2 new javac warning(s)
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
.{color:green}+1{color} the patch does not change any JPA
Entity/Colum/Basic/Lob/Transient annotations
.{color:green}+1{color} the patch does not modify JPA files
{color:red}-1 TESTS{color}
.Tests run: 1802
.Tests failed: 1
.Tests errors: 0
.The patch failed the following testcases:
.
testMessage_withMixedStatus(org.apache.oozie.command.coord.TestAbandonedCoordChecker)
{color:green}+1 DISTRO{color}
.{color:green}+1{color} distro tarball builds with the patch
{color:red}*-1 Overall result, please check the reported -1(s)*{color}
The full output of the test-patch run is available at
. https://builds.apache.org/job/oozie-trunk-precommit-build/3060/
> Connection pool for SMTP connection
> ---
>
> Key: OOZIE-2473
> URL: https://issues.apache.org/jira/browse/OOZIE-2473
> Project: Oozie
> Issue Type: Bug
>Reporter: Satish Subhashrao Saley
>Assignee: Satish Subhashrao Saley
> Attachments: OOZIE-2473-1.patch, OOZIE-2473-1.patch,
> OOZIE-2473-2.patch
>
>
> Currently, to send an email we setup new connection every time which seems
> costly. It would be good to have a connection pool.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OOZIE-2473) Connection pool for SMTP connection
[
https://issues.apache.org/jira/browse/OOZIE-2473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15215127#comment-15215127
]
Hadoop QA commented on OOZIE-2473:
--
Testing JIRA OOZIE-2473
Cleaning local git workspace
{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:green}+1 RAW_PATCH_ANALYSIS{color}
.{color:green}+1{color} the patch does not introduce any @author tags
.{color:green}+1{color} the patch does not introduce any tabs
.{color:green}+1{color} the patch does not introduce any trailing spaces
.{color:green}+1{color} the patch does not introduce any line longer than
132
.{color:green}+1{color} the patch does adds/modifies 2 testcase(s)
{color:green}+1 RAT{color}
.{color:green}+1{color} the patch does not seem to introduce new RAT
warnings
{color:green}+1 JAVADOC{color}
.{color:green}+1{color} the patch does not seem to introduce new Javadoc
warnings
{color:red}-1 COMPILE{color}
.{color:green}+1{color} HEAD compiles
.{color:green}+1{color} patch compiles
.{color:red}-1{color} the patch seems to introduce 2 new javac warning(s)
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
.{color:green}+1{color} the patch does not change any JPA
Entity/Colum/Basic/Lob/Transient annotations
.{color:green}+1{color} the patch does not modify JPA files
{color:red}-1 TESTS{color} - patch does not compile, cannot run testcases
{color:green}+1 DISTRO{color}
.{color:green}+1{color} distro tarball builds with the patch
{color:red}*-1 Overall result, please check the reported -1(s)*{color}
The full output of the test-patch run is available at
. https://builds.apache.org/job/oozie-trunk-precommit-build/2787/
> Connection pool for SMTP connection
> ---
>
> Key: OOZIE-2473
> URL: https://issues.apache.org/jira/browse/OOZIE-2473
> Project: Oozie
> Issue Type: Bug
>Reporter: Satish Subhashrao Saley
>Assignee: Satish Subhashrao Saley
> Attachments: OOZIE-2473-1.patch, OOZIE-2473-1.patch
>
>
> Currently, to send an email we setup new connection every time which seems
> costly. It would be good to have a connection pool.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OOZIE-2473) Connection pool for SMTP connection
[ https://issues.apache.org/jira/browse/OOZIE-2473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15185272#comment-15185272 ] Satish Subhashrao Saley commented on OOZIE-2473: Following are the highlights: 1. Currently, we use Transport.send() static method to send an email. This will create new connection every time. 2. To avoid this, we can use sendMessage() method of Transport class and save the transport object inside pool. 3. Our current javax.mail package is quite old as per (http://mvnrepository.com/artifact/javax.mail/mail/1.4). It was when Sun Microsystems owned Java. I was getting "javax.mail.NoSuchProviderException: Invalid protocol: null" as they changed provider names. new - javax.mail.Provider[TRANSPORT,smtp,com.sun.mail.smtp.SMTPTransport,Oracle] old - javax.mail.Provider[TRANSPORT,smtp,com.sun.mail.smtp.SMTPTransport,Sun Microsystems, Inc] Therefore, we switched to 1.5.5 version (https://java.net/projects/javamail/pages/Home). 4. We have used Apache Commons Pool (https://commons.apache.org/proper/commons-pool/) library for implementing pool. 5. PoolService has been introduced so that in future, anyone can make use of this/any library and implement their own pool. Through PoolService they can access it from anywhere. 6. oozie-default introduces some name-value pairs with respect to SMTP connection pool. > Connection pool for SMTP connection > --- > > Key: OOZIE-2473 > URL: https://issues.apache.org/jira/browse/OOZIE-2473 > Project: Oozie > Issue Type: Bug >Reporter: Satish Subhashrao Saley >Assignee: Satish Subhashrao Saley > Attachments: OOZIE-2473-1.patch > > > Currently, to send an email we setup new connection every time which seems > costly. It would be good to have a connection pool. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OOZIE-2473) Connection pool for SMTP connection
[ https://issues.apache.org/jira/browse/OOZIE-2473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15185262#comment-15185262 ] Satish Subhashrao Saley commented on OOZIE-2473: [Review board link|https://reviews.apache.org/r/44516] > Connection pool for SMTP connection > --- > > Key: OOZIE-2473 > URL: https://issues.apache.org/jira/browse/OOZIE-2473 > Project: Oozie > Issue Type: Bug >Reporter: Satish Subhashrao Saley >Assignee: Satish Subhashrao Saley > Attachments: OOZIE-2473-1.patch > > > Currently, to send an email we setup new connection every time which seems > costly. It would be good to have a connection pool. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
