[jira] [Commented] (OOZIE-3183) Better logging for SshActionExecutor and extended HA capability when calling to remote host

2018-02-14 Thread Peter Cseh (JIRA)

[ 
https://issues.apache.org/jira/browse/OOZIE-3183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16364068#comment-16364068
 ] 

Peter Cseh commented on OOZIE-3183:
---

+1 
Improving logging is always a good idea. Also Oracle's documentation of 
waitFor() states that it uses exitCode() by default, but it should be improved 
by the native implementations.

> Better logging for SshActionExecutor and extended HA capability when calling 
> to remote host
> ---
>
> Key: OOZIE-3183
> URL: https://issues.apache.org/jira/browse/OOZIE-3183
> Project: Oozie
>  Issue Type: Improvement
>  Components: action
>Affects Versions: 5.0.0b1
>Reporter: Andras Piros
>Assignee: Andras Piros
>Priority: Major
> Fix For: 5.0.0
>
> Attachments: OOZIE-3183.001.patch
>
>
> In some High Availability environments, when an SSH action's 
> {{SshActionExecutor#start()}} runs on another node than 
> {{SshActionExecutor#check()}}, it can happen that due to network bandwidth 
> reasons calling {{Process#exitValue()}} is not enough - but calling 
> {{Process#waitFor()}} is better.
> Also, for better error root cause analysis, enhance logging along 
> {{SshActionExecutor}} for the critical parts.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OOZIE-3183) Better logging for SshActionExecutor and extended HA capability when calling to remote host

2018-02-14 Thread Andras Piros (JIRA)

[ 
https://issues.apache.org/jira/browse/OOZIE-3183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16364037#comment-16364037
 ] 

Andras Piros commented on OOZIE-3183:
-

Failing test {{TestHiveActionExecutor#testHiveAction()}} is unrelated. FindBugs 
warnings come from untouched parts. [~gezapeti] can you please review?

> Better logging for SshActionExecutor and extended HA capability when calling 
> to remote host
> ---
>
> Key: OOZIE-3183
> URL: https://issues.apache.org/jira/browse/OOZIE-3183
> Project: Oozie
>  Issue Type: Improvement
>  Components: action
>Affects Versions: 5.0.0b1
>Reporter: Andras Piros
>Assignee: Andras Piros
>Priority: Major
> Fix For: 5.0.0
>
> Attachments: OOZIE-3183.001.patch
>
>
> In some High Availability environments, when an SSH action's 
> {{SshActionExecutor#start()}} runs on another node than 
> {{SshActionExecutor#check()}}, it can happen that due to network bandwidth 
> reasons calling {{Process#exitValue()}} is not enough - but calling 
> {{Process#waitFor()}} is better.
> Also, for better error root cause analysis, enhance logging along 
> {{SshActionExecutor}} for the critical parts.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OOZIE-3183) Better logging for SshActionExecutor and extended HA capability when calling to remote host

2018-02-13 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/OOZIE-3183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16363447#comment-16363447
 ] 

Hadoop QA commented on OOZIE-3183:
--


Testing JIRA OOZIE-3183

Cleaning local git workspace



{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:red}-1 RAW_PATCH_ANALYSIS{color}
.{color:green}+1{color} the patch does not introduce any @author tags
.{color:green}+1{color} the patch does not introduce any tabs
.{color:green}+1{color} the patch does not introduce any trailing spaces
.{color:green}+1{color} the patch does not introduce any line longer than 
132
.{color:red}-1{color} the patch does not add/modify any testcase
{color:green}+1 RAT{color}
.{color:green}+1{color} the patch does not seem to introduce new RAT 
warnings
{color:green}+1 JAVADOC{color}
.{color:green}+1{color} the patch does not seem to introduce new Javadoc 
warnings
.{color:red}WARNING{color}: the current HEAD has 100 Javadoc warning(s)
{color:green}+1 COMPILE{color}
.{color:green}+1{color} HEAD compiles
.{color:green}+1{color} patch compiles
.{color:green}+1{color} the patch does not seem to introduce new javac 
warnings
{color:red}-1{color} There are [4] new bugs found below threshold in total that 
must be fixed.
. {color:green}+1{color} There are no new bugs found in [webapp].
. {color:red}-1{color} There are [4] new bugs found below threshold in [core] 
that must be fixed.
. You can find the FindBugs diff here (look for the red and orange ones): 
core/findbugs-new.html
. The most important FindBugs errors are:
. At SshActionExecutor.java:[line 136]: This usage of 
java/lang/Runtime.exec([Ljava/lang/String;)Ljava/lang/Process; can be 
vulnerable to Command Injection
. At SshActionExecutor.java:[line 133]: At SshActionExecutor.java:[line 132]
. Dead store to log in 
org.apache.oozie.action.ssh.SshActionExecutor.doExecute(String, String, String, 
String[], boolean, WorkflowAction, String, boolean): At 
SshActionExecutor.java:[line 136]
. java/io/File.init(Ljava/lang/String;)V reads a file whose location 
might be specified by user input: At SshActionExecutor.java:[line 418]
. At SshActionExecutor.java:[line 376]: At SshActionExecutor.java:[line 380]
. {color:green}+1{color} There are no new bugs found in [tools].
. {color:green}+1{color} There are no new bugs found in [sharelib/hive2].
. {color:green}+1{color} There are no new bugs found in [sharelib/distcp].
. {color:green}+1{color} There are no new bugs found in [sharelib/hcatalog].
. {color:green}+1{color} There are no new bugs found in [sharelib/streaming].
. {color:green}+1{color} There are no new bugs found in [sharelib/sqoop].
. {color:green}+1{color} There are no new bugs found in [sharelib/oozie].
. {color:green}+1{color} There are no new bugs found in [sharelib/pig].
. {color:green}+1{color} There are no new bugs found in [sharelib/hive].
. {color:green}+1{color} There are no new bugs found in [sharelib/spark].
. {color:green}+1{color} There are no new bugs found in [client].
. {color:green}+1{color} There are no new bugs found in [examples].
. {color:green}+1{color} There are no new bugs found in [docs].
. {color:green}+1{color} There are no new bugs found in [server].
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
.{color:green}+1{color} the patch does not change any JPA 
Entity/Colum/Basic/Lob/Transient annotations
.{color:green}+1{color} the patch does not modify JPA files
{color:red}-1 TESTS{color}
.Tests run: 2092
.Tests failed: 1
.Tests errors: 1

.The patch failed the following testcases:

testHiveAction(org.apache.oozie.action.hadoop.TestHiveActionExecutor)

.Tests failing with errors:
testNewUsingACLs(org.apache.oozie.util.TestZKUtilsWithSecurity)

.{color:orange}Tests failed at first run:{color}
TestJavaActionExecutor#testCredentialsSkip
TestCoordActionsKillXCommand#testActionKillCommandActionNumbers
.For the complete list of flaky tests, see TEST-SUMMARY-FULL files.
{color:green}+1 DISTRO{color}
.{color:green}+1{color} distro tarball builds with the patch 


{color:red}*-1 Overall result, please check the reported -1(s)*{color}

{color:red}. There is at least one warning, please check{color}

The full output of the test-patch run is available at

. https://builds.apache.org/job/PreCommit-OOZIE-Build/396/



> Better logging for SshActionExecutor and extended HA capability when calling 
> to remote host
> ---
>
> Key: OOZIE-3183
> URL: https://issues.apache.org/jira/browse/OOZIE-3183
> Project: Oozie
>  Issue Type: Improvement
>  Components: action
>Affects Versions: 5.0.0b1
>Reporter: Andras Piros
>Assignee: Andras Piros
>

[jira] [Commented] (OOZIE-3183) Better logging for SshActionExecutor and extended HA capability when calling to remote host

2018-02-13 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/OOZIE-3183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16363362#comment-16363362
 ] 

Hadoop QA commented on OOZIE-3183:
--

PreCommit-OOZIE-Build started


> Better logging for SshActionExecutor and extended HA capability when calling 
> to remote host
> ---
>
> Key: OOZIE-3183
> URL: https://issues.apache.org/jira/browse/OOZIE-3183
> Project: Oozie
>  Issue Type: Improvement
>  Components: action
>Affects Versions: 5.0.0b1
>Reporter: Andras Piros
>Assignee: Andras Piros
>Priority: Major
> Fix For: 5.0.0
>
> Attachments: OOZIE-3183.001.patch
>
>
> In some High Availability environments, when an SSH action's 
> {{SshActionExecutor#start()}} runs on another node than 
> {{SshActionExecutor#check()}}, it can happen that due to network bandwidth 
> reasons calling {{Process#exitValue()}} is not enough - but calling 
> {{Process#waitFor()}} is better.
> Also, for better error root cause analysis, enhance logging along 
> {{SshActionExecutor}} for the critical parts.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)