[jira] [Commented] (OOZIE-3608) Coordinator emits wrong WARN about TimeZones
[
https://issues.apache.org/jira/browse/OOZIE-3608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17186799#comment-17186799
]
ASF subversion and git services commented on OOZIE-3608:
Commit 7bcd9819dd825dc906f03978cd4e967c75d108b0 in oozie's branch
refs/heads/master from Gezapeti Cseh
[ https://gitbox.apache.org/repos/asf?p=oozie.git;h=7bcd981 ]
OOZIE-3608 Coordinator emits wrong WARN about TimeZones (larsfrancke via
gezapeti)
> Coordinator emits wrong WARN about TimeZones
>
>
> Key: OOZIE-3608
> URL: https://issues.apache.org/jira/browse/OOZIE-3608
> Project: Oozie
> Issue Type: Bug
> Components: coordinator
>Affects Versions: 5.2.0
>Reporter: Lars Francke
>Assignee: Lars Francke
>Priority: Minor
> Fix For: 5.3.0
>
> Attachments: OOZIE-3608-001.patch, OOZIE-3608-001.patch
>
>
> OOZIE-2867 introduced a log message when the timezone is one that is not DST
> aware.
> Unfortunately the logic for printing the warning is wrong.
> It now prints warnings only for correct timezones:
> {code:java}
> GMT, UTC or Region/City Timezone formats are preferred instead of UTC {code}
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OOZIE-3608) Coordinator emits wrong WARN about TimeZones
[
https://issues.apache.org/jira/browse/OOZIE-3608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17179407#comment-17179407
]
Lars Francke commented on OOZIE-3608:
-
Ah, no worries, as long as the code is there I don't mind.
> Coordinator emits wrong WARN about TimeZones
>
>
> Key: OOZIE-3608
> URL: https://issues.apache.org/jira/browse/OOZIE-3608
> Project: Oozie
> Issue Type: Bug
> Components: coordinator
>Affects Versions: 5.2.0
>Reporter: Lars Francke
>Assignee: Lars Francke
>Priority: Minor
> Fix For: 5.3.0
>
> Attachments: OOZIE-3608-001.patch, OOZIE-3608-001.patch
>
>
> OOZIE-2867 introduced a log message when the timezone is one that is not DST
> aware.
> Unfortunately the logic for printing the warning is wrong.
> It now prints warnings only for correct timezones:
> {code:java}
> GMT, UTC or Region/City Timezone formats are preferred instead of UTC {code}
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OOZIE-3608) Coordinator emits wrong WARN about TimeZones
[
https://issues.apache.org/jira/browse/OOZIE-3608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17179399#comment-17179399
]
Gézapeti commented on OOZIE-3608:
-
It's there, I've just messed up the commit message:
https://github.com/apache/oozie/commit/34b87e1ed8d22315da57acdd108873935c879826
> Coordinator emits wrong WARN about TimeZones
>
>
> Key: OOZIE-3608
> URL: https://issues.apache.org/jira/browse/OOZIE-3608
> Project: Oozie
> Issue Type: Bug
> Components: coordinator
>Affects Versions: 5.2.0
>Reporter: Lars Francke
>Assignee: Lars Francke
>Priority: Minor
> Fix For: 5.3.0
>
> Attachments: OOZIE-3608-001.patch, OOZIE-3608-001.patch
>
>
> OOZIE-2867 introduced a log message when the timezone is one that is not DST
> aware.
> Unfortunately the logic for printing the warning is wrong.
> It now prints warnings only for correct timezones:
> {code:java}
> GMT, UTC or Region/City Timezone formats are preferred instead of UTC {code}
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OOZIE-3608) Coordinator emits wrong WARN about TimeZones
[
https://issues.apache.org/jira/browse/OOZIE-3608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17179396#comment-17179396
]
Lars Francke commented on OOZIE-3608:
-
Thank you [~gezapeti]!
I'm not sure if I'm missing something though but I don't see a commit for this
in master?
> Coordinator emits wrong WARN about TimeZones
>
>
> Key: OOZIE-3608
> URL: https://issues.apache.org/jira/browse/OOZIE-3608
> Project: Oozie
> Issue Type: Bug
> Components: coordinator
>Affects Versions: 5.2.0
>Reporter: Lars Francke
>Assignee: Lars Francke
>Priority: Minor
> Fix For: 5.3.0
>
> Attachments: OOZIE-3608-001.patch, OOZIE-3608-001.patch
>
>
> OOZIE-2867 introduced a log message when the timezone is one that is not DST
> aware.
> Unfortunately the logic for printing the warning is wrong.
> It now prints warnings only for correct timezones:
> {code:java}
> GMT, UTC or Region/City Timezone formats are preferred instead of UTC {code}
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OOZIE-3608) Coordinator emits wrong WARN about TimeZones
[
https://issues.apache.org/jira/browse/OOZIE-3608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17179183#comment-17179183
]
Gézapeti commented on OOZIE-3608:
-
+1, this run is green :)
> Coordinator emits wrong WARN about TimeZones
>
>
> Key: OOZIE-3608
> URL: https://issues.apache.org/jira/browse/OOZIE-3608
> Project: Oozie
> Issue Type: Bug
> Components: coordinator
>Affects Versions: 5.2.0
>Reporter: Lars Francke
>Assignee: Lars Francke
>Priority: Minor
> Attachments: OOZIE-3608-001.patch, OOZIE-3608-001.patch
>
>
> OOZIE-2867 introduced a log message when the timezone is one that is not DST
> aware.
> Unfortunately the logic for printing the warning is wrong.
> It now prints warnings only for correct timezones:
> {code:java}
> GMT, UTC or Region/City Timezone formats are preferred instead of UTC {code}
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OOZIE-3608) Coordinator emits wrong WARN about TimeZones
[
https://issues.apache.org/jira/browse/OOZIE-3608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17179071#comment-17179071
]
Hadoop QA commented on OOZIE-3608:
--
Testing JIRA OOZIE-3608
Cleaning local git workspace
{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:red}-1 RAW_PATCH_ANALYSIS{color}
.{color:green}+1{color} the patch does not introduce any @author tags
.{color:green}+1{color} the patch does not introduce any tabs
.{color:green}+1{color} the patch does not introduce any trailing spaces
.{color:green}+1{color} the patch does not introduce any star imports
.{color:green}+1{color} the patch does not introduce any line longer than
132
.{color:red}-1{color} the patch does not add/modify any testcase
{color:green}+1 RAT{color}
.{color:green}+1{color} the patch does not seem to introduce new RAT
warnings
{color:green}+1 JAVADOC{color}
.{color:green}+1{color} Javadoc generation succeeded with the patch
.{color:green}+1{color} the patch does not seem to introduce new Javadoc
warning(s)
{color:green}+1 COMPILE{color}
.{color:green}+1{color} HEAD compiles
.{color:green}+1{color} patch compiles
.{color:green}+1{color} the patch does not seem to introduce new javac
warnings
{color:red}-1{color} There are [21] new bugs found below threshold in total
that must be fixed.
.{color:green}+1{color} There are no new bugs found in
[fluent-job/fluent-job-api].
.{color:green}+1{color} There are no new bugs found in [docs].
.{color:red}-1{color} There are [6] new bugs found below threshold in
[core] that must be fixed, listing only the first [5] ones.
.You can find the SpotBugs diff here (look for the red and orange ones):
core/findbugs-new.html
.The top [5] most important SpotBugs errors are:
.At BulkJPAExecutor.java:[line 206]: This use of
javax/persistence/EntityManager.createQuery(Ljava/lang/String;)Ljavax/persistence/Query;
can be vulnerable to SQL/JPQL injection
.At BulkJPAExecutor.java:[line 176]: At BulkJPAExecutor.java:[line 175]
.At BulkJPAExecutor.java:[line 205]: At BulkJPAExecutor.java:[line 199]
.This use of
javax/persistence/EntityManager.createQuery(Ljava/lang/String;)Ljavax/persistence/Query;
can be vulnerable to SQL/JPQL injection: At BulkJPAExecutor.java:[line 206]
.At BulkJPAExecutor.java:[line 111]: At BulkJPAExecutor.java:[line 127]
.{color:green}+1{color} There are no new bugs found in [sharelib/spark].
.{color:green}+1{color} There are no new bugs found in [sharelib/git].
.{color:green}+1{color} There are no new bugs found in [sharelib/sqoop].
.{color:green}+1{color} There are no new bugs found in [sharelib/hive2].
.{color:green}+1{color} There are no new bugs found in [sharelib/streaming].
.{color:green}+1{color} There are no new bugs found in [sharelib/pig].
.{color:green}+1{color} There are no new bugs found in [sharelib/oozie].
.{color:green}+1{color} There are no new bugs found in [sharelib/hive].
.{color:green}+1{color} There are no new bugs found in [sharelib/hcatalog].
.{color:green}+1{color} There are no new bugs found in [sharelib/distcp].
.{color:red}-1{color} There are [15] new bugs found below threshold in
[tools] that must be fixed, listing only the first [5] ones.
.You can find the SpotBugs diff here (look for the red and orange ones):
tools/findbugs-new.html
.The top [5] most important SpotBugs errors are:
.At OozieDBCLI.java:[line 584]: This use of
java/sql/Statement.executeUpdate(Ljava/lang/String;)I can be vulnerable to SQL
injection
.At OozieDBCLI.java:[line 574]: At OozieDBCLI.java:[line 573]
.At OozieDBCLI.java:[line 577]: At OozieDBCLI.java:[line 575]
.At OozieDBCLI.java:[line 579]: At OozieDBCLI.java:[line 578]
.At OozieDBCLI.java:[line 584]: At OozieDBCLI.java:[line 581]
.{color:green}+1{color} There are no new bugs found in [server].
.{color:green}+1{color} There are no new bugs found in [client].
.{color:green}+1{color} There are no new bugs found in [examples].
.{color:green}+1{color} There are no new bugs found in [webapp].
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
.{color:green}+1{color} the patch does not change any JPA
Entity/Colum/Basic/Lob/Transient annotations
.{color:green}+1{color} the patch does not modify JPA files
{color:green}+1 TESTS{color}
.Tests run: 3215
.{color:orange}Tests failed at first run:{color}
TestBlockingInputStream#testFastWritingBlockingInputStream
TestPriorityDelayQueue#testPeek
.For the complete list of flaky tests, see TEST-SUMMARY-FULL files.
{color:green}+1 DISTRO{color}
.{color:green}+1{color} distro tarball builds with the patch
{color:green}+1 MODERNIZER{color}
{color:red}*-1 Overall result, please check the reported -1(s)*{color}
The full out
[jira] [Commented] (OOZIE-3608) Coordinator emits wrong WARN about TimeZones
[
https://issues.apache.org/jira/browse/OOZIE-3608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17178991#comment-17178991
]
Hadoop QA commented on OOZIE-3608:
--
PreCommit-OOZIE-Build started
> Coordinator emits wrong WARN about TimeZones
>
>
> Key: OOZIE-3608
> URL: https://issues.apache.org/jira/browse/OOZIE-3608
> Project: Oozie
> Issue Type: Bug
> Components: coordinator
>Affects Versions: 5.2.0
>Reporter: Lars Francke
>Assignee: Lars Francke
>Priority: Minor
> Attachments: OOZIE-3608-001.patch, OOZIE-3608-001.patch
>
>
> OOZIE-2867 introduced a log message when the timezone is one that is not DST
> aware.
> Unfortunately the logic for printing the warning is wrong.
> It now prints warnings only for correct timezones:
> {code:java}
> GMT, UTC or Region/City Timezone formats are preferred instead of UTC {code}
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OOZIE-3608) Coordinator emits wrong WARN about TimeZones
[
https://issues.apache.org/jira/browse/OOZIE-3608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17178984#comment-17178984
]
Lars Francke commented on OOZIE-3608:
-
Thanks! I'll happily take that deal ;)
> Coordinator emits wrong WARN about TimeZones
>
>
> Key: OOZIE-3608
> URL: https://issues.apache.org/jira/browse/OOZIE-3608
> Project: Oozie
> Issue Type: Bug
> Components: coordinator
>Affects Versions: 5.2.0
>Reporter: Lars Francke
>Assignee: Lars Francke
>Priority: Minor
> Attachments: OOZIE-3608-001.patch, OOZIE-3608-001.patch
>
>
> OOZIE-2867 introduced a log message when the timezone is one that is not DST
> aware.
> Unfortunately the logic for printing the warning is wrong.
> It now prints warnings only for correct timezones:
> {code:java}
> GMT, UTC or Region/City Timezone formats are preferred instead of UTC {code}
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OOZIE-3608) Coordinator emits wrong WARN about TimeZones
[
https://issues.apache.org/jira/browse/OOZIE-3608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17178981#comment-17178981
]
Gézapeti commented on OOZIE-3608:
-
Thanks for the patch [~larsfrancke]! I'll use this ticket to test out the
migration of our precommit testing to the new ASF Jenkins :)
To compensate for the possible spam from Jenkins, I'll do a review of your
patch. :)
> Coordinator emits wrong WARN about TimeZones
>
>
> Key: OOZIE-3608
> URL: https://issues.apache.org/jira/browse/OOZIE-3608
> Project: Oozie
> Issue Type: Bug
> Components: coordinator
>Affects Versions: 5.2.0
>Reporter: Lars Francke
>Assignee: Lars Francke
>Priority: Minor
> Attachments: OOZIE-3608-001.patch
>
>
> OOZIE-2867 introduced a log message when the timezone is one that is not DST
> aware.
> Unfortunately the logic for printing the warning is wrong.
> It now prints warnings only for correct timezones:
> {code:java}
> GMT, UTC or Region/City Timezone formats are preferred instead of UTC {code}
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OOZIE-3608) Coordinator emits wrong WARN about TimeZones
[
https://issues.apache.org/jira/browse/OOZIE-3608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17176088#comment-17176088
]
Lars Francke commented on OOZIE-3608:
-
The Jenkins run was aborted but this can't be due to this patch as it'll only
affect a log message.
It timed out.
> Coordinator emits wrong WARN about TimeZones
>
>
> Key: OOZIE-3608
> URL: https://issues.apache.org/jira/browse/OOZIE-3608
> Project: Oozie
> Issue Type: Bug
> Components: coordinator
>Affects Versions: 5.2.0
>Reporter: Lars Francke
>Assignee: Lars Francke
>Priority: Minor
> Attachments: OOZIE-3608-001.patch
>
>
> OOZIE-2867 introduced a log message when the timezone is one that is not DST
> aware.
> Unfortunately the logic for printing the warning is wrong.
> It now prints warnings only for correct timezones:
> {code:java}
> GMT, UTC or Region/City Timezone formats are preferred instead of UTC {code}
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OOZIE-3608) Coordinator emits wrong WARN about TimeZones
[
https://issues.apache.org/jira/browse/OOZIE-3608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17175595#comment-17175595
]
Hadoop QA commented on OOZIE-3608:
--
PreCommit-OOZIE-Build started
> Coordinator emits wrong WARN about TimeZones
>
>
> Key: OOZIE-3608
> URL: https://issues.apache.org/jira/browse/OOZIE-3608
> Project: Oozie
> Issue Type: Bug
> Components: coordinator
>Affects Versions: 5.2.0
>Reporter: Lars Francke
>Assignee: Lars Francke
>Priority: Minor
> Attachments: OOZIE-3608-001.patch
>
>
> OOZIE-2867 introduced a log message when the timezone is one that is not DST
> aware.
> Unfortunately the logic for printing the warning is wrong.
> It now prints warnings only for correct timezones:
> {code:java}
> GMT, UTC or Region/City Timezone formats are preferred instead of UTC {code}
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
