[jira] [Commented] (OOZIE-3619) maxHistory default value set to 720 days assuming it to be hours which is not correct
[ https://issues.apache.org/jira/browse/OOZIE-3619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17329938#comment-17329938 ] Bimalendu Choudhary commented on OOZIE-3619: Actually I was wrong, the default setting in the log4j.properties is set to roll every hour so 720 seems to be correct value. I think some how in my testing the values were set to roll every day which I assumed is default setting and wen all the way lookin why the default value is set to 720. We can clos this. > maxHistory default value set to 720 days assuming it to be hours which is not > correct > - > > Key: OOZIE-3619 > URL: https://issues.apache.org/jira/browse/OOZIE-3619 > Project: Oozie > Issue Type: Bug >Affects Versions: 5.2.0 >Reporter: Bimalendu Choudhary >Priority: Minor > Fix For: trunk > > Attachments: oozie-3619.patch > > > The default value of maxHistory in OozieRollingPolicy.java is set to 720 and > the comments describes it as being hour. However maxHistory is maximum number > of rolled files which can be kept and rest gets deleted. For days, 720 is a > huge number. > > We should change it to default value of 30 which is equivalent to 30 days and > change the comments to describe it as number of rolled files and hours. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OOZIE-3619) maxHistory default value set to 720 days assuming it to be hours which is not correct
[
https://issues.apache.org/jira/browse/OOZIE-3619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17329923#comment-17329923
]
Junfan Zhang commented on OOZIE-3619:
-
Nice catch. But i think the {{oozie-log4j.properties}} should also be changed.
> maxHistory default value set to 720 days assuming it to be hours which is not
> correct
> -
>
> Key: OOZIE-3619
> URL: https://issues.apache.org/jira/browse/OOZIE-3619
> Project: Oozie
> Issue Type: Bug
>Affects Versions: 5.2.0
>Reporter: Bimalendu Choudhary
>Priority: Minor
> Fix For: trunk
>
> Attachments: oozie-3619.patch
>
>
> The default value of maxHistory in OozieRollingPolicy.java is set to 720 and
> the comments describes it as being hour. However maxHistory is maximum number
> of rolled files which can be kept and rest gets deleted. For days, 720 is a
> huge number.
>
> We should change it to default value of 30 which is equivalent to 30 days and
> change the comments to describe it as number of rolled files and hours.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OOZIE-3619) maxHistory default value set to 720 days assuming it to be hours which is not correct
[
https://issues.apache.org/jira/browse/OOZIE-3619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17329437#comment-17329437
]
Hadoop QA commented on OOZIE-3619:
--
Testing JIRA OOZIE-3619
Cleaning local git workspace
{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:red}-1 RAW_PATCH_ANALYSIS{color}
.{color:green}+1{color} the patch does not introduce any @author tags
.{color:green}+1{color} the patch does not introduce any tabs
.{color:green}+1{color} the patch does not introduce any trailing spaces
.{color:green}+1{color} the patch does not introduce any star imports
.{color:green}+1{color} the patch does not introduce any line longer than
132
.{color:red}-1{color} the patch does not add/modify any testcase
{color:green}+1 RAT{color}
.{color:green}+1{color} the patch does not seem to introduce new RAT
warnings
{color:green}+1 JAVADOC{color}
.{color:green}+1{color} Javadoc generation succeeded with the patch
.{color:green}+1{color} the patch does not seem to introduce new Javadoc
warning(s)
{color:green}+1 COMPILE{color}
.{color:green}+1{color} HEAD compiles
.{color:green}+1{color} patch compiles
.{color:green}+1{color} the patch does not seem to introduce new javac
warnings
{color:green}+1{color} There are no new bugs found in total.
.{color:green}+1{color} There are no new bugs found in
[fluent-job/fluent-job-api].
.{color:green}+1{color} There are no new bugs found in [docs].
.{color:green}+1{color} There are no new bugs found in [core].
.{color:green}+1{color} There are no new bugs found in [sharelib/spark].
.{color:green}+1{color} There are no new bugs found in [sharelib/git].
.{color:green}+1{color} There are no new bugs found in [sharelib/sqoop].
.{color:green}+1{color} There are no new bugs found in [sharelib/hive2].
.{color:green}+1{color} There are no new bugs found in [sharelib/streaming].
.{color:green}+1{color} There are no new bugs found in [sharelib/pig].
.{color:green}+1{color} There are no new bugs found in [sharelib/oozie].
.{color:green}+1{color} There are no new bugs found in [sharelib/hive].
.{color:green}+1{color} There are no new bugs found in [sharelib/hcatalog].
.{color:green}+1{color} There are no new bugs found in [sharelib/distcp].
.{color:green}+1{color} There are no new bugs found in [tools].
.{color:green}+1{color} There are no new bugs found in [server].
.{color:green}+1{color} There are no new bugs found in [client].
.{color:green}+1{color} There are no new bugs found in [examples].
.{color:green}+1{color} There are no new bugs found in [webapp].
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
.{color:green}+1{color} the patch does not change any JPA
Entity/Colum/Basic/Lob/Transient annotations
.{color:green}+1{color} the patch does not modify JPA files
{color:green}+1 TESTS{color}
.Tests run: 3215
{color:green}+1 DISTRO{color}
.{color:green}+1{color} distro tarball builds with the patch
{color:green}+1 MODERNIZER{color}
{color:red}*-1 Overall result, please check the reported -1(s)*{color}
The full output of the test-patch run is available at
. https://ci-hadoop.apache.org/job/PreCommit-OOZIE-Build/11/
> maxHistory default value set to 720 days assuming it to be hours which is not
> correct
> -
>
> Key: OOZIE-3619
> URL: https://issues.apache.org/jira/browse/OOZIE-3619
> Project: Oozie
> Issue Type: Bug
>Affects Versions: 5.2.0
>Reporter: Bimalendu Choudhary
>Priority: Minor
> Fix For: trunk
>
> Attachments: oozie-3619.patch
>
>
> The default value of maxHistory in OozieRollingPolicy.java is set to 720 and
> the comments describes it as being hour. However maxHistory is maximum number
> of rolled files which can be kept and rest gets deleted. For days, 720 is a
> huge number.
>
> We should change it to default value of 30 which is equivalent to 30 days and
> change the comments to describe it as number of rolled files and hours.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OOZIE-3619) maxHistory default value set to 720 days assuming it to be hours which is not correct
[ https://issues.apache.org/jira/browse/OOZIE-3619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17329371#comment-17329371 ] Hadoop QA commented on OOZIE-3619: -- PreCommit-OOZIE-Build started > maxHistory default value set to 720 days assuming it to be hours which is not > correct > - > > Key: OOZIE-3619 > URL: https://issues.apache.org/jira/browse/OOZIE-3619 > Project: Oozie > Issue Type: Bug >Affects Versions: 5.2.0 >Reporter: Bimalendu Choudhary >Priority: Minor > Fix For: trunk > > Attachments: oozie-3619.patch > > > The default value of maxHistory in OozieRollingPolicy.java is set to 720 and > the comments describes it as being hour. However maxHistory is maximum number > of rolled files which can be kept and rest gets deleted. For days, 720 is a > huge number. > > We should change it to default value of 30 which is equivalent to 30 days and > change the comments to describe it as number of rolled files and hours. -- This message was sent by Atlassian Jira (v8.3.4#803005)
