[jira] [Commented] (OOZIE-3689) Remove usage of commons-httpclient due to EOL
[ https://issues.apache.org/jira/browse/OOZIE-3689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17649193#comment-17649193 ] Janos Makai commented on OOZIE-3689: Thank you [~dionusos] > Remove usage of commons-httpclient due to EOL > - > > Key: OOZIE-3689 > URL: https://issues.apache.org/jira/browse/OOZIE-3689 > Project: Oozie > Issue Type: Improvement >Affects Versions: 5.2.1 >Reporter: Janos Makai >Assignee: Janos Makai >Priority: Major > Fix For: 5.3.0 > > Attachments: OOZIE-3689-001.patch > > > Currently usages of `commons-httpclient` can be found > `TestHAShareLibService`'s unit test, however, `commons-httpclient` is in EOL > state. > Oozie at this moment does not pull it in directly, but used from a transitive > dependency. > The goal of this ticket is to modify the test inside `TestHAShareLibService` > not to use `commons-httpclient`. > NOTE: this change only introduces a unit test change and does not contains > production change. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OOZIE-3689) Remove usage of commons-httpclient due to EOL
[ https://issues.apache.org/jira/browse/OOZIE-3689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17648433#comment-17648433 ] ASF subversion and git services commented on OOZIE-3689: Commit 2d9ab40595f5df0019bf9285f40c33bfdf5499c9 in oozie's branch refs/heads/master from Denes Bodo [ https://gitbox.apache.org/repos/asf?p=oozie.git;h=2d9ab4059 ] OOZIE-3689 Remove usage of commons-httpclient due to EOL (jmakai via dionusos) > Remove usage of commons-httpclient due to EOL > - > > Key: OOZIE-3689 > URL: https://issues.apache.org/jira/browse/OOZIE-3689 > Project: Oozie > Issue Type: Improvement >Affects Versions: 5.2.1 >Reporter: Janos Makai >Assignee: Janos Makai >Priority: Major > Attachments: OOZIE-3689-001.patch > > > Currently usages of `commons-httpclient` can be found > `TestHAShareLibService`'s unit test, however, `commons-httpclient` is in EOL > state. > Oozie at this moment does not pull it in directly, but used from a transitive > dependency. > The goal of this ticket is to modify the test inside `TestHAShareLibService` > not to use `commons-httpclient`. > NOTE: this change only introduces a unit test change and does not contains > production change. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OOZIE-3689) Remove usage of commons-httpclient due to EOL
[ https://issues.apache.org/jira/browse/OOZIE-3689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17648195#comment-17648195 ] Janos Makai commented on OOZIE-3689: Hi [~dionusos] could you please review the provided patch? The issues found by SpotBugs are unrelated to this change. > Remove usage of commons-httpclient due to EOL > - > > Key: OOZIE-3689 > URL: https://issues.apache.org/jira/browse/OOZIE-3689 > Project: Oozie > Issue Type: Improvement >Affects Versions: 5.2.1 >Reporter: Janos Makai >Assignee: Janos Makai >Priority: Major > Attachments: OOZIE-3689-001.patch > > > Currently usages of `commons-httpclient` can be found > `TestHAShareLibService`'s unit test, however, `commons-httpclient` is in EOL > state. > Oozie at this moment does not pull it in directly, but used from a transitive > dependency. > The goal of this ticket is to modify the test inside `TestHAShareLibService` > not to use `commons-httpclient`. > NOTE: this change only introduces a unit test change and does not contains > production change. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OOZIE-3689) Remove usage of commons-httpclient due to EOL
[
https://issues.apache.org/jira/browse/OOZIE-3689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17648194#comment-17648194
]
Hadoop QA commented on OOZIE-3689:
--
Testing JIRA OOZIE-3689
Cleaning local git workspace
{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:green}+1 RAW_PATCH_ANALYSIS{color}
.{color:green}+1{color} the patch does not introduce any @author tags
.{color:green}+1{color} the patch does not introduce any tabs
.{color:green}+1{color} the patch does not introduce any trailing spaces
.{color:green}+1{color} the patch does not introduce any star imports
.{color:green}+1{color} the patch does not introduce any line longer than
132
.{color:green}+1{color} the patch adds/modifies 1 testcase(s)
{color:green}+1 RAT{color}
.{color:green}+1{color} the patch does not seem to introduce new RAT
warnings
{color:green}+1 JAVADOC{color}
.{color:green}+1{color} Javadoc generation succeeded with the patch
.{color:green}+1{color} the patch does not seem to introduce new Javadoc
warning(s)
{color:green}+1 COMPILE{color}
.{color:green}+1{color} HEAD compiles
.{color:green}+1{color} patch compiles
.{color:green}+1{color} the patch does not seem to introduce new javac
warnings
{color:red}-1{color} There are [1] new bugs found below threshold in total that
must be fixed.
.{color:green}+1{color} There are no new bugs found in [examples].
.{color:green}+1{color} There are no new bugs found in
[fluent-job/fluent-job-api].
.{color:green}+1{color} There are no new bugs found in [sharelib/hive].
.{color:green}+1{color} There are no new bugs found in [sharelib/hive2].
.{color:green}+1{color} There are no new bugs found in [sharelib/git].
.{color:green}+1{color} There are no new bugs found in [sharelib/distcp].
.{color:green}+1{color} There are no new bugs found in [sharelib/hcatalog].
.{color:green}+1{color} There are no new bugs found in [sharelib/sqoop].
.{color:green}+1{color} There are no new bugs found in [sharelib/spark].
.{color:red}-1{color} There are [1] new bugs found below threshold in
[sharelib/oozie] that must be fixed.
.You can find the SpotBugs diff here (look for the red and orange ones):
sharelib/oozie/findbugs-new.html
.The most important SpotBugs errors are:
.At ShellMain.java:[line 93]: This usage of
java/lang/ProcessBuilder.(Ljava/util/List;)V can be vulnerable to
Command Injection
.At ShellMain.java:[line 91]: At ShellMain.java:[line 90]
.At ShellMain.java:[line 92]
.{color:green}+1{color} There are no new bugs found in [sharelib/pig].
.{color:green}+1{color} There are no new bugs found in [sharelib/streaming].
.{color:green}+1{color} There are no new bugs found in [server].
.{color:green}+1{color} There are no new bugs found in [docs].
.{color:green}+1{color} There are no new bugs found in [webapp].
.{color:green}+1{color} There are no new bugs found in [core].
.{color:green}+1{color} There are no new bugs found in [tools].
.{color:green}+1{color} There are no new bugs found in [client].
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
.{color:green}+1{color} the patch does not change any JPA
Entity/Colum/Basic/Lob/Transient annotations
.{color:green}+1{color} the patch does not modify JPA files
{color:green}+1 TESTS{color}
.Tests run: 3259
.{color:orange}Tests failed at first run:{color}
TestJMSAccessorService#testConnectionRetry
.For the complete list of flaky tests, see TEST-SUMMARY-FULL files.
{color:green}+1 DISTRO{color}
.{color:green}+1{color} distro tarball builds with the patch
{color:green}+1 MODERNIZER{color}
{color:red}*-1 Overall result, please check the reported -1(s)*{color}
The full output of the test-patch run is available at
. https://ci-hadoop.apache.org/job/PreCommit-OOZIE-Build/172/
> Remove usage of commons-httpclient due to EOL
> -
>
> Key: OOZIE-3689
> URL: https://issues.apache.org/jira/browse/OOZIE-3689
> Project: Oozie
> Issue Type: Improvement
>Affects Versions: 5.2.1
>Reporter: Janos Makai
>Assignee: Janos Makai
>Priority: Major
> Attachments: OOZIE-3689-001.patch
>
>
> Currently usages of `commons-httpclient` can be found
> `TestHAShareLibService`'s unit test, however, `commons-httpclient` is in EOL
> state.
> Oozie at this moment does not pull it in directly, but used from a transitive
> dependency.
> The goal of this ticket is to modify the test inside `TestHAShareLibService`
> not to use `commons-httpclient`.
> NOTE: this change only introduces a unit test change and does not contains
> production change.
--
This message was sent by Atlassian Jira
(v8.20.10#820010
[jira] [Commented] (OOZIE-3689) Remove usage of commons-httpclient due to EOL
[ https://issues.apache.org/jira/browse/OOZIE-3689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17648151#comment-17648151 ] Hadoop QA commented on OOZIE-3689: -- PreCommit-OOZIE-Build started > Remove usage of commons-httpclient due to EOL > - > > Key: OOZIE-3689 > URL: https://issues.apache.org/jira/browse/OOZIE-3689 > Project: Oozie > Issue Type: Improvement >Affects Versions: 5.2.1 >Reporter: Janos Makai >Assignee: Janos Makai >Priority: Major > Attachments: OOZIE-3689-001.patch > > > Currently usages of `commons-httpclient` can be found > `TestHAShareLibService`'s unit test, however, `commons-httpclient` is in EOL > state. > Oozie at this moment does not pull it in directly, but used from a transitive > dependency. > The goal of this ticket is to modify the test inside `TestHAShareLibService` > not to use `commons-httpclient`. > NOTE: this change only introduces a unit test change and does not contains > production change. -- This message was sent by Atlassian Jira (v8.20.10#820010)
