Re: Review Request 47837: OOZIE-2501 ZK reentrant lock doesn't work for few cases

2016-09-22 Thread Purshotam Shah
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47837/ --- (Updated Sept. 22, 2016, 5:55 p.m.) Review request for oozie. Bugs:

Re: Review Request 47837: OOZIE-2501 ZK reentrant lock doesn't work for few cases

2016-09-22 Thread Purshotam Shah
> On Aug. 8, 2016, 11:58 a.m., Peter Bacsko wrote: > > core/src/test/java/org/apache/oozie/lock/TestMemoryLocks.java, line 352 > > > > > > Yes I understand that you want to make sure that weakrefs are cleared > >

Re: Review Request 47837: OOZIE-2501 ZK reentrant lock doesn't work for few cases

2016-08-08 Thread Peter Bacsko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47837/#review145089 --- core/src/test/java/org/apache/oozie/lock/TestMemoryLocks.java

Re: Review Request 47837: OOZIE-2501 ZK reentrant lock doesn't work for few cases

2016-08-04 Thread Purshotam Shah
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47837/#review144833 --- core/src/test/java/org/apache/oozie/lock/TestMemoryLocks.java

Re: Review Request 47837: OOZIE-2501 ZK reentrant lock doesn't work for few cases

2016-08-03 Thread Peter Bacsko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47837/#review144690 --- core/src/test/java/org/apache/oozie/lock/TestMemoryLocks.java

Re: Review Request 47837: OOZIE-2501 ZK reentrant lock doesn't work for few cases

2016-08-03 Thread Rohini Palaniswamy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47837/#review144632 --- Ship it! Ship It! - Rohini Palaniswamy On Aug. 3, 2016,

Re: Review Request 47837: OOZIE-2501 ZK reentrant lock doesn't work for few cases

2016-08-03 Thread Purshotam Shah
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47837/ --- (Updated Aug. 3, 2016, 4:56 p.m.) Review request for oozie. Bugs: OOZIE-2501

Re: Review Request 47837: OOZIE-2501 ZK reentrant lock doesn't work for few cases

2016-08-03 Thread Purshotam Shah
> On July 13, 2016, 11:32 p.m., Rohini Palaniswamy wrote: > > core/src/main/java/org/apache/oozie/command/wf/ActionStartXCommand.java, > > line 405 > > > > > > This code seems to be for a different issue. Can you

Re: Review Request 47837: OOZIE-2501 ZK reentrant lock doesn't work for few cases

2016-08-03 Thread Purshotam Shah
> On Aug. 1, 2016, 7:55 p.m., Rohini Palaniswamy wrote: > > core/src/main/java/org/apache/oozie/lock/MemoryLocks.java, lines 90-92 > > > > > > This is redundant. lockEntry cannot be null here.

Re: Review Request 47837: OOZIE-2501 ZK reentrant lock doesn't work for few cases

2016-08-01 Thread Rohini Palaniswamy
> On July 13, 2016, 11:32 p.m., Rohini Palaniswamy wrote: > > core/src/main/java/org/apache/oozie/command/wf/ActionStartXCommand.java, > > line 405 > > > > > > This code seems to be for a different issue. Can you

Re: Review Request 47837: OOZIE-2501 ZK reentrant lock doesn't work for few cases

2016-08-01 Thread Rohini Palaniswamy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47837/#review144379 --- core/src/main/java/org/apache/oozie/lock/MemoryLocks.java (lines

Re: Review Request 47837: OOZIE-2501 ZK reentrant lock doesn't work for few cases

2016-08-01 Thread Purshotam Shah
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47837/ --- (Updated Aug. 1, 2016, 6:23 p.m.) Review request for oozie. Bugs: OOZIE-2501

Re: Review Request 47837: OOZIE-2501 ZK reentrant lock doesn't work for few cases

2016-07-29 Thread Purshotam Shah
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47837/ --- (Updated July 29, 2016, 9:16 p.m.) Review request for oozie. Bugs:

Re: Review Request 47837: OOZIE-2501 ZK reentrant lock doesn't work for few cases

2016-07-29 Thread Purshotam Shah
> On July 13, 2016, 11:32 p.m., Rohini Palaniswamy wrote: > > core/src/main/java/org/apache/oozie/service/MemoryLocksService.java, line 33 > > > > > > protected It is used for MemoryLocks which is not subcalss of

Re: Review Request 47837: OOZIE-2501 ZK reentrant lock doesn't work for few cases

2016-07-13 Thread Rohini Palaniswamy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47837/#review142151 ---