Re: Review Request 65606: OOZIE-2814 OYA: Update example workflows to newest schemas

2018-02-14 Thread Attila Sasvari via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65606/ --- (Updated Feb. 14, 2018, 11:13 a.m.) Review request for oozie. Changes

Re: Review Request 65606: OOZIE-2814 OYA: Update example workflows to newest schemas

2018-02-14 Thread Attila Sasvari via Review Board
> On Feb. 14, 2018, 10:50 a.m., Peter Bacsko wrote: > > core/src/test/java/org/apache/oozie/action/hadoop/TestJavaActionExecutor.java > > Lines 2349 (patched) > > > > > > Can't we accidentally skip the PREP phase?

Re: Review Request 65606: OOZIE-2814 OYA: Update example workflows to newest schemas

2018-02-14 Thread Peter Bacsko via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65606/#review197501 ---

Re: Review Request 65606: OOZIE-2814 OYA: Update example workflows to newest schemas

2018-02-14 Thread Peter Bacsko via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65606/#review197500 ---

Re: Review Request 65606: OOZIE-2814 OYA: Update example workflows to newest schemas

2018-02-14 Thread Peter Cseh via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65606/#review197498 ---

Re: Review Request 65606: OOZIE-2814 OYA: Update example workflows to newest schemas

2018-02-13 Thread András Piros via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65606/#review197436 --- Ship it! Ship It! - András Piros On Feb. 12, 2018, 4:19

Re: Review Request 65606: OOZIE-2814 OYA: Update example workflows to newest schemas

2018-02-13 Thread András Piros via Review Board
> On Feb. 12, 2018, 8:05 p.m., András Piros wrote: > > core/src/main/java/org/apache/oozie/workflow/lite/LiteWorkflowAppParser.java > > Line 460 (original), 465-467 (patched) > > > > > > This is pretty hard to

Re: Review Request 65606: OOZIE-2814 OYA: Update example workflows to newest schemas

2018-02-13 Thread Attila Sasvari via Review Board
> On Feb. 12, 2018, 8:05 p.m., András Piros wrote: > > core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java > > Lines 266-271 (patched) > > > > > > What happens if both `resource-manager` and

Re: Review Request 65606: OOZIE-2814 OYA: Update example workflows to newest schemas

2018-02-13 Thread Peter Cseh via Review Board
> On Feb. 12, 2018, 8:05 p.m., András Piros wrote: > > core/src/test/java/org/apache/oozie/workflow/lite/TestLiteWorkflowAppParser.java > > Lines 1680 (patched) > > > > > > Would give a catchier name and remove

Re: Review Request 65606: OOZIE-2814 OYA: Update example workflows to newest schemas

2018-02-12 Thread András Piros via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65606/#review197301 ---

Re: Review Request 65606: OOZIE-2814 OYA: Update example workflows to newest schemas

2018-02-12 Thread Attila Sasvari via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65606/ --- (Updated Feb. 12, 2018, 4:19 p.m.) Review request for oozie. Repository:

Review Request 65606: OOZIE-2814 OYA: Update example workflows to newest schemas

2018-02-12 Thread Attila Sasvari via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65606/ --- Review request for oozie. Repository: oozie-git Description ---