Re: Review Request 66084: Oozie-core fails with checkstyle errors.

2018-03-27 Thread András Piros via Review Board 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66084/#review200041
---


Ship it!




Ship It!

- András Piros


On March 20, 2018, 5:36 a.m., Alisha Prabhu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66084/
> ---
> 
> (Updated March 20, 2018, 5:36 a.m.)
> 
> 
> Review request for oozie.
> 
> 
> Bugs: OOZIE-3176
> https://issues.apache.org/jira/browse/OOZIE-3176
> 
> 
> Repository: oozie-git
> 
> 
> Description
> ---
> 
> There are multiple checkstyle violations in the Oozie-core module.
> Maven command used is mvn clean install -DskipTests
> 
> 
> Diffs
> -
> 
>   core/src/main/java/org/apache/oozie/BundleActionBean.java eeec549 
>   core/src/main/java/org/apache/oozie/BundleJobBean.java dec0967 
>   core/src/main/java/org/apache/oozie/CoordinatorActionBean.java ddec1e6 
>   core/src/main/java/org/apache/oozie/CoordinatorJobBean.java 5999f40 
>   core/src/main/java/org/apache/oozie/CoordinatorJobInfo.java 04c5bc9 
>   core/src/main/java/org/apache/oozie/DagELFunctions.java 22ac624 
>   core/src/main/java/org/apache/oozie/SLAEventBean.java b30867b 
>   core/src/main/java/org/apache/oozie/WorkflowActionBean.java 6b05b89 
>   core/src/main/java/org/apache/oozie/WorkflowJobBean.java cb06bec 
>   core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java 
> 122dfd0 
>   core/src/main/java/org/apache/oozie/client/rest/JsonBean.java c8bd7c2 
>   
> core/src/main/java/org/apache/oozie/command/bundle/BundleJobSuspendXCommand.java
>  669ac5e 
>   
> core/src/main/java/org/apache/oozie/command/coord/CoordActionInputCheckXCommand.java
>  179cc45 
>   
> core/src/main/java/org/apache/oozie/command/coord/CoordActionStartXCommand.java
>  16d7036 
>   core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java 
> ff7bf8a 
>   core/src/main/java/org/apache/oozie/command/coord/CoordCommandUtils.java 
> fbc6152 
>   
> core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java
>  2b91253 
>   
> core/src/main/java/org/apache/oozie/command/coord/CoordPushDependencyCheckXCommand.java
>  1e864ea 
>   core/src/main/java/org/apache/oozie/command/coord/CoordResumeXCommand.java 
> 1998924 
>   core/src/main/java/org/apache/oozie/command/coord/CoordSubmitXCommand.java 
> 42bdc99 
>   core/src/main/java/org/apache/oozie/command/coord/CoordSuspendXCommand.java 
> 1195ef0 
>   core/src/main/java/org/apache/oozie/command/wf/ActionEndXCommand.java 
> 86ee1cc 
>   core/src/main/java/org/apache/oozie/command/wf/ActionKillXCommand.java 
> 61891b8 
>   core/src/main/java/org/apache/oozie/command/wf/ActionStartXCommand.java 
> 71c29cd 
>   core/src/main/java/org/apache/oozie/command/wf/ActionXCommand.java 29ccd32 
>   core/src/main/java/org/apache/oozie/coord/CoordUtils.java 2874bf6 
>   core/src/main/java/org/apache/oozie/coord/HCatELFunctions.java f40f406 
>   
> core/src/main/java/org/apache/oozie/executor/jpa/BundleJobsGetRunningOrPendingJPAExecutor.java
>  18ceb10 
>   
> core/src/main/java/org/apache/oozie/executor/jpa/CoordActionRemoveJPAExecutor.java
>  02a4f68 
>   
> core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetRunningActionsCountJPAExecutor.java
>  274b3c1 
>   
> core/src/main/java/org/apache/oozie/executor/jpa/WorkflowActionRetryManualGetJPAExecutor.java
>  51449db 
>   
> core/src/main/java/org/apache/oozie/executor/jpa/WorkflowInfoWithActionsSubsetGetJPAExecutor.java
>  43c7d08 
>   
> core/src/main/java/org/apache/oozie/executor/jpa/WorkflowJobsBasicInfoFromParentId.java
>  4b8adfb 
>   core/src/main/java/org/apache/oozie/service/AuthorizationService.java 
> d76e1ea 
>   core/src/main/java/org/apache/oozie/service/PurgeService.java c2c966b 
>   core/src/main/java/org/apache/oozie/servlet/JsonRestServlet.java 404d3cd 
>   core/src/main/java/org/apache/oozie/servlet/ServletUtilities.java 9cdd915 
>   core/src/main/java/org/apache/oozie/servlet/V0AdminServlet.java d4a0989 
>   core/src/main/java/org/apache/oozie/servlet/V0JobsServlet.java ff50f3d 
>   core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 0d275fd 
>   core/src/main/java/org/apache/oozie/sla/SLARegistrationBean.java 5eac78c 
>   core/src/main/java/org/apache/oozie/sla/SLASummaryBean.java e9ea9ba 
>   core/src/main/java/org/apache/oozie/sla/listener/SLAEmailEventListener.java 
> d08521c 
>   core/src/main/java/org/apache/oozie/store/WorkflowStore.java 821abc5 
>   core/src/main/java/org/apache/oozie/util/OozieRollingPolicy.java 625053c 
>   core/src/main/java/org/apache/oozie/util/ParameterVerifier.java f3f4630 
>   core/src/main/java/org/apache/oozie/util/ParameterVerifierException.java 
> ef9a591 
>

Re: Review Request 66084: Oozie-core fails with checkstyle errors.

2018-03-26 Thread Peter Cseh via Review Board 


> On March 19, 2018, 8:37 a.m., Attila Sasvari wrote:
> > core/src/main/resources/jetty-logging.properties
> > Line 1 (original), 1 (patched)
> > 
> >
> > Please leave .properties files intact. ``/**/`` is not a valid comment. 
> > Format: 
> > https://docs.oracle.com/javase/8/docs/api/java/util/Properties.html#load-java.io.Reader-
> 
> Alisha Prabhu wrote:
> Have now kept all the .properties files intact.
> 
> Peter Cseh wrote:
> I think the proper solution here is to don't use CheckStyle for header 
> checking. We have RAT to check the headers.
> Please remove this section from the checkstyle config: 
> https://github.com/apache/oozie/blob/master/src/main/resources/checkstyle.xml#L29-L31
>  and the corresponging file: 
> https://github.com/apache/oozie/blob/master/src/main/resources/checkstyle-header.txt
> 
> Alisha Prabhu wrote:
> Uploaded the patch by making the above changes.

It looks good! I've attached this patch to the Jira so the pre-commit hook can 
kick in.


- Peter


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66084/#review199384
---


On March 20, 2018, 5:36 a.m., Alisha Prabhu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66084/
> ---
> 
> (Updated March 20, 2018, 5:36 a.m.)
> 
> 
> Review request for oozie.
> 
> 
> Bugs: OOZIE-3176
> https://issues.apache.org/jira/browse/OOZIE-3176
> 
> 
> Repository: oozie-git
> 
> 
> Description
> ---
> 
> There are multiple checkstyle violations in the Oozie-core module.
> Maven command used is mvn clean install -DskipTests
> 
> 
> Diffs
> -
> 
>   core/src/main/java/org/apache/oozie/BundleActionBean.java eeec549 
>   core/src/main/java/org/apache/oozie/BundleJobBean.java dec0967 
>   core/src/main/java/org/apache/oozie/CoordinatorActionBean.java ddec1e6 
>   core/src/main/java/org/apache/oozie/CoordinatorJobBean.java 5999f40 
>   core/src/main/java/org/apache/oozie/CoordinatorJobInfo.java 04c5bc9 
>   core/src/main/java/org/apache/oozie/DagELFunctions.java 22ac624 
>   core/src/main/java/org/apache/oozie/SLAEventBean.java b30867b 
>   core/src/main/java/org/apache/oozie/WorkflowActionBean.java 6b05b89 
>   core/src/main/java/org/apache/oozie/WorkflowJobBean.java cb06bec 
>   core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java 
> 122dfd0 
>   core/src/main/java/org/apache/oozie/client/rest/JsonBean.java c8bd7c2 
>   
> core/src/main/java/org/apache/oozie/command/bundle/BundleJobSuspendXCommand.java
>  669ac5e 
>   
> core/src/main/java/org/apache/oozie/command/coord/CoordActionInputCheckXCommand.java
>  179cc45 
>   
> core/src/main/java/org/apache/oozie/command/coord/CoordActionStartXCommand.java
>  16d7036 
>   core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java 
> ff7bf8a 
>   core/src/main/java/org/apache/oozie/command/coord/CoordCommandUtils.java 
> fbc6152 
>   
> core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java
>  2b91253 
>   
> core/src/main/java/org/apache/oozie/command/coord/CoordPushDependencyCheckXCommand.java
>  1e864ea 
>   core/src/main/java/org/apache/oozie/command/coord/CoordResumeXCommand.java 
> 1998924 
>   core/src/main/java/org/apache/oozie/command/coord/CoordSubmitXCommand.java 
> 42bdc99 
>   core/src/main/java/org/apache/oozie/command/coord/CoordSuspendXCommand.java 
> 1195ef0 
>   core/src/main/java/org/apache/oozie/command/wf/ActionEndXCommand.java 
> 86ee1cc 
>   core/src/main/java/org/apache/oozie/command/wf/ActionKillXCommand.java 
> 61891b8 
>   core/src/main/java/org/apache/oozie/command/wf/ActionStartXCommand.java 
> 71c29cd 
>   core/src/main/java/org/apache/oozie/command/wf/ActionXCommand.java 29ccd32 
>   core/src/main/java/org/apache/oozie/coord/CoordUtils.java 2874bf6 
>   core/src/main/java/org/apache/oozie/coord/HCatELFunctions.java f40f406 
>   
> core/src/main/java/org/apache/oozie/executor/jpa/BundleJobsGetRunningOrPendingJPAExecutor.java
>  18ceb10 
>   
> core/src/main/java/org/apache/oozie/executor/jpa/CoordActionRemoveJPAExecutor.java
>  02a4f68 
>   
> core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetRunningActionsCountJPAExecutor.java
>  274b3c1 
>   
> core/src/main/java/org/apache/oozie/executor/jpa/WorkflowActionRetryManualGetJPAExecutor.java
>  51449db 
>   
> core/src/main/java/org/apache/oozie/executor/jpa/WorkflowInfoWithActionsSubsetGetJPAExecutor.java
>  43c7d08 
>   
> core/src/main/java/org/apache/oozie/executor/jpa/WorkflowJobsBasicInfoFromParentId.java
>  4b8adfb 
>   core/src/main/java/org/apache/oozie/service/AuthorizationService.java 
> d76e1ea 
>

Re: Review Request 66084: Oozie-core fails with checkstyle errors.

2018-03-26 Thread Alisha Prabhu 


> On March 19, 2018, 8:37 a.m., Attila Sasvari wrote:
> >

Hi Attila Sasvari, can you please review the updated patch. Thank you.


- Alisha


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66084/#review199384
---


On March 20, 2018, 5:36 a.m., Alisha Prabhu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66084/
> ---
> 
> (Updated March 20, 2018, 5:36 a.m.)
> 
> 
> Review request for oozie.
> 
> 
> Bugs: OOZIE-3176
> https://issues.apache.org/jira/browse/OOZIE-3176
> 
> 
> Repository: oozie-git
> 
> 
> Description
> ---
> 
> There are multiple checkstyle violations in the Oozie-core module.
> Maven command used is mvn clean install -DskipTests
> 
> 
> Diffs
> -
> 
>   core/src/main/java/org/apache/oozie/BundleActionBean.java eeec549 
>   core/src/main/java/org/apache/oozie/BundleJobBean.java dec0967 
>   core/src/main/java/org/apache/oozie/CoordinatorActionBean.java ddec1e6 
>   core/src/main/java/org/apache/oozie/CoordinatorJobBean.java 5999f40 
>   core/src/main/java/org/apache/oozie/CoordinatorJobInfo.java 04c5bc9 
>   core/src/main/java/org/apache/oozie/DagELFunctions.java 22ac624 
>   core/src/main/java/org/apache/oozie/SLAEventBean.java b30867b 
>   core/src/main/java/org/apache/oozie/WorkflowActionBean.java 6b05b89 
>   core/src/main/java/org/apache/oozie/WorkflowJobBean.java cb06bec 
>   core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java 
> 122dfd0 
>   core/src/main/java/org/apache/oozie/client/rest/JsonBean.java c8bd7c2 
>   
> core/src/main/java/org/apache/oozie/command/bundle/BundleJobSuspendXCommand.java
>  669ac5e 
>   
> core/src/main/java/org/apache/oozie/command/coord/CoordActionInputCheckXCommand.java
>  179cc45 
>   
> core/src/main/java/org/apache/oozie/command/coord/CoordActionStartXCommand.java
>  16d7036 
>   core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java 
> ff7bf8a 
>   core/src/main/java/org/apache/oozie/command/coord/CoordCommandUtils.java 
> fbc6152 
>   
> core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java
>  2b91253 
>   
> core/src/main/java/org/apache/oozie/command/coord/CoordPushDependencyCheckXCommand.java
>  1e864ea 
>   core/src/main/java/org/apache/oozie/command/coord/CoordResumeXCommand.java 
> 1998924 
>   core/src/main/java/org/apache/oozie/command/coord/CoordSubmitXCommand.java 
> 42bdc99 
>   core/src/main/java/org/apache/oozie/command/coord/CoordSuspendXCommand.java 
> 1195ef0 
>   core/src/main/java/org/apache/oozie/command/wf/ActionEndXCommand.java 
> 86ee1cc 
>   core/src/main/java/org/apache/oozie/command/wf/ActionKillXCommand.java 
> 61891b8 
>   core/src/main/java/org/apache/oozie/command/wf/ActionStartXCommand.java 
> 71c29cd 
>   core/src/main/java/org/apache/oozie/command/wf/ActionXCommand.java 29ccd32 
>   core/src/main/java/org/apache/oozie/coord/CoordUtils.java 2874bf6 
>   core/src/main/java/org/apache/oozie/coord/HCatELFunctions.java f40f406 
>   
> core/src/main/java/org/apache/oozie/executor/jpa/BundleJobsGetRunningOrPendingJPAExecutor.java
>  18ceb10 
>   
> core/src/main/java/org/apache/oozie/executor/jpa/CoordActionRemoveJPAExecutor.java
>  02a4f68 
>   
> core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetRunningActionsCountJPAExecutor.java
>  274b3c1 
>   
> core/src/main/java/org/apache/oozie/executor/jpa/WorkflowActionRetryManualGetJPAExecutor.java
>  51449db 
>   
> core/src/main/java/org/apache/oozie/executor/jpa/WorkflowInfoWithActionsSubsetGetJPAExecutor.java
>  43c7d08 
>   
> core/src/main/java/org/apache/oozie/executor/jpa/WorkflowJobsBasicInfoFromParentId.java
>  4b8adfb 
>   core/src/main/java/org/apache/oozie/service/AuthorizationService.java 
> d76e1ea 
>   core/src/main/java/org/apache/oozie/service/PurgeService.java c2c966b 
>   core/src/main/java/org/apache/oozie/servlet/JsonRestServlet.java 404d3cd 
>   core/src/main/java/org/apache/oozie/servlet/ServletUtilities.java 9cdd915 
>   core/src/main/java/org/apache/oozie/servlet/V0AdminServlet.java d4a0989 
>   core/src/main/java/org/apache/oozie/servlet/V0JobsServlet.java ff50f3d 
>   core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 0d275fd 
>   core/src/main/java/org/apache/oozie/sla/SLARegistrationBean.java 5eac78c 
>   core/src/main/java/org/apache/oozie/sla/SLASummaryBean.java e9ea9ba 
>   core/src/main/java/org/apache/oozie/sla/listener/SLAEmailEventListener.java 
> d08521c 
>   core/src/main/java/org/apache/oozie/store/WorkflowStore.java 821abc5 
>   core/src/main/java/org/apache/oozie/util/OozieRollingPolicy.java 625053c 
>   core/src/main/java/org/apache/oozie/util/ParameterVerifier.java f3f4630 
>

Re: Review Request 66084: Oozie-core fails with checkstyle errors.

2018-03-19 Thread Alisha Prabhu 


> On March 19, 2018, 8:37 a.m., Attila Sasvari wrote:
> > core/src/main/resources/jetty-logging.properties
> > Line 1 (original), 1 (patched)
> > 
> >
> > Please leave .properties files intact. ``/**/`` is not a valid comment. 
> > Format: 
> > https://docs.oracle.com/javase/8/docs/api/java/util/Properties.html#load-java.io.Reader-
> 
> Alisha Prabhu wrote:
> Have now kept all the .properties files intact.
> 
> Peter Cseh wrote:
> I think the proper solution here is to don't use CheckStyle for header 
> checking. We have RAT to check the headers.
> Please remove this section from the checkstyle config: 
> https://github.com/apache/oozie/blob/master/src/main/resources/checkstyle.xml#L29-L31
>  and the corresponging file: 
> https://github.com/apache/oozie/blob/master/src/main/resources/checkstyle-header.txt

Uploaded the patch by making the above changes.


- Alisha


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66084/#review199384
---


On March 20, 2018, 5:36 a.m., Alisha Prabhu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66084/
> ---
> 
> (Updated March 20, 2018, 5:36 a.m.)
> 
> 
> Review request for oozie.
> 
> 
> Bugs: OOZIE-3176
> https://issues.apache.org/jira/browse/OOZIE-3176
> 
> 
> Repository: oozie-git
> 
> 
> Description
> ---
> 
> There are multiple checkstyle violations in the Oozie-core module.
> Maven command used is mvn clean install -DskipTests
> 
> 
> Diffs
> -
> 
>   core/src/main/java/org/apache/oozie/BundleActionBean.java eeec549 
>   core/src/main/java/org/apache/oozie/BundleJobBean.java dec0967 
>   core/src/main/java/org/apache/oozie/CoordinatorActionBean.java ddec1e6 
>   core/src/main/java/org/apache/oozie/CoordinatorJobBean.java 5999f40 
>   core/src/main/java/org/apache/oozie/CoordinatorJobInfo.java 04c5bc9 
>   core/src/main/java/org/apache/oozie/DagELFunctions.java 22ac624 
>   core/src/main/java/org/apache/oozie/SLAEventBean.java b30867b 
>   core/src/main/java/org/apache/oozie/WorkflowActionBean.java 6b05b89 
>   core/src/main/java/org/apache/oozie/WorkflowJobBean.java cb06bec 
>   core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java 
> 122dfd0 
>   core/src/main/java/org/apache/oozie/client/rest/JsonBean.java c8bd7c2 
>   
> core/src/main/java/org/apache/oozie/command/bundle/BundleJobSuspendXCommand.java
>  669ac5e 
>   
> core/src/main/java/org/apache/oozie/command/coord/CoordActionInputCheckXCommand.java
>  179cc45 
>   
> core/src/main/java/org/apache/oozie/command/coord/CoordActionStartXCommand.java
>  16d7036 
>   core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java 
> ff7bf8a 
>   core/src/main/java/org/apache/oozie/command/coord/CoordCommandUtils.java 
> fbc6152 
>   
> core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java
>  2b91253 
>   
> core/src/main/java/org/apache/oozie/command/coord/CoordPushDependencyCheckXCommand.java
>  1e864ea 
>   core/src/main/java/org/apache/oozie/command/coord/CoordResumeXCommand.java 
> 1998924 
>   core/src/main/java/org/apache/oozie/command/coord/CoordSubmitXCommand.java 
> 42bdc99 
>   core/src/main/java/org/apache/oozie/command/coord/CoordSuspendXCommand.java 
> 1195ef0 
>   core/src/main/java/org/apache/oozie/command/wf/ActionEndXCommand.java 
> 86ee1cc 
>   core/src/main/java/org/apache/oozie/command/wf/ActionKillXCommand.java 
> 61891b8 
>   core/src/main/java/org/apache/oozie/command/wf/ActionStartXCommand.java 
> 71c29cd 
>   core/src/main/java/org/apache/oozie/command/wf/ActionXCommand.java 29ccd32 
>   core/src/main/java/org/apache/oozie/coord/CoordUtils.java 2874bf6 
>   core/src/main/java/org/apache/oozie/coord/HCatELFunctions.java f40f406 
>   
> core/src/main/java/org/apache/oozie/executor/jpa/BundleJobsGetRunningOrPendingJPAExecutor.java
>  18ceb10 
>   
> core/src/main/java/org/apache/oozie/executor/jpa/CoordActionRemoveJPAExecutor.java
>  02a4f68 
>   
> core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetRunningActionsCountJPAExecutor.java
>  274b3c1 
>   
> core/src/main/java/org/apache/oozie/executor/jpa/WorkflowActionRetryManualGetJPAExecutor.java
>  51449db 
>   
> core/src/main/java/org/apache/oozie/executor/jpa/WorkflowInfoWithActionsSubsetGetJPAExecutor.java
>  43c7d08 
>   
> core/src/main/java/org/apache/oozie/executor/jpa/WorkflowJobsBasicInfoFromParentId.java
>  4b8adfb 
>   core/src/main/java/org/apache/oozie/service/AuthorizationService.java 
> d76e1ea 
>   core/src/main/java/org/apache/oozie/service/PurgeService.java c2c966b 
>

Re: Review Request 66084: Oozie-core fails with checkstyle errors.

2018-03-19 Thread Alisha Prabhu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66084/
---

(Updated March 20, 2018, 5:36 a.m.)


Review request for oozie.


Changes
---

Modified checkstyle.xml, removed checkstyle-header.txt


Bugs: OOZIE-3176
https://issues.apache.org/jira/browse/OOZIE-3176


Repository: oozie-git


Description
---

There are multiple checkstyle violations in the Oozie-core module.
Maven command used is mvn clean install -DskipTests


Diffs (updated)
-

  core/src/main/java/org/apache/oozie/BundleActionBean.java eeec549 
  core/src/main/java/org/apache/oozie/BundleJobBean.java dec0967 
  core/src/main/java/org/apache/oozie/CoordinatorActionBean.java ddec1e6 
  core/src/main/java/org/apache/oozie/CoordinatorJobBean.java 5999f40 
  core/src/main/java/org/apache/oozie/CoordinatorJobInfo.java 04c5bc9 
  core/src/main/java/org/apache/oozie/DagELFunctions.java 22ac624 
  core/src/main/java/org/apache/oozie/SLAEventBean.java b30867b 
  core/src/main/java/org/apache/oozie/WorkflowActionBean.java 6b05b89 
  core/src/main/java/org/apache/oozie/WorkflowJobBean.java cb06bec 
  core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java 
122dfd0 
  core/src/main/java/org/apache/oozie/client/rest/JsonBean.java c8bd7c2 
  
core/src/main/java/org/apache/oozie/command/bundle/BundleJobSuspendXCommand.java
 669ac5e 
  
core/src/main/java/org/apache/oozie/command/coord/CoordActionInputCheckXCommand.java
 179cc45 
  
core/src/main/java/org/apache/oozie/command/coord/CoordActionStartXCommand.java 
16d7036 
  core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java 
ff7bf8a 
  core/src/main/java/org/apache/oozie/command/coord/CoordCommandUtils.java 
fbc6152 
  
core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java
 2b91253 
  
core/src/main/java/org/apache/oozie/command/coord/CoordPushDependencyCheckXCommand.java
 1e864ea 
  core/src/main/java/org/apache/oozie/command/coord/CoordResumeXCommand.java 
1998924 
  core/src/main/java/org/apache/oozie/command/coord/CoordSubmitXCommand.java 
42bdc99 
  core/src/main/java/org/apache/oozie/command/coord/CoordSuspendXCommand.java 
1195ef0 
  core/src/main/java/org/apache/oozie/command/wf/ActionEndXCommand.java 86ee1cc 
  core/src/main/java/org/apache/oozie/command/wf/ActionKillXCommand.java 
61891b8 
  core/src/main/java/org/apache/oozie/command/wf/ActionStartXCommand.java 
71c29cd 
  core/src/main/java/org/apache/oozie/command/wf/ActionXCommand.java 29ccd32 
  core/src/main/java/org/apache/oozie/coord/CoordUtils.java 2874bf6 
  core/src/main/java/org/apache/oozie/coord/HCatELFunctions.java f40f406 
  
core/src/main/java/org/apache/oozie/executor/jpa/BundleJobsGetRunningOrPendingJPAExecutor.java
 18ceb10 
  
core/src/main/java/org/apache/oozie/executor/jpa/CoordActionRemoveJPAExecutor.java
 02a4f68 
  
core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetRunningActionsCountJPAExecutor.java
 274b3c1 
  
core/src/main/java/org/apache/oozie/executor/jpa/WorkflowActionRetryManualGetJPAExecutor.java
 51449db 
  
core/src/main/java/org/apache/oozie/executor/jpa/WorkflowInfoWithActionsSubsetGetJPAExecutor.java
 43c7d08 
  
core/src/main/java/org/apache/oozie/executor/jpa/WorkflowJobsBasicInfoFromParentId.java
 4b8adfb 
  core/src/main/java/org/apache/oozie/service/AuthorizationService.java d76e1ea 
  core/src/main/java/org/apache/oozie/service/PurgeService.java c2c966b 
  core/src/main/java/org/apache/oozie/servlet/JsonRestServlet.java 404d3cd 
  core/src/main/java/org/apache/oozie/servlet/ServletUtilities.java 9cdd915 
  core/src/main/java/org/apache/oozie/servlet/V0AdminServlet.java d4a0989 
  core/src/main/java/org/apache/oozie/servlet/V0JobsServlet.java ff50f3d 
  core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 0d275fd 
  core/src/main/java/org/apache/oozie/sla/SLARegistrationBean.java 5eac78c 
  core/src/main/java/org/apache/oozie/sla/SLASummaryBean.java e9ea9ba 
  core/src/main/java/org/apache/oozie/sla/listener/SLAEmailEventListener.java 
d08521c 
  core/src/main/java/org/apache/oozie/store/WorkflowStore.java 821abc5 
  core/src/main/java/org/apache/oozie/util/OozieRollingPolicy.java 625053c 
  core/src/main/java/org/apache/oozie/util/ParameterVerifier.java f3f4630 
  core/src/main/java/org/apache/oozie/util/ParameterVerifierException.java 
ef9a591 
  core/src/main/java/org/apache/oozie/util/PollablePriorityDelayQueue.java 
03279eb 
  core/src/main/java/org/apache/oozie/util/db/Schema.java 1278be1 
  core/src/main/java/org/apache/oozie/workflow/lite/ActionNodeDef.java 97c7134 
  core/src/main/java/org/apache/oozie/workflow/lite/DBLiteWorkflowLib.java 
dd6afa0 
  core/src/main/java/org/apache/oozie/workflow/lite/LiteWorkflowAppParser.java 
78b0652 
  core/src/main/resources/localoozie-log4j.properties 906397f

Re: Review Request 66084: Oozie-core fails with checkstyle errors.

2018-03-19 Thread Peter Cseh via Review Board 


> On March 19, 2018, 8:37 a.m., Attila Sasvari wrote:
> > core/src/main/resources/jetty-logging.properties
> > Line 1 (original), 1 (patched)
> > 
> >
> > Please leave .properties files intact. ``/**/`` is not a valid comment. 
> > Format: 
> > https://docs.oracle.com/javase/8/docs/api/java/util/Properties.html#load-java.io.Reader-
> 
> Alisha Prabhu wrote:
> Have now kept all the .properties files intact.

I think the proper solution here is to don't use CheckStyle for header 
checking. We have RAT to check the headers.
Please remove this section from the checkstyle config: 
https://github.com/apache/oozie/blob/master/src/main/resources/checkstyle.xml#L29-L31
 and the corresponging file: 
https://github.com/apache/oozie/blob/master/src/main/resources/checkstyle-header.txt


- Peter


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66084/#review199384
---


On March 19, 2018, 12:32 p.m., Alisha Prabhu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66084/
> ---
> 
> (Updated March 19, 2018, 12:32 p.m.)
> 
> 
> Review request for oozie.
> 
> 
> Bugs: OOZIE-3176
> https://issues.apache.org/jira/browse/OOZIE-3176
> 
> 
> Repository: oozie-git
> 
> 
> Description
> ---
> 
> There are multiple checkstyle violations in the Oozie-core module.
> Maven command used is mvn clean install -DskipTests
> 
> 
> Diffs
> -
> 
>   core/src/main/java/org/apache/oozie/BundleActionBean.java eeec549 
>   core/src/main/java/org/apache/oozie/BundleJobBean.java dec0967 
>   core/src/main/java/org/apache/oozie/CoordinatorActionBean.java ddec1e6 
>   core/src/main/java/org/apache/oozie/CoordinatorJobBean.java 5999f40 
>   core/src/main/java/org/apache/oozie/CoordinatorJobInfo.java 04c5bc9 
>   core/src/main/java/org/apache/oozie/DagELFunctions.java 22ac624 
>   core/src/main/java/org/apache/oozie/SLAEventBean.java b30867b 
>   core/src/main/java/org/apache/oozie/WorkflowActionBean.java 6b05b89 
>   core/src/main/java/org/apache/oozie/WorkflowJobBean.java cb06bec 
>   core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java 
> 122dfd0 
>   core/src/main/java/org/apache/oozie/client/rest/JsonBean.java c8bd7c2 
>   
> core/src/main/java/org/apache/oozie/command/bundle/BundleJobSuspendXCommand.java
>  669ac5e 
>   
> core/src/main/java/org/apache/oozie/command/coord/CoordActionInputCheckXCommand.java
>  179cc45 
>   
> core/src/main/java/org/apache/oozie/command/coord/CoordActionStartXCommand.java
>  16d7036 
>   core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java 
> ff7bf8a 
>   core/src/main/java/org/apache/oozie/command/coord/CoordCommandUtils.java 
> fbc6152 
>   
> core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java
>  2b91253 
>   
> core/src/main/java/org/apache/oozie/command/coord/CoordPushDependencyCheckXCommand.java
>  1e864ea 
>   core/src/main/java/org/apache/oozie/command/coord/CoordResumeXCommand.java 
> 1998924 
>   core/src/main/java/org/apache/oozie/command/coord/CoordSubmitXCommand.java 
> 42bdc99 
>   core/src/main/java/org/apache/oozie/command/coord/CoordSuspendXCommand.java 
> 1195ef0 
>   core/src/main/java/org/apache/oozie/command/wf/ActionEndXCommand.java 
> 86ee1cc 
>   core/src/main/java/org/apache/oozie/command/wf/ActionKillXCommand.java 
> 61891b8 
>   core/src/main/java/org/apache/oozie/command/wf/ActionStartXCommand.java 
> 71c29cd 
>   core/src/main/java/org/apache/oozie/command/wf/ActionXCommand.java 29ccd32 
>   core/src/main/java/org/apache/oozie/coord/CoordUtils.java 2874bf6 
>   core/src/main/java/org/apache/oozie/coord/HCatELFunctions.java f40f406 
>   
> core/src/main/java/org/apache/oozie/executor/jpa/BundleJobsGetRunningOrPendingJPAExecutor.java
>  18ceb10 
>   
> core/src/main/java/org/apache/oozie/executor/jpa/CoordActionRemoveJPAExecutor.java
>  02a4f68 
>   
> core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetRunningActionsCountJPAExecutor.java
>  274b3c1 
>   
> core/src/main/java/org/apache/oozie/executor/jpa/WorkflowActionRetryManualGetJPAExecutor.java
>  51449db 
>   
> core/src/main/java/org/apache/oozie/executor/jpa/WorkflowInfoWithActionsSubsetGetJPAExecutor.java
>  43c7d08 
>   
> core/src/main/java/org/apache/oozie/executor/jpa/WorkflowJobsBasicInfoFromParentId.java
>  4b8adfb 
>   core/src/main/java/org/apache/oozie/service/AuthorizationService.java 
> d76e1ea 
>   core/src/main/java/org/apache/oozie/service/PurgeService.java c2c966b 
>   core/src/main/java/org/apache/oozie/servlet/JsonRestServlet.java 404d3cd 
>

Re: Review Request 66084: Oozie-core fails with checkstyle errors.

2018-03-19 Thread Alisha Prabhu 


> On March 19, 2018, 8:37 a.m., Attila Sasvari wrote:
> > core/src/main/java/org/apache/oozie/util/db/BasicDataSourceWrapper.java
> > Lines 44 (patched)
> > 
> >
> > It breaks the precommit build (mkdistro, see 
> > https://builds.apache.org/job/PreCommit-OOZIE-Build/416/artifact/test-patch/reports/DISTRO.out)

Have kept the BasicDataSourceWrapper.java file intact.
Got build success after running the below command :
bin/mkdistro.sh -DskipTests -Puber -DtargetJavaVersion=1.8 -DjavaVersion=1.8


> On March 19, 2018, 8:37 a.m., Attila Sasvari wrote:
> > core/src/main/resources/jetty-logging.properties
> > Line 1 (original), 1 (patched)
> > 
> >
> > Please leave .properties files intact. ``/**/`` is not a valid comment. 
> > Format: 
> > https://docs.oracle.com/javase/8/docs/api/java/util/Properties.html#load-java.io.Reader-

Have now kept all the .properties files intact.


- Alisha


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66084/#review199384
---


On March 19, 2018, 12:32 p.m., Alisha Prabhu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66084/
> ---
> 
> (Updated March 19, 2018, 12:32 p.m.)
> 
> 
> Review request for oozie.
> 
> 
> Bugs: OOZIE-3176
> https://issues.apache.org/jira/browse/OOZIE-3176
> 
> 
> Repository: oozie-git
> 
> 
> Description
> ---
> 
> There are multiple checkstyle violations in the Oozie-core module.
> Maven command used is mvn clean install -DskipTests
> 
> 
> Diffs
> -
> 
>   core/src/main/java/org/apache/oozie/BundleActionBean.java eeec549 
>   core/src/main/java/org/apache/oozie/BundleJobBean.java dec0967 
>   core/src/main/java/org/apache/oozie/CoordinatorActionBean.java ddec1e6 
>   core/src/main/java/org/apache/oozie/CoordinatorJobBean.java 5999f40 
>   core/src/main/java/org/apache/oozie/CoordinatorJobInfo.java 04c5bc9 
>   core/src/main/java/org/apache/oozie/DagELFunctions.java 22ac624 
>   core/src/main/java/org/apache/oozie/SLAEventBean.java b30867b 
>   core/src/main/java/org/apache/oozie/WorkflowActionBean.java 6b05b89 
>   core/src/main/java/org/apache/oozie/WorkflowJobBean.java cb06bec 
>   core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java 
> 122dfd0 
>   core/src/main/java/org/apache/oozie/client/rest/JsonBean.java c8bd7c2 
>   
> core/src/main/java/org/apache/oozie/command/bundle/BundleJobSuspendXCommand.java
>  669ac5e 
>   
> core/src/main/java/org/apache/oozie/command/coord/CoordActionInputCheckXCommand.java
>  179cc45 
>   
> core/src/main/java/org/apache/oozie/command/coord/CoordActionStartXCommand.java
>  16d7036 
>   core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java 
> ff7bf8a 
>   core/src/main/java/org/apache/oozie/command/coord/CoordCommandUtils.java 
> fbc6152 
>   
> core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java
>  2b91253 
>   
> core/src/main/java/org/apache/oozie/command/coord/CoordPushDependencyCheckXCommand.java
>  1e864ea 
>   core/src/main/java/org/apache/oozie/command/coord/CoordResumeXCommand.java 
> 1998924 
>   core/src/main/java/org/apache/oozie/command/coord/CoordSubmitXCommand.java 
> 42bdc99 
>   core/src/main/java/org/apache/oozie/command/coord/CoordSuspendXCommand.java 
> 1195ef0 
>   core/src/main/java/org/apache/oozie/command/wf/ActionEndXCommand.java 
> 86ee1cc 
>   core/src/main/java/org/apache/oozie/command/wf/ActionKillXCommand.java 
> 61891b8 
>   core/src/main/java/org/apache/oozie/command/wf/ActionStartXCommand.java 
> 71c29cd 
>   core/src/main/java/org/apache/oozie/command/wf/ActionXCommand.java 29ccd32 
>   core/src/main/java/org/apache/oozie/coord/CoordUtils.java 2874bf6 
>   core/src/main/java/org/apache/oozie/coord/HCatELFunctions.java f40f406 
>   
> core/src/main/java/org/apache/oozie/executor/jpa/BundleJobsGetRunningOrPendingJPAExecutor.java
>  18ceb10 
>   
> core/src/main/java/org/apache/oozie/executor/jpa/CoordActionRemoveJPAExecutor.java
>  02a4f68 
>   
> core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetRunningActionsCountJPAExecutor.java
>  274b3c1 
>   
> core/src/main/java/org/apache/oozie/executor/jpa/WorkflowActionRetryManualGetJPAExecutor.java
>  51449db 
>   
> core/src/main/java/org/apache/oozie/executor/jpa/WorkflowInfoWithActionsSubsetGetJPAExecutor.java
>  43c7d08 
>   
> core/src/main/java/org/apache/oozie/executor/jpa/WorkflowJobsBasicInfoFromParentId.java
>  4b8adfb 
>   core/src/main/java/org/apache/oozie/service/AuthorizationService.java 
> d76e1ea 
>

Re: Review Request 66084: Oozie-core fails with checkstyle errors.

2018-03-19 Thread Alisha Prabhu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66084/
---

(Updated March 19, 2018, 12:32 p.m.)


Review request for oozie.


Bugs: OOZIE-3176
https://issues.apache.org/jira/browse/OOZIE-3176


Repository: oozie-git


Description
---

There are multiple checkstyle violations in the Oozie-core module.
Maven command used is mvn clean install -DskipTests


Diffs (updated)
-

  core/src/main/java/org/apache/oozie/BundleActionBean.java eeec549 
  core/src/main/java/org/apache/oozie/BundleJobBean.java dec0967 
  core/src/main/java/org/apache/oozie/CoordinatorActionBean.java ddec1e6 
  core/src/main/java/org/apache/oozie/CoordinatorJobBean.java 5999f40 
  core/src/main/java/org/apache/oozie/CoordinatorJobInfo.java 04c5bc9 
  core/src/main/java/org/apache/oozie/DagELFunctions.java 22ac624 
  core/src/main/java/org/apache/oozie/SLAEventBean.java b30867b 
  core/src/main/java/org/apache/oozie/WorkflowActionBean.java 6b05b89 
  core/src/main/java/org/apache/oozie/WorkflowJobBean.java cb06bec 
  core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java 
122dfd0 
  core/src/main/java/org/apache/oozie/client/rest/JsonBean.java c8bd7c2 
  
core/src/main/java/org/apache/oozie/command/bundle/BundleJobSuspendXCommand.java
 669ac5e 
  
core/src/main/java/org/apache/oozie/command/coord/CoordActionInputCheckXCommand.java
 179cc45 
  
core/src/main/java/org/apache/oozie/command/coord/CoordActionStartXCommand.java 
16d7036 
  core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java 
ff7bf8a 
  core/src/main/java/org/apache/oozie/command/coord/CoordCommandUtils.java 
fbc6152 
  
core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java
 2b91253 
  
core/src/main/java/org/apache/oozie/command/coord/CoordPushDependencyCheckXCommand.java
 1e864ea 
  core/src/main/java/org/apache/oozie/command/coord/CoordResumeXCommand.java 
1998924 
  core/src/main/java/org/apache/oozie/command/coord/CoordSubmitXCommand.java 
42bdc99 
  core/src/main/java/org/apache/oozie/command/coord/CoordSuspendXCommand.java 
1195ef0 
  core/src/main/java/org/apache/oozie/command/wf/ActionEndXCommand.java 86ee1cc 
  core/src/main/java/org/apache/oozie/command/wf/ActionKillXCommand.java 
61891b8 
  core/src/main/java/org/apache/oozie/command/wf/ActionStartXCommand.java 
71c29cd 
  core/src/main/java/org/apache/oozie/command/wf/ActionXCommand.java 29ccd32 
  core/src/main/java/org/apache/oozie/coord/CoordUtils.java 2874bf6 
  core/src/main/java/org/apache/oozie/coord/HCatELFunctions.java f40f406 
  
core/src/main/java/org/apache/oozie/executor/jpa/BundleJobsGetRunningOrPendingJPAExecutor.java
 18ceb10 
  
core/src/main/java/org/apache/oozie/executor/jpa/CoordActionRemoveJPAExecutor.java
 02a4f68 
  
core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetRunningActionsCountJPAExecutor.java
 274b3c1 
  
core/src/main/java/org/apache/oozie/executor/jpa/WorkflowActionRetryManualGetJPAExecutor.java
 51449db 
  
core/src/main/java/org/apache/oozie/executor/jpa/WorkflowInfoWithActionsSubsetGetJPAExecutor.java
 43c7d08 
  
core/src/main/java/org/apache/oozie/executor/jpa/WorkflowJobsBasicInfoFromParentId.java
 4b8adfb 
  core/src/main/java/org/apache/oozie/service/AuthorizationService.java d76e1ea 
  core/src/main/java/org/apache/oozie/service/PurgeService.java c2c966b 
  core/src/main/java/org/apache/oozie/servlet/JsonRestServlet.java 404d3cd 
  core/src/main/java/org/apache/oozie/servlet/ServletUtilities.java 9cdd915 
  core/src/main/java/org/apache/oozie/servlet/V0AdminServlet.java d4a0989 
  core/src/main/java/org/apache/oozie/servlet/V0JobsServlet.java ff50f3d 
  core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 0d275fd 
  core/src/main/java/org/apache/oozie/sla/SLARegistrationBean.java 5eac78c 
  core/src/main/java/org/apache/oozie/sla/SLASummaryBean.java e9ea9ba 
  core/src/main/java/org/apache/oozie/sla/listener/SLAEmailEventListener.java 
d08521c 
  core/src/main/java/org/apache/oozie/store/WorkflowStore.java 821abc5 
  core/src/main/java/org/apache/oozie/util/OozieRollingPolicy.java 625053c 
  core/src/main/java/org/apache/oozie/util/ParameterVerifier.java f3f4630 
  core/src/main/java/org/apache/oozie/util/ParameterVerifierException.java 
ef9a591 
  core/src/main/java/org/apache/oozie/util/PollablePriorityDelayQueue.java 
03279eb 
  core/src/main/java/org/apache/oozie/util/db/Schema.java 1278be1 
  core/src/main/java/org/apache/oozie/workflow/lite/ActionNodeDef.java 97c7134 
  core/src/main/java/org/apache/oozie/workflow/lite/DBLiteWorkflowLib.java 
dd6afa0 
  core/src/main/java/org/apache/oozie/workflow/lite/LiteWorkflowAppParser.java 
78b0652 
  core/src/main/resources/localoozie-log4j.properties 906397f 
  core/src/test/java/org/apache/hadoop/examples/SleepJob.java 342f8b3

Re: Review Request 66084: Oozie-core fails with checkstyle errors.

2018-03-19 Thread Attila Sasvari via Review Board 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66084/#review199384
---




core/src/main/java/org/apache/oozie/util/db/BasicDataSourceWrapper.java
Lines 44 (patched)


It breaks the precommit build (mkdistro, see 
https://builds.apache.org/job/PreCommit-OOZIE-Build/416/artifact/test-patch/reports/DISTRO.out)



core/src/main/resources/jetty-logging.properties
Line 1 (original), 1 (patched)


Please leave .properties files intact. ``/**/`` is not a valid comment. 
Format: 
https://docs.oracle.com/javase/8/docs/api/java/util/Properties.html#load-java.io.Reader-



core/src/main/resources/localoozie-log4j.properties
Line 1 (original), 1 (patched)


Please leave .properties files intact. ``/**/`` is not a valid comment. 
Format: 
https://docs.oracle.com/javase/8/docs/api/java/util/Properties.html#load-java.io.Reader-



core/src/main/resources/oozie-log4j.properties
Line 1 (original), 1 (patched)


Please leave .properties files intact. ``/**/`` is not a valid comment. 
Format: 
https://docs.oracle.com/javase/8/docs/api/java/util/Properties.html#load-java.io.Reader-


- Attila Sasvari


On March 15, 2018, 9:49 a.m., Alisha Prabhu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66084/
> ---
> 
> (Updated March 15, 2018, 9:49 a.m.)
> 
> 
> Review request for oozie.
> 
> 
> Bugs: OOZIE-3176
> https://issues.apache.org/jira/browse/OOZIE-3176
> 
> 
> Repository: oozie-git
> 
> 
> Description
> ---
> 
> There are multiple checkstyle violations in the Oozie-core module.
> Maven command used is mvn clean install -DskipTests
> 
> 
> Diffs
> -
> 
>   core/src/main/java/org/apache/oozie/BundleActionBean.java eeec549 
>   core/src/main/java/org/apache/oozie/BundleJobBean.java dec0967 
>   core/src/main/java/org/apache/oozie/CoordinatorActionBean.java ddec1e6 
>   core/src/main/java/org/apache/oozie/CoordinatorJobBean.java 5999f40 
>   core/src/main/java/org/apache/oozie/CoordinatorJobInfo.java 04c5bc9 
>   core/src/main/java/org/apache/oozie/DagELFunctions.java 22ac624 
>   core/src/main/java/org/apache/oozie/SLAEventBean.java b30867b 
>   core/src/main/java/org/apache/oozie/WorkflowActionBean.java 6b05b89 
>   core/src/main/java/org/apache/oozie/WorkflowJobBean.java cb06bec 
>   core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java 
> bc0f405 
>   core/src/main/java/org/apache/oozie/client/rest/JsonBean.java c8bd7c2 
>   
> core/src/main/java/org/apache/oozie/command/bundle/BundleJobSuspendXCommand.java
>  669ac5e 
>   
> core/src/main/java/org/apache/oozie/command/coord/CoordActionInputCheckXCommand.java
>  179cc45 
>   
> core/src/main/java/org/apache/oozie/command/coord/CoordActionStartXCommand.java
>  16d7036 
>   core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java 
> ff7bf8a 
>   core/src/main/java/org/apache/oozie/command/coord/CoordCommandUtils.java 
> fbc6152 
>   
> core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java
>  2b91253 
>   
> core/src/main/java/org/apache/oozie/command/coord/CoordPushDependencyCheckXCommand.java
>  1e864ea 
>   core/src/main/java/org/apache/oozie/command/coord/CoordResumeXCommand.java 
> 1998924 
>   core/src/main/java/org/apache/oozie/command/coord/CoordSubmitXCommand.java 
> 42bdc99 
>   core/src/main/java/org/apache/oozie/command/coord/CoordSuspendXCommand.java 
> 1195ef0 
>   core/src/main/java/org/apache/oozie/command/wf/ActionEndXCommand.java 
> 86ee1cc 
>   core/src/main/java/org/apache/oozie/command/wf/ActionKillXCommand.java 
> 61891b8 
>   core/src/main/java/org/apache/oozie/command/wf/ActionStartXCommand.java 
> 71c29cd 
>   core/src/main/java/org/apache/oozie/command/wf/ActionXCommand.java 29ccd32 
>   core/src/main/java/org/apache/oozie/coord/CoordUtils.java 2874bf6 
>   core/src/main/java/org/apache/oozie/coord/HCatELFunctions.java f40f406 
>   
> core/src/main/java/org/apache/oozie/executor/jpa/BundleJobsGetRunningOrPendingJPAExecutor.java
>  18ceb10 
>   
> core/src/main/java/org/apache/oozie/executor/jpa/CoordActionRemoveJPAExecutor.java
>  02a4f68 
>   
> core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetRunningActionsCountJPAExecutor.java
>  274b3c1 
>   
> core/src/main/java/org/apache/oozie/executor/jpa/WorkflowActionRetryManualGetJPAExecutor.java
>  51449db 
>   
> core/src/main/java/org/apache/oozie/executor/jpa/WorkflowInfoWithActionsSubsetGetJPAExecutor.java
>  43c7d08 
>   
>

Review Request 66084: Oozie-core fails with checkstyle errors.

2018-03-15 Thread Alisha Prabhu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66084/
---

Review request for oozie.


Bugs: OOZIE-3176
https://issues.apache.org/jira/browse/OOZIE-3176


Repository: oozie-git


Description
---

There are multiple checkstyle violations in the Oozie-core module.
Maven command used is mvn clean install -DskipTests


Diffs
-

  core/src/main/java/org/apache/oozie/BundleActionBean.java eeec549 
  core/src/main/java/org/apache/oozie/BundleJobBean.java dec0967 
  core/src/main/java/org/apache/oozie/CoordinatorActionBean.java ddec1e6 
  core/src/main/java/org/apache/oozie/CoordinatorJobBean.java 5999f40 
  core/src/main/java/org/apache/oozie/CoordinatorJobInfo.java 04c5bc9 
  core/src/main/java/org/apache/oozie/DagELFunctions.java 22ac624 
  core/src/main/java/org/apache/oozie/SLAEventBean.java b30867b 
  core/src/main/java/org/apache/oozie/WorkflowActionBean.java 6b05b89 
  core/src/main/java/org/apache/oozie/WorkflowJobBean.java cb06bec 
  core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java 
bc0f405 
  core/src/main/java/org/apache/oozie/client/rest/JsonBean.java c8bd7c2 
  
core/src/main/java/org/apache/oozie/command/bundle/BundleJobSuspendXCommand.java
 669ac5e 
  
core/src/main/java/org/apache/oozie/command/coord/CoordActionInputCheckXCommand.java
 179cc45 
  
core/src/main/java/org/apache/oozie/command/coord/CoordActionStartXCommand.java 
16d7036 
  core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java 
ff7bf8a 
  core/src/main/java/org/apache/oozie/command/coord/CoordCommandUtils.java 
fbc6152 
  
core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java
 2b91253 
  
core/src/main/java/org/apache/oozie/command/coord/CoordPushDependencyCheckXCommand.java
 1e864ea 
  core/src/main/java/org/apache/oozie/command/coord/CoordResumeXCommand.java 
1998924 
  core/src/main/java/org/apache/oozie/command/coord/CoordSubmitXCommand.java 
42bdc99 
  core/src/main/java/org/apache/oozie/command/coord/CoordSuspendXCommand.java 
1195ef0 
  core/src/main/java/org/apache/oozie/command/wf/ActionEndXCommand.java 86ee1cc 
  core/src/main/java/org/apache/oozie/command/wf/ActionKillXCommand.java 
61891b8 
  core/src/main/java/org/apache/oozie/command/wf/ActionStartXCommand.java 
71c29cd 
  core/src/main/java/org/apache/oozie/command/wf/ActionXCommand.java 29ccd32 
  core/src/main/java/org/apache/oozie/coord/CoordUtils.java 2874bf6 
  core/src/main/java/org/apache/oozie/coord/HCatELFunctions.java f40f406 
  
core/src/main/java/org/apache/oozie/executor/jpa/BundleJobsGetRunningOrPendingJPAExecutor.java
 18ceb10 
  
core/src/main/java/org/apache/oozie/executor/jpa/CoordActionRemoveJPAExecutor.java
 02a4f68 
  
core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetRunningActionsCountJPAExecutor.java
 274b3c1 
  
core/src/main/java/org/apache/oozie/executor/jpa/WorkflowActionRetryManualGetJPAExecutor.java
 51449db 
  
core/src/main/java/org/apache/oozie/executor/jpa/WorkflowInfoWithActionsSubsetGetJPAExecutor.java
 43c7d08 
  
core/src/main/java/org/apache/oozie/executor/jpa/WorkflowJobsBasicInfoFromParentId.java
 4b8adfb 
  core/src/main/java/org/apache/oozie/service/AuthorizationService.java d76e1ea 
  core/src/main/java/org/apache/oozie/service/PurgeService.java c2c966b 
  core/src/main/java/org/apache/oozie/servlet/JsonRestServlet.java 404d3cd 
  core/src/main/java/org/apache/oozie/servlet/ServletUtilities.java 9cdd915 
  core/src/main/java/org/apache/oozie/servlet/V0AdminServlet.java d4a0989 
  core/src/main/java/org/apache/oozie/servlet/V0JobsServlet.java ff50f3d 
  core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 0d275fd 
  core/src/main/java/org/apache/oozie/sla/SLARegistrationBean.java 5eac78c 
  core/src/main/java/org/apache/oozie/sla/SLASummaryBean.java e9ea9ba 
  core/src/main/java/org/apache/oozie/sla/listener/SLAEmailEventListener.java 
d08521c 
  core/src/main/java/org/apache/oozie/store/WorkflowStore.java 821abc5 
  core/src/main/java/org/apache/oozie/util/OozieRollingPolicy.java 625053c 
  core/src/main/java/org/apache/oozie/util/ParameterVerifier.java f3f4630 
  core/src/main/java/org/apache/oozie/util/ParameterVerifierException.java 
ef9a591 
  core/src/main/java/org/apache/oozie/util/PollablePriorityDelayQueue.java 
03279eb 
  core/src/main/java/org/apache/oozie/util/db/BasicDataSourceWrapper.java 
826f95b 
  core/src/main/java/org/apache/oozie/util/db/Schema.java 1278be1 
  core/src/main/java/org/apache/oozie/workflow/lite/ActionNodeDef.java 97c7134 
  core/src/main/java/org/apache/oozie/workflow/lite/DBLiteWorkflowLib.java 
dd6afa0 
  core/src/main/java/org/apache/oozie/workflow/lite/LiteWorkflowAppParser.java 
c236daf 
  core/src/main/resources/jetty-logging.properties 3da7c30 
  core/src/main/resources/localoozie-log4j.properties 906397f