[GitHub] [openoffice] leginee commented on pull request #133: graphite: remove the -Werror option from debug builds

2021-07-04 Thread GitBox


leginee commented on pull request #133:
URL: https://github.com/apache/openoffice/pull/133#issuecomment-873534871


   Okay, lets merge. The issues are there anyhow. I dont think the code is 
better or worse with the change.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org
For additional commands, e-mail: dev-h...@openoffice.apache.org



[GitHub] [openoffice] leginee commented on pull request #133: graphite: remove the -Werror option from debug builds

2021-06-20 Thread GitBox


leginee commented on pull request #133:
URL: https://github.com/apache/openoffice/pull/133#issuecomment-864513194


   Then we have 2 choices. Fix the Issues or prepare the switch to a 
replacement.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org
For additional commands, e-mail: dev-h...@openoffice.apache.org



[GitHub] [openoffice] leginee commented on pull request #133: graphite: remove the -Werror option from debug builds

2021-06-19 Thread GitBox


leginee commented on pull request #133:
URL: https://github.com/apache/openoffice/pull/133#issuecomment-864492889


   The meaing of the Flag is
   -Werror: every warning is treated as an error.
   
   Since Grafite is a dependency it is fine to build without. However Imho we 
should strife for removing Warnings from Code.
   Maybe it is worth trying to build with a new Version of Grafite on Suse 
Machines?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org
For additional commands, e-mail: dev-h...@openoffice.apache.org