Re: MacOS testing for bug 112829 (SVG clipboard format)

2024-03-04 Thread Jim Jagielski
Yes, please commit that...

> On Feb 25, 2024, at 10:50 PM, Damjan Jovanovic  wrote:
> 
> What I meant is, test trunk or AOO42X, whichever is more convenient. If it
> doesn't show image/svg+xml on the clipboard, apply that patch and test
> again.
> 
> There is no branch which has that patch I sent, because I am not sure it
> works yet.
> 
> On Sun, Feb 25, 2024 at 8:07 PM Jim Jagielski  wrote:
> 
>> I mean, is there a branch with this already folded in?
>> 
>>> On Feb 22, 2024, at 2:27 PM, Damjan Jovanovic  wrote:
>>> 
>>> Either trunk or AOO42X.
>>> 
>>> On Thu, Feb 22, 2024 at 7:11 PM Jim Jagielski  wrote:
>>> 
 Which branch?
 
> On Feb 22, 2024, at 10:54 AM, Damjan Jovanovic 
 wrote:
> 
> Hi
> 
> For bug 112829, I got graphics and charts to copy out of AOO in SVG
 format
> on FreeBSD and Windows (and probably Linux), but I wasn't able to test
> macOS. A quick look at the code shows we might need another patch to
>> get
 it
> working there, possibly the one below.
> 
> Can someone please test it and report back? Don't only verify you can
> paste, examine the clipboard formats after copying a chart, and make
>> sure
> it contains "image/svg+xml".
> 
> Thank you
> Damjan
> 
> ---snip---
> diff --git a/main/vcl/aqua/source/dtrans/DataFlavorMapping.cxx
> b/main/vcl/aqua/source/dtrans/DataFlavorMapping.cxx
> index d5e2b6f371..d8f67c 100644
> --- a/main/vcl/aqua/source/dtrans/DataFlavorMapping.cxx
> +++ b/main/vcl/aqua/source/dtrans/DataFlavorMapping.cxx
> @@ -94,6 +94,7 @@ namespace // private
> const NSString* PBTYPE_GDIMF = @"application/x-openoffice-gdimetafile
> ;windows_formatname=\"GDIMetaFile\"";
> const NSString* PBTYPE_WMF =
> @"application/x-openoffice-wmf;windows_formatname=\"Image
> WMF\"";
> const NSString* PBTYPE_EMF =
> @"application/x-openoffice-emf;windows_formatname=\"Image
> EMF\"";
> +  const NSString* PBTYPE_SVG = @"image/svg+xml;windows_
> formatname=\"image/svg+xml\"";
> 
> const NSString* PBTYPE_DUMMY_INTERNAL = @"application/x-openoffice-
> internal";
> 
> @@ -107,6 +108,7 @@ namespace // private
> const char* FLAVOR_GDIMF =
 "application/x-openoffice-gdimetafile;windows_
> formatname=\"GDIMetaFile\"";
> const char* FLAVOR_WMF =
> "application/x-openoffice-wmf;windows_formatname=\"Image
> WMF\"";
> const char* FLAVOR_EMF =
> "application/x-openoffice-emf;windows_formatname=\"Image
> EMF\"";
> +  const char* FLAVOR_SVG = "image/svg+xml;windows_
> formatname=\"image/svg+xml\"";
> 
> const char* FLAVOR_DUMMY_INTERNAL =
 "application/x-openoffice-internal";
> 
> @@ -138,6 +140,7 @@ namespace // private
>{ PBTYPE_GDIMF, FLAVOR_GDIMF, "GDIMetaFile", CPPUTYPE_SEQINT8
>> },
>{ PBTYPE_WMF, FLAVOR_WMF, "Windows MetaFile", CPPUTYPE_SEQINT8
 },
>{ PBTYPE_EMF, FLAVOR_EMF, "Windows Enhanced MetaFile",
> CPPUTYPE_SEQINT8 },
> + { PBTYPE_SVG, FLAVOR_SVG, "Scalable Vector Graphics",
> CPPUTYPE_SEQINT8 },
>{ PBTYPE_SODX, FLAVOR_SODX, "Star Object Descriptor (XML)",
> CPPUTYPE_SEQINT8 },
> { PBTYPE_DUMMY_INTERNAL, FLAVOR_DUMMY_INTERNAL, "internal
> data",CPPUTYPE_SEQINT8 }
>  };
> ---snip---
 
 
 -
 To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org
 For additional commands, e-mail: dev-h...@openoffice.apache.org
 
 
>> 
>> 
>> -
>> To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org
>> For additional commands, e-mail: dev-h...@openoffice.apache.org
>> 
>> 


-
To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org
For additional commands, e-mail: dev-h...@openoffice.apache.org



Re: MacOS testing for bug 112829 (SVG clipboard format)

2024-02-25 Thread Damjan Jovanovic
What I meant is, test trunk or AOO42X, whichever is more convenient. If it
doesn't show image/svg+xml on the clipboard, apply that patch and test
again.

There is no branch which has that patch I sent, because I am not sure it
works yet.

On Sun, Feb 25, 2024 at 8:07 PM Jim Jagielski  wrote:

> I mean, is there a branch with this already folded in?
>
> > On Feb 22, 2024, at 2:27 PM, Damjan Jovanovic  wrote:
> >
> > Either trunk or AOO42X.
> >
> > On Thu, Feb 22, 2024 at 7:11 PM Jim Jagielski  wrote:
> >
> >> Which branch?
> >>
> >>> On Feb 22, 2024, at 10:54 AM, Damjan Jovanovic 
> >> wrote:
> >>>
> >>> Hi
> >>>
> >>> For bug 112829, I got graphics and charts to copy out of AOO in SVG
> >> format
> >>> on FreeBSD and Windows (and probably Linux), but I wasn't able to test
> >>> macOS. A quick look at the code shows we might need another patch to
> get
> >> it
> >>> working there, possibly the one below.
> >>>
> >>> Can someone please test it and report back? Don't only verify you can
> >>> paste, examine the clipboard formats after copying a chart, and make
> sure
> >>> it contains "image/svg+xml".
> >>>
> >>> Thank you
> >>> Damjan
> >>>
> >>> ---snip---
> >>> diff --git a/main/vcl/aqua/source/dtrans/DataFlavorMapping.cxx
> >>> b/main/vcl/aqua/source/dtrans/DataFlavorMapping.cxx
> >>> index d5e2b6f371..d8f67c 100644
> >>> --- a/main/vcl/aqua/source/dtrans/DataFlavorMapping.cxx
> >>> +++ b/main/vcl/aqua/source/dtrans/DataFlavorMapping.cxx
> >>> @@ -94,6 +94,7 @@ namespace // private
> >>>  const NSString* PBTYPE_GDIMF = @"application/x-openoffice-gdimetafile
> >>> ;windows_formatname=\"GDIMetaFile\"";
> >>>  const NSString* PBTYPE_WMF =
> >>> @"application/x-openoffice-wmf;windows_formatname=\"Image
> >>> WMF\"";
> >>>  const NSString* PBTYPE_EMF =
> >>> @"application/x-openoffice-emf;windows_formatname=\"Image
> >>> EMF\"";
> >>> +  const NSString* PBTYPE_SVG = @"image/svg+xml;windows_
> >>> formatname=\"image/svg+xml\"";
> >>>
> >>>  const NSString* PBTYPE_DUMMY_INTERNAL = @"application/x-openoffice-
> >>> internal";
> >>>
> >>> @@ -107,6 +108,7 @@ namespace // private
> >>>  const char* FLAVOR_GDIMF =
> >> "application/x-openoffice-gdimetafile;windows_
> >>> formatname=\"GDIMetaFile\"";
> >>>  const char* FLAVOR_WMF =
> >>> "application/x-openoffice-wmf;windows_formatname=\"Image
> >>> WMF\"";
> >>>  const char* FLAVOR_EMF =
> >>> "application/x-openoffice-emf;windows_formatname=\"Image
> >>> EMF\"";
> >>> +  const char* FLAVOR_SVG = "image/svg+xml;windows_
> >>> formatname=\"image/svg+xml\"";
> >>>
> >>>  const char* FLAVOR_DUMMY_INTERNAL =
> >> "application/x-openoffice-internal";
> >>>
> >>> @@ -138,6 +140,7 @@ namespace // private
> >>> { PBTYPE_GDIMF, FLAVOR_GDIMF, "GDIMetaFile", CPPUTYPE_SEQINT8
> },
> >>> { PBTYPE_WMF, FLAVOR_WMF, "Windows MetaFile", CPPUTYPE_SEQINT8
> >> },
> >>> { PBTYPE_EMF, FLAVOR_EMF, "Windows Enhanced MetaFile",
> >>> CPPUTYPE_SEQINT8 },
> >>> + { PBTYPE_SVG, FLAVOR_SVG, "Scalable Vector Graphics",
> >>> CPPUTYPE_SEQINT8 },
> >>> { PBTYPE_SODX, FLAVOR_SODX, "Star Object Descriptor (XML)",
> >>> CPPUTYPE_SEQINT8 },
> >>>  { PBTYPE_DUMMY_INTERNAL, FLAVOR_DUMMY_INTERNAL, "internal
> >>> data",CPPUTYPE_SEQINT8 }
> >>>   };
> >>> ---snip---
> >>
> >>
> >> -
> >> To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org
> >> For additional commands, e-mail: dev-h...@openoffice.apache.org
> >>
> >>
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org
> For additional commands, e-mail: dev-h...@openoffice.apache.org
>
>


Re: MacOS testing for bug 112829 (SVG clipboard format)

2024-02-25 Thread Jim Jagielski
I mean, is there a branch with this already folded in?

> On Feb 22, 2024, at 2:27 PM, Damjan Jovanovic  wrote:
> 
> Either trunk or AOO42X.
> 
> On Thu, Feb 22, 2024 at 7:11 PM Jim Jagielski  wrote:
> 
>> Which branch?
>> 
>>> On Feb 22, 2024, at 10:54 AM, Damjan Jovanovic 
>> wrote:
>>> 
>>> Hi
>>> 
>>> For bug 112829, I got graphics and charts to copy out of AOO in SVG
>> format
>>> on FreeBSD and Windows (and probably Linux), but I wasn't able to test
>>> macOS. A quick look at the code shows we might need another patch to get
>> it
>>> working there, possibly the one below.
>>> 
>>> Can someone please test it and report back? Don't only verify you can
>>> paste, examine the clipboard formats after copying a chart, and make sure
>>> it contains "image/svg+xml".
>>> 
>>> Thank you
>>> Damjan
>>> 
>>> ---snip---
>>> diff --git a/main/vcl/aqua/source/dtrans/DataFlavorMapping.cxx
>>> b/main/vcl/aqua/source/dtrans/DataFlavorMapping.cxx
>>> index d5e2b6f371..d8f67c 100644
>>> --- a/main/vcl/aqua/source/dtrans/DataFlavorMapping.cxx
>>> +++ b/main/vcl/aqua/source/dtrans/DataFlavorMapping.cxx
>>> @@ -94,6 +94,7 @@ namespace // private
>>>  const NSString* PBTYPE_GDIMF = @"application/x-openoffice-gdimetafile
>>> ;windows_formatname=\"GDIMetaFile\"";
>>>  const NSString* PBTYPE_WMF =
>>> @"application/x-openoffice-wmf;windows_formatname=\"Image
>>> WMF\"";
>>>  const NSString* PBTYPE_EMF =
>>> @"application/x-openoffice-emf;windows_formatname=\"Image
>>> EMF\"";
>>> +  const NSString* PBTYPE_SVG = @"image/svg+xml;windows_
>>> formatname=\"image/svg+xml\"";
>>> 
>>>  const NSString* PBTYPE_DUMMY_INTERNAL = @"application/x-openoffice-
>>> internal";
>>> 
>>> @@ -107,6 +108,7 @@ namespace // private
>>>  const char* FLAVOR_GDIMF =
>> "application/x-openoffice-gdimetafile;windows_
>>> formatname=\"GDIMetaFile\"";
>>>  const char* FLAVOR_WMF =
>>> "application/x-openoffice-wmf;windows_formatname=\"Image
>>> WMF\"";
>>>  const char* FLAVOR_EMF =
>>> "application/x-openoffice-emf;windows_formatname=\"Image
>>> EMF\"";
>>> +  const char* FLAVOR_SVG = "image/svg+xml;windows_
>>> formatname=\"image/svg+xml\"";
>>> 
>>>  const char* FLAVOR_DUMMY_INTERNAL =
>> "application/x-openoffice-internal";
>>> 
>>> @@ -138,6 +140,7 @@ namespace // private
>>> { PBTYPE_GDIMF, FLAVOR_GDIMF, "GDIMetaFile", CPPUTYPE_SEQINT8 },
>>> { PBTYPE_WMF, FLAVOR_WMF, "Windows MetaFile", CPPUTYPE_SEQINT8
>> },
>>> { PBTYPE_EMF, FLAVOR_EMF, "Windows Enhanced MetaFile",
>>> CPPUTYPE_SEQINT8 },
>>> + { PBTYPE_SVG, FLAVOR_SVG, "Scalable Vector Graphics",
>>> CPPUTYPE_SEQINT8 },
>>> { PBTYPE_SODX, FLAVOR_SODX, "Star Object Descriptor (XML)",
>>> CPPUTYPE_SEQINT8 },
>>>  { PBTYPE_DUMMY_INTERNAL, FLAVOR_DUMMY_INTERNAL, "internal
>>> data",CPPUTYPE_SEQINT8 }
>>>   };
>>> ---snip---
>> 
>> 
>> -
>> To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org
>> For additional commands, e-mail: dev-h...@openoffice.apache.org
>> 
>> 


-
To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org
For additional commands, e-mail: dev-h...@openoffice.apache.org



Re: MacOS testing for bug 112829 (SVG clipboard format)

2024-02-22 Thread Damjan Jovanovic
Either trunk or AOO42X.

On Thu, Feb 22, 2024 at 7:11 PM Jim Jagielski  wrote:

> Which branch?
>
> > On Feb 22, 2024, at 10:54 AM, Damjan Jovanovic 
> wrote:
> >
> > Hi
> >
> > For bug 112829, I got graphics and charts to copy out of AOO in SVG
> format
> > on FreeBSD and Windows (and probably Linux), but I wasn't able to test
> > macOS. A quick look at the code shows we might need another patch to get
> it
> > working there, possibly the one below.
> >
> > Can someone please test it and report back? Don't only verify you can
> > paste, examine the clipboard formats after copying a chart, and make sure
> > it contains "image/svg+xml".
> >
> > Thank you
> > Damjan
> >
> > ---snip---
> > diff --git a/main/vcl/aqua/source/dtrans/DataFlavorMapping.cxx
> > b/main/vcl/aqua/source/dtrans/DataFlavorMapping.cxx
> > index d5e2b6f371..d8f67c 100644
> > --- a/main/vcl/aqua/source/dtrans/DataFlavorMapping.cxx
> > +++ b/main/vcl/aqua/source/dtrans/DataFlavorMapping.cxx
> > @@ -94,6 +94,7 @@ namespace // private
> >   const NSString* PBTYPE_GDIMF = @"application/x-openoffice-gdimetafile
> > ;windows_formatname=\"GDIMetaFile\"";
> >   const NSString* PBTYPE_WMF =
> > @"application/x-openoffice-wmf;windows_formatname=\"Image
> > WMF\"";
> >   const NSString* PBTYPE_EMF =
> > @"application/x-openoffice-emf;windows_formatname=\"Image
> > EMF\"";
> > +  const NSString* PBTYPE_SVG = @"image/svg+xml;windows_
> > formatname=\"image/svg+xml\"";
> >
> >   const NSString* PBTYPE_DUMMY_INTERNAL = @"application/x-openoffice-
> > internal";
> >
> > @@ -107,6 +108,7 @@ namespace // private
> >   const char* FLAVOR_GDIMF =
> "application/x-openoffice-gdimetafile;windows_
> > formatname=\"GDIMetaFile\"";
> >   const char* FLAVOR_WMF =
> > "application/x-openoffice-wmf;windows_formatname=\"Image
> > WMF\"";
> >   const char* FLAVOR_EMF =
> > "application/x-openoffice-emf;windows_formatname=\"Image
> > EMF\"";
> > +  const char* FLAVOR_SVG = "image/svg+xml;windows_
> > formatname=\"image/svg+xml\"";
> >
> >   const char* FLAVOR_DUMMY_INTERNAL =
> "application/x-openoffice-internal";
> >
> > @@ -138,6 +140,7 @@ namespace // private
> >  { PBTYPE_GDIMF, FLAVOR_GDIMF, "GDIMetaFile", CPPUTYPE_SEQINT8 },
> >  { PBTYPE_WMF, FLAVOR_WMF, "Windows MetaFile", CPPUTYPE_SEQINT8
> },
> >  { PBTYPE_EMF, FLAVOR_EMF, "Windows Enhanced MetaFile",
> > CPPUTYPE_SEQINT8 },
> > + { PBTYPE_SVG, FLAVOR_SVG, "Scalable Vector Graphics",
> > CPPUTYPE_SEQINT8 },
> >  { PBTYPE_SODX, FLAVOR_SODX, "Star Object Descriptor (XML)",
> > CPPUTYPE_SEQINT8 },
> >   { PBTYPE_DUMMY_INTERNAL, FLAVOR_DUMMY_INTERNAL, "internal
> > data",CPPUTYPE_SEQINT8 }
> >};
> > ---snip---
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org
> For additional commands, e-mail: dev-h...@openoffice.apache.org
>
>


Re: MacOS testing for bug 112829 (SVG clipboard format)

2024-02-22 Thread Jim Jagielski
Which branch?

> On Feb 22, 2024, at 10:54 AM, Damjan Jovanovic  wrote:
> 
> Hi
> 
> For bug 112829, I got graphics and charts to copy out of AOO in SVG format
> on FreeBSD and Windows (and probably Linux), but I wasn't able to test
> macOS. A quick look at the code shows we might need another patch to get it
> working there, possibly the one below.
> 
> Can someone please test it and report back? Don't only verify you can
> paste, examine the clipboard formats after copying a chart, and make sure
> it contains "image/svg+xml".
> 
> Thank you
> Damjan
> 
> ---snip---
> diff --git a/main/vcl/aqua/source/dtrans/DataFlavorMapping.cxx
> b/main/vcl/aqua/source/dtrans/DataFlavorMapping.cxx
> index d5e2b6f371..d8f67c 100644
> --- a/main/vcl/aqua/source/dtrans/DataFlavorMapping.cxx
> +++ b/main/vcl/aqua/source/dtrans/DataFlavorMapping.cxx
> @@ -94,6 +94,7 @@ namespace // private
>   const NSString* PBTYPE_GDIMF = @"application/x-openoffice-gdimetafile
> ;windows_formatname=\"GDIMetaFile\"";
>   const NSString* PBTYPE_WMF =
> @"application/x-openoffice-wmf;windows_formatname=\"Image
> WMF\"";
>   const NSString* PBTYPE_EMF =
> @"application/x-openoffice-emf;windows_formatname=\"Image
> EMF\"";
> +  const NSString* PBTYPE_SVG = @"image/svg+xml;windows_
> formatname=\"image/svg+xml\"";
> 
>   const NSString* PBTYPE_DUMMY_INTERNAL = @"application/x-openoffice-
> internal";
> 
> @@ -107,6 +108,7 @@ namespace // private
>   const char* FLAVOR_GDIMF = "application/x-openoffice-gdimetafile;windows_
> formatname=\"GDIMetaFile\"";
>   const char* FLAVOR_WMF =
> "application/x-openoffice-wmf;windows_formatname=\"Image
> WMF\"";
>   const char* FLAVOR_EMF =
> "application/x-openoffice-emf;windows_formatname=\"Image
> EMF\"";
> +  const char* FLAVOR_SVG = "image/svg+xml;windows_
> formatname=\"image/svg+xml\"";
> 
>   const char* FLAVOR_DUMMY_INTERNAL = "application/x-openoffice-internal";
> 
> @@ -138,6 +140,7 @@ namespace // private
>  { PBTYPE_GDIMF, FLAVOR_GDIMF, "GDIMetaFile", CPPUTYPE_SEQINT8 },
>  { PBTYPE_WMF, FLAVOR_WMF, "Windows MetaFile", CPPUTYPE_SEQINT8 },
>  { PBTYPE_EMF, FLAVOR_EMF, "Windows Enhanced MetaFile",
> CPPUTYPE_SEQINT8 },
> + { PBTYPE_SVG, FLAVOR_SVG, "Scalable Vector Graphics",
> CPPUTYPE_SEQINT8 },
>  { PBTYPE_SODX, FLAVOR_SODX, "Star Object Descriptor (XML)",
> CPPUTYPE_SEQINT8 },
>   { PBTYPE_DUMMY_INTERNAL, FLAVOR_DUMMY_INTERNAL, "internal
> data",CPPUTYPE_SEQINT8 }
>};
> ---snip---


-
To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org
For additional commands, e-mail: dev-h...@openoffice.apache.org



MacOS testing for bug 112829 (SVG clipboard format)

2024-02-22 Thread Damjan Jovanovic
Hi

For bug 112829, I got graphics and charts to copy out of AOO in SVG format
on FreeBSD and Windows (and probably Linux), but I wasn't able to test
macOS. A quick look at the code shows we might need another patch to get it
working there, possibly the one below.

Can someone please test it and report back? Don't only verify you can
paste, examine the clipboard formats after copying a chart, and make sure
it contains "image/svg+xml".

Thank you
Damjan

---snip---
diff --git a/main/vcl/aqua/source/dtrans/DataFlavorMapping.cxx
b/main/vcl/aqua/source/dtrans/DataFlavorMapping.cxx
index d5e2b6f371..d8f67c 100644
--- a/main/vcl/aqua/source/dtrans/DataFlavorMapping.cxx
+++ b/main/vcl/aqua/source/dtrans/DataFlavorMapping.cxx
@@ -94,6 +94,7 @@ namespace // private
   const NSString* PBTYPE_GDIMF = @"application/x-openoffice-gdimetafile
;windows_formatname=\"GDIMetaFile\"";
   const NSString* PBTYPE_WMF =
@"application/x-openoffice-wmf;windows_formatname=\"Image
WMF\"";
   const NSString* PBTYPE_EMF =
@"application/x-openoffice-emf;windows_formatname=\"Image
EMF\"";
+  const NSString* PBTYPE_SVG = @"image/svg+xml;windows_
formatname=\"image/svg+xml\"";

   const NSString* PBTYPE_DUMMY_INTERNAL = @"application/x-openoffice-
internal";

@@ -107,6 +108,7 @@ namespace // private
   const char* FLAVOR_GDIMF = "application/x-openoffice-gdimetafile;windows_
formatname=\"GDIMetaFile\"";
   const char* FLAVOR_WMF =
"application/x-openoffice-wmf;windows_formatname=\"Image
WMF\"";
   const char* FLAVOR_EMF =
"application/x-openoffice-emf;windows_formatname=\"Image
EMF\"";
+  const char* FLAVOR_SVG = "image/svg+xml;windows_
formatname=\"image/svg+xml\"";

   const char* FLAVOR_DUMMY_INTERNAL = "application/x-openoffice-internal";

@@ -138,6 +140,7 @@ namespace // private
  { PBTYPE_GDIMF, FLAVOR_GDIMF, "GDIMetaFile", CPPUTYPE_SEQINT8 },
  { PBTYPE_WMF, FLAVOR_WMF, "Windows MetaFile", CPPUTYPE_SEQINT8 },
  { PBTYPE_EMF, FLAVOR_EMF, "Windows Enhanced MetaFile",
CPPUTYPE_SEQINT8 },
+ { PBTYPE_SVG, FLAVOR_SVG, "Scalable Vector Graphics",
CPPUTYPE_SEQINT8 },
  { PBTYPE_SODX, FLAVOR_SODX, "Star Object Descriptor (XML)",
CPPUTYPE_SEQINT8 },
   { PBTYPE_DUMMY_INTERNAL, FLAVOR_DUMMY_INTERNAL, "internal
data",CPPUTYPE_SEQINT8 }
};
---snip---