Re: [ovs-dev] [PATCH 01/12] dpcls: Use 32 packet batches for lookups.

2016-10-11 Thread Fischetti, Antonio
Comments inline. Thanks, Antonio > -Original Message- > From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Jarno > Rajahalme > Sent: Friday, October 7, 2016 10:08 PM > To: Bodireddy, Bhanuprakash > Cc: dev@openvswitch.org > Subject: Re:

Re: [ovs-dev] The Patch netdev-dpdk: add TSO support for vhost-user ports

2016-10-11 Thread Kavanagh, Mark B
> >Hi, all > > >This patch is very important for users want to improve the performance >of the large packets. > > >But you know, in data center, lots of networks using vxlan, so if it >supports vxlan, then it will be very useful. > > >Would you guys has a plan to support it? I would like to help

[ovs-dev] [PATCH 2/2] ovn-nbctl: Fix manpage formatting typo.

2016-10-11 Thread nickcooper-zhangtonghao
Signed-off-by: nickcooper-zhangtonghao --- ovn/utilities/ovn-nbctl.8.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ovn/utilities/ovn-nbctl.8.xml b/ovn/utilities/ovn-nbctl.8.xml index be802da..993e1c4 100644 ---

[ovs-dev] [PATCH 1/2] ovn-nbctl: Add NAT commands.

2016-10-11 Thread nickcooper-zhangtonghao
This patch provides the command line to create NAT rules on logical router. Signed-off-by: nickcooper-zhangtonghao --- ovn/utilities/ovn-nbctl.8.xml | 66 +++ ovn/utilities/ovn-nbctl.c | 185 ++

Re: [ovs-dev] [PATCH] meta-flow: Fix the NXM_NX_* names of xxreg2 and xxreg3.

2016-10-11 Thread Ben Pfaff
On Mon, Oct 10, 2016 at 11:38:21AM -0700, Jarno Rajahalme wrote: > > > On Oct 7, 2016, at 5:54 PM, Justin Pettit wrote: > > > > > >> On Oct 7, 2016, at 5:41 PM, Jarno Rajahalme wrote: > >> > >> xxreg2 and xxreg3 had the same NXM_NX_* names as xxreg0 and

Re: [ovs-dev] [PATCH 4/4] expr: Better simplify some special cases of expressions.

2016-10-11 Thread Ben Pfaff
On Mon, Oct 10, 2016 at 04:52:07PM -0700, Andy Zhou wrote: > On Thu, Oct 6, 2016 at 8:30 PM, Ben Pfaff wrote: > > > It's pretty unlikely that a human would write expressions like these, but > > they can come up in machine-generated expressions and it seems best to > > simplify them

Re: [ovs-dev] [PATCH 09/12] dpif: Reorder elements in dpif_upcall structure.

2016-10-11 Thread Bodireddy, Bhanuprakash
>-Original Message- >From: Jarno Rajahalme [mailto:ja...@ovn.org] >Sent: Monday, October 10, 2016 9:01 PM >To: Bodireddy, Bhanuprakash >Cc: dev@openvswitch.org >Subject: Re: [ovs-dev] [PATCH 09/12] dpif: Reorder elements in dpif_upcall >structure. > >How

Re: [ovs-dev] [PATCH] netdev-dpdk: Optimise the initialization of "port_conf"

2016-10-11 Thread Kavanagh, Mark B
> >The member "max_rx_pkt_len" of "port_conf" is only used if >jumbo_frame enabled, so it can be initialized with value '0'. > >Signed-off-by: Binbin Xu >--- > lib/netdev-dpdk.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > >diff --git a/lib/netdev-dpdk.c

[ovs-dev] The Patch netdev-dpdk: add TSO support for vhost-user ports

2016-10-11 Thread Michael Qiu
Hi, all This patch is very important for users want to improve the performance of the large packets. But you know, in data center, lots of networks using vxlan, so if it supports vxlan, then it will be very useful. Would you guys has a plan to support it? I would like to help test it,

Re: [ovs-dev] [PATCH 05/12] dpif-netdev: Clear flow batches inside packet_batch_execute.

2016-10-11 Thread Fischetti, Antonio
Thanks Daniele for all your explanations. Instead of the proposed changes, is it worth to add a comment to the code just to explain why that loop is needed? This way we will avoid other people attempting to make the same change in the future. Could be something like: +/* All the flow

Re: [ovs-dev] The Patch netdev-dpdk: add TSO support for vhost-user ports

2016-10-11 Thread Michael Qiu
Hi, Mark OK, once it's ready, pls let me know and I'm glade to help to test it. BTW, you mentioned the gap, is that the TSO and CSUM of tunnel offload? I'm familiar with it, and I hope I could do something on it if possible. 2016/10/11 22:34, Kavanagh, Mark B : Hi, all This patch is

[ovs-dev] [PATCH] ovn-test: Fix 'test-ovn composition' crash

2016-10-11 Thread Andy Zhou
Without this fix, the added test will core dump. Signed-off-by: Andy Zhou --- tests/ovn.at | 4 tests/test-ovn.c | 4 ++-- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/tests/ovn.at b/tests/ovn.at index caf9f98..1f65e75 100644 --- a/tests/ovn.at +++

Re: [ovs-dev] [PATCH] netdev-dpdk: Optimise the initialization of "port_conf"

2016-10-11 Thread xu . binbin1
"port_conf" is a global const variables, and in function dpdk_eth_dev_queue_setup it is asigned to the local variables "conf". The jumbo_frame bit is set in the local varables, previous configuration shouldn't influence on the other port. Thanks "Kavanagh, Mark B"

Re: [ovs-dev] [PATCH] tests: Fix double-rebuild of testsuite for "check-valgrind".

2016-10-11 Thread Andy Zhou
On Wed, Oct 5, 2016 at 6:28 PM, Ben Pfaff wrote: > When I ran "make check-valgrind -j10" and the testsuite needed to be > rebuilt, two copies of it were rebuilt in parallel and sometimes they > raced with each other. I don't have the full story on exactly why this > happened, but

Re: [ovs-dev] [PATCH] lex: Treat formfeeds as white space.

2016-10-11 Thread Andy Zhou
On Fri, Oct 7, 2016 at 10:04 AM, Ben Pfaff wrote: > Also vertical tabs, whatever those are. > > Signed-off-by: Ben Pfaff > Acked-by: Andy Zhou ___ dev mailing list dev@openvswitch.org

Re: [ovs-dev] [PATCH] lex: Treat formfeeds as white space.

2016-10-11 Thread Ben Pfaff
On Tue, Oct 11, 2016 at 04:27:40PM -0700, Andy Zhou wrote: > On Fri, Oct 7, 2016 at 10:04 AM, Ben Pfaff wrote: > > > Also vertical tabs, whatever those are. > > > > Signed-off-by: Ben Pfaff > > > > Acked-by: Andy Zhou Thanks, I'll apply this to

Re: [ovs-dev] [PATCH] meta-flow: Fix the NXM_NX_* names of xxreg2 and xxreg3.

2016-10-11 Thread Jarno Rajahalme
> On Oct 11, 2016, at 8:33 AM, Ben Pfaff wrote: > > On Mon, Oct 10, 2016 at 11:38:21AM -0700, Jarno Rajahalme wrote: >> >>> On Oct 7, 2016, at 5:54 PM, Justin Pettit wrote: >>> >>> On Oct 7, 2016, at 5:41 PM, Jarno Rajahalme wrote:

Re: [ovs-dev] [PATCH v1, 1/1] ovn-northd: fix router ingress table ID in comments

2016-10-11 Thread Ben Pfaff
On Tue, Oct 11, 2016 at 07:50:20AM +, Zongkai LI wrote: > This patch fixes wrong table ID in comments for logical router ingress > table IP Routing, ARP Resolution and ARP request. > > Signed-off-by: Zongkai LI Applied, thanks!

[ovs-dev] QoS Rate limiting

2016-10-11 Thread KHAN, RAO ADNAN
Hi, I like to set ingress policy on TAP interfaces using "tc" utility. Reason being that I am using a different vswitch and not using OVS, hence cannot use ovs-vsctl as mentioned on http://openvswitch.org/support/config-cookbooks/qos-rate-limiting/ My question is, how do I get the *device*

[ovs-dev] [CudaMailTagged] [PATCH v3] netdev-dpdk: In some case, needn't reconfigure pmd threads when changing MTU

2016-10-11 Thread Binbin Xu
If the port is not an ethernet port, and the aligned size for the new MTU doesn't change, we needn't to reconfigure pmd thread. What we should do is that updating 'max_packet_len' atomic. Signed-off-by: Binbin Xu --- lib/netdev-dpdk.c | 38

[ovs-dev] [PATCH v1, 1/1] ovn-northd: fix router ingress table ID in comments

2016-10-11 Thread Zongkai LI
This patch fixes wrong table ID in comments for logical router ingress table IP Routing, ARP Resolution and ARP request. Signed-off-by: Zongkai LI --- ovn/northd/ovn-northd.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/ovn/northd/ovn-northd.c

[ovs-dev] [PATCH] netdev-dpdk: Optimise the initialization of "port_conf"

2016-10-11 Thread Binbin Xu
The member "max_rx_pkt_len" of "port_conf" is only used if jumbo_frame enabled, so it can be initialized with value '0'. Signed-off-by: Binbin Xu --- lib/netdev-dpdk.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/lib/netdev-dpdk.c