[ovs-dev] [PATCH v2] datapath: backport: vxlan: avoid using stale vxlan socket.

Upstream commit: commit c6fcc4fc5f8b592600c7409e769ab68da0fb1eca Author: pravin shelar Date: Fri Oct 28 09:59:15 2016 -0700 vxlan: avoid using stale vxlan socket. When vxlan device is closed vxlan socket is freed. This operation can race with

[ovs-dev] ovs-2.5 --with-dpdk compilation error -- warning: implicit declaration of function ‘_mm_alignr_epi8’

Hi, I'm trying to follow the instructions in ovs-2.5/INSTALL.DPDK.md and am getting the following error. This is with dpdk-2.2.0 and Centos 7.1: from lib/netdev-dpdk.c:58: /third-party/dpdk/x86_64-native-linuxapp-gcc/include/rte_memcpy.h: In function ‘rte_memcpy’:

Re: [ovs-dev] [PATCH] ovs-router: Fix selection of source IP address when a gateway ip is introduced

I can't get any of the versions of this patch to apply. Maybe you should just send it as a Github pull request. On Thu, Oct 27, 2016 at 03:21:49PM +, Waizel, Ariel wrote: > OK I tried again - I think the tabs are OK, but not sure about the extra new > lines... if there's a problem I'll try

Re: [ovs-dev] [PATCH 2/3] datapath: backport: geneve: avoid using stale geneve socket.

On 29 October 2016 at 21:33, Pravin B Shelar wrote: > Upstream commit: > commit fceb9c3e38252992bbf1a3028cc2f7b871211533 > Author: pravin shelar > Date: Fri Oct 28 09:59:16 2016 -0700 > > geneve: avoid using stale geneve socket. > > This

Re: [ovs-dev] [PATCH] ofproto-dpif: Log warning when ct action or its variants are not supported.

On 31 October 2016 at 13:23, Ben Pfaff wrote: > Some datapaths do not support the ct action, and others support only a > subset of its features. Until now, it has been difficult to tell why a > particular action is being rejected. This commit should make it clearer. > >

Re: [ovs-dev] [PATCH] FAQ: Mention conntrack capability for packet filtering.

On Fri, Oct 28, 2016 at 12:13:44PM -0700, Han Zhou wrote: > The exiting explanation didn't tell user the conntrack capability > and user may be unaware of the stateful feature of OVS. > > Signed-off-by: Han Zhou Good idea, I rebased this to the new FAQ.rst and rephrased it,

Re: [ovs-dev] [PATCH 1/3] datapath: backport: vxlan: avoid using stale vxlan socket.

On Mon, Oct 31, 2016 at 2:05 PM, Joe Stringer wrote: > On 29 October 2016 at 21:33, Pravin B Shelar wrote: >> Upstream commit: >> commit c6fcc4fc5f8b592600c7409e769ab68da0fb1eca >> Author: pravin shelar >> Date: Fri Oct 28 09:59:15

Re: [ovs-dev] [PATCH 3/3] lisp: avoid using stale lisp socket.

On 29 October 2016 at 21:33, Pravin B Shelar wrote: > This patch is similar to earlier vxlan patch. > Lisp device close operation frees lisp socket. This > operation can race with lisp-xmit function which > dereferences lisp socket. Following patch uses RCU > mechanism to avoid

Re: [ovs-dev] [PATCH] ofproto-dpif: Log warning when ct action or its variants are not supported.

On Mon, Oct 31, 2016 at 02:16:05PM -0700, Joe Stringer wrote: > On 31 October 2016 at 13:23, Ben Pfaff wrote: > > Some datapaths do not support the ct action, and others support only a > > subset of its features. Until now, it has been difficult to tell why a > > particular action

Re: [ovs-dev] [PATCH] ovs-router: Fix selection of source IP address when a gateway ip is introduced

Ariel, do you mind if I submit it myself with your authorship and sign-off as soon as I test it and can give my sign-off? Cascardo. On Mon, Oct 31, 2016 at 01:55:16PM -0700, Ben Pfaff wrote: > I can't get any of the versions of this patch to apply. Maybe you > should just send it as a Github

Re: [ovs-dev] [PATCH 1/3] datapath: backport: vxlan: avoid using stale vxlan socket.

On 29 October 2016 at 21:33, Pravin B Shelar wrote: > Upstream commit: > commit c6fcc4fc5f8b592600c7409e769ab68da0fb1eca > Author: pravin shelar > Date: Fri Oct 28 09:59:15 2016 -0700 > > vxlan: avoid using stale vxlan socket. > > When

Re: [ovs-dev] [PATCH] release: Propose a shorter release cycle for 2.7.

> On Oct 31, 2016, at 12:22 PM, Russell Bryant wrote: > > > > On Mon, Oct 31, 2016 at 5:23 PM, Justin Pettit wrote: > >> > On Oct 29, 2016, at 9:19 AM, Russell Bryant wrote: >> > >> > + >> > +The following table identifies the planned

[ovs-dev] [CudaMailTagged] [PATCH 1/4] ovn: Support DNAT with port.

When the type of NAT is dnat, the externally visible IP address and port number can be DNATted to the IP address and port number in the logical space. Adds a protocol column for the NAT. Valid protocols are tcp or udp. This column is useful when a port number is provided as part of the

Re: [ovs-dev] [PATCH 3/5] lib/dp-packet: Fix data_len issue with multi-segments

2016/10/28 18:09, Kavanagh, Mark B : This patch didn't apply cleanly either; 'apply -3' resolved the issue, but I recommend rebasing to HEAD of master for next version. Other than that, just some minor cosmetic comments inline. When a packet is from DPDK source, and it contains multipule

Re: [ovs-dev] [PATCH 3/5] lib/dp-packet: Fix data_len issue with multi-segments

2016/10/28 18:09, Kavanagh, Mark B : This patch didn't apply cleanly either; 'apply -3' resolved the issue, but I recommend rebasing to HEAD of master for next version. Other than that, just some minor cosmetic comments inline. When a packet is from DPDK source, and it contains multipule

Re: [ovs-dev] [PATCH 1/5] lib/dp-packet: init the mbuf to zero when build with DPDK

2016/10/28 17:25, Kavanagh, Mark B: When building with DPDK, and using xmalloc() to get a new packet, field mbuf of the packet will not be initialized, but it's very important for DPDK port when copying the data to DPDK mbuf, because if ol_flags and other info are random values, DPDK driver may

Re: [ovs-dev] [PATCH 4/5] lib/dp-packet: copy multi-segments data from DPDK mbuf

2016/10/28 18:50, Kavanagh, Mark B : When doing packet clone, if packet source is from DPDK driver, multi-segment must be considered, and copy the segment's data one by one. Signed-off-by: Michael Qiu Signed-off-by: Jijiang Liu --- lib/dp-packet.c

[ovs-dev] [PATCH 3/4] ovn-nbctl: Fix manpage formatting typo.

Signed-off-by: nickcooper-zhangtonghao --- ovn/utilities/ovn-nbctl.8.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ovn/utilities/ovn-nbctl.8.xml b/ovn/utilities/ovn-nbctl.8.xml index be802da..993e1c4 100644 ---

[ovs-dev] [PATCH 2/4] ovn-nbctl: Add NAT commands.

This patch provides the command line to create NAT rules on logical router. Signed-off-by: nickcooper-zhangtonghao --- ovn/utilities/ovn-nbctl.8.xml | 66 ++ ovn/utilities/ovn-nbctl.c | 203 ++

[ovs-dev] [PATCH 4/4] ovs: optimize 'ip_parse_port' function.

Signed-off-by: nickcooper-zhangtonghao --- lib/packets.c | 11 --- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/lib/packets.c b/lib/packets.c index 990c407..1d2d452 100644 --- a/lib/packets.c +++ b/lib/packets.c @@ -436,15 +436,12

[ovs-dev] [PATCH] datapath: geneve: Handle vlan tag

The compat vlan code ignores vlan tag for inner packet on egress path. Following patch fixes this by inserting the tag for inner packet before tunnel encapsulation. Signed-off-by: Pravin B Shelar --- datapath/linux/compat/geneve.c | 26 -- 1 file

Re: [ovs-dev] [PATCH] ovs-router: Fix selection of source IP address when a gateway ip is introduced

Don't mind, go ahead הודעה מקורית מאת: Thadeu Lima de Souza Cascardo נשלח: Monday, October 31, 2016 11:36 PM אל: Ben Pfaff נושא: Re: [ovs-dev] [PATCH] ovs-router: Fix selection of source IP address when a gateway ip is introduced עותק:

[ovs-dev] [PATCH] netdev-dpdk: Fix crash in QoS.

qos_conf can be NULL. This can be easily reproduced by setting egress QoS on a port: ``` ovs-vsctl set port dpdk2 qos=@newqos -- --id=@newqos create qos type=egress-policer other-config:cir=4600 other-config:cbs=2048 ``` Reported-by: Ian Stokes Fixes: 78bd47cf44a5

Re: [ovs-dev] [PATCH 2/5] lib/dp-packet: copy additional packet info when do packet copy

2016/10/28 17:47, Kavanagh, Mark B : Currently, when doing packet copy, lots of DPDK mbuf's info will be missed, like packet type, ol_flags, etc. Those information is very important for DPDK to do packets processing. Signed-off-by: Michael Qiu Signed-off-by: Jijiang Liu

Re: [ovs-dev] [PATCH] ofproto-dpif: Log warning when ct action or its variants are not supported.

On 31 October 2016 at 14:33, Ben Pfaff wrote: > On Mon, Oct 31, 2016 at 02:16:05PM -0700, Joe Stringer wrote: >> On 31 October 2016 at 13:23, Ben Pfaff wrote: >> > Some datapaths do not support the ct action, and others support only a >> > subset of its features.

Re: [ovs-dev] [PATCH v2] datapath: backport: vxlan: avoid using stale vxlan socket.

On Mon, Oct 31, 2016 at 5:24 PM, Joe Stringer wrote: > On 31 October 2016 at 14:36, Pravin B Shelar wrote: >> Upstream commit: >> commit c6fcc4fc5f8b592600c7409e769ab68da0fb1eca >> Author: pravin shelar >> Date: Fri Oct 28 09:59:15

Re: [ovs-dev] [PATCH v2] datapath: backport: vxlan: avoid using stale vxlan socket.

On 31 October 2016 at 14:36, Pravin B Shelar wrote: > Upstream commit: > commit c6fcc4fc5f8b592600c7409e769ab68da0fb1eca > Author: pravin shelar > Date: Fri Oct 28 09:59:15 2016 -0700 > > vxlan: avoid using stale vxlan socket. > > When

Re: [ovs-dev] [PATCH 1/5] lib/dp-packet: init the mbuf to zero when build with DPDK

2016/10/28 17:25, Kavanagh, Mark B : When building with DPDK, and using xmalloc() to get a new packet, field mbuf of the packet will not be initialized, but it's very important for DPDK port when copying the data to DPDK mbuf, because if ol_flags and other info are random values, DPDK driver

[ovs-dev] [PATCH] ofproto-dpif: Log warning when ct action or its variants are not supported.

Some datapaths do not support the ct action, and others support only a subset of its features. Until now, it has been difficult to tell why a particular action is being rejected. This commit should make it clearer. Reported-by: Kevin Lin Reported-at:

Re: [ovs-dev] OVS 2.6.1 release?

> On Oct 31, 2016, at 6:10 AM, Richard Theis wrote: > > > So, it turns out my fix does not introduce any new problems. I have > > just posted > > it, so consider if you want to wait to apply it before releasing. > > Just checking on the current status for 2.6.1 release.

Re: [ovs-dev] OVS 2.6.1 release?

"dev" wrote on 10/25/2016 12:49:47 PM: > From: Thadeu Lima de Souza Cascardo > To: Justin Pettit > Cc: ovs dev > Date: 10/25/2016 12:50 PM > Subject: Re: [ovs-dev] OVS 2.6.1 release? > Sent by: "dev"

Re: [ovs-dev] [PATCH v4] fat-rwlock: Make fat-rwlock upgradable.

Do you have a planned use for it? I'm more interested in infrastructure improvements when there's a use case. On Wed, Oct 12, 2016 at 04:33:21PM +0300, Ilya Maximets wrote: > Hi, Ben. > > So, what about this patch? It's still not in mail-list, I guess, > and still applicable. > > Best regards,

Re: [ovs-dev] [PATCH] release: Propose a shorter release cycle for 2.7.

> On Oct 29, 2016, at 9:19 AM, Russell Bryant wrote: > > diff --git a/Documentation/release-process.md > b/Documentation/release-process.md > index 0f8f49d..0c53812 100644 > --- a/Documentation/release-process.md > +++ b/Documentation/release-process.md > @@ -83,14 +83,24 @@

Re: [ovs-dev] OVS 2.6.1 release?

On Mon, Oct 31, 2016 at 9:57 AM, Justin Pettit wrote: > >> On Oct 18, 2016, at 10:14 PM, Pravin Shelar wrote: >> >> On Tue, Oct 18, 2016 at 8:35 AM, Justin Pettit wrote: >>> On Oct 18, 2016, at 5:31 PM, Russell Bryant

[ovs-dev] fast failover config

Hello, In the sequence of an email I sent earlier for another mailing list, I would like to know if anyone can confirm me if OVS allows for fast failover group type configurations? I've received an answer saying it doesn't but I'm having serious doubts. Thanks Hi, > > I'm trying to configure a

Re: [ovs-dev] fast failover config

Nevermind, just realised what I was doing wrong and made it worked. thanks. 2016-10-24 12:46 GMT+01:00 Rui Q : > Hello, > > In the sequence of an email I sent earlier for another mailing list, I > would like to know if anyone can confirm me if OVS allows for fast

Re: [ovs-dev] [PATCH v4] fat-rwlock: Make fat-rwlock upgradable.

Hi, Ben. So, what about this patch? It's still not in mail-list, I guess, and still applicable. Best regards, Ilya Maximets. On 15.07.2016 15:44, Ilya Maximets wrote: > New functions 'fat_rwlock_{up,down}grade()' introduced to allow > upgrading read-lock to write-lock and downgrading it back. >

Re: [ovs-dev] OVS 2.6.1 release?

> On Oct 18, 2016, at 10:14 PM, Pravin Shelar wrote: > > On Tue, Oct 18, 2016 at 8:35 AM, Justin Pettit wrote: >> >>> On Oct 18, 2016, at 5:31 PM, Russell Bryant wrote: >>> On Tue, Oct 18, 2016 at 4:54 AM, Justin Pettit

Re: [ovs-dev] OVS 2.6.1 release?

> On Oct 25, 2016, at 10:49 AM, Thadeu Lima de Souza Cascardo > wrote: > > So, it turns out my fix does not introduce any new problems. I have just > posted > it, so consider if you want to wait to apply it before releasing. Just to confirm, this is the patch labeled

Re: [ovs-dev] OVS 2.6.1 release?

On Mon, Oct 31, 2016 at 09:57:39AM -0700, Justin Pettit wrote: > > > On Oct 25, 2016, at 10:49 AM, Thadeu Lima de Souza Cascardo > > wrote: > > > > So, it turns out my fix does not introduce any new problems. I have just > > posted > > it, so consider if you want to wait

Re: [ovs-dev] [PATCH] ifnotifier: do not wake up when there is no db connection

On Tue, Oct 25, 2016 at 03:44:43PM -0200, Thadeu Lima de Souza Cascardo wrote: > When bridge uses the interface notifier, it wakes up until a reconfiguration > takes place. However, if there is no connection or a lock contention to the > database, the check for reconfiguration will not take place.

Re: [ovs-dev] OVS 2.6.1 release?

On Mon, Oct 31, 2016 at 09:57:39AM -0700, Justin Pettit wrote: > > > On Oct 25, 2016, at 10:49 AM, Thadeu Lima de Souza Cascardo > > wrote: > > > > So, it turns out my fix does not introduce any new problems. I have just > > posted > > it, so consider if you want to wait

Re: [ovs-dev] [PATCH] release: Propose a shorter release cycle for 2.7.

On Mon, Oct 31, 2016 at 5:23 PM, Justin Pettit wrote: > > > On Oct 29, 2016, at 9:19 AM, Russell Bryant wrote: > > > > diff --git a/Documentation/release-process.md b/Documentation/release- > process.md > > index 0f8f49d..0c53812 100644 > > ---

[ovs-dev] [PATCH 2/2] ofproto-dpif-xlate: remove vlan checking when mirroring packets

Even access port can carry packets on different VLANs when working with OpenFlow. And VLANs can be selected for mirroring. So it is not needed to check vlan when mirroring packets. Signed-off-by: Hunt Xu --- ofproto/ofproto-dpif-xlate.c | 32 +++

[ovs-dev] [PATCH 1/2] ofproto-dpif-xlate: don't check vlan in normal action if vid changed

If a packet's vlan vid has been changed(striped or modified) before entering the "normal" processing, it should be consider a packet on the new VLAN. Therefore vlan checking is not needed. Signed-off-by: Hunt Xu --- ofproto/ofproto-dpif-xlate.c | 23

[ovs-dev] [PATCH 0/2] ofproto-dpif-xlate: remove unneeded vlan check

Hi folks, At the very beginning I was just trying to modify packets ingressing from an access port, using "mod_vlan_vid" & "NORMAL" to change the VLAN vid, expecting them to be then switched to the ports which carries the dest VLAN. However, I failed. I used "ovs-appctl ofproto/trace" to debug,