- Original Message -
> From: "Aaron Conole"
> To: dev@openvswitch.org
> Sent: Tuesday, May 24, 2016 4:35:29 PM
> Subject: [ovs-dev] [RFC] ovs-tcpdump: Add a tcpdump wrapper utility
>
> Currently, there is some documentation which describes setting up and
> using port mirrors for bridges
With a recent kernel (4.6-ish) and current OVS master, I'm seeing failures
in several system-traffic.at test cases under "make check-kernel".
For the "conntrack - FTP" test failure, all seems to be well up to the
last test case, which is a passive FTP request with flows2.txt policy
installed.
The
- Original Message -
> From: "Joe Stringer"
> To: "Lance Richardson"
> Cc: "ovs dev"
> Sent: Tuesday, May 31, 2016 8:29:44 PM
> Subject: Re: [ovs-dev] conntrack - FTP test case failure
>
> On 31 May 2016 at 15:54, Lance Richardson wr
- Original Message -
> From: "Joe Stringer"
> To: "Lance Richardson"
> Cc: dev@openvswitch.org, "Paul Boca"
> Sent: Thursday, June 2, 2016 9:41:23 PM
> Subject: Re: [ovs-dev] [PATCH V2 4/4] tests: Fix fail of
> OVS_APP_EXIT_AND_WAIT on
- Original Message -
> From: "Joe Stringer"
> To: "Lance Richardson"
> Cc: dev@openvswitch.org, "Paul Boca"
> Sent: Thursday, June 2, 2016 9:41:23 PM
> Subject: Re: [ovs-dev] [PATCH V2 4/4] tests: Fix fail of
> OVS_APP_EXIT_AND_WAIT on W
- Original Message -
> From: "Ben Pfaff"
> To: "Lance Richardson"
> Cc: "Joe Stringer" , dev@openvswitch.org, "Paul Boca"
>
> Sent: Friday, June 3, 2016 12:38:56 PM
> Subject: Re: [ovs-dev] [PATCH V2 4/4] tests: Fix fail of
&g
- Original Message -
> From: "Ben Pfaff"
> To: "Lance Richardson"
> Cc: "Joe Stringer" , dev@openvswitch.org, "Paul Boca"
>
> Sent: Friday, June 3, 2016 2:31:30 PM
> Subject: Re: [ovs-dev] [PATCH V2 4/4] tests: Fix fail of
&g
- Original Message -
> From: "Ben Pfaff"
> To: "Lance Richardson"
> Cc: "Joe Stringer" , dev@openvswitch.org, "Paul Boca"
>
> Sent: Friday, June 3, 2016 3:14:55 PM
> Subject: Re: [ovs-dev] [PATCH V2 4/4] tests: Fix fail of
&g
ocess ID as separate parameters. In order
to better detect issues in this logic in the future, checks have
been added to verify that the pidfile exists before using its
contents.
Tested on a Linux system.
Fixes: f9b11f2a09b4 ("tests: Make OVS_APP_EXIT_AND_WAIT() wait for process
terminati
- Original Message -
> From: "Darrell Ball"
> To: "Lance Richardson"
> Cc: "ovs dev"
> Sent: Tuesday, July 12, 2016 7:05:18 PM
> Subject: Re: [ovs-dev] [PATCH] ovn-controller-vtep: occasional failure in
> "binding 1" test
> > diff --git a/tests/ovn-controller-vtep.at b/tests/ovn-controller-vtep.at
> > index c296f0e..c978137 100644
> > --- a/tests/ovn-controller-vtep.at
> > +++ b/tests/ovn-controller-vtep.at
> > @@ -225,8 +225,9 @@ AT_CHECK([sed -n 's/^.*\(|WARN|.*\)$/\1/p'
> > ovn-controller-vtep.log | sed 's/([[-
>
command will fail because ovs-vtep will have already deleted
p0 from the vtep db.
Eliminate this race while adding an additional check to verify that
ovs-vtep is working as expected by waiting for ovs-vtep to remove
entries for the deleted physical ports from the vtep db.
Signed-off-by: Lance Ric
I've been doing some investigation into the "Limiting the impact of
a compromised chassis" issue described in ovn/TODO. These are some initial
thoughts, posting here for feedback and any other ideas folks might have
about how we should go about solving this part of the issue.
The fact that we're h
> From: "Darrell Ball"
> To: "Lance Richardson"
> Cc: "ovs dev"
> Sent: Tuesday, July 12, 2016 5:34:04 PM
> Subject: Re: [ovs-dev] Question about ovs-vtep implementation
>
> On Fri, Jul 8, 2016 at 12:20 PM, Lance Richardson
> wrote:
&g
> From: "Lance Richardson"
> To: dev@openvswitch.org
> Sent: Wednesday, July 6, 2016 7:39:52 PM
> Subject: [ovs-dev] [PATCH] netdev-dummy: fix crash with more than one passive
> connection
>
> Investigation found that Some of the occasional failures in the
> &q
- Original Message -
> From: "Ben Pfaff"
> To: "Amitabha Biswas"
> Cc: dev@openvswitch.org
> Sent: Monday, July 18, 2016 1:33:56 PM
> Subject: Re: [ovs-dev] [v1 1/1] Fix "raceful" E2E ovn tests
>
> On Fri, May 20, 2016 at 11:17:57AM -0700, Amitabha Biswas wrote:
> > This patch fixes the
- Original Message -
> From: "Ben Pfaff"
> To: "Lance Richardson"
> Cc: "Amitabha Biswas" , dev@openvswitch.org
> Sent: Monday, July 18, 2016 2:34:02 PM
> Subject: Re: [ovs-dev] [v1 1/1] Fix "raceful" E2E ovn tests
>
> On
- Original Message -
> From: "Darrell Ball"
> To: "Lance Richardson"
> Cc: "ovs dev" , "Daniele Di Proietto"
>
> Sent: Friday, July 15, 2016 2:06:36 PM
> Subject: Re: [ovs-dev] Question about ovs-vtep implementation
>
- Original Message -
> From: "Ryan Moats"
> To: "Lance Richardson"
> Cc: dev@openvswitch.org
> Sent: Monday, July 18, 2016 11:36:27 PM
> Subject: Re: [ovs-dev] [PATCH] netdev-dummy: fix crash with more than one
> passive connection
>
- Original Message -
> From: "Ryan Moats"
> To: "Lance Richardson"
> Cc: dev@openvswitch.org
> Sent: Tuesday, July 19, 2016 10:20:37 AM
> Subject: Re: [ovs-dev] [PATCH] netdev-dummy: fix crash with more than one
> passive connection
>
>
It seems the failure rate for OVN end-to-end tests went up significantly
when commit 70c7cfef188b5ae9940abd5b7d9fe46b1fa88c8e was merged earlier
this week.
After this commit, 100 iterations of "make check TESTSUITEFLAGs='-j8 -k ovn'"
gave (number of failures in left-most column):
2 2179: ovn
- Original Message -
> From: "Ryan Moats"
> To: "Lance Richardson"
> Cc: "ovs dev"
> Sent: Thursday, July 21, 2016 9:05:53 AM
> Subject: Re: [ovs-dev] ovn test failures
>
> "dev" wrote on 07/21/2016 06:32:02 AM:
>
>
- Original Message -
> From: "Ben Pfaff"
> To: "Lance Richardson"
> Cc: dev@openvswitch.org
> Sent: Friday, July 22, 2016 6:47:14 PM
> Subject: Re: [ovs-dev] [PATCH v2] ovn-controller: eliminate stall in ofctrl
> state machine
>
> On
- Original Message -
> From: "Ben Pfaff"
> To: "Lance Richardson"
> Cc: dev@openvswitch.org
> Sent: Friday, July 22, 2016 6:16:59 PM
> Subject: Re: [ovs-dev] [PATCH] netdev-dummy: fix crash with more than one
> passive connection
>
> On
> From: "Ben Pfaff"
> To: "Lance Richardson"
> Cc: dev@openvswitch.org
> Sent: Saturday, July 23, 2016 1:49:36 AM
> Subject: Re: [ovs-dev] [PATCH v2] ovn-controller: eliminate stall in ofctrl
> state machine
>
> On Fri, Jul 22, 2016
- Original Message -
> From: "Ryan Moats"
> To: dev@openvswitch.org
> Sent: Friday, July 22, 2016 5:54:26 PM
> Subject: [ovs-dev] [PATCH] ovn-controller: Handle physical changes correctly
>
> [1] reported increased failure rates in certain tests
> with incremental processing (the numbers
Wow, that is a very strange finding.
I also see it on Fedora 23 with gcc (GCC) 5.3.1 20160406 (Red Hat 5.3.1-6),
2/100 failures with default configuration, 100% failure rate with -march=native.
Lance
- Original Message -
> From: "Ilya Maximets"
> To: "Numan Siddique" , "Ben Pfaff" ,
d 20 times out of 20 attempts with
this fix.
Signed-off-by: Lance Richardson
---
tests/ovn.at | 4
1 file changed, 4 insertions(+)
diff --git a/tests/ovn.at b/tests/ovn.at
index 059c969..d353143 100644
--- a/tests/ovn.at
+++ b/tests/ovn.at
@@ -2334,6 +2334,10 @@ echo "-
- Original Message -
> From: "Lance Richardson"
> To: dev@openvswitch.org
> Sent: Friday, June 3, 2016 6:09:26 PM
> Subject: [ovs-dev] [PATCH] tests: fix issue in use of OVS_APP_EXIT_AND_WAIT
>
> Commit f9b11f2a09b4 introduced a loop to wait for process exi
- Original Message -
> From: "Alin Serdean"
> To: "Lance Richardson" , dev@openvswitch.org
> Cc: "Paul Boca"
> Sent: Monday, June 6, 2016 8:52:37 PM
> Subject: RE: [ovs-dev] [PATCH] tests: fix issue in use of
> OVS_APP_EXIT_AND_WAIT
>
ddress this issue by adding a one second sleep between steps (2) and
> (3). Adding a sleep does not actually fix anything, but it
> does make this test case more likely to work correctly.
>
> In one series of tests, this test case failed 11 times out of 20
> without this fix and su
Sorry, wrong commit ID for Fixes: tag, it should be:
Fixes: 5412db307420 ("ovn: Add column enabled to table Logical_Router")
- Original Message -
> From: "Lance Richardson"
> To: dev@openvswitch.org, "Ben Pfaff"
> Sent: Thursday, June 9, 2016 9:4
- Original Message -
> From: "Guru Shetty"
> To: "Aaron Rosen"
> Cc: "ovs dev"
> Sent: Thursday, June 9, 2016 4:20:37 PM
> Subject: Re: [ovs-dev] [PATCH 8/8] automake: Add ovs-bugtool.in to
> flake8-check.
>
> On 9 June 2016 at 13:14, Aaron Rosen wrote:
>
> > This patch seemed to
g; I've attempted to recreate but after
resurrecting a Windows box and working out how to build ovs on it,
I've found that (sadly) ovs builds but has unresolved run-time linkage
issues on win7.
Do you have any suggestions for moving forward?
Thanks,
Lance
- Original Message -
- Original Message -
> From: "Paul Boca"
> To: "Lance Richardson"
> Cc: dev@openvswitch.org, "Alin Serdean" ,
> "Ben Pfaff"
> Sent: Friday, June 10, 2016 4:16:15 AM
> Subject: RE: [ovs-dev] [PATCH] tests: fix issue in use of
&g
- Original Message -
> From: "Ben Pfaff"
> To: "Lance Richardson"
> Cc: dev@openvswitch.org
> Sent: Friday, June 10, 2016 11:16:08 AM
> Subject: Re: [ovs-dev] [PATCH] tests: fix issue in use of
> OVS_APP_EXIT_AND_WAIT
>
> On Fri, Jun 03, 2016
ocess ID as separate parameters. In order
to better detect issues in this logic in the future, checks have
been added to verify that the pidfile exists before using its
contents.
Tested on a Linux system.
Signed-off-by: Lance Richardson
---
v2: Updated definition of OVS_VSCTL_CLEANUP in ovs-vsctl.
- Original Message -
> From: "Lance Richardson"
> To: dev@openvswitch.org
> Sent: Friday, June 10, 2016 12:17:57 PM
> Subject: [ovs-dev] [PATCH] tests: fix issue in use of OVS_APP_EXIT_AND_WAIT
>
Apologies, I f
- Original Message -
> From: "Alin Serdean"
> To: "Lance Richardson" , dev@openvswitch.org
> Sent: Tuesday, June 14, 2016 1:22:36 PM
> Subject: RE: tests: fix issue in use of OVS_APP_EXIT_AND_WAIT
>
> I'll take a look over it tomorrow :).
- Original Message -
> From: "Paul Boca"
> To: "Lance Richardson" , "Alin Serdean"
>
> Cc: dev@openvswitch.org
> Sent: Tuesday, June 21, 2016 5:37:59 AM
> Subject: RE: tests: fix issue in use of OVS_APP_EXIT_AND_WAIT
>
> Hi Lan
Any feedback? I see that there are still numerous occurrences of the failure
addressed by this patch.
Thanks,
Lance
- Original Message -
> From: "Lance Richardson"
> To: dev@openvswitch.org, "Ben Pfaff" , na...@cn.ibm.com
> Sent: Thursday, June 9, 2
- Original Message -
> From: "Alin Serdean"
> To: "Lance Richardson" , dev@openvswitch.org
> Sent: Tuesday, June 14, 2016 1:22:36 PM
> Subject: RE: tests: fix issue in use of OVS_APP_EXIT_AND_WAIT
>
> I'll take a look over it tomorrow :).
- Original Message -
> From: "Paul Boca"
> To: "Lance Richardson"
> Cc: "Alin Serdean" , dev@openvswitch.org,
> "Ben Pfaff"
> Sent: Tuesday, June 21, 2016 3:43:44 PM
> Subject: RE: tests: fix issue in use of OVS_APP_EXIT_AND
> $8 > output],
> + AT_CHECK([ovsdb-client -vjsonrpc --detach --no-chdir
> --pidfile="`pwd`"/client-pid --log-file="`pwd`"/ovsdb-client-log -d json
> monitor --format=csv unix:socket $4 $5 $8 > output],
> [0], [ignore], [ignore], [kil
- Original Message -
> From: "Guru Shetty"
> To: "Paul Boca"
> Cc: dev@openvswitch.org
> Sent: Friday, June 24, 2016 2:50:35 PM
> Subject: Re: [ovs-dev] [PATCH] tests: Fixed ovsdb-monitor tests
>
> On 24 June 2016 at 09:51, Paul Boca wrote:
>
> > Redirect ovsdb-client stderr to /dev/nu
- Original Message -
> From: "Bhanuprakash Bodireddy"
> To: dev@openvswitch.org
> Sent: Monday, June 27, 2016 12:11:40 PM
> Subject: [ovs-dev] [PATCH] Makefile.am: Add clang static analysis support
>
> Clang Static Analyzer is a source code analysis tool to find bugs. This
> patch adds
- Original Message -
> From: "Bhanuprakash Bodireddy"
> To: "Lance Richardson"
> Cc: dev@openvswitch.org
> Sent: Monday, June 27, 2016 3:23:26 PM
> Subject: RE: [ovs-dev] [PATCH] Makefile.am: Add clang static analysis support
>
> >-Ori
> + scan-build -o $(srcdir)/tests/clang-analyzer-results
> --use-analyzer=/usr/bin/clang \
> + make || exit 1; \
> + else \
> + echo -e "Unable to find clang/scan-build, Install clang,clang-analyzer
>
ion is possible. This addresses
a cause of occasional failures in the "3 HVs, 3 LS, 3 lports/LS, 1 LR"
test case.
Signed-off-by: Lance Richardson
---
ovn/controller/binding.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ovn/controller/binding.c b/ovn/controller/binding
Gracefully exit all daemons in this test case.
Signed-off-by: Lance Richardson
---
tests/ovn.at | 21 +++--
1 file changed, 19 insertions(+), 2 deletions(-)
diff --git a/tests/ovn.at b/tests/ovn.at
index 37888bf..b8a9bf5 100644
--- a/tests/ovn.at
+++ b/tests/ovn.at
@@ -1866,9
- Original Message -
> From: "Ben Pfaff"
> To: "Lance Richardson"
> Cc: dev@openvswitch.org
> Sent: Saturday, July 2, 2016 2:45:23 PM
> Subject: Re: [ovs-dev] [PATCH] ovn: gracefully exit daemons in "3 HVs, 3 LS,
> 3 lports/LS, 1 LR" te
- Original Message -
> From: "Ben Pfaff"
> To: "Lance Richardson"
> Cc: dev@openvswitch.org
> Sent: Saturday, July 2, 2016 3:23:35 PM
> Subject: Re: [ovs-dev] [PATCH] ovn-controller: process lport bindings only
> when transaction is possible
&
- Original Message -
> From: "Lance Richardson"
> To: "Ben Pfaff"
> Cc: dev@openvswitch.org
> Sent: Saturday, July 2, 2016 4:11:14 PM
> Subject: Re: [ovs-dev] [PATCH] ovn-controller: process lport bindings only
> when transaction is poss
- Original Message -
> From: "Bhanuprakash Bodireddy"
> To: dev@openvswitch.org
> Cc: "daniele di proietto"
> Sent: Sunday, July 3, 2016 10:48:25 AM
> Subject: [ovs-dev] [PATCH v8 2/2] INSTALL.DPDK: Refactor DPDK install guide,
> add ADVANCED doc
>
> Add INSTALL.DPDK-ADVANCED doc
- Original Message -
> From: "Ben Pfaff"
> To: "Lance Richardson"
> Cc: dev@openvswitch.org
> Sent: Sunday, July 3, 2016 3:18:51 PM
> Subject: Re: [ovs-dev] [PATCH] ovn-controller: process lport bindings only
> when transaction is possible
>
&
This change set introduces new macros to simplify and consolidate
process termination handling for OVN test cases.
Signed-off-by: Lance Richardson
---
tests/ofproto-macros.at | 47
tests/ovn-controller.at | 11 +-
tests/ovn.at| 277
the state machine's "while state != old_state"
loop to include processing of receive events. Without this
fix, around 40 failures are seen out of 100 attempts, with
this fix no failures have been observed in several hundred
attempts.
Signed-off-by: Lance Richardson
---
ovn
- Original Message -
> From: "Lance Richardson"
> To: dev@openvswitch.org
> Sent: Tuesday, July 5, 2016 8:58:24 AM
> Subject: [ovs-dev] [PATCH] ovn-controller: eliminate stall in ofctrl state
> machine
>
> The "ovn -- 2 HVs, 3 LRs connecte
- Original Message -
> From: "Ryan Moats"
> To: "Lance Richardson"
> Cc: dev@openvswitch.org
> Sent: Tuesday, July 5, 2016 12:17:17 PM
> Subject: Re: [ovs-dev] [PATCH] ovn-controller: eliminate stall in ofctrl
> statemachine
>
++ b/Makefile.am
> @@ -401,6 +401,13 @@ ovsext_clean: datapath-windows/ovsext.sln
> endif
> .PHONY: ovsext
>
> +clang-analyze: clean
> + @which clang scan-build >/dev/null 2>&1 || \
> + (echo "Unable to find clang/scan
to a crash when the bogus packet buffer on the list is
dereferenced).
Fix by taking a hint from David Wheeler and adding a level of
indirection.
Signed-off-by: Lance Richardson
---
lib/netdev-dummy.c | 17 ++---
1 file changed, 10 insertions(+), 7 deletions(-)
diff --git a/lib/netd
n this test
case, and the difference between EPIPE and ECONNRESET on send
is simply a matter of whether the peer had unconsumed data
in its receive buffer when the peer socket was closed, it should
be OK to ignore "reset by peer" logs as well.
Signed-off-by: Lance Richardson
---
tests/ovn-sbc
Self-NAK, this is needed in two other locations and a typo
needs to be fixed. V2 is in progress.
- Original Message -
> From: "Lance Richardson"
> To: dev@openvswitch.org
> Sent: Thursday, July 7, 2016 2:49:14 PM
> Subject: [ovs-dev] [PATCH] ovn-sbctl: eliminat
l and
ovn-vtep-controller tests, so fix it there as well.
Signed-off-by: Lance Richardson
---
Changes in v2:
- Duplicated fix in ovn-nbctl.at and ovn-controller-vtep.at
- Changed sed match string from 'connection reset' to 'reset by peer'.
tests/ovn-controll
- Original Message -
> From: "Justin Pettit"
> To: "Lance Richardson"
> Cc: dev@openvswitch.org
> Sent: Thursday, July 7, 2016 5:25:52 PM
> Subject: Re: [ovs-dev] [PATCH] ovn-controller: eliminate stall in ofctrl
> state machine
>
>
>
served in
several hundred attempts.
Signed-off-by: Lance Richardson
---
v2: Added maximum iteration limit to state machine loop.
ovn/controller/ofctrl.c | 50 ++---
1 file changed, 27 insertions(+), 23 deletions(-)
diff --git a/ovn/controller/ofctrl.c
Oops, had intended to cc: Justin.
- Original Message -
> From: "Lance Richardson"
> To: dev@openvswitch.org
> Sent: Thursday, July 7, 2016 8:31:08 PM
> Subject: [ovs-dev] [PATCH v2] ovn-controller: eliminate stall in ofctrl
> state machine
>
> The
command will fail because ovs-vtep will have already deleted
p0 from the vtep db.
Accomodate this race while ensuring that p0 and p1 have been removed
from both dbs by using the "--if-exists" option on the second delete.
Signed-off-by: Lance Richardson
---
tests/ovn-controller-vte
The "ovn-controller-vtep - vtep-macs 1" test case fails occasionally,
with ovs-vswitchd logs similar to these:
bridge|INFO|bridge br-vtep_vtep_ls1: added interface vx1 on port 2
tunnel|WARN|bfd1.2.3.5: attempting to add tunnel port with same config as
port 'vx1' (::->1.2.3.5, key=0, dp po
+ Ryan Moats
- Original Message -
> From: "Lance Richardson"
> To: dev@openvswitch.org
> Cc: "Justin Pettit"
> Sent: Thursday, July 7, 2016 8:33:57 PM
> Subject: Re: [ovs-dev] [PATCH v2] ovn-controller: eliminate stall in ofctrl
> state machine
- Original Message -
> From: "Darrell Ball"
> To: dlu...@gmail.com, d...@openvswitch.com
> Sent: Monday, July 11, 2016 11:07:03 AM
> Subject: [ovs-dev] [patch_v8] ovn: Add local router support (RFC).
>
> This patch adds local router support. The idea is to do openflow rule
> calculatio
- Original Message -
> From: "Ryan Moats"
> To: "Lance Richardson"
> Cc: dev@openvswitch.org, "Justin Pettit"
> Sent: Monday, July 11, 2016 1:44:18 PM
> Subject: Re: [ovs-dev] [PATCH v2] ovn-controller: eliminate stall in ofctrl
> sta
- Original Message -
> From: "Ben Pfaff"
> To: "Lance Richardson"
> Cc: dev@openvswitch.org
> Sent: Tuesday, February 23, 2016 7:26:13 PM
> Subject: Re: [ovs-dev] [PATCH] ovsdb-idl: improve error handling when schema
> is not available
>
&
entered
when a negative response to a schema request is received. When in
this state, ovsdb_idl_is_alive() now returns 'false', allowing clients
(currently ovn-nbctl, ovn-sbctl, vtep-ctl, and ovs-vsctl) to detect this
condition and exit with an appropriate error message.
Signed-off-by:
Daemons started in OVN tests are currently killed (via "on_exit kill"
in start_daemon()). This is problematic for tools (such as gcov) that
rely on exit() being called.
Fix by using "ovs-appctl ... exit" to gracefully terminate the daemons.
Signed-off-by: Lance Richards
As documented, the as() function should only create a subshell
to execute the provided command when a command is present. Correct
the implementation to check for the presence of the command parameter
instead of the sandbox name (which is always present in current
usage).
Signed-off-by: Lance
to a gcda file,
the gcda file will be corrupted.
These errors can be avoided by ensuring that deamons have fully
exited when given the "exit" command before executing any cleanup
actions.
Lance Richardson (4):
tests: Make OVS_APP_EXIT_AND_WAIT() wait for process termination
tests: m
macro.
Signed-off-by: Lance Richardson
---
tests/ovs-macros.at | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/tests/ovs-macros.at b/tests/ovs-macros.at
index f2923b0..dc7b700 100644
--- a/tests/ovs-macros.at
+++ b/tests/ovs-macros.at
@@ -135,8 +135,9 @@ dnl
dnl Ask the
Tools such as gcov rely on normal termination (via exit()), ensure
consistent graceful termination of daemons in tests by using
the OVS_APP_EXIT_AND_WAIT() macro.
Signed-off-by: Lance Richardson
---
tests/bridge.at| 2 +
tests/completion.at| 2 +-
tests/daemon.at
Add "check-lcov" target to generate an HTML code coverage report
for testsuite execution using lcov and genhtml.
Signed-off-by: Lance Richardson
---
.gitignore| 1 +
INSTALL.md| 6 ++
tests/automake.mk | 17 +
3 files changed, 24 insertions(+)
di
Lance
- Original Message -
> From: "Lance Richardson"
> To: dev@openvswitch.org
> Sent: Wednesday, March 2, 2016 4:40:44 PM
> Subject: [ovs-dev] [RFC 0/4] testsuite code coverage usability fixes, lcov
>
> This series addresses usability issues when executin
- Original Message -
> From: "Aaron Conole"
> To: "Lance Richardson"
> Cc: dev@openvswitch.org
> Sent: Wednesday, March 2, 2016 5:40:32 PM
> Subject: Re: [ovs-dev] [RFC 0/4] testsuite code coverage usability fixes, lcov
>
> Lance Richard
- Original Message -
> From: "Lance Richardson"
> To: dev@openvswitch.org
> Sent: Wednesday, March 2, 2016 4:40:44 PM
> Subject: [ovs-dev] [RFC 0/4] testsuite code coverage usability fixes, lcov
>
> This series addresses usability issues when executi
After fixing a couple of trivial compilation issues, I stopped at
one that's probably less trivial:
libtool: compile: clang -DHAVE_CONFIG_H -I. -I ./include -I ./include -I ./lib
-I ./lib -I/opt/local/include -Wstrict-prototypes -Wall -Wextra
-Wno-sign-compare -Wpointer-arith -Wformat-security
Handle OS X like other BSDs (date -r is not supported, use sha1
instead of sha1sum).
Signed-off-by: Lance Richardson
---
utilities/ovs-pki.in | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/utilities/ovs-pki.in b/utilities/ovs-pki.in
index a96ada3..9b2b5aa 100755
--- a
2016 2025 2026 2027 2028 2029 2030 failed
Lance Richardson (5):
ofproto-dpif: rename wait() to avoid collision with system wait(2)
timeval: Add clock_gettime() for OS X
utilities: OS X compatibility
rtbsd: OS X does not implement RTM_IFANNOUNCE
osx: Temporary compilation workarounds
Base OS X does not implement a tap netdevice, stub out netdev-bsd.c
for OS X.
OS X rounding/padding rules for rtnetlink messages need to be
researched, for now force route_table_fallback_lookup() to return
failure on OS X systems.
Signed-off-by: Lance Richardson
---
lib/netdev-bsd.c | 2
OS X does not implement clock_gettime().
Signed-off-by: Lance Richardson
---
lib/timeval.c | 33 -
1 file changed, 32 insertions(+), 1 deletion(-)
diff --git a/lib/timeval.c b/lib/timeval.c
index d390df1..8190b87 100644
--- a/lib/timeval.c
+++ b/lib/timeval.c
Conditionally compile code referencing RTM_IFANNOUNCE only for
non-OS X builds.
Signed-off-by: Lance Richardson
---
lib/route-table-bsd.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/lib/route-table-bsd.c b/lib/route-table-bsd.c
index b5ff3cc..b8c7089 100644
--- a/lib/route-table-bsd.c
Rename ofproto-dpif wait() to avoid collision with wait(2) under OS X.
Signed-off-by: Lance Richardson
---
ofproto/ofproto-dpif.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/ofproto/ofproto-dpif.c b/ofproto/ofproto-dpif.c
index b963ff2..2402a58 100644
--- a/ofproto
Rename ofproto-dpif wait() to avoid collision with wait(2) under OS X.
Signed-off-by: Lance Richardson
---
Changes from v1: None
ofproto/ofproto-dpif.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/ofproto/ofproto-dpif.c b/ofproto/ofproto-dpif.c
index b963ff2..2402a58
Avoid collision with system headers when building under OS X.
Signed-off-by: Lance Richardson
---
Changes from v1: this patch is new in v2.
lib/byte-order.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/byte-order.h b/lib/byte-order.h
index 3430e29..41c3931
OS X does not implement clock_gettime(), implement replacement.
Signed-off-by: Lance Richardson
---
Changes from v1: None
lib/timeval.c | 33 -
1 file changed, 32 insertions(+), 1 deletion(-)
diff --git a/lib/timeval.c b/lib/timeval.c
index d390df1..8190b87
Conditional compilation to account for:
- OS X does not implement RTM_IFANNOUNCE.
- OS X does not implement tap netdeivces.
- OS X does not implement RT_ROUNDUP().
Signed-off-by: Lance Richardson
---
Changes from v1:
- Combined patches 4 and 5 into patch number 4
- Added implementation
Handle OS X like other BSDs (date -r is not supported, use sha1
instead of sha1sum).
Signed-off-by: Lance Richardson
---
Changes from v1: None
utilities/ovs-pki.in | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/utilities/ovs-pki.in b/utilities/ovs-pki.in
index a96ada3
ng
in route_table_fallback_lookup(). Untested.
- Added patch to avoid collision between system ntohll() and htonll()
(should have been in v1, I somehow dropped it via "git rebase -i")
Lance Richardson (4):
ofproto-dpif: rename wait() to avoid collision with system wa
- Original Message -
> From: "Aaron Conole"
> To: "Lance Richardson"
> Cc: dev@openvswitch.org
> Sent: Tuesday, March 15, 2016 2:58:43 PM
> Subject: Re: [ovs-dev] [PATCH v2 0/5] Initial support for OS X builds
>
> Hi Lance,
>
> Lance R
- Fix two build issues
- Add build/prepare scripts for OS X
- Update .travis.yml to add an OS X build
Lance Richardson (2):
osx: Fix OS X build issues
travis: support OS X builds
.travis.yml | 13 +-
.travis/build.sh | 109
Add support for travis-ci OS X builds:
- Add linux- prefix to existing build/prepare scripts
- Create new OS X flavored build/prepare scripts
- Update .travis.yml for OS X
At this time only one build job included in the matrix for OS X.
Signed-off-by: Lance Richardson
---
.travis.yml
Newer versions of OS X define ntohll() and htonll() macros,
while older versions (including the version used for travis-ci
builds) do not. Adjust conditional compilation test to work
for both cases.
Eliminate an unused variable warning in lib/rtbsd.c.
Signed-off-by: Lance Richardson
---
lib
1 - 100 of 168 matches
Mail list logo
