On Wed, Aug 27, 2014 at 09:51:59AM -0700, Ben Pfaff wrote:
On Wed, Aug 27, 2014 at 10:26:14AM +0900, Simon Horman wrote:
On Fri, Aug 22, 2014 at 08:30:08AM -0700, Ben Pfaff wrote:
On Fri, Aug 22, 2014 at 09:19:41PM +0900, Simon Horman wrote:
I have been working with Netronome
On Wed, Aug 27, 2014 at 03:03:53PM -0500, Jesse Gross wrote:
On Wed, Aug 27, 2014 at 11:51 AM, Ben Pfaff b...@nicira.com wrote:
On Wed, Aug 27, 2014 at 10:26:14AM +0900, Simon Horman wrote:
On Fri, Aug 22, 2014 at 08:30:08AM -0700, Ben Pfaff wrote:
On Fri, Aug 22, 2014 at 09:19:41PM +0900
On Thu, Aug 28, 2014 at 10:11:57AM +0900, Simon Horman wrote:
On Wed, Aug 27, 2014 at 09:51:59AM -0700, Ben Pfaff wrote:
On Wed, Aug 27, 2014 at 10:26:14AM +0900, Simon Horman wrote:
[snip]
The proposal seems reasonable on its own but given that EXT-350 allows a
standardized way to add
On Thu, Aug 28, 2014 at 10:12:49AM +0900, Simon Horman wrote:
On Wed, Aug 27, 2014 at 03:03:53PM -0500, Jesse Gross wrote:
On Wed, Aug 27, 2014 at 11:51 AM, Ben Pfaff b...@nicira.com wrote:
On Wed, Aug 27, 2014 at 10:26:14AM +0900, Simon Horman wrote:
On Fri, Aug 22, 2014 at 08:30:08AM
On Fri, Aug 29, 2014 at 10:20:55AM -0400, Jamal Hadi Salim wrote:
On 08/26/14 16:54, Thomas Graf wrote:
On 08/26/14 at 01:13pm, Alexei Starovoitov wrote:
I think it's important distinction. In-kernel OVS is not OF.
It's a networking function that has hard-coded packet parser,
N-tuple match
2014/09/01 21:40 Thomas Graf tg...@noironetworks.com:
On 09/01/14 at 05:10pm, Simon Horman wrote:
We are left with two questions for you:
1. Would you look at a proposal (I have some rough code that even works)
for a select group action in the datapath prior to the finalisation
On Tue, Sep 02, 2014 at 09:03:24AM -0700, Ben Pfaff wrote:
On Mon, Sep 01, 2014 at 04:59:22PM +0900, Simon Horman wrote:
On Thu, Aug 28, 2014 at 10:11:57AM +0900, Simon Horman wrote:
On Wed, Aug 27, 2014 at 09:51:59AM -0700, Ben Pfaff wrote:
On Wed, Aug 27, 2014 at 10:26:14AM +0900
On Tue, Sep 02, 2014 at 06:55:14PM -0700, Jesse Gross wrote:
On Mon, Sep 1, 2014 at 1:10 AM, Simon Horman simon.hor...@netronome.com
wrote:
On Thu, Aug 28, 2014 at 10:12:49AM +0900, Simon Horman wrote:
On Wed, Aug 27, 2014 at 03:03:53PM -0500, Jesse Gross wrote:
On Wed, Aug 27, 2014
On Tue, Sep 02, 2014 at 07:20:30PM -0700, Pravin Shelar wrote:
On Tue, Sep 2, 2014 at 6:55 PM, Jesse Gross je...@nicira.com wrote:
On Mon, Sep 1, 2014 at 1:10 AM, Simon Horman simon.hor...@netronome.com
wrote:
On Thu, Aug 28, 2014 at 10:12:49AM +0900, Simon Horman wrote:
On Wed, Aug 27
On Thu, Sep 04, 2014 at 11:24:58AM +0200, Jiri Pirko wrote:
Thu, Sep 04, 2014 at 11:04:49AM CEST, simon.hor...@netronome.com wrote:
Hi Jiri,
sorry for coming a little late to the party.
I'm very happy to see work in this area.
On Thu, Aug 21, 2014 at 06:19:03PM +0200, Jiri Pirko wrote:
On Thu, Sep 04, 2014 at 02:48:37PM +0200, Jiri Pirko wrote:
Wed, Sep 03, 2014 at 06:37:08PM CEST, john.fastab...@gmail.com wrote:
On 09/03/2014 02:24 AM, Jiri Pirko wrote:
Benefit from the possibility to work with flows in switch devices and
use the swdev api to offload flow datapath.
On Thu, Sep 04, 2014 at 09:30:45AM -0700, Scott Feldman wrote:
On Sep 4, 2014, at 2:04 AM, Simon Horman simon.hor...@netronome.com wrote:
[snip]
In relation to ports and datapaths it seems to me that the API that
has been developed accommodates a model where a port may belong
On Fri, Sep 05, 2014 at 12:02:03AM -0700, Scott Feldman wrote:
On Sep 4, 2014, at 9:08 PM, Simon Horman simon.hor...@netronome.com wrote:
On Thu, Sep 04, 2014 at 09:30:45AM -0700, Scott Feldman wrote:
On Sep 4, 2014, at 2:04 AM, Simon Horman simon.hor...@netronome.com
wrote
On Fri, Sep 05, 2014 at 12:07:17PM -0700, Jesse Gross wrote:
On Thu, Sep 4, 2014 at 12:28 AM, Simon Horman
simon.hor...@netronome.com wrote:
On Tue, Sep 02, 2014 at 07:20:30PM -0700, Pravin Shelar wrote:
On Tue, Sep 2, 2014 at 6:55 PM, Jesse Gross je...@nicira.com wrote:
On Mon, Sep 1
On Thu, Sep 11, 2014 at 05:46:03PM -0700, Jesse Gross wrote:
On Sun, Sep 7, 2014 at 7:18 PM, Simon Horman simon.hor...@netronome.com
wrote:
On Fri, Sep 05, 2014 at 12:07:17PM -0700, Jesse Gross wrote:
On Thu, Sep 4, 2014 at 12:28 AM, Simon Horman
simon.hor...@netronome.com wrote
5545e7826896e861c (lib/odp-util: Add tunnel tp_src,
tp_dst parsing and formatting) of that tree.
Simon Horman (8):
odp: select group action attributes
netlink: Allow suppression of warnings for duplicate attributes
odp-util: formatting of datapath select group action
datapath: execution of select group
. This relates to a proposed
Open Flow extension that we have made.
Signed-off-by: Simon Horman simon.hor...@netronome.com
---
datapath/linux/compat/include/linux/openvswitch.h | 31 +++
lib/dpif-netdev.c | 1 +
lib/dpif.c
then it
is up to the caller to parse the message to extract all the attributes.
This is in preparation for allowing multiple OVS_SELECT_GROUP_ATTR_BUCKET
attributes in a nested OVS_ACTION_ATTR_SELECT_GROUP attribute.
Signed-off-by: Simon Horman simon.hor...@netronome.com
---
lib/netlink.c | 2 +-
lib
Allow formatting of select group action. This is used
when pretty-printing datapath flows. Subsequent patches
will add support for the select group action to the datapath
and ovs-vswtichd.
Signed-off-by: Simon Horman simon.hor...@netronome.com
---
lib/odp-util.c | 67
.
Thus the algorithm and used and its implementation are not central
to the prototype.
Signed-off-by: Simon Horman simon.hor...@netronome.com
---
datapath/actions.c | 70 ++
1 file changed, 70 insertions(+)
diff --git a/datapath/actions.c b/datapath
This is in preparation for using last_action() from
more than one C file as part of supporting an odp select group action.
Signed-off-by: Simon Horman simon.hor...@netronome.com
---
datapath/actions.c | 6 --
datapath/datapath.h | 5 +
2 files changed, 5 insertions(+), 6 deletions
This is a quick hack to enable the datapath group select action.
It is in lieu of some combination of:
* probing
* run-time configuration by the end-use.
* run-time heuristic to use the action as appropriate
Signed-off-by: Simon Horman simon.hor...@netronome.com
---
ofproto/ofproto-dpif-xlate.c
Allow validation and copying of select group actions.
This completes the prototype select group action implementation
in the datapath. Subsequent patches will add support to ovs-vswtichd.
Signed-off-by: Simon Horman simon.hor...@netronome.com
---
datapath/flow_netlink.c | 102
.
This would most likely require further datapath modifications.
Signed-off-by: Simon Horman simon.hor...@netronome.com
---
ofproto/ofproto-dpif-xlate.c | 108 ++-
1 file changed, 107 insertions(+), 1 deletion(-)
diff --git a/ofproto/ofproto-dpif-xlate.c b/ofproto
packets may be forwarded
incorrectly.
Signed-off-by: Simon Horman simon.hor...@netronome.com
---
ofproto/ofproto-dpif-rid.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ofproto/ofproto-dpif-rid.c b/ofproto/ofproto-dpif-rid.c
index b3d98eb..e75dfc8 100644
--- a/ofproto/ofproto
It is add-groups rather than add-group that takes FILE as an argument.
Signed-off-by: Simon Horman simon.hor...@netronome.com
---
utilities/ovs-ofctl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/utilities/ovs-ofctl.c b/utilities/ovs-ofctl.c
index 4a90155..8dcd72c 100644
On Fri, Sep 19, 2014 at 02:44:49PM +0100, Thomas Graf wrote:
On 09/18/14 at 10:55am, Simon Horman wrote:
Allow formatting of select group action. This is used
when pretty-printing datapath flows. Subsequent patches
will add support for the select group action to the datapath
and ovs
On Fri, Sep 19, 2014 at 03:06:38PM +0100, Thomas Graf wrote:
On 09/18/14 at 10:55am, Simon Horman wrote:
diff --git a/datapath/datapath.h b/datapath/datapath.h
index c5d3c86..74a15e6 100644
--- a/datapath/datapath.h
+++ b/datapath/datapath.h
@@ -209,4 +209,9 @@ do
On Fri, Sep 19, 2014 at 03:05:27PM +0100, Thomas Graf wrote:
On 09/18/14 at 10:55am, Simon Horman wrote:
+const struct nlattr *bucket_actions(const struct nlattr *attr)
+{
+ const struct nlattr *a;
+ int rem;
+
+ for (a = nla_data(attr), rem = nla_len(attr); rem 0
On Wed, Sep 24, 2014 at 02:06:46PM -0700, Andy Zhou wrote:
Pushed. Thanks for the fix!
Thanks!
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
Hi,
this short series proposes to minor simplifications to ofproto-dpif-rid.
They are not related to each other other than that there is a minor
conflict in applying the second patch if the first one is not present.
Simon Horman (2):
ofproto-dpif-rid: remove struct rid_map
ofproto-dpif-rid
struct rid_map only has one member which is a struct hmap.
This allows for a slight simplification of the code by removing
struct rid_map and using a struct hmap directly instead.
Signed-off-by: Simon Horman simon.hor...@netronome.com
---
ofproto/ofproto-dpif-rid.c | 20
1
The return value of rid_pool_add() is never used
so the code may be slightly simplified by removing it.
Signed-off-by: Simon Horman simon.hor...@netronome.com
---
ofproto/ofproto-dpif-rid.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/ofproto/ofproto-dpif-rid.c b
Signed-off-by: Simon Horman simon.hor...@netronome.com
---
I have now had one patch accepted from this address,
I hope there will be more.
I would also like to continue to use ho...@verge.net.au
for work that is not related to Netronome.
---
AUTHORS | 1 +
1 file changed, 1 insertion(+)
diff
of this
helper means it is best off in netlink.h regardless of if it is used more than
one .c file or not. Thus I would like it considered independent
of the work on an odp select group action.
Signed-off-by: Simon Horman simon.hor...@netronome.com
---
datapath/actions.c | 11
On Wed, Sep 24, 2014 at 09:20:15AM +0100, Thomas Graf wrote:
On 09/24/14 at 03:00pm, Simon Horman wrote:
On Fri, Sep 19, 2014 at 03:06:38PM +0100, Thomas Graf wrote:
Can we rename move this to net/netlink.h instead?
Sure, how about nla_is_last()?
Sounds great
Done. I have posted
On Wed, Sep 24, 2014 at 09:19:42AM +0100, Thomas Graf wrote:
On 09/24/14 at 03:01pm, Simon Horman wrote:
+ /* Only possible type of attributes is
OVS_SELECT_GROUP_ATTR_BUCKET */
+ for (bucket = nla_data(attr), rem = nla_len(attr); rem 0;
+bucket
On Tue, Oct 07, 2014 at 09:50:36PM -0700, Stephen Hemminger wrote:
On Wed, 8 Oct 2014 09:40:51 +0900
Simon Horman simon.hor...@netronome.com wrote:
+struct ovs_offload_ops {
+ /* Flow offload functions */
+ /* Called when a flow entry is added to the flow table */
+ void
On Tue, Oct 07, 2014 at 09:55:21PM -0700, Stephen Hemminger wrote:
On Wed, 8 Oct 2014 09:40:51 +0900
Simon Horman simon.hor...@netronome.com wrote:
+
+struct ovs_offload_ops {
+ /* Flow offload functions */
+ /* Called when a flow entry is added to the flow table */
+ void
On Fri, Sep 26, 2014 at 04:57:25PM -0700, Ben Pfaff wrote:
On Thu, Sep 18, 2014 at 10:55:10AM +0900, Simon Horman wrote:
This patch is a prototype and has several limitations:
* It assumes that no actions follow a select group action
because the resulting packet after a select group
On Fri, Sep 26, 2014 at 04:55:42PM -0700, Ben Pfaff wrote:
On Thu, Sep 18, 2014 at 10:55:05AM +0900, Simon Horman wrote:
Add a multiple field to struct nl_policy which if set suppresses
warning of duplicate attributes in nl_parse_nested().
As is the case without this patch only the last
On Mon, Oct 13, 2014 at 01:46:24PM -0700, Ben Pfaff wrote:
On Thu, Oct 09, 2014 at 10:14:36AM +0900, Simon Horman wrote:
On Fri, Sep 26, 2014 at 04:57:25PM -0700, Ben Pfaff wrote:
On Thu, Sep 18, 2014 at 10:55:10AM +0900, Simon Horman wrote:
This patch is a prototype and has several
if upstream likes
to take new API calls that aren't used. Perhaps a good way forwards
would be for me to re-submit this patch against the upstream net-next
kernel.
Pravin, how would you feel about that?
On Wed, Sep 24, 2014 at 9:28 PM, Simon Horman
simon.hor...@netronome.com wrote
2014/10/17 19:25 Pravin Shelar pshe...@nicira.com:
On Fri, Oct 17, 2014 at 12:16 AM, Simon Horman
simon.hor...@netronome.com wrote:
On Thu, Oct 16, 2014 at 04:50:10PM -0700, Andy Zhou wrote:
Simon, The change makes a lot of sense.
I am just wondering if we should upstream the netlink.h
added to exercise
this change.
Signed-off-by: Simon Horman simon.hor...@netronome.com
---
lib/ofp-util.c | 14 ++
tests/ofproto.at | 16
2 files changed, 30 insertions(+)
diff --git a/lib/ofp-util.c b/lib/ofp-util.c
index d765d03..573f38a 100644
--- a/lib/ofp-util.c
On Fri, Oct 10, 2014 at 09:40:56AM -0700, Ben Pfaff wrote:
On Wed, Oct 08, 2014 at 02:09:53PM -0700, Daniele Di Proietto wrote:
Signed-off-by: Daniele Di Proietto ddiproie...@vmware.com
Can you estimate the additional memory overhead per-datapath flow that
this adds? Our recent review of
On Thu, Oct 16, 2014 at 02:33:03PM -0700, Jarno Rajahalme wrote:
flow inserts and removals are simplified:
- No need for classifier internal mutex, as dpif-netdev already has a
'flow_mutex'.
- Number of memory allocations/frees can be halved.
Lookup code path is a bit more effcient as
On Tue, Oct 28, 2014 at 05:08:08PM -0400, David Miller wrote:
From: Simon Horman simon.hor...@netronome.com
Date: Mon, 27 Oct 2014 16:12:16 +0900
The original motivation for this change was to allow the helper to be used
in files other than actions.c as part of work on an odp select group
On Tue, Oct 28, 2014 at 02:47:00PM -0700, Alex Wang wrote:
Hey Simon,
I did the following test:
- Environment:
host 1: 7 pmd threads, each pmd thread handling one rx queue from
interface dpdk1
bash-4.3# ovs-appctl dpctl/show
netdev@ovs-netdev:
lookups:
the flow monitor request decoder.
This is in preparation for supporting OpenFlow1.4 flow monitors.
Signed-off-by: Simon Horman ho...@verge.net.au
---
ofproto/ofproto.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/ofproto/ofproto.c b/ofproto/ofproto.c
index 793574b
Handle modify and delete commands in OpenFlow1.4 flow monitor requests.
These commands are not yet allowed by the decoder which
will be updated by a subsequent patch.
Signed-off-by: Simon Horman ho...@verge.net.au
---
ofproto/ofproto.c | 19 +++
1 file changed, 15 insertions
This is in preparation for supporting OpenFlow1.4
flow monitor replies.
Signed-off-by: Simon Horman ho...@verge.net.au
---
include/openflow/openflow-1.4.h | 77 +
1 file changed, 77 insertions(+)
diff --git a/include/openflow/openflow-1.4.h b/include
This has the effect of exposing an out_group argument to
ovs-ofctl's monitor subcommand for use with OpenFlow1.4+.
A subsequent patch will update the documentation for ovs-ofctl.
Signed-off-by: Simon Horman ho...@verge.net.au
---
lib/ofp-parse.c | 7 +++
1 file changed, 7 insertions
Signed-off-by: Simon Horman ho...@verge.net.au
---
lib/ofp-util.c | 174 -
1 file changed, 147 insertions(+), 27 deletions(-)
diff --git a/lib/ofp-util.c b/lib/ofp-util.c
index 3a98007..f4eb925 100644
--- a/lib/ofp-util.c
+++ b/lib/ofp
Signed-off-by: Simon Horman ho...@verge.net.au
---
lib/ofp-print.c| 26 +-
tests/ofp-print.at | 27 +++
2 files changed, 48 insertions(+), 5 deletions(-)
diff --git a/lib/ofp-print.c b/lib/ofp-print.c
index 3d3fa0b..f3bb065 100644
--- a/lib/ofp
This has the effect of exposing an new !other argument to
ovs-ofctl's monitor subcommand for use with OpenFlow1.4+.
A subsequent patch will update the documentation for ovs-ofctl.
Signed-off-by: Simon Horman ho...@verge.net.au
---
lib/ofp-parse.c | 3 +++
1 file changed, 3 insertions(+)
diff
Provide and use helper to parse group id.
This in preparation for adding group_out support to the parser
for flow monitor requests. This also requires parsing of a group id.
Signed-off-by: Simon Horman ho...@verge.net.au
---
lib/ofp-parse.c | 48
Signed-off-by: Simon Horman ho...@verge.net.au
---
tests/ofproto.at | 471 ++-
1 file changed, 467 insertions(+), 4 deletions(-)
diff --git a/tests/ofproto.at b/tests/ofproto.at
index e528dfd..915cf96 100644
--- a/tests/ofproto.at
+++ b/tests
This is in preparation for supporting OpenFlow1.4 flow monitor replies.
Signed-off-by: Simon Horman ho...@verge.net.au
---
ofproto/connmgr.c | 16 +---
ofproto/connmgr.h | 5 +
ofproto/ofproto.c | 25 +
3 files changed, 35 insertions(+), 11 deletions
This is in preparation for supporting OpenFlow flow monitor request
commands other than OFPFMC_ADD.
Signed-off-by: Simon Horman ho...@verge.net.au
---
lib/ofp-util.c | 2 ++
lib/ofp-util.h | 2 ++
2 files changed, 4 insertions(+)
diff --git a/lib/ofp-util.c b/lib/ofp-util.c
index 181a464
This is now supported for OpenFlow1.4+.
Signed-off-by: Simon Horman ho...@verge.net.au
---
utilities/ovs-ofctl.8.in | 7 +++
1 file changed, 7 insertions(+)
diff --git a/utilities/ovs-ofctl.8.in b/utilities/ovs-ofctl.8.in
index c1a14e8..6923709 100644
--- a/utilities/ovs-ofctl.8.in
+++ b
Signed-off-by: Simon Horman ho...@verge.net.au
---
tests/ofproto.at | 43 +++
1 file changed, 43 insertions(+)
diff --git a/tests/ofproto.at b/tests/ofproto.at
index 5ba23e0..e528dfd 100644
--- a/tests/ofproto.at
+++ b/tests/ofproto.at
@@ -2267,6 +2267,49
Signed-off-by: Simon Horman ho...@verge.net.au
---
ofproto/connmgr.c | 12 +++
ofproto/connmgr.h | 8 +---
ofproto/ofproto.c | 60 ++-
3 files changed, 55 insertions(+), 25 deletions(-)
diff --git a/ofproto/connmgr.c b/ofproto
Signed-off-by: Simon Horman ho...@verge.net.au
---
tests/ofproto.at | 52
1 file changed, 52 insertions(+)
diff --git a/tests/ofproto.at b/tests/ofproto.at
index 86c69b3..5ba23e0 100644
--- a/tests/ofproto.at
+++ b/tests/ofproto.at
@@ -2267,6
checking.
This is in preparation for supporting OpenFlow 1.4 flow monitor replies.
Signed-off-by: Simon Horman ho...@verge.net.au
---
lib/ofp-print.c | 14 +--
lib/ofp-util.c| 107 +++---
lib/ofp-util.h| 2 +-
ofproto/connmgr.c | 19
Signed-off-by: Simon Horman ho...@verge.net.au
---
lib/ofp-util.c| 49 +++--
lib/ofp-util.h| 3 ++-
utilities/ovs-ofctl.c | 6 +++---
3 files changed, 52 insertions(+), 6 deletions(-)
diff --git a/lib/ofp-util.c b/lib/ofp-util.c
index
This is in preparation for supporting OpenFlow1.4
flow monitor requests.
Signed-off-by: Simon Horman ho...@verge.net.au
---
v2
* No change
---
include/openflow/openflow-1.4.h | 47 +
1 file changed, 47 insertions(+)
diff --git a/include/openflow/openflow
This is analogous to ofoperation_has_out_port,
operating on a group rather than a port.
This is in preparation for adding out_group support to flow monitors
which is in turn in preparation for supporting OpenFlow1.4 flow monitors.
Signed-off-by: Simon Horman ho...@verge.net.au
---
v2
Add OFPRAW_OFPST14_FLOW_MONITOR_REQUEST and
OFPRAW_OFPST14_FLOW_MONITOR_REPLY.
This is a step towards supporting OpenFlow1.4 flow monitors.
Signed-off-by: Simon Horman ho...@verge.net.au
---
v2
* Use ofp-msg instead of ofp-errors as subject prefix
* Group NX extension messages
This is in preparation for supporting OpenFlow1.4 flow monitors
Signed-off-by: Simon Horman ho...@verge.net.au
---
v2
* No change
---
lib/ofp-parse.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/lib/ofp-parse.c b/lib/ofp-parse.c
index 500478a..b76ef0a 100644
--- a/lib/ofp-parse.c
+++ b
This is in preparation for supporting OpenFlow flow monitor request
commands other than OFPFMC_ADD.
Signed-off-by: Simon Horman ho...@verge.net.au
---
v2
* No change
---
lib/ofp-util.c | 2 ++
lib/ofp-util.h | 2 ++
2 files changed, 4 insertions(+)
diff --git a/lib/ofp-util.c b/lib/ofp-util.c
This is in preparation for adding out_group support to flow monitors
which is in turn in preparation for supporting OpenFlow1.4 flow monitors.
Signed-off-by: Simon Horman ho...@verge.net.au
---
v2
* No change
---
ofproto/connmgr.c | 1 +
ofproto/connmgr.h | 1 +
2 files changed, 2 insertions
-by: Simon Horman ho...@verge.net.au
---
v2
* No change
---
lib/ofp-parse.c| 16
lib/ofp-print.c| 4 +++-
lib/ofp-util.c | 44 +---
lib/ofp-util.h | 6 --
ofproto/connmgr.c | 14
support for EXT-187 flow monitors (an extension to
OpenFlow1.3).
This patch-set depends on:
[PATCH 0/3] Honour NXFMF_OWN flag of flow monitors
To aid review this patch-set and its dependencies are available in git at
https://github.com/horms/openvswitch.git devel/flow_monitor-v2
Simon Horman
Filter updates based on the out_group of a flow monitor.
This is analogous to the existing treatment of out_port.
This is in preparation for supporting OpenFlow1.4 flow monitors.
Signed-off-by: Simon Horman ho...@verge.net.au
---
v2
* No change
---
ofproto/connmgr.c | 1 +
1 file changed, 1
If the ONLY_OWN flag of a flow monitor is set then ofmonitor_report should
skip sending updates to other controllers.
This is in preparation for supporting OpenFlow1.4 flow monitors.
Signed-off-by: Simon Horman ho...@verge.net.au
---
v2
* No change
---
ofproto/connmgr.c | 1 +
1 file changed
Signed-off-by: Simon Horman ho...@verge.net.au
---
v2
* Re-arrange case statement to group unsupported versions with default
---
lib/ofp-util.c| 48 ++--
lib/ofp-util.h| 3 ++-
utilities/ovs-ofctl.c | 6 +++---
3 files changed, 51
Signed-off-by: Simon Horman ho...@verge.net.au
---
v2
* No change
---
lib/ofp-util.c | 103 +++--
1 file changed, 92 insertions(+), 11 deletions(-)
diff --git a/lib/ofp-util.c b/lib/ofp-util.c
index 05cba63..9493370 100644
--- a/lib/ofp-util.c
Provide and use helper to parse group id.
This in preparation for adding group_out support to the parser
for flow monitor requests. This also requires parsing of a group id.
Signed-off-by: Simon Horman ho...@verge.net.au
---
v2
* No change
---
lib/ofp-parse.c | 48
Use a list rather than an array to track monitor requests
in handle_flow_monitor_request().
This is in preparation for supporting OpenFlow1.4 flow monitor requests
with delete and modify commands.
Signed-off-by: Simon Horman ho...@verge.net.au
---
v2
* No change
---
ofproto/connmgr.c | 2
This is consists of extending and renaming
existing code for NX flow monitor requests.
Signed-off-by: Simon Horman ho...@verge.net.au
---
v2
* No change
---
lib/ofp-print.c| 68 +++---
tests/ofp-print.at | 12 ++
2 files changed, 72
Handle modify and delete commands in OpenFlow1.4 flow monitor requests.
These commands are not yet allowed by the decoder which
will be updated by a subsequent patch.
Signed-off-by: Simon Horman ho...@verge.net.au
---
v2
* No change
---
ofproto/ofproto.c | 19 +++
1 file changed
Break out monitor deletion code into a new function
flow_monitor_delete which is paramatised over the id of
the monitor to delete.
This is in preparation for supporting OpenFlow1.4 flow monitor requests
with delete and modify commands.
Signed-off-by: Simon Horman ho...@verge.net.au
---
v2
This has the effect of exposing an new !other argument to
ovs-ofctl's monitor subcommand for use with OpenFlow1.4+.
A subsequent patch will update the documentation for ovs-ofctl.
Signed-off-by: Simon Horman ho...@verge.net.au
---
v2
* No change
---
lib/ofp-parse.c | 3 +++
1 file changed, 3
This is in preparation for supporting OpenFlow1.4
flow monitor replies.
Signed-off-by: Simon Horman ho...@verge.net.au
---
v2
* No change
---
include/openflow/openflow-1.4.h | 77 +
1 file changed, 77 insertions(+)
diff --git a/include/openflow/openflow
This is in preparation for supporting OpenFlow1.4 flow monitor replies.
Signed-off-by: Simon Horman ho...@verge.net.au
---
v2
* No change
---
ofproto/connmgr.c | 16 +---
ofproto/connmgr.h | 5 +
ofproto/ofproto.c | 25 +
3 files changed, 35 insertions
This is now supported for OpenFlow1.4+.
Signed-off-by: Simon Horman ho...@verge.net.au
---
v2
* No change
---
utilities/ovs-ofctl.8.in | 5 +
1 file changed, 5 insertions(+)
diff --git a/utilities/ovs-ofctl.8.in b/utilities/ovs-ofctl.8.in
index ad9fe78..7edfd8d 100644
--- a/utilities/ovs
Signed-off-by: Simon Horman ho...@verge.net.au
---
v2
* No change
---
tests/ofproto.at | 52
1 file changed, 52 insertions(+)
diff --git a/tests/ofproto.at b/tests/ofproto.at
index 86c69b3..5ba23e0 100644
--- a/tests/ofproto.at
+++ b/tests
This is now supported for OpenFlow1.4+.
Signed-off-by: Simon Horman ho...@verge.net.au
---
v2
* No change
---
utilities/ovs-ofctl.8.in | 7 +++
1 file changed, 7 insertions(+)
diff --git a/utilities/ovs-ofctl.8.in b/utilities/ovs-ofctl.8.in
index 7edfd8d..6fa784c 100644
--- a/utilities/ovs
Signed-off-by: Simon Horman ho...@verge.net.au
---
v2
* Do not use OF1.4 paused and resumed messages for OF1.1 - OF1.3
---
ofproto/connmgr.c | 12 +++
ofproto/connmgr.h | 8 +---
ofproto/ofproto.c | 60 ++-
3 files changed, 55
At this time the encoding function is always called
with OFP10_VERSION. A subsequent patch will call it
with the prevailing version.
Signed-off-by: Simon Horman ho...@verge.net.au
---
v2
* Re-arrange case statement to group unsupported versions with default
---
lib/ofp-util.c| 108
Test printing of EXT-187: flow entry notification
(ONF flow monitors) requests.
Signed-off-by: Simon Horman ho...@verge.net.au
---
v2
* First post
---
tests/ofp-print.at | 12
1 file changed, 12 insertions(+)
diff --git a/tests/ofp-print.at b/tests/ofp-print.at
index 2fc1e12
This is in preparation for supporting EXT-187: flow entry notification
extension (ONF flow monitor).
Signed-off-by: Simon Horman ho...@verge.net.au
---
v2
* First post
---
lib/ofp-msgs.c | 22 +-
1 file changed, 17 insertions(+), 5 deletions(-)
diff --git a/lib/ofp-msgs.c b
This has the effect of exposing an out_group argument to
ovs-ofctl's monitor subcommand for use with OpenFlow1.4+.
A subsequent patch will update the documentation for ovs-ofctl.
Signed-off-by: Simon Horman ho...@verge.net.au
---
v2
* No change
---
lib/ofp-parse.c | 7 +++
1 file changed
Signed-off-by: Simon Horman ho...@verge.net.au
---
v2
* Rebased
* Remove spurious use of diff-flows
* Consistently use a space in OpenFlow 1.4
---
tests/ofproto.at | 468 ++-
1 file changed, 464 insertions(+), 4 deletions(-)
diff --git a/tests
This is analogous to Nicira extension support.
This is in preparation for supporting EXT-187: flow entry notification
extension (ONF flow monitor).
Signed-off-by: Simon Horman ho...@verge.net.au
---
v2
* First post
---
build-aux/extract-ofp-msgs | 17 +
1 file changed, 17
checking.
This is in preparation for supporting OpenFlow 1.4 flow monitor replies.
Signed-off-by: Simon Horman ho...@verge.net.au
---
v2
* No change
---
lib/ofp-print.c | 14 +--
lib/ofp-util.c| 107 +++---
lib/ofp-util.h| 2 +-
ofproto
Support decoding of EXT-187: flow entry notification extension
(ONF flow monitor) replies.
This re-uses existing Nicira extension code as other than the header
the wire format is the same.
Signed-off-by: Simon Horman ho...@verge.net.au
---
v2
* First post
---
lib/ofp-util.c | 3 ++-
1 file
Test printing of EXT-187: flow entry notification extension
(ONF flow monitor) replies.
Signed-off-by: Simon Horman ho...@verge.net.au
---
v2
* First post
---
tests/ofp-print.at | 15 +++
1 file changed, 15 insertions(+)
diff --git a/tests/ofp-print.at b/tests/ofp-print.at
index
Update documentation of ofputil_flow_monitor_request to note
that it abstracts onf13_flow_monitor_request as well
as {nx,ofp14}_flow_monitor_request.
This is in preparation for supporting EXT-187: flow entry notification
extension (ONF flow monitor).
Signed-off-by: Simon Horman ho
1 - 100 of 4342 matches
Mail list logo
