Re: [ovs-dev] [PATCH] lib: Use proper type cast to poison lists.

2015-12-15 Thread Joe Stringer 
On 15 December 2015 at 00:43, Ben Pfaff  wrote:
> On Mon, Dec 14, 2015 at 10:30:11PM -0800, Joe Stringer wrote:
>> 'struct ovs_list' comprises of two pointers to 'struct ovs_list'.
>> Use these in the cast rather than void*.
>>
>> VMware-BZ: #1571356
>> Signed-off-by: Joe Stringer 
>
> I guess this is a harmless refinement.
>
> Acked-by: Ben Pfaff 

Thanks, applied to master and branch-2.5.
___
dev mailing list
[email protected]
http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH] lib: Use proper type cast to poison lists.

2015-12-15 Thread Ben Pfaff 
On Mon, Dec 14, 2015 at 10:30:11PM -0800, Joe Stringer wrote:
> 'struct ovs_list' comprises of two pointers to 'struct ovs_list'.
> Use these in the cast rather than void*.
> 
> VMware-BZ: #1571356
> Signed-off-by: Joe Stringer 

I guess this is a harmless refinement.

Acked-by: Ben Pfaff 
___
dev mailing list
[email protected]
http://openvswitch.org/mailman/listinfo/dev

[ovs-dev] [PATCH] lib: Use proper type cast to poison lists.

2015-12-14 Thread Joe Stringer 
'struct ovs_list' comprises of two pointers to 'struct ovs_list'.
Use these in the cast rather than void*.

VMware-BZ: #1571356
Signed-off-by: Joe Stringer 
---
 lib/list.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lib/list.h b/lib/list.h
index db4a61365cf8..f9c9d850717e 100644
--- a/lib/list.h
+++ b/lib/list.h
@@ -26,8 +26,8 @@
 /* "struct ovs_list" with pointers that will (probably) cause segfaults if
  * dereferenced and, better yet, show up clearly in a debugger. */
 #define OVS_LIST_POISON \
-(struct ovs_list) { (void *) (uintptr_t) 0xULL, \
-(void *) (uintptr_t) 0xULL }
+(struct ovs_list) { (struct ovs_list *) (uintptr_t) 0xULL, \
+(struct ovs_list *) (uintptr_t) 0xULL }
 
 static inline void list_init(struct ovs_list *);
 static inline void list_poison(struct ovs_list *);
-- 
2.1.4

___
dev mailing list
[email protected]
http://openvswitch.org/mailman/listinfo/dev