Re: [ovs-dev] [PATCH] ovn-controller: Fix possible null pointer dereference.

2016-09-20 Thread Justin Pettit
> On Sep 20, 2016, at 10:00 AM, Ben Pfaff wrote: > > On Mon, Sep 19, 2016 at 06:01:15PM -0700, Justin Pettit wrote: >> The code dereferences "chassis", which could be null if chassis_run() >> returns null. "chassis" will always be null if "chassis_id" is null, so >> checking "chassis" is suffic

Re: [ovs-dev] [PATCH] ovn-controller: Fix possible null pointer dereference.

2016-09-20 Thread Ben Pfaff
On Mon, Sep 19, 2016 at 06:01:15PM -0700, Justin Pettit wrote: > The code dereferences "chassis", which could be null if chassis_run() > returns null. "chassis" will always be null if "chassis_id" is null, so > checking "chassis" is sufficient to check both. > > Found by inspection. > > Signed-o

[ovs-dev] [PATCH] ovn-controller: Fix possible null pointer dereference.

2016-09-19 Thread Justin Pettit
The code dereferences "chassis", which could be null if chassis_run() returns null. "chassis" will always be null if "chassis_id" is null, so checking "chassis" is sufficient to check both. Found by inspection. Signed-off-by: Justin Pettit --- ovn/controller/ovn-controller.c | 2 +- 1 file cha