Re: [ovs-dev] [PATCH] stream-ssl: Fix memory leak on error path.
On Fri, Oct 14, 2016 at 01:11:07PM -0700, Andy Zhou wrote: > On Fri, Oct 14, 2016 at 11:12 AM, Ben Pfaff wrote: > > > The commit that this fixes is from 2009. > > > > Reported-by: Kai-Wei Fan > > Fixes: 9467fe624698 ("Add SSL support to "stream" library and OVSDB.") > > Signed-off-by: Ben Pfaff > > > > LGTM > Acked-by: Andy Zhou Thanks, I applied this to master and to branches back to 2.3. ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
Re: [ovs-dev] [PATCH] stream-ssl: Fix memory leak on error path.
On Fri, Oct 14, 2016 at 11:12 AM, Ben Pfaff wrote: > The commit that this fixes is from 2009. > > Reported-by: Kai-Wei Fan > Fixes: 9467fe624698 ("Add SSL support to "stream" library and OVSDB.") > Signed-off-by: Ben Pfaff > LGTM Acked-by: Andy Zhou ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
[ovs-dev] [PATCH] stream-ssl: Fix memory leak on error path.
The commit that this fixes is from 2009. Reported-by: Kai-Wei Fan Fixes: 9467fe624698 ("Add SSL support to "stream" library and OVSDB.") Signed-off-by: Ben Pfaff --- lib/stream-ssl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/stream-ssl.c b/lib/stream-ssl.c index a5c32a1..dcafc2d 100644 --- a/lib/stream-ssl.c +++ b/lib/stream-ssl.c @@ -670,7 +670,7 @@ ssl_send(struct stream *stream, const void *buffer, size_t n) case EAGAIN: return n; default: -sslv->txbuf = NULL; +ssl_clear_txbuf(sslv); return -error; } } -- 2.1.3 ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev