On 28 September 2016 at 16:21, Joe Stringer wrote:
> On 28 September 2016 at 14:22, Daniele Di Proietto
> wrote:
>> Thanks for doing this cleanup, my instant revalidation series should be much
>> simpler after this.
>>
>> It looks like this needs rebasing, but it is pretty trivial
>>
>> I've gon
On 28 September 2016 at 14:22, Daniele Di Proietto wrote:
> Thanks for doing this cleanup, my instant revalidation series should be much
> simpler after this.
>
> It looks like this needs rebasing, but it is pretty trivial
>
> I've gone through the code, I only have a couple minor of comments abou
Thanks for doing this cleanup, my instant revalidation series should be
much simpler after this.
It looks like this needs rebasing, but it is pretty trivial
I've gone through the code, I only have a couple minor of comments about
how commits are organized.
Other than that it looks good to me.
F
The function revalidate_ukey() has bothered me for some time. It's long enough
with enough local variables that it's easy to forget to properly cleanup after
a function call. Error conditions are interspersed with optimizations to
shortcut revalidation so it's easy to forget how changes are suppose
