Re: [ovs-dev] [PATCH net-next v12 5/9] openvswitch: add processing of L3 packets

2016-10-21 Thread Jiri Benc
On Thu, 20 Oct 2016 21:19:14 -0700, Pravin Shelar wrote: > On Mon, Oct 17, 2016 at 6:02 AM, Jiri Benc wrote: > > @@ -609,8 +597,10 @@ static int ovs_packet_cmd_execute(struct sk_buff *skb, > > struct genl_info *info) > > > > err = ovs_flow_key_extract_userspace(net,

Re: [ovs-dev] [PATCH net-next v12 5/9] openvswitch: add processing of L3 packets

2016-10-20 Thread Pravin Shelar
On Mon, Oct 17, 2016 at 6:02 AM, Jiri Benc wrote: > Support receiving, extracting flow key and sending of L3 packets (packets > without an Ethernet header). > > Note that even after this patch, non-Ethernet interfaces are still not > allowed to be added to bridges. Similarly,

Re: [ovs-dev] [PATCH net-next v12 5/9] openvswitch: add processing of L3 packets

2016-10-20 Thread Pravin Shelar
On Wed, Oct 19, 2016 at 9:52 AM, Jiri Benc wrote: > On Tue, 18 Oct 2016 22:13:45 -0700, Pravin Shelar wrote: >> On Mon, Oct 17, 2016 at 6:02 AM, Jiri Benc wrote: >> > - skb_reset_network_header(skb); >> > + skb->protocol =

Re: [ovs-dev] [PATCH net-next v12 5/9] openvswitch: add processing of L3 packets

2016-10-19 Thread Jiri Benc
On Tue, 18 Oct 2016 22:13:45 -0700, Pravin Shelar wrote: > On Mon, Oct 17, 2016 at 6:02 AM, Jiri Benc wrote: > > - skb_reset_network_header(skb); > > + skb->protocol = parse_ethertype(skb); > > I am not sure about changing skb->protocol here. > By changing

Re: [ovs-dev] [PATCH net-next v12 5/9] openvswitch: add processing of L3 packets

2016-10-18 Thread Pravin Shelar
On Mon, Oct 17, 2016 at 6:02 AM, Jiri Benc wrote: > Support receiving, extracting flow key and sending of L3 packets (packets > without an Ethernet header). > > Note that even after this patch, non-Ethernet interfaces are still not > allowed to be added to bridges. Similarly,

[ovs-dev] [PATCH net-next v12 5/9] openvswitch: add processing of L3 packets

2016-10-17 Thread Jiri Benc
Support receiving, extracting flow key and sending of L3 packets (packets without an Ethernet header). Note that even after this patch, non-Ethernet interfaces are still not allowed to be added to bridges. Similarly, netlink interface for sending and receiving L3 packets to/from user space is not